searching for reviewer(NeilDeakin)
3cc54d1aa9d214a78c5f46c437cc7aa2ecec94dd: Bug 416771 - Allow window.focus() to switch tabs. r=NeilDeakin,dao a=jcristau CLOSED TREE
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 22 May 2019 17:21:29 +0000 - rev 533340
Push 11295 by ccoroiu@mozilla.com at Thu, 23 May 2019 11:54:32 +0000
Bug 416771 - Allow window.focus() to switch tabs. r=NeilDeakin,dao a=jcristau CLOSED TREE Differential Revision: https://phabricator.services.mozilla.com/D31643
b147035a8d927107360761f99441c25c3e5dcaed: Bug 416771 - Use RefPtr<Element> rather than nsCOMPtr in BrowserParent. r=NeilDeakin a=jcristau
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 21 May 2019 14:14:57 +0000 - rev 533339
Push 11295 by ccoroiu@mozilla.com at Thu, 23 May 2019 11:54:32 +0000
Bug 416771 - Use RefPtr<Element> rather than nsCOMPtr in BrowserParent. r=NeilDeakin a=jcristau Depends on D31641 Differential Revision: https://phabricator.services.mozilla.com/D31642
c42e0bb77074f3b28879493ff9267b5ffb59d45a: Bug 416771 - Fix non-unified build in BrowserParent. r=NeilDeakin a=jcristau
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 21 May 2019 14:11:51 +0000 - rev 533338
Push 11295 by ccoroiu@mozilla.com at Thu, 23 May 2019 11:54:32 +0000
Bug 416771 - Fix non-unified build in BrowserParent. r=NeilDeakin a=jcristau Depends on D31640 Differential Revision: https://phabricator.services.mozilla.com/D31641
37d3185821e914e32603fb808dbb58cbb861fb1a: Bug 416771 - Remove OwnerDoc() null-checks. r=NeilDeakin a=jcristau
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 21 May 2019 14:10:04 +0000 - rev 533337
Push 11295 by ccoroiu@mozilla.com at Thu, 23 May 2019 11:54:32 +0000
Bug 416771 - Remove OwnerDoc() null-checks. r=NeilDeakin a=jcristau OwnerDoc() never returns null. Differential Revision: https://phabricator.services.mozilla.com/D31640
1274c074caef1fb327fad2d59bda256e5029e5e2: Bug 1550930 part 3. Stop using [array] for nsIDroppedLinkHandler.dropLinks. r=NeilDeakin
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 15 May 2019 20:58:08 +0000 - rev 532827
Push 11272 by apavel@mozilla.com at Thu, 16 May 2019 15:28:22 +0000
Bug 1550930 part 3. Stop using [array] for nsIDroppedLinkHandler.dropLinks. r=NeilDeakin Differential Revision: https://phabricator.services.mozilla.com/D30770
5945a8e0198b041454d61bfc92b2d3e79229d352: Bug 1550930 part 2. Stop using [array] for nsIDroppedLinkHandler.validateURIsForDrop. r=NeilDeakin
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 15 May 2019 20:52:52 +0000 - rev 532826
Push 11272 by apavel@mozilla.com at Thu, 16 May 2019 15:28:22 +0000
Bug 1550930 part 2. Stop using [array] for nsIDroppedLinkHandler.validateURIsForDrop. r=NeilDeakin Differential Revision: https://phabricator.services.mozilla.com/D30769
a0d592c0cd66b61393d78a81a88be2d9f133837b: Bug 1550930 part 1. Stop using [array] for nsIDroppedLinkHandler.queryLinks. r=NeilDeakin
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 15 May 2019 20:24:00 +0000 - rev 532825
Push 11272 by apavel@mozilla.com at Thu, 16 May 2019 15:28:22 +0000
Bug 1550930 part 1. Stop using [array] for nsIDroppedLinkHandler.queryLinks. r=NeilDeakin Differential Revision: https://phabricator.services.mozilla.com/D30768
be2fb503011adec5a8d387f2bc531e13fab0fd8e: Bug 1550934. Stop using [array] in nsIBrowser. r=NeilDeakin
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 15 May 2019 21:12:44 +0000 - rev 532818
Push 11272 by apavel@mozilla.com at Thu, 16 May 2019 15:28:22 +0000
Bug 1550934. Stop using [array] in nsIBrowser. r=NeilDeakin Differential Revision: https://phabricator.services.mozilla.com/D30771
e5cca993c39d3f074d1d36d02ce95afeedf6a8ce: Bug 1533955 - Show some UI to indicate that a subframe has crashed. r=NeilDeakin
Mike Conley <mconley@mozilla.com> - Wed, 01 May 2019 20:05:24 +0000 - rev 530974
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1533955 - Show some UI to indicate that a subframe has crashed. r=NeilDeakin Differential Revision: https://phabricator.services.mozilla.com/D29238
52b38a9f7f8f663e5a3862bf88bcbd5711651d7e: Bug 1533955 - Move the current message manager actors to a legacy list, and create a new list of JS Window Actors. r=NeilDeakin
Mike Conley <mconley@mozilla.com> - Wed, 01 May 2019 20:05:06 +0000 - rev 530973
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1533955 - Move the current message manager actors to a legacy list, and create a new list of JS Window Actors. r=NeilDeakin Differential Revision: https://phabricator.services.mozilla.com/D29237
9b011be3928562d0ae27acd5680dd215bc9ab2f3: Bug 1515204 - add mouseup after drop in EventUtils, r=NeilDeakin
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Tue, 30 Apr 2019 12:55:23 +0000 - rev 530742
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1515204 - add mouseup after drop in EventUtils, r=NeilDeakin Differential Revision: https://phabricator.services.mozilla.com/D28749
f3c2a7206699cc369fbfdfcff2dc4685cfdd079e: Bug 1547532 - Make nsTypeAheadFind use mozilla::PresShell directly rather than via nsIPresShell r=NeilDeakin
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 30 Apr 2019 00:19:17 +0000 - rev 530662
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1547532 - Make nsTypeAheadFind use mozilla::PresShell directly rather than via nsIPresShell r=NeilDeakin Differential Revision: https://phabricator.services.mozilla.com/D29195
dde986f8138db1c196ddaa173271239a3de0c925: Bug 1545359: indicate 'focusedElement' in nsIFocusManager.idl can be an anonymous descendant of the element which was focused r=NeilDeakin
Mirko Brodesser <mbrodesser@mozilla.com> - Mon, 29 Apr 2019 13:30:35 +0000 - rev 530559
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1545359: indicate 'focusedElement' in nsIFocusManager.idl can be an anonymous descendant of the element which was focused r=NeilDeakin Differential Revision: https://phabricator.services.mozilla.com/D28029
72ae3513844cdb10886cd351ad7bf7ea5d512248: Bug 1515204 - add mouseup after drop in EventUtils, r=NeilDeakin
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Thu, 25 Apr 2019 15:45:23 +0000 - rev 530146
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1515204 - add mouseup after drop in EventUtils, r=NeilDeakin Differential Revision: https://phabricator.services.mozilla.com/D28749
b9a9068783f7848082d2a6559974ade2a78b3e6f: Bug 1532643 - [Wayland] Set popup window hierarchy run-time on Wayland for menus in the same frame hierarchy, r=NeilDeakin
Martin Stransky <stransky@redhat.com> - Wed, 17 Apr 2019 14:19:57 +0000 - rev 529359
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1532643 - [Wayland] Set popup window hierarchy run-time on Wayland for menus in the same frame hierarchy, r=NeilDeakin Wayland protocol allows to have only one popup window attached to a parent widget. Recently we use a toplevel window widget as parent for all popups. That means a second level menu (like File -> New Container Tab) is not displayed as both ("File" and "New Container Tab" menus) have the same parent widget. As a solution allow to get the actual parent run-time and set that when we open the window on toolkit level. This patch covers menu widgets in the same frame hierarchy. Differential Revision: https://phabricator.services.mozilla.com/D26112
b5f523e6d49841c25d7423870fa6e36e026e24a0: Bug 1543694 - Prevent content from adding place flavors to a DataTransfer. r=NeilDeakin
Marco Bonardo <mbonardo@mozilla.com> - Thu, 11 Apr 2019 17:12:06 +0000 - rev 528036
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1543694 - Prevent content from adding place flavors to a DataTransfer. r=NeilDeakin Differential Revision: https://phabricator.services.mozilla.com/D27121
c523c4658e98d236594a1124820a0b142300e6cd: Bug 1540150 - Make it impossible to enter the native drag-drop loop in test automation. r=NeilDeakin
Mike Conley <mconley@mozilla.com> - Thu, 11 Apr 2019 17:17:36 +0000 - rev 527888
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1540150 - Make it impossible to enter the native drag-drop loop in test automation. r=NeilDeakin Differential Revision: https://phabricator.services.mozilla.com/D25428
e8c98e4ec66e450d3e406f6dde0e541053bb37d9: Bug 1541970 - Support incontentshell attribute for XUL panel;r=NeilDeakin
Julian Descottes <jdescottes@mozilla.com> - Tue, 09 Apr 2019 09:41:56 +0000 - rev 527518
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1541970 - Support incontentshell attribute for XUL panel;r=NeilDeakin (more a feedback request than review request at this stage) Adding a new attribute to the panel was the easiest way I could find to make this work without too much plumbing However I don't know how to check that the attribute comes from a chrome privileged script. I tried using PresContext()->IsChrome() but this is also false in our situation. Would you prefer another approach? Otherwise what kind of test would you write for this kind of feature? Differential Revision: https://phabricator.services.mozilla.com/D26211
05cee469e93e48ac706f6ad0bca54f52c71b5d69: Bug 1474902 - Part 2. Make nsFocusManager::DetermineElementToMoveFocus public. r=NeilDeakin
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Fri, 05 Apr 2019 17:12:27 +0900 - rev 526955
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1474902 - Part 2. Make nsFocusManager::DetermineElementToMoveFocus public. r=NeilDeakin Actually, there is no public method to get next element/content by tabIndex or TAB key. So I would like to use GetNextTabbableContent from IMEStateManager. Differential Revision: https://phabricator.services.mozilla.com/D12884
5dae6d1b597a0de158d61e156df1c7f479bbcfbe: Bug 1540150 - Make it impossible to enter the native drag-drop loop in test automation. r=NeilDeakin
Mike Conley <mconley@mozilla.com> - Thu, 04 Apr 2019 15:06:30 +0000 - rev 526820
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1540150 - Make it impossible to enter the native drag-drop loop in test automation. r=NeilDeakin Differential Revision: https://phabricator.services.mozilla.com/D25428
ba0820e380a330b9971299c168b2f75aa5140e7b: Bug 1540150 - Make it impossible to enter the native drag-drop loop in test automation. r=NeilDeakin
Mike Conley <mconley@mozilla.com> - Wed, 03 Apr 2019 14:20:04 +0000 - rev 526598
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1540150 - Make it impossible to enter the native drag-drop loop in test automation. r=NeilDeakin Differential Revision: https://phabricator.services.mozilla.com/D25428
62ccd3a5de2a598dc8b5298ed5d3111f4de29cfd: Bug 1531119 - Remove editMenuCommands.inc.xul and make editMenuOverlay.js in charge of constructing the relevant commandset DOM r=bdahl,NeilDeakin
Brian Grinstead <bgrinstead@mozilla.com> - Thu, 21 Mar 2019 14:18:48 +0000 - rev 524252
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1531119 - Remove editMenuCommands.inc.xul and make editMenuOverlay.js in charge of constructing the relevant commandset DOM r=bdahl,NeilDeakin This allows us to drop preprocessing and makes it simpler to add edit menu functionality to any type of document. Differential Revision: https://phabricator.services.mozilla.com/D21446
3c781347296418c3bf05f3aef1946bad319026e2: Bug 1543694 - Prevent content from adding place flavors to a DataTransfer. r=NeilDeakin a=pascalc
Marco Bonardo <mbonardo@mozilla.com> - Thu, 11 Apr 2019 17:12:06 +0000 - rev 523173
Push 11086 by archaeopteryx@coole-files.de at Mon, 15 Apr 2019 08:56:59 +0000
Bug 1543694 - Prevent content from adding place flavors to a DataTransfer. r=NeilDeakin a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D27121
1e165cd680b96372e6eeeea01a9ad3e78a219b01: Bug 1524983 - Make nsFocusManager::Blur() hand off focus one level up only. r=NeilDeakin
Henri Sivonen <hsivonen@hsivonen.fi> - Thu, 14 Mar 2019 16:25:33 +0000 - rev 521907
Push 10870 by nbeleuzu@mozilla.com at Fri, 15 Mar 2019 20:00:07 +0000
Bug 1524983 - Make nsFocusManager::Blur() hand off focus one level up only. r=NeilDeakin Depends on D22974 Differential Revision: https://phabricator.services.mozilla.com/D22468
1a69c88b8863eb5560c69b2f3a7bf24d164a5db5: Bug 1533716 - Make out-of-process iframes able to request focus. r=masayuki,NeilDeakin
Henri Sivonen <hsivonen@hsivonen.fi> - Thu, 14 Mar 2019 16:20:51 +0000 - rev 521906
Push 10870 by nbeleuzu@mozilla.com at Fri, 15 Mar 2019 20:00:07 +0000
Bug 1533716 - Make out-of-process iframes able to request focus. r=masayuki,NeilDeakin Depends on D22969 Differential Revision: https://phabricator.services.mozilla.com/D22974
b7184b1a3d78d8ab80d3a4dabd4f7836621d32b6: Bug 1534258 - Send Deactivate() messages to out-of-process iframes. r=NeilDeakin
Henri Sivonen <hsivonen@hsivonen.fi> - Thu, 14 Mar 2019 16:00:32 +0000 - rev 521896
Push 10870 by nbeleuzu@mozilla.com at Fri, 15 Mar 2019 20:00:07 +0000
Bug 1534258 - Send Deactivate() messages to out-of-process iframes. r=NeilDeakin Differential Revision: https://phabricator.services.mozilla.com/D22969
8a2800ad38adc98d863bcc4effc52d84aaa105c4: Bug 1532483 - Perma TV toolkit/content/tests/chrome/test_edit_contextmenu.html | paste enabled, r=NeilDeakin
Alexander Surkov <surkov.alexander@gmail.com> - Wed, 06 Mar 2019 14:52:52 +0000 - rev 520500
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1532483 - Perma TV toolkit/content/tests/chrome/test_edit_contextmenu.html | paste enabled, r=NeilDeakin Differential Revision: https://phabricator.services.mozilla.com/D22122
71e5f2f8ca11283011a40cc7a30199417a0e48bf: Bug 1531155 - Support context menus in html:textarea in the parent process, r=NeilDeakin
Alexander Surkov <surkov.alexander@gmail.com> - Mon, 04 Mar 2019 21:07:28 +0000 - rev 520170
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1531155 - Support context menus in html:textarea in the parent process, r=NeilDeakin Differential Revision: https://phabricator.services.mozilla.com/D21092
d8cdae952942c13e39008a5b6ab6400aa7cdfde1: Bug 1531836 - only look for a window specific icon on the disk if an 'icon' attribute has been specified on the XUL window, r=NeilDeakin.
Florian Quèze <florian@queze.net> - Fri, 01 Mar 2019 18:32:17 +0000 - rev 519881
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1531836 - only look for a window specific icon on the disk if an 'icon' attribute has been specified on the XUL window, r=NeilDeakin. Differential Revision: https://phabricator.services.mozilla.com/D21753
d7779ef1fa2f2941508e094ca652f017e448786a: Bug 1465457 - Remove assertion in nsChromeRegistryContent::IsLocaleRTL requiring "global" package r=NeilDeakin
Brian Grinstead <bgrinstead@mozilla.com> - Tue, 26 Feb 2019 17:13:48 +0000 - rev 519115
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1465457 - Remove assertion in nsChromeRegistryContent::IsLocaleRTL requiring "global" package r=NeilDeakin We are running certain xul reftests in the content process registered in chrome://reftest, and it's OK for them to call this function (which is triggered at end of XUL doc loading). Differential Revision: https://phabricator.services.mozilla.com/D21220
a686eb70ac0144b6e5271567b07000836a4d2fff: Bug 1526824 - Remove "src" attribute handling from menuitem XBL and styles; r=NeilDeakin
Brian Grinstead <bgrinstead@mozilla.com> - Mon, 11 Feb 2019 05:48:36 +0000 - rev 516405
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1526824 - Remove "src" attribute handling from menuitem XBL and styles; r=NeilDeakin This appears to be unused, and the [image] attribute on the host is inherited onto .menu-iconic-icon[src] as an alternative. Differential Revision: https://phabricator.services.mozilla.com/D19315
2b59993a9659cd432afe453dcb4d3cc75aca7ba5: Bug 1516258 - Part 2 - Remove XULScrollElement. r=NeilDeakin
Paolo Amadini <paolo.mozmail@amadzone.org> - Thu, 10 Jan 2019 11:50:31 +0000 - rev 511650
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1516258 - Part 2 - Remove XULScrollElement. r=NeilDeakin There is still styling associated with the "scrollbox" element, but eventually those instances can be replaced with simple boxes. Differential Revision: https://phabricator.services.mozilla.com/D15298
7484d3a99bfc3de6b40f28bd1fe2c71dd456eb3f: Bug 1519917 - Consider <menulist> with sizetopopup unset equal to sizetopopup="pref" r=NeilDeakin
Timothy Guan-tin Chien <timdream@gmail.com> - Wed, 16 Jan 2019 16:30:45 +0000 - rev 511213
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1519917 - Consider <menulist> with sizetopopup unset equal to sizetopopup="pref" r=NeilDeakin sizetopopup is set to "pref" by default by the menulist XBL binding, however when converting the binding to custom element, it did not set the attribute value at a time that is early enough. This patch updates nsMenuPopupFrame and nsMenuFrame so that it considers <menulist> with unset sizetopopup attribute as equal to "pref" to avoid the problem above. This reftest layout/reftests/xul/menulist-shrinkwrap-2.xul can detect this failure. The sizetopopup attribute is never meant to be set dynamically; the fix here does not allow us to do so. Differential Revision: https://phabricator.services.mozilla.com/D16410
a643bdc1b7a48ab27192c0fb6b5411319c9b2eaf: Bug 1458046 - avoid remote updates when the browser is not active and fix editcontrols_update test, r=NeilDeakin
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Wed, 16 Jan 2019 16:20:43 +0000 - rev 511211
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1458046 - avoid remote updates when the browser is not active and fix editcontrols_update test, r=NeilDeakin Differential Revision: https://phabricator.services.mozilla.com/D16626
15895cfafac18c606afcfac68d89cc4f3653d065: Bug 1514498 - Hide rather than collapse scrollbar thumb when scrollbar is disabled. r=NeilDeakin
Xidorn Quan <me@upsuper.org> - Thu, 10 Jan 2019 14:15:30 +0000 - rev 510432
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1514498 - Hide rather than collapse scrollbar thumb when scrollbar is disabled. r=NeilDeakin Collapsing thumb causes frame of scrollbar to cache an incorrect pref size, which makes it not able to appear in certain cases. This patch changes it to use "visibility: hidden" instead so that the thumb is hidden but still contributes to the width of scrollbar. An alternative would be also change the code in nsScrollbarFrame to set something other than collapsed attribute instead, but I'm not sure whether doing that is any better than just adding a rule. We need the rule anyway regardless of what we set on the element. Differential Revision: https://phabricator.services.mozilla.com/D15244
3e99aed6c14d423119aebd1cb2214f3270008faf: Bug 1454357 - Remove the scrollbox binding r=NeilDeakin
Timothy Guan-tin Chien <timdream@gmail.com> - Wed, 09 Jan 2019 20:12:26 +0000 - rev 510306
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1454357 - Remove the scrollbox binding r=NeilDeakin With all the previous efforts, the scrollbox binding now does nothing but to create an inner box element holding the scrolling content. It turned out that inner box can be easily removed. The padding set by the document sheets can be moved to the srollbox element directly. The only gotcha is XULScrollElement::ScrollByIndex() -- it can now reach the child item frames directly from the scrolled frame. Depends on D15169 Differential Revision: https://phabricator.services.mozilla.com/D15170
24b9b8cb6c615c78895f5007f4f81a06dbe5df06: Bug 1454360 - Use "arrowscrollbox" in the "popup-scrollbars" binding. r=NeilDeakin
Paolo Amadini <paolo.mozmail@amadzone.org> - Fri, 04 Jan 2019 15:07:12 +0000 - rev 510040
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1454360 - Use "arrowscrollbox" in the "popup-scrollbars" binding. r=NeilDeakin This prepares this binding for the unification with the "popup" binding, and removes the last consumer of the scrollByIndex method of XULScrollElement. Because some code paths in "arrowscrollbox" are optimized using requestAnimationFrame, the related scrolling tests are now asynchronous. Differential Revision: https://phabricator.services.mozilla.com/D15276
a62a47488906d8cb8d793a53e89a7fe66246d602: Bug 1516763 - Remove the feature to set a direction on the "richlistbox" element. r=NeilDeakin
Timothy Guan-tin Chien <timdream@gmail.com> - Sat, 29 Dec 2018 13:05:04 +0000 - rev 509209
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1516763 - Remove the feature to set a direction on the "richlistbox" element. r=NeilDeakin This reverts the change implemented in bug 490178 in preparation for removing the inner scrollbox of the "richlistbox" binding.
7ddc13a7de8d8d42546f96b5a14379c4ca49dfde: Bug 1514498 - Hide rather than collapse scrollbar thumb when scrollbar is disabled. r=NeilDeakin, a=RyanVM
Xidorn Quan <me@upsuper.org> - Thu, 10 Jan 2019 14:15:30 +0000 - rev 506657
Push 10501 by ryanvm@gmail.com at Sat, 12 Jan 2019 21:41:05 +0000
Bug 1514498 - Hide rather than collapse scrollbar thumb when scrollbar is disabled. r=NeilDeakin, a=RyanVM Collapsing thumb causes frame of scrollbar to cache an incorrect pref size, which makes it not able to appear in certain cases. This patch changes it to use "visibility: hidden" instead so that the thumb is hidden but still contributes to the width of scrollbar. An alternative would be also change the code in nsScrollbarFrame to set something other than collapsed attribute instead, but I'm not sure whether doing that is any better than just adding a rule. We need the rule anyway regardless of what we set on the element. Differential Revision: https://phabricator.services.mozilla.com/D15244
ce34faf0d1ef5d62b9d1021c1bcf7e66cc3b8620: Bug 1503887 - clear focused window when Blur() is called and there's no docshell, presshell, or the focused element is no longer in the composed document r=NeilDeakin
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Fri, 07 Dec 2018 09:00:28 +0000 - rev 506029
Push 10304 by csabou@mozilla.com at Mon, 10 Dec 2018 13:40:42 +0000
Bug 1503887 - clear focused window when Blur() is called and there's no docshell, presshell, or the focused element is no longer in the composed document r=NeilDeakin Differential Revision: https://phabricator.services.mozilla.com/D13655
1bbf691c2a7ef844d76d45ff5a3ecb50ab91d415: Bug 1509576 - Fix crash when showing tooltip. r=NeilDeakin
Brendan Dahl <bdahl@mozilla.com> - Wed, 28 Nov 2018 18:42:57 +0000 - rev 504999
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1509576 - Fix crash when showing tooltip. r=NeilDeakin Handle the case when there is no tooltip text provider. Differential Revision: https://phabricator.services.mozilla.com/D13105
3eff39403c8c53f2a0871be7740e1957f2f45ff9: Bug 1426492 - Add an assertion to limit XBL bindings in the content process r=NeilDeakin
Timothy Guan-tin Chien <timdream@gmail.com> - Sat, 03 Nov 2018 11:11:31 +0000 - rev 500764
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1426492 - Add an assertion to limit XBL bindings in the content process r=NeilDeakin Differential Revision: https://phabricator.services.mozilla.com/D8907
d1e4e5029ffb1e38b6328b8c9d422edfb4603107: Bug 1497476 - Remove nsITransferable.kFlavorHasDataProvider. r=NeilDeakin
Tom Schuster <evilpies@gmail.com> - Tue, 16 Oct 2018 20:35:10 +0000 - rev 498762
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1497476 - Remove nsITransferable.kFlavorHasDataProvider. r=NeilDeakin Depends on D8074 Differential Revision: https://phabricator.services.mozilla.com/D8075
729dc4b0b006c47a77ce65fd129054962467d6ec: Bug 1509576 - Fix crash when showing tooltip. r=NeilDeakin, a=lizzard
Brendan Dahl <bdahl@mozilla.com> - Wed, 28 Nov 2018 18:42:57 +0000 - rev 498722
Push 10288 by ryanvm@gmail.com at Sun, 02 Dec 2018 21:24:48 +0000
Bug 1509576 - Fix crash when showing tooltip. r=NeilDeakin, a=lizzard Handle the case when there is no tooltip text provider. Differential Revision: https://phabricator.services.mozilla.com/D13105
48be1c7d47ef2dbc664d350dbe7f1837d1d39ce7: Bug 1492950 - Get rid of getBrowserForDocument, getBrowserForContentWindow and _getTabForContentWindow. r=NeilDeakin
Mike Conley <mconley@mozilla.com> - Tue, 02 Oct 2018 17:54:15 +0000 - rev 494958
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1492950 - Get rid of getBrowserForDocument, getBrowserForContentWindow and _getTabForContentWindow. r=NeilDeakin Depends on D6716 Differential Revision: https://phabricator.services.mozilla.com/D6718
1940595cb776790de40008a4b90d54356f5e5753: Bug 1492950 - Get tabbrowser.js and browser.js off of _getTabForContentWindow. r=NeilDeakin
Mike Conley <mconley@mozilla.com> - Tue, 02 Oct 2018 17:53:47 +0000 - rev 494957
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1492950 - Get tabbrowser.js and browser.js off of _getTabForContentWindow. r=NeilDeakin Depends on D6715 Differential Revision: https://phabricator.services.mozilla.com/D6716
a1b2eb69cd3c3c99091518ef41dee7f9efd06373: Bug 1492950 - Don't allow CPOW windows to be passed to SimpleTest.waitForFocus. r=NeilDeakin
Mike Conley <mconley@mozilla.com> - Tue, 02 Oct 2018 17:53:12 +0000 - rev 494956
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1492950 - Don't allow CPOW windows to be passed to SimpleTest.waitForFocus. r=NeilDeakin Depends on D6714 Differential Revision: https://phabricator.services.mozilla.com/D6715
b418f5bf31cb13510dc7068f386e653f22b3fe62: Bug 1491906 - Add async mode to tabpanels binding. r=NeilDeakin
Mike Conley <mconley@mozilla.com> - Thu, 20 Sep 2018 15:57:33 +0000 - rev 493199
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1491906 - Add async mode to tabpanels binding. r=NeilDeakin We need this because the AsyncTabSwitcher is responsible for switching between the remote browser tab panels asynchronously. Asynchronous mode for the tabpanels binding delegates the responsibility of actually changing the index of the underlying deck to someone else (AsyncTabSwitcher, in this case). Differential Revision: https://phabricator.services.mozilla.com/D6184
a56e2ed44746ab6bfaec2026cbda83fa443a48ba: Bug 1486558 - Handle title changes on ancestors without a mouseout in between. r=NeilDeakin
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 19 Sep 2018 00:56:59 +0000 - rev 493076
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1486558 - Handle title changes on ancestors without a mouseout in between. r=NeilDeakin This page is changing the title attribute on an ancestor while we move the mouse around in a canvas. Our code assumes that given we've moved the mouse around and hid the tooltip we shouldn't show it again until the next mouseout. Instead of keeping track of whether we've already shown the tooltip, keep track of the last used tooltip string, and avoid showing the tooltip again in the callback if it's the same. Differential Revision: https://phabricator.services.mozilla.com/D4443
0851acd8fd1eece8ea4afc885467ff94c8c75571: Bug 1491906 - Add async mode to tabpanels binding. r=NeilDeakin
Mike Conley <mconley@mozilla.com> - Wed, 19 Sep 2018 14:18:26 +0000 - rev 492977
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1491906 - Add async mode to tabpanels binding. r=NeilDeakin We need this because the AsyncTabSwitcher is responsible for switching between the remote browser tab panels asynchronously. Asynchronous mode for the tabpanels binding delegates the responsibility of actually changing the index of the underlying deck to someone else (AsyncTabSwitcher, in this case). Differential Revision: https://phabricator.services.mozilla.com/D6184