searching for reviewer(JanH)
a74afc1a7a210a327a623a075c5c206ef08e60ed: Bug 1550291 - Add new "Crash handler" notification channel; r=JanH, a=RyanVM
Petru Lingurar <petru.lingurar@softvision.ro> - Fri, 07 Jun 2019 08:01:46 +0000 - rev 533873
Push 11446 by ryanvm@gmail.com at Thu, 13 Jun 2019 21:32:43 +0000
Bug 1550291 - Add new "Crash handler" notification channel; r=JanH, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D33028
65747386d437720e71bf5a57eb637dc56e343dd2: Bug 1480877 - Only add RECEIVE_BOOT_COMPLETED Android permission with Stumbler r=JanH
Matthew Finkel <Matthew.Finkel@gmail.com> - Fri, 17 May 2019 07:38:54 +0000 - rev 533172
Push 11276 by rgurzau@mozilla.com at Mon, 20 May 2019 13:11:24 +0000
Bug 1480877 - Only add RECEIVE_BOOT_COMPLETED Android permission with Stumbler r=JanH Differential Revision: https://phabricator.services.mozilla.com/D31525
74252063fc9ec6f72bd27968444ac5de397c6bc1: Bug 1534451 - Send Mobile Activation Telemetry ping. r=JanH
Vlad Baicu <vlad.baicu@softvision.ro> - Wed, 15 May 2019 14:00:12 +0000 - rev 532788
Push 11272 by apavel@mozilla.com at Thu, 16 May 2019 15:28:22 +0000
Bug 1534451 - Send Mobile Activation Telemetry ping. r=JanH Differential Revision: https://phabricator.services.mozilla.com/D29668
6ff9d6783ae0e67b522400818dbd02e1e42b74f6: Bug 1534451 - Send Mobile Activation Telemetry ping. r=JanH
Vlad Baicu <vlad.baicu@softvision.ro> - Tue, 14 May 2019 12:28:51 +0000 - rev 532612
Push 11270 by rgurzau@mozilla.com at Wed, 15 May 2019 15:07:19 +0000
Bug 1534451 - Send Mobile Activation Telemetry ping. r=JanH Differential Revision: https://phabricator.services.mozilla.com/D29668
91bc05242c6f02a5d30c71557693129303e7067e: Bug 1534451 - Send Mobile Activation Telemetry ping. r=JanH
Vlad Baicu <vlad.baicu@softvision.ro> - Fri, 10 May 2019 22:03:10 +0000 - rev 532504
Push 11268 by csabou@mozilla.com at Tue, 14 May 2019 15:24:22 +0000
Bug 1534451 - Send Mobile Activation Telemetry ping. r=JanH Differential Revision: https://phabricator.services.mozilla.com/D29668
17b693747dbd8b6020787a0111ed4883b517acff: Bug 1495344 - Added color definitions for sepia mode in mobile aboutReader.css r=JanH
Sonali9 <sonali18317@iiitd.ac.in> - Tue, 07 May 2019 18:59:13 +0000 - rev 531769
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1495344 - Added color definitions for sepia mode in mobile aboutReader.css r=JanH Differential Revision: https://phabricator.services.mozilla.com/D29735
176a74bf9fe22def92fd0fb9286c708d3514bdc4: Bug 1544525 - Update about:addons's AMO title; r=Pike,JanH
Petru Lingurar <petru.lingurar@softvision.ro> - Fri, 19 Apr 2019 07:14:54 +0000 - rev 528997
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1544525 - Update about:addons's AMO title; r=Pike,JanH And ensure we will always show a localized title, even if we have to fallback to the old already localized one. Differential Revision: https://phabricator.services.mozilla.com/D27858
db411f941b862836f10050c056b8e55c3fd2f4e2: Bug 1543680 - Set playbackState as playing when entering in PiP mode; r=JanH
Petru Lingurar <petru.lingurar@softvision.ro> - Wed, 17 Apr 2019 17:00:00 +0000 - rev 528876
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1543680 - Set playbackState as playing when entering in PiP mode; r=JanH playbackState's default value is PlaybackState.STOPPED. We can only enter PiP mode if media is playing but we don't save this playing state. If the user hasn't done anything to change this, like pause-play, when we check the playbackState in BrowserApp to know to force fullscreen if still playing we will not do so because the state is PlaybackState.STOPPED. Differential Revision: https://phabricator.services.mozilla.com/D27935
4799fcf678c3367b4582d5e46667056c6864f57a: Bug 1543468 - Stop using toolkit netError.css URL on Android. r=JanH
Tim Nguyen <ntim.bugs@gmail.com> - Wed, 10 Apr 2019 19:32:20 +0000 - rev 527684
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1543468 - Stop using toolkit netError.css URL on Android. r=JanH Differential Revision: https://phabricator.services.mozilla.com/D26964
8e592445e44255edb05d4d21bd3ecbda21a1ede1: Bug 1506231 - Top Sites tiles will show only one site for the same base url; r=JanH
Petru Lingurar <petru.lingurar@softvision.ro> - Fri, 29 Mar 2019 07:57:51 +0000 - rev 525553
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1506231 - Top Sites tiles will show only one site for the same base url; r=JanH Differential Revision: https://phabricator.services.mozilla.com/D24487
b6c4db66365c6f8ba081892d0992548a8f74d05f: Bug 1531057 - Add a test to check that session history respects the layout scroll range. r=JanH
Botond Ballo <botond@mozilla.com> - Wed, 27 Mar 2019 20:20:05 +0000 - rev 525264
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1531057 - Add a test to check that session history respects the layout scroll range. r=JanH Differential Revision: https://phabricator.services.mozilla.com/D23753
51b9ea3597634038f0b5df7ac79f3476d3287785: Bug 1463878 - Add SessionStateAggregator.js (mostly lifted from desktop code with modifications to reflect GV's needs) and code to send incremental session storage updates to Java. r=snorp,JanH
Dylan Roeh <droeh@mozilla.com> - Fri, 22 Mar 2019 00:51:11 +0000 - rev 524387
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1463878 - Add SessionStateAggregator.js (mostly lifted from desktop code with modifications to reflect GV's needs) and code to send incremental session storage updates to Java. r=snorp,JanH Differential Revision: https://phabricator.services.mozilla.com/D23696
11415a3e72f68f06b935bc5962e486947baec71a: Bug 1463878 - Add SessionStateAggregator.js (mostly lifted from desktop code with modifications to reflect GV's needs) and code to send incremental session storage updates to Java. r=snorp,JanH
Dylan Roeh <droeh@mozilla.com> - Thu, 21 Mar 2019 21:29:33 +0000 - rev 524307
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1463878 - Add SessionStateAggregator.js (mostly lifted from desktop code with modifications to reflect GV's needs) and code to send incremental session storage updates to Java. r=snorp,JanH Differential Revision: https://phabricator.services.mozilla.com/D23696
0c5057ecdb645afe71d8ce60a4c9d533a73bb000: Bug 1534213 - Reduce the number of WebpageItemRow layout refreshes; r=JanH
Petru Lingurar <petru.lingurar@softvision.ro> - Tue, 19 Mar 2019 22:02:30 +0000 - rev 524010
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1534213 - Reduce the number of WebpageItemRow layout refreshes; r=JanH Previously, WebpageItemRow's layout would be updated everytime a new Tab for it's url would be ADDED/CLOSED/LOCATION_CHANGED to force a recheck of the need to show the "Switch to tab hint". To prevent multiple layout refreshes for every such event we will check the current display status of the "Switch to tab hint" against the newly computed value after an ADDED/CLOSED/LOCATION_CHANGED event was received. Eagerly changing the value for 'switchToTabHintShown' along with informing about the need for layout refresh to prevent any race conditions between receiving more events and actualy refreshing the layout. (In my tests I saw ADDED/LOCATION_CHANGE refreshing the same layout needlessly) Differential Revision: https://phabricator.services.mozilla.com/D24013
ec55d1e895f99a9cc3085d2bcf54dc962abdbdcc: Bug 1544525 - Update about:addons's AMO title; r=Pike,JanH a=pascalc l10n=flod
Petru Lingurar <petru.lingurar@softvision.ro> - Fri, 19 Apr 2019 07:14:54 +0000 - rev 523301
Push 11138 by archaeopteryx@coole-files.de at Tue, 23 Apr 2019 19:02:09 +0000
Bug 1544525 - Update about:addons's AMO title; r=Pike,JanH a=pascalc l10n=flod And ensure we will always show a localized title, even if we have to fallback to the old already localized one. Differential Revision: https://phabricator.services.mozilla.com/D27858
2d12891a1a5493bac5886af3ede2db14b30a1ee6: Bug 1543680 - Set playbackState as playing when entering in PiP mode. r=JanH a=pascalc
Petru Lingurar <petru.lingurar@softvision.ro> - Sun, 21 Apr 2019 03:11:06 +0300 - rev 523265
Push 11121 by nbeleuzu@mozilla.com at Sun, 21 Apr 2019 00:24:44 +0000
Bug 1543680 - Set playbackState as playing when entering in PiP mode. r=JanH a=pascalc Summary: playbackState's default value is PlaybackState.STOPPED. We can only enter PiP mode if media is playing but we don't save this playing state. If the user hasn't done anything to change this, like pause-play, when we check the playbackState in BrowserApp to know to force fullscreen if still playing we will not do so because the state is PlaybackState.STOPPED. Reviewers: JanH Reviewed By: JanH Subscribers: jya Bug #: 1543680 Differential Revision: https://phabricator.services.mozilla.com/D27935
e2f09a8bd87cb38405446b594058104f0c694561: Bug 1531057 - Add a test to check that session history respects the layout scroll range. r=JanH a=test-only
Botond Ballo <botond@mozilla.com> - Wed, 27 Mar 2019 20:20:05 +0000 - rev 522936
Push 10995 by archaeopteryx@coole-files.de at Thu, 04 Apr 2019 08:26:45 +0000
Bug 1531057 - Add a test to check that session history respects the layout scroll range. r=JanH a=test-only Differential Revision: https://phabricator.services.mozilla.com/D23753
8c19d4132c70122a35d3115c0af65e3bf14cee1d: Bug 1534213 - Reduce the number of WebpageItemRow layout refreshes; r=JanH a=pascalc
Petru Lingurar <petru.lingurar@softvision.ro> - Tue, 19 Mar 2019 22:02:30 +0000 - rev 522699
Push 10907 by archaeopteryx@coole-files.de at Mon, 25 Mar 2019 11:57:16 +0000
Bug 1534213 - Reduce the number of WebpageItemRow layout refreshes; r=JanH a=pascalc Previously, WebpageItemRow's layout would be updated everytime a new Tab for it's url would be ADDED/CLOSED/LOCATION_CHANGED to force a recheck of the need to show the "Switch to tab hint". To prevent multiple layout refreshes for every such event we will check the current display status of the "Switch to tab hint" against the newly computed value after an ADDED/CLOSED/LOCATION_CHANGED event was received. Eagerly changing the value for 'switchToTabHintShown' along with informing about the need for layout refresh to prevent any race conditions between receiving more events and actualy refreshing the layout. (In my tests I saw ADDED/LOCATION_CHANGE refreshing the same layout needlessly) Differential Revision: https://phabricator.services.mozilla.com/D24013
0699c6be752a56ecf666e4611959ac3be7a90841: Bug 1535949 - browser.js: Fix typo in the identifier r=JanH
Sylvestre Ledru <sledru@mozilla.com> - Sun, 17 Mar 2019 20:41:46 +0000 - rev 522606
Push 10871 by cbrindusan@mozilla.com at Mon, 18 Mar 2019 15:49:32 +0000
Bug 1535949 - browser.js: Fix typo in the identifier r=JanH Differential Revision: https://phabricator.services.mozilla.com/D23812
36132f5347e8b31f4fe5b28d0bd182f6fe606237: Bug 1531047 - Part 2: Refactor TabQueue to a foreground service. r=JanH
Vlad Baicu <vlad.baicu@softvision.ro> - Fri, 15 Mar 2019 11:21:29 +0000 - rev 522030
Push 10871 by cbrindusan@mozilla.com at Mon, 18 Mar 2019 15:49:32 +0000
Bug 1531047 - Part 2: Refactor TabQueue to a foreground service. r=JanH Refactored the TabQueueService to be a foreground service from Android O onwards. The service now uses a foreground notification that briefly informs the user that a new tab is being added to the queue. Depends on D23528 Differential Revision: https://phabricator.services.mozilla.com/D23529
a0bf4a689da43de720ad9be71ab6fdafea1c5790: Bug 1517895 - Scroll the visual viewport in SessionStoreUtils::RestoreScrollPosition(). r=JanH
Botond Ballo <botond@mozilla.com> - Wed, 13 Mar 2019 23:07:24 +0000 - rev 521796
Push 10867 by dvarga@mozilla.com at Thu, 14 Mar 2019 15:20:45 +0000
Bug 1517895 - Scroll the visual viewport in SessionStoreUtils::RestoreScrollPosition(). r=JanH Differential Revision: https://phabricator.services.mozilla.com/D19876
f41b081164d2bf2c02a6120b178eb10511a78f18: Bug 1517895 - Wait for mozvisualscroll explicitly in the session store tests. r=JanH
Botond Ballo <botond@mozilla.com> - Wed, 13 Mar 2019 16:00:07 +0000 - rev 521795
Push 10867 by dvarga@mozilla.com at Thu, 14 Mar 2019 15:20:45 +0000
Bug 1517895 - Wait for mozvisualscroll explicitly in the session store tests. r=JanH SSTabScrollCaptured can sometimes be fired for other reasons, causing us to query the visual scroll position before it has been updated. Not explicitly waiting for SSTabScrollCaptured is also safe in this case because we're only querying the session store's view of the scroll position *after* closing the tab, which will flush any pending scroll position updates in the session store. Differential Revision: https://phabricator.services.mozilla.com/D19875
02e879149e47419f08e03e73fe61a7d7abe58a24: Bug 1517895 - Use scrollToVisual() in the session store tests. r=JanH
Botond Ballo <botond@mozilla.com> - Wed, 13 Mar 2019 16:00:07 +0000 - rev 521794
Push 10867 by dvarga@mozilla.com at Thu, 14 Mar 2019 15:20:45 +0000
Bug 1517895 - Use scrollToVisual() in the session store tests. r=JanH Differential Revision: https://phabricator.services.mozilla.com/D19874
8541dfa55436ca1ad01d3fe056832b41438ef33e: Bug 1534943 - also update android CSS for font-size changes, r=JanH
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Wed, 13 Mar 2019 19:40:26 +0000 - rev 521773
Push 10867 by dvarga@mozilla.com at Thu, 14 Mar 2019 15:20:45 +0000
Bug 1534943 - also update android CSS for font-size changes, r=JanH Differential Revision: https://phabricator.services.mozilla.com/D23325
adc910e55eb67f7d667cdaca586997fca225f492: Bug 1507427 - Apply size restrictions for the largeIcon used in NotificationClient; r=JanH
Petru-Mugurel Lingurar <petru.lingurar@softvision.ro> - Mon, 04 Mar 2019 17:39:53 +0000 - rev 520226
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1507427 - Apply size restrictions for the largeIcon used in NotificationClient; r=JanH There are crash reports for large heap allocations for Bitmaps from the NotificationClient#add method. As more of a speculative fix this patch introduces bitmap size constraints for the largeIcon of the notification this method posts. Previously the app would happily load any image from the passed in image URL even though the maximum size the largeIcon can be is 256x256 pixels. Differential Revision: https://phabricator.services.mozilla.com/D21666
7ae76ec6dad573ca4313bc1f117f88e1f5be3935: Bug 1507531 - FilePicker will request WRITE_EXTERNAL_STORAGE; r=JanH
Petru Lingurar <petru.lingurar@softvision.ro> - Fri, 22 Feb 2019 15:43:13 +0000 - rev 518921
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1507531 - FilePicker will request WRITE_EXTERNAL_STORAGE; r=JanH "Prior to Android 8.0 (API level 26), if an app requested a permission at runtime and the permission was granted, the system would also incorrectly grant the app the rest of the permissions that belonged to the same permission group, and that were registered in the manifest. For apps targeting Android 8.0, this behavior has been corrected. The app is granted only the permissions it has explicitly requested. However, once the user grants a permission to the app, all subsequent requests for permissions in that permission group are automatically granted." https://developer.android.com/about/versions/oreo/android-8.0-changes#rmp Our FilePicker can delegate other applications to record media files (photo/audio/video) which are then to be sent to websites. They must be saved locally before the upload, scenario that wasn't possible anymore on Oreo+ because of the change in how Android handles runtime permissions. As a way to get around this one could grant the "Storage" permission from System Settings which would grant the app both READ and WRITE access. But for actually being prepared to handle all situations our FilePicker must ask for the WRITE_EXTERNAL_STORAGE permission at runtime. Differential Revision: https://phabricator.services.mozilla.com/D20821
1b04fd61d51221a8bb1ecc383c72e6b63b09fc7d: Bug 1438010 - Add support for double tapping to launch app in "Open in app" prompt r=JanH
Vivek Dhingra <vivek3zero@gmail.com> - Fri, 30 Mar 2018 19:06:48 -0400 - rev 517976
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1438010 - Add support for double tapping to launch app in "Open in app" prompt r=JanH This patch sets doubleTapButton to "OK" action. So when a user double taps an app, "OK" action is selected out of "OK" and "Cancel" actions. MozReview-Commit-ID: Kqw2pg5zz50
8ca888f573652270684dc7b85d1a796fbd4c5f0b: Bug 1511946 - Hint about "Switch to tab" option for AwesomeScreen's stream items; r=JanH
Petru Lingurar <petru.lingurar@softvision.ro> - Mon, 18 Feb 2019 11:03:48 +0000 - rev 517645
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1511946 - Hint about "Switch to tab" option for AwesomeScreen's stream items; r=JanH The behaviour of switching to an already opened tab for an item in the stream list was already in place, this patch just modifies the item's layout by adding a text hint about this possibility - "Switch to tab", dynamically, depending on if a tab is already opened or not in the current session. Each stream item will implement `Tabs.OnTabsChangedListener` and check if the changed Tab had stream's Url. If so it will pass this event to the list's Adapter which will refresh the stream item's layout. Differential Revision: https://phabricator.services.mozilla.com/D18997
15a0cccc792cf33e66b785d1e629e91237ddc369: Bug 1525872 PushEvent.data is null for push messages encrypted with aes128gcm r=JanH
Andrei Lazar <andrei.a.lazar@softvision.ro> - Mon, 18 Feb 2019 08:15:26 +0000 - rev 517642
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1525872 PushEvent.data is null for push messages encrypted with aes128gcm r=JanH Added check for AES128GCM encoding since we won't have separate enckey and cryptokey but rather encoded in the body. Differential Revision: https://phabricator.services.mozilla.com/D19806
28b82ee1219559a59a0614ec233daa2b8ba1453d: Bug 1503978 - Force fullscreen after PiP only if media is playing; r=JanH
Petru-Mugurel Lingurar <petru.lingurar@softvision.ro> - Fri, 15 Feb 2019 17:32:42 +0000 - rev 517612
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1503978 - Force fullscreen after PiP only if media is playing; r=JanH Otherwise the user should see and be able to interact with the whole page. Refactored `PictureInPictureController` to check the media playing status for only the current tab, the one the user has in front and for which we may allow PiP because `GeckoMediaControlAgent.isMediaPlaying()` would give us false positives in the case where the current Tab is in fullscreen but not playing media, while at the same time a background Tab is playing media. BrowserApp will only force fullscreen after returning from PiP if media playback has ended, but will keep fullscreen for playing/paused media. Differential Revision: https://phabricator.services.mozilla.com/D19750
ed60c55e6f005b5a382606ec1d4fbc71fd5272c6: Bug 1525796 - Ignore close tab action if user is moving the item; r=JanH
Petru-Mugurel Lingurar <petru.lingurar@softvision.ro> - Fri, 15 Feb 2019 08:18:33 +0000 - rev 517426
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1525796 - Ignore close tab action if user is moving the item; r=JanH Using an ItemTouchHelper for various motion actions means it will have a strong reference to that item's layout and prevent it from being destroyed when the adapter tries to remove it before the animations are finished - the item will be removed from RecyclerView's Adapter but the item's layout will still remain on screen. Differential Revision: https://phabricator.services.mozilla.com/D19673
33cac757cc2a08dac46e2926cab0a8b4d473954e: Bug 1498911 - Allow cycling through search results when keeping the buttons pressed; r=JanH
Petru Lingurar <petru.lingurar@softvision.ro> - Mon, 04 Feb 2019 10:00:39 +0200 - rev 514516
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1498911 - Allow cycling through search results when keeping the buttons pressed; r=JanH Summary: For every `Enter` or `Shift+Enter` ACTION_DOWN event a new next/previous search will be made. Keeping the buttons pressed will cycle through all the search results endlessly. Depends on D17133 Reviewers: JanH Reviewed By: JanH Bug #: 1498911 Differential Revision: https://phabricator.services.mozilla.com/D18203
45c0ce350507fbe5a5a7885b55c2e8bce39fc00e: Bug 1516665 - Part 3: Additional logging. r=JanH
Vlad Baicu <vlad.baicu@softvision.ro> - Fri, 01 Feb 2019 15:51:27 +0000 - rev 514336
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1516665 - Part 3: Additional logging. r=JanH Added additional logging. In case the agent is not attached but we are not on a release or beta build, allow createNotification to be called with a null context so that we may be able to gather more information from the reports. Depends on D18115 Differential Revision: https://phabricator.services.mozilla.com/D18116
41d0bcfb107b06f1e1844c9bfa532ec158b31486: Bug 1516665 - Part 2: Cleanup. r=JanH
Vlad Baicu <vlad.baicu@softvision.ro> - Fri, 01 Feb 2019 15:08:00 +0000 - rev 514335
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1516665 - Part 2: Cleanup. r=JanH Some code cleanup. Depends on D17391 Differential Revision: https://phabricator.services.mozilla.com/D18115
60c21be97bb247b077390fd18e43e458166d2257: Bug 1516665 - Prevent MediaControlService NPE. r=JanH
Vlad Baicu <vlad.baicu@softvision.ro> - Fri, 01 Feb 2019 15:07:29 +0000 - rev 514334
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1516665 - Prevent MediaControlService NPE. r=JanH Use MediaControlService's context when creating the notification in order to prevent a NPE. Differential Revision: https://phabricator.services.mozilla.com/D17391
ee85b1ccaa18e47a0c56b5b0fe8408cfc4a20181: Bug 1498911 - FindInPageBar will now handle `Enter` and `Shift+Enter`; r=JanH
Petru Lingurar <petru.lingurar@softvision.ro> - Mon, 28 Jan 2019 07:28:05 +0000 - rev 513470
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1498911 - FindInPageBar will now handle `Enter` and `Shift+Enter`; r=JanH `Enter` will search for the next occurrence of the "Find" string. `Shift+Enter` will search for the previous occurrence of the "Find" string. For this, FindInPageBar will intercept all `onKey` events and - on `KeyEvent.ACTION_DOWN` will consume `Shift+Enter` which would otherwise insert a newline character in the search box - on `KeyEvent.ACTION_UP` will do a new next/previous search depending on the keys pressed. Differential Revision: https://phabricator.services.mozilla.com/D17133
9a68634dc411b49987bbbd6434602c9ffbc2c6ea: Bug 1519418 - Replace MMA preferences with sharedPreferences. r=JanH a=lizzard
Vlad Baicu <vlad.baicu@softvision.ro> - Wed, 06 Mar 2019 04:04:30 +0200 - rev 513388
Push 10833 by nbeleuzu@mozilla.com at Wed, 06 Mar 2019 02:16:57 +0000
Bug 1519418 - Replace MMA preferences with sharedPreferences. r=JanH a=lizzard Summary: Patch D16319 attempted to clean the MMA code and allow for easier debugging of LP deeplinks on dev builds. However it introduced a regression because the MMA preferences were being accessed by the initializing activity. By making getDeviceId public and static, calling it from another activity would result in a null value returned. I have refactored the code to use shared preferences and remove the dependency on other activities. Reviewers: JanH, petru Reviewed By: petru Bug #: 1519418 Differential Revision: https://phabricator.services.mozilla.com/D21984
fd591b31f209c11b4b770666e7697345834b9856: Bug 1527648 - Uid deeplink nullpointer check. r=JanH a=lizzard
Dorel Luca <dluca@mozilla.com> - Fri, 22 Feb 2019 11:11:03 +0200 - rev 513197
Push 10752 by dluca@mozilla.com at Fri, 22 Feb 2019 09:32:19 +0000
Bug 1527648 - Uid deeplink nullpointer check. r=JanH a=lizzard Summary: Patch from bug 1519418 introduced a regression by removing line separators from the uid parameter contained within deeplinks. However, not all deeplinks are mandatory to contain the uid parameter. Added a null check before replacing the line separators. Reviewers: JanH, petru Reviewed By: petru Bug #: 1527648 Differential Revision: https://phabricator.services.mozilla.com/D20367
6fec628734c8d1e2fcd72c14296424f459413e8e: Bug 1525872 PushEvent.data is null for push messages encrypted with aes128gcm r=JanH a=lizzard
Andrei Lazar <andrei.a.lazar@softvision.ro> - Mon, 18 Feb 2019 08:15:26 +0000 - rev 513176
Push 10743 by aiakab@mozilla.com at Thu, 21 Feb 2019 02:38:27 +0000
Bug 1525872 PushEvent.data is null for push messages encrypted with aes128gcm r=JanH a=lizzard Added check for AES128GCM encoding since we won't have separate enckey and cryptokey but rather encoded in the body. Differential Revision: https://phabricator.services.mozilla.com/D19806
be69f7164f217491b3219b0182f331e8209cba5e: Bug 1516665 - Part 2: Cleanup. r=JanH a=lizzard
Vlad Baicu <vlad.baicu@softvision.ro> - Fri, 01 Feb 2019 15:08:00 +0000 - rev 512895
Push 10636 by rgurzau@mozilla.com at Thu, 07 Feb 2019 02:59:13 +0000
Bug 1516665 - Part 2: Cleanup. r=JanH a=lizzard Some code cleanup. Depends on D17391 Differential Revision: https://phabricator.services.mozilla.com/D18115
1ce04026e6ebe42dfc1ba8efd2478e33dd8c13cb: Bug 1516665 - Prevent MediaControlService NPE. r=JanH a=lizzard
Vlad Baicu <vlad.baicu@softvision.ro> - Fri, 01 Feb 2019 15:07:29 +0000 - rev 512894
Push 10636 by rgurzau@mozilla.com at Thu, 07 Feb 2019 02:59:13 +0000
Bug 1516665 - Prevent MediaControlService NPE. r=JanH a=lizzard Use MediaControlService's context when creating the notification in order to prevent a NPE. Differential Revision: https://phabricator.services.mozilla.com/D17391
5d0fef351a29306c1e46fbc70681ff1791cf6973: Bug 1473470 - Part 3 - Remove "Saved logins" from "Clear private data" options. r=JanH
Petru Lingurar <petru.lingurar@softvision.ro> - Tue, 15 Jan 2019 11:02:33 +0200 - rev 511006
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1473470 - Part 3 - Remove "Saved logins" from "Clear private data" options. r=JanH Summary: Login data is to be removed only from "about:logins" where the users that use Sync are also informed about the perils of doing so. Depends on D16027 Reviewers: JanH, #geckoview-reviewers Reviewed By: JanH Subscribers: flod Bug #: 1473470 Differential Revision: https://phabricator.services.mozilla.com/D16029
ae52a3250ebf124caed547e09671af3f29928d20: Bug 1473470 - Part 2 - Inform user about synced logins if Sync is used. r=JanH
Petru Lingurar <petru.lingurar@softvision.ro> - Tue, 15 Jan 2019 11:01:08 +0200 - rev 511005
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1473470 - Part 2 - Inform user about synced logins if Sync is used. r=JanH Summary: The reason for this ticket was that it was not immediately obvious for Sync users that deleting logins on this device may affect all logins stored in user's Sync account. So it was possible that users could unintentionally loose all their login data. While we should still offer the option to remove login data, even to Sync users, we will explicitly inform them that deleting logins can affect all their synced logins. Also refactored the code to minimize duplicated code. Depends on D16026 Reviewers: JanH, #geckoview-reviewers Reviewed By: JanH Subscribers: reviewbot, flod Bug #: 1473470 Differential Revision: https://phabricator.services.mozilla.com/D16027
a7034ada9fb35dffe4e0729987cb00b2e37d46ac: Bug 1473470 - Part 1 - Add new "Delete all" option to about:logins; r=JanH
Petru Lingurar <petru.lingurar@softvision.ro> - Mon, 14 Jan 2019 13:42:42 +0000 - rev 510853
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1473470 - Part 1 - Add new "Delete all" option to about:logins; r=JanH This new option allows removing all logins from our login manager. Differential Revision: https://phabricator.services.mozilla.com/D16026
4f4436e2493a153ccff73f2a470e8964f1c33519: Bug 1513938 - Enforce a Bundle size limit and drop `privateSession` if exceeds it; r=JanH
Petru Lingurar <petru.lingurar@softvision.ro> - Fri, 21 Dec 2018 08:56:47 +0000 - rev 508754
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1513938 - Enforce a Bundle size limit and drop `privateSession` if exceeds it; r=JanH The `privateSession` key would normally allow persisting the Private Browsing session across OOMs in Activity's Bundle. We need to do that to avoid storing private, sensible data on disk like we do with the normal browsing session. In some cases `privateSession` would contain a lot of data which, along with other possible concurrent transactions could overflow Binder's buffer which has a limited fixed size, currently 1Mb. To avoid this, we will drop `privateSession` from the Bundle if the resulting size is greater than a _speculative_ size of 300KBs which would mean that in the case of an OOM all Private Browsing state would be lost. Bug 1515592 is filed to investigate for a better solution. Differential Revision: https://phabricator.services.mozilla.com/D15067
4b128c704ca68d570978622fe85fc72c4fb180fa: Bug 1509434 - Part 2 - Wait for AudioFocusAgent to be initialized before starting testMediaControl;r=JanH
Petru Lingurar <petru.lingurar@softvision.ro> - Sun, 16 Dec 2018 19:48:16 +0000 - rev 508000
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1509434 - Part 2 - Wait for AudioFocusAgent to be initialized before starting testMediaControl;r=JanH Inside the tests from testMediaControl audio focus is not immediately checked as for the tests from testAudioFocus but nonetheless we should make sure AudioFocusAgent is initialized before proceeding with the media tests. Depends on D14417 Differential Revision: https://phabricator.services.mozilla.com/D14418
f525a4f572f63763bea9699f9b66cb1384dd90cd: Bug 1509434 - Part 1 - Wait for AudioFocusAgent to be initialized before starting testAudioFocus;r=JanH
Petru Lingurar <petru.lingurar@softvision.ro> - Mon, 17 Dec 2018 07:59:44 +0000 - rev 507999
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1509434 - Part 1 - Wait for AudioFocusAgent to be initialized before starting testAudioFocus;r=JanH There is a small race between actually starting the test after Gecko:Ready and having the AudioFocusAgent that the tests depend on initialized, which is also done after Gecko:Ready. To avoid this situation we will wait for Gecko:Ready and then for AudioFocusAgent to complete it's initialization. Differential Revision: https://phabricator.services.mozilla.com/D14417
fd2587f34b52775d4f6b8816a4310485bef78575: Bug 1512267 - If you set a pres shell resolution, you must scale to it. r=kats,JanH
Botond Ballo <botond@mozilla.com> - Mon, 10 Dec 2018 19:32:59 +0000 - rev 506839
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1512267 - If you set a pres shell resolution, you must scale to it. r=kats,JanH Differential Revision: https://phabricator.services.mozilla.com/D13928
2c2abfb19c1aad5e35d39f0febd96c266be4ed5e: Bug 1501688 Temporary files generated by opening external files with content:// scheme should be sanitized r=JanH
Andrei Lazar <andrei.a.lazar@softvision.ro> - Mon, 10 Dec 2018 15:57:48 +0000 - rev 506801
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1501688 Temporary files generated by opening external files with content:// scheme should be sanitized r=JanH Implemented cache sanitizing for files generated by handling the content:// scheme. Differential Revision: https://phabricator.services.mozilla.com/D11779
c85e2fe3af3bf7617cf737f7dad350b46c436b06: Bug 1501024 WifiScanner should use ApplicationContext r=JanH
Andrei Lazar <andrei.a.lazar@softvision.ro> - Mon, 10 Dec 2018 09:33:18 +0000 - rev 506789
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1501024 WifiScanner should use ApplicationContext r=JanH Fixed lint warning regarding memory leak inside WifiManager constructor. Differential Revision: https://phabricator.services.mozilla.com/D13930