searching for reviewer(Gijs)
62321377e204a921c6cf4282565756267fbea2dc: Bug 1552219. Get rid of unnecessary variables that clutter PrintUtils.printWindow. r=Gijs
Jonathan Watt <jwatt@jwatt.org> - Fri, 03 May 2019 07:34:07 +0100 - rev 533201
Push 11276 by rgurzau@mozilla.com at Mon, 20 May 2019 13:11:24 +0000
Bug 1552219. Get rid of unnecessary variables that clutter PrintUtils.printWindow. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D31488
b8de4598780a6e000e3cd3b8fbde5ba3b972c492: Bug 1456725 - Tabs.jsm: Update documentURI in waitForCondition to handle not yet loaded tabs. r=Gijs
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Thu, 16 May 2019 00:29:14 +0000 - rev 532841
Push 11272 by apavel@mozilla.com at Thu, 16 May 2019 15:28:22 +0000
Bug 1456725 - Tabs.jsm: Update documentURI in waitForCondition to handle not yet loaded tabs. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D31340
bf04bcac450c62314cd6d4deed2b3629651c54e4: Bug 1471522 - Move blocklist target app filter to Blocklist module r=Gijs
Mathieu Leplatre <mathieu@mozilla.com> - Wed, 15 May 2019 22:22:50 +0000 - rev 532831
Push 11272 by apavel@mozilla.com at Thu, 16 May 2019 15:28:22 +0000
Bug 1471522 - Move blocklist target app filter to Blocklist module r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D31222
255211227da24911c8ce2112de7f9d26d2a13bbf: Bug 1501214 - Reusable helper to download Remote Settings attachments r=nanj,glasserc,Gijs
Mathieu Leplatre <mathieu@mozilla.com> - Fri, 10 May 2019 22:57:40 +0000 - rev 532303
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1501214 - Reusable helper to download Remote Settings attachments r=nanj,glasserc,Gijs Reusable helper to download Remote Settings attachments Differential Revision: https://phabricator.services.mozilla.com/D28707
7e1942ace2b27c0905642f3c2ea83c848ba947b1: Bug 1501214 - Reusable helper to download Remote Settings attachments r=nanj,glasserc,Gijs
Mathieu Leplatre <mathieu@mozilla.com> - Wed, 08 May 2019 16:18:07 +0000 - rev 531905
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1501214 - Reusable helper to download Remote Settings attachments r=nanj,glasserc,Gijs Reusable helper to download Remote Settings attachments Differential Revision: https://phabricator.services.mozilla.com/D28707
9518f9e5ecf9e34e618e728dc8725534bd7a0b70: Bug 1547635: PanelMultiView: Don't override keyboard navigation in context menus. r=Gijs
James Teh <jteh@mozilla.com> - Wed, 08 May 2019 05:18:17 +0000 - rev 531818
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1547635: PanelMultiView: Don't override keyboard navigation in context menus. r=Gijs Normally, context menu keyboard handling takes precedence. However, because we have a capturing window keydown listener, our listener takes precedence. Therefore, we need to check for an open context menu and suppress our keyboard handling in this case. Differential Revision: https://phabricator.services.mozilla.com/D29791
6ad2b2b28addd2d74dd85e21caac7e2cb631e776: Bug 1549543 Make search initialization failures more obvious r=Gijs
Andrew Swan <aswan@mozilla.com> - Tue, 07 May 2019 13:46:17 +0000 - rev 531742
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1549543 Make search initialization failures more obvious r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D30094
4d11e2cf33f3513dcd7072a7f6ea2124366054f1: Bug 1395824 Add css for table borders in aboutReader.css r=Gijs
Sonali9 <sonali18317@iiitd.ac.in> - Mon, 06 May 2019 19:00:03 +0000 - rev 531578
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1395824 Add css for table borders in aboutReader.css r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D29957
59dc2743695d817f095bf76acce8de6073b26598: Bug 1532318 - Part 3 : update js code related to the change of nsIHttpChannel r=Gijs
Thomas Nguyen <tnguyen@mozilla.com> - Thu, 02 May 2019 12:34:06 +0000 - rev 531091
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1532318 - Part 3 : update js code related to the change of nsIHttpChannel r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D22787
f6903c331545b2aa793ea72f4a59c39ff2b0a13c: Bug 1546633: PanelMultiView: Send mousedown event when activating a button via the keyboard. r=Gijs
James Teh <jteh@mozilla.com> - Thu, 02 May 2019 10:35:57 +0000 - rev 531071
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1546633: PanelMultiView: Send mousedown event when activating a button via the keyboard. r=Gijs Previously, we sent a command event and a click event. Normally, the command event executes the action, then the click event closes the menu. However, in some cases (e.g. the Library button), there is no command event handler and the mousedown event executes the action instead. Differential Revision: https://phabricator.services.mozilla.com/D29151
216b689c8984878e48ab5aa879510032da0f0a1f: Bug 1545766: PanelMultiView: Don't override keyboard navigation in embedded documents. r=Gijs
James Teh <jteh@mozilla.com> - Thu, 02 May 2019 10:35:49 +0000 - rev 531070
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1545766: PanelMultiView: Don't override keyboard navigation in embedded documents. r=Gijs Extension panels contain embedded documents; i.e. a <browser> element. We want users to be able to tab to these and we want them to be focused automatically if a subview is opened from the keyboard, so treat them as tabbable. However, once an embedded document is focused, we can't manage keyboard navigation inside it, so don't try. Previously, we tried, which meant keys were overridden even though they didn't do anything, breaking keyboard navigation in extensions altogether. Differential Revision: https://phabricator.services.mozilla.com/D28442
041741ce164674137968c39aab0a9c80e84c99db: Bug 1546633: PanelMultiView: Send mousedown event when activating a button via the keyboard. r=Gijs
James Teh <jteh@mozilla.com> - Wed, 01 May 2019 04:01:35 +0000 - rev 530865
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1546633: PanelMultiView: Send mousedown event when activating a button via the keyboard. r=Gijs Previously, we sent a command event and a click event. Normally, the command event executes the action, then the click event closes the menu. However, in some cases (e.g. the Library button), there is no command event handler and the mousedown event executes the action instead. Differential Revision: https://phabricator.services.mozilla.com/D29151
fbc294a6fe785b56a5ef52b5b1ea61d511bebc52: Bug 1545766: PanelMultiView: Don't override keyboard navigation in embedded documents. r=Gijs
James Teh <jteh@mozilla.com> - Wed, 01 May 2019 04:01:35 +0000 - rev 530864
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1545766: PanelMultiView: Don't override keyboard navigation in embedded documents. r=Gijs Extension panels contain embedded documents; i.e. a <browser> element. We want users to be able to tab to these and we want them to be focused automatically if a subview is opened from the keyboard, so treat them as tabbable. However, once an embedded document is focused, we can't manage keyboard navigation inside it, so don't try. Previously, we tried, which meant keys were overridden even though they didn't do anything, breaking keyboard navigation in extensions altogether. Differential Revision: https://phabricator.services.mozilla.com/D28442
542aa98191211b92dec7bb0eae8e8c1cd6f69cd7: Bug 1546599 - Reset FxA avatar menu title on logout r=Gijs
Vijay Budhram <vbudhram@mozilla.com> - Wed, 24 Apr 2019 22:41:27 +0000 - rev 530038
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1546599 - Reset FxA avatar menu title on logout r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D28712
23fa85727bd08cecb31c0bd43f27d9507a6189a6: Bug 1546093 - Fixing typo of about-telemetry-time-stamp-header leading to missing translation in en-US r=Gijs
Christian Frey <christianhfrey@gmail.com> - Wed, 24 Apr 2019 22:35:15 +0000 - rev 530037
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1546093 - Fixing typo of about-telemetry-time-stamp-header leading to missing translation in en-US r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D28734
4e06efa9d48ede0a40fdbb321c870986e72a0cae: Bug 1546737 - Don't use the hidden window in browser_xhr_sandbox.js. r=Gijs
Felipe Gomes <felipc@gmail.com> - Wed, 24 Apr 2019 22:43:04 +0000 - rev 530035
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1546737 - Don't use the hidden window in browser_xhr_sandbox.js. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D28710
f9ccfa09fb6d69c35ddeeaf8984c044e8731ca2a: Bug 1546101 - Fixing argument paramater passed to about-telemetry-settings-explanation to fix release vs pre-release info in about:telemetry r=Gijs
Christian Frey <christianhfrey@gmail.com> - Wed, 24 Apr 2019 22:38:10 +0000 - rev 530034
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1546101 - Fixing argument paramater passed to about-telemetry-settings-explanation to fix release vs pre-release info in about:telemetry r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D28730
92e638c435da77351cd0d9900d9e0d9bf85a610f: Bug 1543080 - Show more options menu on first click r=Gijs
Mark Striemer <mstriemer@mozilla.com> - Wed, 24 Apr 2019 15:10:31 +0000 - rev 530010
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1543080 - Show more options menu on first click r=Gijs There was a bug where the panel would be hidden on the first click on Windows (and I think Linux, too). This was happening because the focusin event would trigger after mousedown and hide the panel on the first click. Then the button would have focus and we wouldn't get a focusin on the second click. This updates the focusin handler to check if this is the first focusin event, and ignore it if the event target matches our triggering event's target. Differential Revision: https://phabricator.services.mozilla.com/D28587
0e2ecd6b6f11a52d15f88c16506a9edc5e4e4e15: Bug 1546378: Write cross process CSP inheritance tests. r=Gijs
Christoph Kerschbaumer <ckerschb@christophkerschbaumer.com> - Wed, 24 Apr 2019 15:21:37 +0000 - rev 529491
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1546378: Write cross process CSP inheritance tests. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D28599
57df9b1a703372161d01f4d5633707e5344c8d3c: Bug 1546378: Write cross process CSP inheritance tests. r=Gijs
Christoph Kerschbaumer <ckerschb@christophkerschbaumer.com> - Wed, 24 Apr 2019 11:45:26 +0000 - rev 529457
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1546378: Write cross process CSP inheritance tests. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D28599
f40a3485926cadae4bb326767a3ff5268a1814ec: Bug 1513646 - Remove Normandy remote-action infrastructure r=Gijs
Michael Cooper <mcooper@mozilla.com> - Tue, 23 Apr 2019 13:23:07 +0000 - rev 529358
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1513646 - Remove Normandy remote-action infrastructure r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D28227
9bc2f8e17d8062bd98fef67460ef0e74d5e0df17: Bug 1546326: Correctly detect missing directories on Windows. r=Gijs
Dave Townsend <dtownsend@oxymoronical.com> - Tue, 23 Apr 2019 17:23:35 +0000 - rev 529333
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1546326: Correctly detect missing directories on Windows. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D28514
6569e4cca483da6fb943a60e3e60ed4c052f7fc6: Bug 1541167 Stop doing synchronous main-thread I/O to validate the blocklist r=Gijs
Andrew Swan <aswan@mozilla.com> - Tue, 23 Apr 2019 16:11:13 +0000 - rev 529328
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1541167 Stop doing synchronous main-thread I/O to validate the blocklist r=Gijs The main change here is moving the old AddonManager.validateBlocklist() into Blocklist.jsm and getting rid of any main-thread I/O. This patch also includes a small functional change: previously we would always copy the application-supplied blocklist.xml into the profile directory. With this change, blocklist.xml is not copied from the application into the profile. This entails an extra open() when we're falling back to the application-supplied blocklist file but saves all the I/O required to actually copy the file. Differential Revision: https://phabricator.services.mozilla.com/D27829
8ab68eea15b8e9585d0dd3ffd7f499b39a808dcb: Bug 1187696 - Toolbar too bright in Reader dark mode r=Gijs
akshitha <akshithashetty84@gmail.com> - Tue, 23 Apr 2019 16:13:27 +0000 - rev 529326
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1187696 - Toolbar too bright in Reader dark mode r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D26331
8015d85e20f5a3721db7998d7cc3234786eed958: Bug 1544863: Explicitly pass csp to createContentWindow(). r=Gijs,baku
Christoph Kerschbaumer <ckerschb@christophkerschbaumer.com> - Tue, 23 Apr 2019 14:37:40 +0000 - rev 529312
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1544863: Explicitly pass csp to createContentWindow(). r=Gijs,baku Differential Revision: https://phabricator.services.mozilla.com/D27871
7d3f2f4c53beb19d3ccd4873a731cf15062170fc: Bug 1544863: Explicitly pass csp to createContentWindow(). r=Gijs,baku
Christoph Kerschbaumer <ckerschb@christophkerschbaumer.com> - Tue, 23 Apr 2019 13:02:40 +0000 - rev 529301
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1544863: Explicitly pass csp to createContentWindow(). r=Gijs,baku Differential Revision: https://phabricator.services.mozilla.com/D27871
8ce092764f601dc1d02c2f7a779ff405796b1b03: Bug 1545962 - Use <template> instead of CDATA for about:preferences r=Gijs
Brian Grinstead <bgrinstead@mozilla.com> - Mon, 22 Apr 2019 22:38:57 +0000 - rev 529238
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1545962 - Use <template> instead of CDATA for about:preferences r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D28280
fc479e4e17f208520ccfa4fd29bacc1a90ba4bfa: Bug 1519514 - make sure document.l10n is initialized before triggering conext menu over a tab in browser_ext_menus_activeTab.js test r=Gijs
Alexander Surkov <surkov.alexander@gmail.com> - Mon, 22 Apr 2019 20:18:02 +0000 - rev 529234
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1519514 - make sure document.l10n is initialized before triggering conext menu over a tab in browser_ext_menus_activeTab.js test r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D28366
7d6de1b4d5f980454e8a924390812743917596f0: Bug 1545052 - Fix broken about:preferences link (Android), r=Gijs
Avery Berninger <berning5@msu.edu> - Mon, 22 Apr 2019 20:37:17 +0000 - rev 529226
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1545052 - Fix broken about:preferences link (Android), r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D28169
61587f94c1729e446879c995386ba60fc31f39ba: Bug 1545983 - Update "Recent Closed Tabs" and "Recent Closed Windows" menus to reference their menupopup correctly r=Gijs
Brian Grinstead <bgrinstead@mozilla.com> - Mon, 22 Apr 2019 10:14:44 +0000 - rev 529157
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1545983 - Update "Recent Closed Tabs" and "Recent Closed Windows" menus to reference their menupopup correctly r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D28298
9e242ede9b1c647366d60fc2bad3b2c78539c31e: Bug 1542334 - Add FxA toolbar menu to app menu r=Gijs
Vijay Budhram <vbudhram@mozilla.com> - Fri, 19 Apr 2019 14:05:24 +0000 - rev 529022
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1542334 - Add FxA toolbar menu to app menu r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D26377
f0c2b4af4d6dd3d69455e184bbbd635a3de48e42: Bug 1539414 - checkboxes are not redrawn on Win7 classic theme r=Gijs
Alexander Surkov <surkov.alexander@gmail.com> - Tue, 16 Apr 2019 16:01:33 +0000 - rev 529018
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1539414 - checkboxes are not redrawn on Win7 classic theme r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D27727
ac2351ce41ef7644f399db4d926e499bbb0db711: Bug 1543828 - Use <bdi> inside video controls content r=Gijs
Brian Grinstead <bgrinstead@mozilla.com> - Thu, 18 Apr 2019 17:45:22 +0000 - rev 528943
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1543828 - Use <bdi> inside video controls content r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D27757
f7a15eb24f3de849d7b42dca8b827ade5354df0e: Bug 1529879: Block changing the profile list when another process has changed it. r=froydnj,Gijs,flod
Dave Townsend <dtownsend@oxymoronical.com> - Tue, 05 Mar 2019 12:51:44 -0800 - rev 528873
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1529879: Block changing the profile list when another process has changed it. r=froydnj,Gijs,flod On startup we record the size and modified time of the profile lists. If changed we refuse to flush any new changes to disk. Also adds a getter to check if they've changed so the UI can do something sensible. All attempts to flush are now checked for success. In some cases in early startup the failure mode isn't great, we just quit startup. The assumption though is that it's extremely unlikely that the files will have changed on disk in the time between when they are read and when profile selection occurs, likely less than a second later. The profile reset flow is changed to only delete the old profile and flush once all the migration has completed, so if something fails the user gets back to their old profile. In testing I ended up having to fix bug 1522584 so background file deletions on a background thread are safer. I haven't implemented any UI tests right now since making modifications to the profiles means modifying the actual user's profiles which I'm not keen to do. See bug 1539868. Differential Revision: https://phabricator.services.mozilla.com/D25278
081a659775d32b167cb0e74b7fb0e7ab1aee7a62: Bug 1529879: Block changing the profile list when another process has changed it. r=froydnj,Gijs,flod
Dave Townsend <dtownsend@oxymoronical.com> - Thu, 18 Apr 2019 04:34:29 +0000 - rev 528793
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1529879: Block changing the profile list when another process has changed it. r=froydnj,Gijs,flod On startup we record the size and modified time of the profile lists. If changed we refuse to flush any new changes to disk. Also adds a getter to check if they've changed so the UI can do something sensible. All attempts to flush are now checked for success. In some cases in early startup the failure mode isn't great, we just quit startup. The assumption though is that it's extremely unlikely that the files will have changed on disk in the time between when they are read and when profile selection occurs, likely less than a second later. The profile reset flow is changed to only delete the old profile and flush once all the migration has completed, so if something fails the user gets back to their old profile. In testing I ended up having to fix bug 1522584 so background file deletions on a background thread are safer. I haven't implemented any UI tests right now since making modifications to the profiles means modifying the actual user's profiles which I'm not keen to do. See bug 1539868. Differential Revision: https://phabricator.services.mozilla.com/D25278
77dbf6f2d6d4f9825e9041946f4cb78c75f5a8dd: Bug 1529879: Block changing the profile list when another process has changed it. r=froydnj,Gijs,flod
Dave Townsend <dtownsend@oxymoronical.com> - Wed, 17 Apr 2019 20:06:20 +0000 - rev 528756
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1529879: Block changing the profile list when another process has changed it. r=froydnj,Gijs,flod On startup we record the size and modified time of the profile lists. If changed we refuse to flush any new changes to disk. Also adds a getter to check if they've changed so the UI can do something sensible. All attempts to flush are now checked for success. In some cases in early startup the failure mode isn't great, we just quit startup. The assumption though is that it's extremely unlikely that the files will have changed on disk in the time between when they are read and when profile selection occurs, likely less than a second later. The profile reset flow is changed to only delete the old profile and flush once all the migration has completed, so if something fails the user gets back to their old profile. In testing I ended up having to fix bug 1522584 so background file deletions on a background thread are safer. I haven't implemented any UI tests right now since making modifications to the profiles means modifying the actual user's profiles which I'm not keen to do. See bug 1539868. Differential Revision: https://phabricator.services.mozilla.com/D25278
f3cde072814736f2e8c533f03b136641b368d51a: Bug 1544909 - Fix appearance of about:telemetry current ping dialog. r=Gijs
Tim Nguyen <ntim.bugs@gmail.com> - Wed, 17 Apr 2019 08:40:12 +0000 - rev 528662
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1544909 - Fix appearance of about:telemetry current ping dialog. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D27851
c4bdde9df1118e74c3922884677ee769697dc987: Bug 1532701 - Disabled checkboxes should not accept label@control being clicked to toggle their checked state. r=Gijs
Jared Wein <jwein@mozilla.com> - Tue, 16 Apr 2019 21:55:48 +0000 - rev 528616
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1532701 - Disabled checkboxes should not accept label@control being clicked to toggle their checked state. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D27825
2a745d4407f448ff7d6d020d7dd4aeb32f4fb139: Bug 1540879 - Stop using deprecated Array generics in tabbox.xml. r=Gijs
Dão Gottwald <dao@mozilla.com> - Wed, 17 Apr 2019 08:38:46 +0000 - rev 528604
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1540879 - Stop using deprecated Array generics in tabbox.xml. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D27754
2d54ea3f62080c6553de8204d701886352291158: Bug 1541062, Remove eval() from updates.js, r=Gijs
Jonas Allmann <jallmann@mozilla.com> - Tue, 16 Apr 2019 15:28:54 +0000 - rev 528527
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1541062, Remove eval() from updates.js, r=Gijs Remove eval() from updates.js Refactor code to make mapping of pageids to js-objects obsolete Remove now unnecessary object attributes from wizard pages in updates.xul Differential Revision: https://phabricator.services.mozilla.com/D25921
7a36097057bd65fecbe440dc3a9364d29ad05744: Bug 1544534: Add carveout for NullPrincipal when asserting if explicit CSP and CSP on Principal are equal. r=Gijs
Christoph Kerschbaumer <ckerschb@christophkerschbaumer.com> - Tue, 16 Apr 2019 14:19:44 +0000 - rev 528501
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1544534: Add carveout for NullPrincipal when asserting if explicit CSP and CSP on Principal are equal. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D27700
ddb852bfc987ae7d695912723271b8021293e695: Bug 1523757 - Convert panelUI.inc.xul to Fluent r=flod,Gijs
Christian Frey <christianhfrey@gmail.com> - Mon, 15 Apr 2019 18:10:46 +0000 - rev 528378
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1523757 - Convert panelUI.inc.xul to Fluent r=flod,Gijs Differential Revision: https://phabricator.services.mozilla.com/D26447
f068f655d8df0c1b618423f295a131b161c6da8c: Bug 1527075 - stop linting intl/l10n/ in m-c given it's linted in github r=Gijs,jaws
Christian Frey <christianhfrey@gmail.com> - Mon, 15 Apr 2019 16:43:02 +0000 - rev 528340
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1527075 - stop linting intl/l10n/ in m-c given it's linted in github r=Gijs,jaws Differential Revision: https://phabricator.services.mozilla.com/D27530
2e5c5542353aa0d9f3c84523a687f3cddbc31c97: Bug 1454865: PanelMultiView: When entering a subview using the keyboard, focus the first button after the Back button in the subview. r=Gijs
James Teh <jteh@mozilla.com> - Mon, 15 Apr 2019 01:38:15 +0000 - rev 528280
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1454865: PanelMultiView: When entering a subview using the keyboard, focus the first button after the Back button in the subview. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D26067
8329ed3a30b94e4467806fd5b9f66782cb1d9132: Bug 1477673: Refactor PanelMultiView keyboard navigation to use a TreeWalker. r=Gijs,johannh
James Teh <jteh@mozilla.com> - Mon, 15 Apr 2019 01:38:08 +0000 - rev 528279
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1477673: Refactor PanelMultiView keyboard navigation to use a TreeWalker. r=Gijs,johannh Previously, this code cached a list of controls on first use and used that for navigation. This refactor addresses several issues: 1. There is now a separate focus order for tab/shift+tab and down/up arrows. This allows menulists, textboxes, etc. which use the arrow keys themselves to be focused with tab, but skipped with the arrows. This means the user won't fall into these controls when using the up/down arrow keys and be confused by the subsequent arrowing behaviour. 2. When a menulist, textbox, etc. is focused, the arrow keys, space and enter are now passed to the control. This is a better fix for handling of the arrow keys by menulists (bug 1522092). It also fixes left arrow in a textarea moving to the previous view instead of moving the caret (bug 1489874). 3. This improves handling of dynamic updates to the panel. For example, elements that are initially disabled and enabled later will be navigable. This is because the next element is determined dynamically by the TreeWalker, rather than using a cached list. 4. The interim fix for bug 1522092 disabled PanelMultiView keyboard navigation. This caused some regressions, including arrow keys/activation on the Site Identity Report a Problem link (bug 1539976) and some controls not being navigable if the Site Identity panel is opened using the mouse (bug 1539984). With the above fixes, we can now re-enable PanelMultiView keyboard navigation in the Site identity panel and thus fix these regressions. 5. Previously, PanelMultiView keyboard navigation was disabled in the main toolbar overflow menu. This is because the search box can be added to the overflow menu, which previously caused problems for the arrow keys. With the above fixes, we can now safely enable PanelMultiView keyboard navigation in the overflow menu. 6. PanelMultiView keyboard tests have been added. Previously, we relied on tests specific to various panels to exercise this functionality. Differential Revision: https://phabricator.services.mozilla.com/D25905
31aea004045a5572adb1a665fca15f19531b4a42: Bug 724457 - Stop using graytext for shortcuts in menus. r=Gijs
Dão Gottwald <dao@mozilla.com> - Fri, 12 Apr 2019 12:42:48 +0000 - rev 528081
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 724457 - Stop using graytext for shortcuts in menus. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D27275
70ed6fa7f92135943a370c39dffb5c0895350b01: Bug 1541045 - Drag space checkbox should be grey out when disabled r=Gijs
Alexander Surkov <surkov.alexander@gmail.com> - Thu, 11 Apr 2019 15:38:57 +0000 - rev 527832
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1541045 - Drag space checkbox should be grey out when disabled r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D27065
3514a3988f2505b9739cea0664c4a2b7579f5d33: Bug 1543143 - deleted bogus selector in aboutLicense.css r=Gijs
nidhi <nimbus2020b@gmail.com> - Thu, 11 Apr 2019 09:23:08 +0000 - rev 527776
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1543143 - deleted bogus selector in aboutLicense.css r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D27039
71363080b33a217ccfb66350a7d44eeaf07c45c2: Bug 1523747 - Move customize mode strings over to fluent, r=Gijs,jaws,flod
Nicholas Cowles <cowlesni@msu.edu> - Wed, 10 Apr 2019 15:46:31 +0000 - rev 527607
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1523747 - Move customize mode strings over to fluent, r=Gijs,jaws,flod Differential Revision: https://phabricator.services.mozilla.com/D26418
1fe827432de458d397fcfc78280bed57291ffc6f: Bug 1542858: Duplicate browser_data_load_inherit_csp.js and use upgrade-insecure-requests. r=Gijs
Christoph Kerschbaumer <ckerschb@christophkerschbaumer.com> - Wed, 10 Apr 2019 12:35:03 +0000 - rev 527569
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1542858: Duplicate browser_data_load_inherit_csp.js and use upgrade-insecure-requests. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D26735