searching for reviewer(Gijs)
f9c4aed5b00f2332f62905b783d5718359559d48: Bug 1811271 - sort blocked DLLs at the top of the list r=Gijs a=pascalc
Greg Stoll <gstoll@mozilla.com> - Mon, 23 Jan 2023 14:51:45 +0000 - rev 721130
Push 17487 by pchevrel@mozilla.com at Thu, 26 Jan 2023 13:22:43 +0000
Bug 1811271 - sort blocked DLLs at the top of the list r=Gijs a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D167292
c37de1807b92df786bb5888ebd05fd7279a3ee9c: Bug 1804414 - Tabstrip animation should respect OS reduced motion pref r=Gijs,emilio a=pascalc
Cieara Meador <cmeador@mozilla.com> - Mon, 23 Jan 2023 22:51:45 +0000 - rev 721125
Push 17484 by pchevrel@mozilla.com at Wed, 25 Jan 2023 10:36:09 +0000
Bug 1804414 - Tabstrip animation should respect OS reduced motion pref r=Gijs,emilio a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D167101
dbf4cdf3d91c5887ccf5fedbe0b4d8f7f57e0ea4: Bug 1810539 - show correct blocked status after reloading about:third-party r=yjuglaret,Gijs a=pascalc
Greg Stoll <gstoll@mozilla.com> - Thu, 19 Jan 2023 15:55:45 +0000 - rev 721082
Push 17462 by pchevrel@mozilla.com at Fri, 20 Jan 2023 16:04:34 +0000
Bug 1810539 - show correct blocked status after reloading about:third-party r=yjuglaret,Gijs a=pascalc Previously if a module was on the dynamic blocklist but had not attempted to load in this run of Firefox, we would always show it as blocked when loading the about:third-party page. This meant that if the user unblocked the module and then reloaded the page, it would show up as blocked, when the intended behavior is to show it as not blocked. (since this is what will happen after Firefox restarts) The fix is to use the same mechanism that we do with modules that have attempted to load: call AboutThirdParty.lookupModuleType() to determine whether it was blocked on launch, and whether it will be blocked the next time Firefox restarts. I went ahead and also added a call to see whether the module was involved in a previous crash, and added that icon as well. I intend to uplift this to Beta, as this can lead to a pretty confusing situation for users where they think they have blocked something but they have not. (or vice versa) Differential Revision: https://phabricator.services.mozilla.com/D167082
2ad6331416aec238ee3a88b9cd640c1619ea4189: Bug 1804064 - Firefox View window should not be saved r=Gijs,kcochrane
Sarah Clements <sclements@mozilla.com> - Wed, 11 Jan 2023 11:59:19 +0000 - rev 720799
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1804064 - Firefox View window should not be saved r=Gijs,kcochrane * If Firefox view tab is the last selected tab when a window is closed it should not be saved; the first tab should be used instead. This patch updates a test, updates the title that is saved and the selected index Differential Revision: https://phabricator.services.mozilla.com/D166362
ab7b84090e375dc46cb2678cdbbe25cf5ee55ea7: Bug 1809465 - Replace _hoveredTab with a private tab property. r=Gijs
Dão Gottwald <dao@mozilla.com> - Tue, 10 Jan 2023 17:10:30 +0000 - rev 720735
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1809465 - Replace _hoveredTab with a private tab property. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D166441
2b00b517fee0f5275ca8ca22254b51d70022be34: Bug 1775638 - Fix flaky browser_adoptTab_failure.js. r=Gijs
Oriol Brufau <oriol-bugzilla@hotmail.com> - Mon, 09 Jan 2023 12:31:49 +0000 - rev 720541
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1775638 - Fix flaky browser_adoptTab_failure.js. r=Gijs _captureRemoteThumbnail was already checking that the provided browser hadn't been removed at the beginning, but due to using "await" this could also happen in the middle, causing an exception. That was the reason for flakyness in browser_adoptTab_failure.js This patch adds extra checks, and replaces "aBrowser.parentNode" with the more meaningful "aBrowser.isConnected", since there is no need to use "parentNode" to get the "ownerDocument". Differential Revision: https://phabricator.services.mozilla.com/D166264
af3799d0f7a53568b853a25582ed6f45606addb4: Bug 1808615 - Make addTab default skipLoad to createLazyBrowser. r=Gijs,extension-reviewers,nika,robwu
Oriol Brufau <oriol-bugzilla@hotmail.com> - Sat, 07 Jan 2023 13:51:47 +0000 - rev 720448
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1808615 - Make addTab default skipLoad to createLazyBrowser. r=Gijs,extension-reviewers,nika,robwu And make callers rely on that instead of allowInheritPrincipal when creating lazy tabs. Unlike allowInheritPrincipal, skipLoad sets the nodefaultsrc attribute. This avoids a load instead of falling back to about:blank. One consequence of that is that switching to a lazy about:blank tab will not notify invoke listeners registered with addTabsProgressListener (listeners registered with addProgressListener will still be invoked). Thus test browser_open_in_lazy_tab.js needs to be updated. Differential Revision: https://phabricator.services.mozilla.com/D166012
2b67bd0dd255a576b4b2dbc7ab1c2614e096ce2d: Bug 1808615 - Make addTab default skipLoad to createLazyBrowser. r=Gijs,extension-reviewers,nika,robwu
Oriol Brufau <oriol-bugzilla@hotmail.com> - Sat, 07 Jan 2023 00:37:36 +0000 - rev 720421
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1808615 - Make addTab default skipLoad to createLazyBrowser. r=Gijs,extension-reviewers,nika,robwu And make callers rely on that instead of allowInheritPrincipal when creating lazy tabs. Differential Revision: https://phabricator.services.mozilla.com/D166012
ef929be929e54e74c1f9bfc7a67668d0031ea340: Bug 1808661 - Remove before-multiselected and beforeMultiselected. r=Gijs,dao
Oriol Brufau <oriol-bugzilla@hotmail.com> - Fri, 06 Jan 2023 21:48:01 +0000 - rev 720415
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1808661 - Remove before-multiselected and beforeMultiselected. r=Gijs,dao Depends on D166026 Differential Revision: https://phabricator.services.mozilla.com/D166027
f7ba804ea8ec6284e075d10a233f22306b40a4e3: Bug 1808661 - Remove last-visible-tab and _lastTab. r=Gijs,dao
Oriol Brufau <oriol-bugzilla@hotmail.com> - Fri, 06 Jan 2023 21:48:01 +0000 - rev 720414
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1808661 - Remove last-visible-tab and _lastTab. r=Gijs,dao Differential Revision: https://phabricator.services.mozilla.com/D166026
7b073cd0f4d7ff866929a504c30fe730eb496116: Bug 1808661 - Remove first-visible-tab and _firstTab. r=Gijs,dao
Oriol Brufau <oriol-bugzilla@hotmail.com> - Fri, 06 Jan 2023 21:48:01 +0000 - rev 720413
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1808661 - Remove first-visible-tab and _firstTab. r=Gijs,dao Differential Revision: https://phabricator.services.mozilla.com/D166025
b9aaf8c0af510f07d6ce137f16bacfb196f70e73: Bug 1808661 - Remove beforeselected-visible and _beforeSelectedTab. r=Gijs,dao
Oriol Brufau <oriol-bugzilla@hotmail.com> - Fri, 06 Jan 2023 21:48:00 +0000 - rev 720412
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1808661 - Remove beforeselected-visible and _beforeSelectedTab. r=Gijs,dao Differential Revision: https://phabricator.services.mozilla.com/D166024
607a282e25f540e03bd140e2475269b538c512ff: Bug 1808661 - Remove before-multiselected and beforeMultiselected. r=Gijs,dao
Oriol Brufau <oriol-bugzilla@hotmail.com> - Fri, 06 Jan 2023 19:38:54 +0000 - rev 720394
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1808661 - Remove before-multiselected and beforeMultiselected. r=Gijs,dao Depends on D166026 Differential Revision: https://phabricator.services.mozilla.com/D166027
c2ad604be36106e5ceea7b2fd761d93abf01b54f: Bug 1808661 - Remove last-visible-tab and _lastTab. r=Gijs,dao
Oriol Brufau <oriol-bugzilla@hotmail.com> - Fri, 06 Jan 2023 19:38:53 +0000 - rev 720393
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1808661 - Remove last-visible-tab and _lastTab. r=Gijs,dao Differential Revision: https://phabricator.services.mozilla.com/D166026
b22c7589a7bbf5ffa272632e03439af8ccc03dbd: Bug 1808661 - Remove first-visible-tab and _firstTab. r=Gijs,dao
Oriol Brufau <oriol-bugzilla@hotmail.com> - Fri, 06 Jan 2023 19:38:53 +0000 - rev 720392
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1808661 - Remove first-visible-tab and _firstTab. r=Gijs,dao Differential Revision: https://phabricator.services.mozilla.com/D166025
b0c1ee751b7aadebaa0fff0356560b36ac83bc87: Bug 1808661 - Remove beforeselected-visible and _beforeSelectedTab. r=Gijs,dao
Oriol Brufau <oriol-bugzilla@hotmail.com> - Fri, 06 Jan 2023 19:38:53 +0000 - rev 720391
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1808661 - Remove beforeselected-visible and _beforeSelectedTab. r=Gijs,dao Differential Revision: https://phabricator.services.mozilla.com/D166024
a6f06d52eb9184158d7b2db06f7ac848b72a3ddd: Bug 1802889 - Resolve Fx View mobile promo message being incorrectly shown when signing out of current FxA device r=Gijs
Kelly Cochrane <kcochrane@mozilla.com> - Fri, 06 Jan 2023 13:11:01 +0000 - rev 720346
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1802889 - Resolve Fx View mobile promo message being incorrectly shown when signing out of current FxA device r=Gijs There are two things I've added here: - The observers for when FxA devices are connected/disconnected were not added/removed as part of this update: https://phabricator.services.mozilla.com/D153069. - When a mobile device is the only synced device beyond the current one (desktop) and you remove the current device (desktop), then sign back in from Fx View Tab Pickup banner, `fxAccounts.device.recentDeviceList` only returns the mobile device for some reason (possibly due to device cache). This causes our checks for a secondary device to fail (as we now only have access to the mobile device from `recentDeviceList`, and we're assuming the one device we DO have access to is our current device - which is not the case). This is why Tab Pickup was incorrectly displaying the "Connect a mobile device" message. I've added a check at the start of `refreshDevices()` to manually refresh the device list (ignoring device cache) if the `recentDeviceList` doesn't contain a device with `isCurrentDevice` set to `true`. This is really a workaround for the caching stuff going on behind the scenes, but this does seem to fix things from our end. Differential Revision: https://phabricator.services.mozilla.com/D165960
b6260907be11fee863350ad1725d25b9f3f90234: Bug 434327 - Fallback to $HOME in absence of $HOME/Desktop r=settings-reviewers,Gijs
Nihal Jere <nihal@nihaljere.xyz> - Thu, 05 Jan 2023 23:45:14 +0000 - rev 720328
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 434327 - Fallback to $HOME in absence of $HOME/Desktop r=settings-reviewers,Gijs There are many Linux systems where $HOME is preferred as the "default" directory to $HOME/Desktop. This prevents the creation of $HOME/Desktop every time about:preferences is opened. Differential Revision: https://phabricator.services.mozilla.com/D165979
ee59d072d5b53c80a2a5fef14a8b76d56da946f3: Bug 1802541 - Throw if Remote Settings client is instantiated in child process (r=Gijs)
Mathieu Leplatre <mathieu@mozilla.com> - Thu, 05 Jan 2023 20:09:36 +0000 - rev 720309
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1802541 - Throw if Remote Settings client is instantiated in child process (r=Gijs) Differential Revision: https://phabricator.services.mozilla.com/D165885
4d1f87d5eb0ecb11adf4fac89416ed4af922de9b: Bug 1805529 - The Sqlite.sys.mjs module may open connections too late on shutdown. r=Gijs
Marco Bonardo <mbonardo@mozilla.com> - Thu, 05 Jan 2023 13:33:23 +0000 - rev 720261
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1805529 - The Sqlite.sys.mjs module may open connections too late on shutdown. r=Gijs Asynchronously opening a connection through the Sqlite module may intersect a shutdown phase so that the request for the connection happens when the phase is still open, but the callback is invoked after the phase has been closed. In this case adding a shutdown blocker to close the connection will fail and async shutdown is likely to crash after waiting for the Sqlite module. In these edge cases it's safer to just close the connection and reject to the consumer. Differential Revision: https://phabricator.services.mozilla.com/D164597
83e148b22444d6f3a3e947fbc85041457a1c69c5: Bug 1808172 - Simplify handling of utility objects in Prompter.jsm. r=Gijs
Mark Banner <standard8@mozilla.com> - Tue, 03 Jan 2023 23:05:11 +0000 - rev 719963
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1808172 - Simplify handling of utility objects in Prompter.jsm. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D165791
a48f11cac5f20eede84e0f01451b12d8c02d26cd: Bug 1808289 - Automatically replace Cu.reportError with console.error (browser/themes, browser/modules). r=Gijs
Mark Banner <standard8@mozilla.com> - Tue, 03 Jan 2023 19:16:20 +0000 - rev 719938
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1808289 - Automatically replace Cu.reportError with console.error (browser/themes, browser/modules). r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D165848
bfdc0c55f440be57981a8dfbbbc2d23cebf7f6dc: Bug 1808289 - Automatically replace Cu.reportError calls with console.error (BrowserGlue.sys.mjs). r=Gijs
Mark Banner <standard8@mozilla.com> - Tue, 03 Jan 2023 19:16:20 +0000 - rev 719937
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1808289 - Automatically replace Cu.reportError calls with console.error (BrowserGlue.sys.mjs). r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D165847
3b50dc7033a3cef412ab116d324f9dbf8e9c6105: Bug 1808115 - Remove the separate EmbedPrompter wrapper, use Prompter instead. r=Gijs,necko-reviewers,geckoview-reviewers,valentin,m_kato
Mark Banner <standard8@mozilla.com> - Tue, 03 Jan 2023 17:19:48 +0000 - rev 719925
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1808115 - Remove the separate EmbedPrompter wrapper, use Prompter instead. r=Gijs,necko-reviewers,geckoview-reviewers,valentin,m_kato We no longer support the legacy add-ons, so this should not be necessary. Differential Revision: https://phabricator.services.mozilla.com/D165764
ccaec9f3c11a1eb01e207a78df4096fea00fafb6: Bug 1802338 - Centralize z-indices that fight in the browser area. r=Gijs
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 03 Jan 2023 13:35:26 +0000 - rev 719886
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1802338 - Centralize z-indices that fight in the browser area. r=Gijs Not sure if this is worth it, your call. But it's a bit clearer to figure out what fights with what. Differential Revision: https://phabricator.services.mozilla.com/D163003
f1cd977f33007e71c03cd7f0c89768624bf23093: Bug 1807975 - Tweak dialog checkbox alignment r=Gijs
Gregory Pappas <gp3033@protonmail.com> - Mon, 02 Jan 2023 13:33:17 +0000 - rev 719826
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1807975 - Tweak dialog checkbox alignment r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D165697
492f77863dcccf4a7d640e5e1090eb28406c2415: Bug 1760460 - Turn gBrowser._removingTabs into a Set. r=Gijs
Oriol Brufau <oriol-bugzilla@hotmail.com> - Sun, 01 Jan 2023 18:09:28 +0000 - rev 719804
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1760460 - Turn gBrowser._removingTabs into a Set. r=Gijs Thus avoiding ugly things like: this._removingTabs.splice(this._removingTabs.indexOf(aTab), 1); Differential Revision: https://phabricator.services.mozilla.com/D165736
59635f1ed0bd911ea5ad727ca568b374ab169e97: Bug 1744362 - Part 8: allow blocking of third-party DLLs on about:third-party r=Gijs,fluent-reviewers,flod
Greg Stoll <gstoll@mozilla.com> - Fri, 30 Dec 2022 20:10:05 +0000 - rev 719776
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1744362 - Part 8: allow blocking of third-party DLLs on about:third-party r=Gijs,fluent-reviewers,flod Differential Revision: https://phabricator.services.mozilla.com/D164490
1b0ce2a20f13235cae99937cd749acfcdaa80665: Bug 1807646 - Fix up dialog checkbox alignment. r=Gijs
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 28 Dec 2022 18:16:53 +0000 - rev 719634
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1807646 - Fix up dialog checkbox alignment. r=Gijs The 100% was resolving to 0 with XUL. That said I don't think we have a multi-line dialog here, and if we had I don't think it'd behave correctly either with or without the patch (or before the regressing bug for that matter). Differential Revision: https://phabricator.services.mozilla.com/D165543
e94e0e699e55cecd6110551f918c46cb9fa90a82: Bug 1807827: Add note to browser-menubar.inc to warn against modifying the Window menu to prevent bugs such as bug 1807697. r=Gijs
Stephen A Pohl <spohl.mozilla.bugs@gmail.com> - Wed, 28 Dec 2022 17:53:12 +0000 - rev 719633
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1807827: Add note to browser-menubar.inc to warn against modifying the Window menu to prevent bugs such as bug 1807697. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D165622
e15c46e9f7e47f252ff16f66b5ab0faa26e42a54: Bug 1807697: Move the 'Tabs sharing devices' menu item for WebRTC from the Window menu to the Tools menu on macOS. r=Gijs
Stephen A Pohl <spohl.mozilla.bugs@gmail.com> - Wed, 28 Dec 2022 14:47:42 +0000 - rev 719625
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1807697: Move the 'Tabs sharing devices' menu item for WebRTC from the Window menu to the Tools menu on macOS. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D165563
da9133df4cd456f433b09bc6a17f21ffb8cea89c: Bug 1744362 - Part 8: allow blocking of third-party DLLs on about:third-party r=Gijs,fluent-reviewers,flod
Greg Stoll <gstoll@mozilla.com> - Tue, 27 Dec 2022 20:06:42 +0000 - rev 719600
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1744362 - Part 8: allow blocking of third-party DLLs on about:third-party r=Gijs,fluent-reviewers,flod Differential Revision: https://phabricator.services.mozilla.com/D164490
8b50446f91e58eb4c93a02483cb7da59e21580aa: Bug 1744362 - Part 8: allow blocking of third-party DLLs on about:third-party r=Gijs,fluent-reviewers,flod
Greg Stoll <gstoll@mozilla.com> - Tue, 27 Dec 2022 12:59:09 +0000 - rev 719569
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1744362 - Part 8: allow blocking of third-party DLLs on about:third-party r=Gijs,fluent-reviewers,flod Differential Revision: https://phabricator.services.mozilla.com/D164490
ab4dceb3ca5172cfe87aa7570339e1e51ec1412e: Bug 1806503 - Automatically replace Cu.reportError with console.error (browser/actors, browser/base). r=Gijs
Mark Banner <standard8@mozilla.com> - Tue, 27 Dec 2022 10:08:58 +0000 - rev 719561
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1806503 - Automatically replace Cu.reportError with console.error (browser/actors, browser/base). r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D165068
bbd4db7fae199c702a470fa953c830aef3432a47: Bug 1807233 - Make treecol labels crop again. r=Gijs
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 26 Dec 2022 10:14:37 +0000 - rev 719539
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1807233 - Make treecol labels crop again. r=Gijs This is the lower-risk fix. Ideally we'd move all the places windows etc to use modern flex layout, but that might be worth doing at some other time. Differential Revision: https://phabricator.services.mozilla.com/D165489
96c9a8df806fe18e86ffc2652dbcbb2e0b42d942: Bug 1803488 - Replace Mozilla Rally with Firefox Relay in about:preferences#moreFromMozilla. r=Gijs,flod,omc-reviewers,fluent-reviewers,settings-reviewers,pdahiya
Shane Hughes <shughes@mozilla.com> - Thu, 22 Dec 2022 00:45:21 +0000 - rev 719329
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1803488 - Replace Mozilla Rally with Firefox Relay in about:preferences#moreFromMozilla. r=Gijs,flod,omc-reviewers,fluent-reviewers,settings-reviewers,pdahiya Differential Revision: https://phabricator.services.mozilla.com/D164747
793ccea62b2b971eca7c6c854cc2dedc378a61ab: Bug 1803488 - Replace Mozilla Rally with Firefox Relay in about:preferences#moreFromMozilla. r=Gijs,flod,omc-reviewers,fluent-reviewers,settings-reviewers,pdahiya
Shane Hughes <shughes@mozilla.com> - Wed, 21 Dec 2022 20:49:44 +0000 - rev 719300
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1803488 - Replace Mozilla Rally with Firefox Relay in about:preferences#moreFromMozilla. r=Gijs,flod,omc-reviewers,fluent-reviewers,settings-reviewers,pdahiya Differential Revision: https://phabricator.services.mozilla.com/D164747
42b0ce8616dad59cd99a71515a237298928824b7: Bug 1806451: Remove superfluous and non-functional inwindowmenu attributes. r=Gijs
Stephen A Pohl <spohl.mozilla.bugs@gmail.com> - Wed, 21 Dec 2022 13:33:33 +0000 - rev 719122
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1806451: Remove superfluous and non-functional inwindowmenu attributes. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D165280
baca9604cdcb14d2164ffb52b51f935d410ead38: Bug 1800733 - Fix macOS keychain values for Opera and Opera GX migrators. r=Gijs
Mike Conley <mconley@mozilla.com> - Tue, 20 Dec 2022 19:26:33 +0000 - rev 719022
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1800733 - Fix macOS keychain values for Opera and Opera GX migrators. r=Gijs It turns out we just had these two values wrong. Using the Keychain Access utility on macOS, I was able to find the right values for both browsers and then do a successfull password import from each. Notably, both Opera and Opera GX share the same Keychain service and account name despite being two separate products. Differential Revision: https://phabricator.services.mozilla.com/D165180
579507cb9fb861a0b59c170af9194a7da76e6714: Bug 1805118 - fix selector so the 'Change Device Name' button state is correct. r=settings-reviewers,Gijs
Mark Hammond <mhammond@skippinet.com.au> - Tue, 20 Dec 2022 01:08:00 +0000 - rev 718933
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1805118 - fix selector so the 'Change Device Name' button state is correct. r=settings-reviewers,Gijs Differential Revision: https://phabricator.services.mozilla.com/D164429
e61e04de54d1b3b90eadfedd3906fa310e887ad3: Bug 1805694 - Allow browser_selectpopup_large to partially fail on win7. r=Gijs
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 19 Dec 2022 16:15:52 +0000 - rev 718860
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1805694 - Allow browser_selectpopup_large to partially fail on win7. r=Gijs I can't repro this at all on win10 with either native or non-native menus, nor hacking my way so that all win7 styles apply, nor on win7 by hand on a VM... So that kinda sucks :( Let's take this very minor regression in this subtest? I don't think it's particularly worrisome (the select looks good in the mochitest failure screenshot and works ok in local testing...). Depends on D164693 Differential Revision: https://phabricator.services.mozilla.com/D165024
252048cddc5d36e06782e75189096188861dda69: Bug 1806195 - Split large select popup tests out of browser_selectpopup.js. r=Gijs
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 19 Dec 2022 11:34:35 +0000 - rev 718824
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1806195 - Split large select popup tests out of browser_selectpopup.js. r=Gijs They fail on win7 only with my patch for bug 1805694 (tried win 10 with and without native menus and nothing, sigh) and I need to debug them. Let's do this while at it, this makes the test run on macOS and Linux too, since browser_selectpopup is sadly disabled on those platforms. Differential Revision: https://phabricator.services.mozilla.com/D164951
6b1770b08548c14ff346416b5d272201f11a8efb: Bug 1805319 - Fix typo in webrtc indicator message id. r=flod,fluent-reviewers,Gijs
Eemeli Aro <eemeli@mozilla.com> - Mon, 19 Dec 2022 10:45:24 +0000 - rev 718819
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1805319 - Fix typo in webrtc indicator message id. r=flod,fluent-reviewers,Gijs Differential Revision: https://phabricator.services.mozilla.com/D165004
e1f4445f79b882792ca036bec4bd560deb623b3c: Bug 1805889 - Stop abusing the options object in the Panel View. r=Gijs
Marco Bonardo <mbonardo@mozilla.com> - Mon, 19 Dec 2022 10:18:22 +0000 - rev 718816
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1805889 - Stop abusing the options object in the Panel View. r=Gijs Make Places views constructors arguments more coherent, passing the root and view elements up to the super class explicitly. Remove the options argument, that was not strictly necessary, the same info can be obtained directly. Rename the "builder" attribute to "afterplacescontent" to clarify what it is and make panel use it, instead of passing an insertionPoint option. Additional cleanups: Make chevron and BMB menus use coherent popupshowing observers. Remove useless .viewElt accessor, .associatedElement can be used instead. Avoid an access to the private _rootElt property from the controller. Differential Revision: https://phabricator.services.mozilla.com/D164827
f446a96d1211c5f27f53b095332a2245b5056f37: Bug 1805415 - Use activateItem() rather than click() to activate menuitems. r=Gijs,extension-reviewers,pip-reviewers,search-reviewers
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 15 Dec 2022 03:11:55 +0000 - rev 718236
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1805415 - Use activateItem() rather than click() to activate menuitems. r=Gijs,extension-reviewers,pip-reviewers,search-reviewers Bug 1805414 will move menu event handling to the DOM. With that change the current synthetic click behavior of XUL menuitems breaks. On current central, we rely on nsMenuFrame::HandleEvent not getting called at all for synthetic clicks, and instead we just fire a command event synchronously here: https://searchfox.org/mozilla-central/rev/a0d4f8f112c5c792ae272bf6ce50763ddd23ffa2/dom/xul/nsXULElement.cpp#1071 After my patch the command event is fired properly (potentially asynchronously too) by the regular menu activation machinery, which is preferable. * They fire a command event synchronously (even though on some platforms like macOS activating a context menu item is async). * They use a totally different codepath from what a user does. * They don't deal with native menus, etc. We have a proper API for this (activateItem) which takes a much more closer codepath to what users do, requires that the menu is shown, etc. Use that API instead for testing. As a benefit, tests now do not need to close the context menu manually when clicking on a menu item (because we trigger the same code path as users clicking the menu). Differential Revision: https://phabricator.services.mozilla.com/D164567
e135135001842522c73b6376a002dbac285daa7b: Bug 1805415 - Use activateItem() rather than click() to activate menuitems. r=Gijs,extension-reviewers,pip-reviewers,search-reviewers
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 14 Dec 2022 10:25:17 +0000 - rev 718136
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1805415 - Use activateItem() rather than click() to activate menuitems. r=Gijs,extension-reviewers,pip-reviewers,search-reviewers Bug 1805414 will move menu event handling to the DOM. With that change the current synthetic click behavior of XUL menuitems breaks. On current central, we rely on nsMenuFrame::HandleEvent not getting called at all for synthetic clicks, and instead we just fire a command event synchronously here: https://searchfox.org/mozilla-central/rev/a0d4f8f112c5c792ae272bf6ce50763ddd23ffa2/dom/xul/nsXULElement.cpp#1071 After my patch the command event is fired properly (potentially asynchronously too) by the regular menu activation machinery, which is preferable. * They fire a command event synchronously (even though on some platforms like macOS activating a context menu item is async). * They use a totally different codepath from what a user does. * They don't deal with native menus, etc. We have a proper API for this (activateItem) which takes a much more closer codepath to what users do, requires that the menu is shown, etc. Use that API instead for testing. As a benefit, tests now do not need to close the context menu manually when clicking on a menu item (because we trigger the same code path as users clicking the menu). Differential Revision: https://phabricator.services.mozilla.com/D164567
c15369379d03e1bed290f423be8879e351e47aca: Bug 1804793 - add missing data-l10n-args for tokenName in changepassword.xhtml r=Gijs
Dana Keeler <dkeeler@mozilla.com> - Tue, 13 Dec 2022 19:59:53 +0000 - rev 718051
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1804793 - add missing data-l10n-args for tokenName in changepassword.xhtml r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D164278
a868f954be082e15cc006e9612f25339c4e8bd89: Bug 1800149 - Part 2: Stop sending some values from a content process in ClickHandler, r=Gijs
Nika Layzell <nika@thelayzells.com> - Tue, 13 Dec 2022 18:35:18 +0000 - rev 718042
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1800149 - Part 2: Stop sending some values from a content process in ClickHandler, r=Gijs Currently we are sending some values, such as principals, from the content process when handling clicks from the ClickHandler actor. This information is already available in the parent process on WindowGlobalParent, so changes the code to fetch the values from there instead. Differential Revision: https://phabricator.services.mozilla.com/D161836
8694ca5957b766e1f81deb60cbb09084ed1d6a73: Bug 1800149 - Part 1: Stop sending some values from a content process in nsContextMenu, r=Gijs,extension-reviewers,robwu
Nika Layzell <nika@thelayzells.com> - Tue, 13 Dec 2022 18:35:18 +0000 - rev 718041
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1800149 - Part 1: Stop sending some values from a content process in nsContextMenu, r=Gijs,extension-reviewers,robwu Currently we are sending some values, such as principals, from the content process when creating a nsContextMenu. This information is already available in the parent process on WindowGlobalParent, so changes the code to fetch the values from there instead. Differential Revision: https://phabricator.services.mozilla.com/D161835
300b0ac8eb7be542901c94bd85ad5d82481ec03f: Bug 1799393 - Prevent hidden Fx View tab from triggering the closing multiple tabs warning in Windows and Linux r=Gijs
Bernard Igiri <bigiri@mozilla.com> - Tue, 13 Dec 2022 14:27:17 +0000 - rev 717989
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1799393 - Prevent hidden Fx View tab from triggering the closing multiple tabs warning in Windows and Linux r=Gijs Updated the tab closing prompt logic to use the number of visible tabs open to determine if the prompt should show in Windows and Linux. Differential Revision: https://phabricator.services.mozilla.com/D162627