searching for reviewer(Gijs)
c609f1155d16: Bug 1403466 - Don't set a max-height on panelviews used by WebExtensions, because it causes browser contents to be cut-off. r=Gijs, a=ritu
Mike de Boer <mdeboer@mozilla.com> - Tue, 10 Oct 2017 12:44:04 +0200 - rev 432405
Push 7950 by ryanvm@gmail.com at 2017-10-12 01:17 +0000
Bug 1403466 - Don't set a max-height on panelviews used by WebExtensions, because it causes browser contents to be cut-off. r=Gijs, a=ritu Setting a max-height caused the '_handleDOMChange' method in ext-browser-content.js to consistently lie about the scrollHeight, since it was never allowed to grow beyond the maxHeight - even when the document needs to be larger to fit its contents. We don't need this aggressiveness in Photon panels anyway, so that makes it doubly safe to remove this code. MozReview-Commit-ID: HJVMXXHS4By
63c9ad5b7e93: Bug 1402126 - Change the icon size of Download items in the Library's Downloads panel view to 32px. r=Gijs, a=ritu
Mike de Boer <mdeboer@mozilla.com> - Thu, 05 Oct 2017 18:06:05 +0200 - rev 432378
Push 7947 by ryanvm@gmail.com at 2017-10-11 18:32 +0000
Bug 1402126 - Change the icon size of Download items in the Library's Downloads panel view to 32px. r=Gijs, a=ritu MozReview-Commit-ID: FE1EftZWmzV
da0c1e20a0cc: Bug 1387808 - Don't ever fixate the width and height of the main view, but leave it flexible. r=Gijs, a=ritu
Mike de Boer <mdeboer@mozilla.com> - Thu, 05 Oct 2017 13:14:02 +0200 - rev 432377
Push 7947 by ryanvm@gmail.com at 2017-10-11 18:32 +0000
Bug 1387808 - Don't ever fixate the width and height of the main view, but leave it flexible. r=Gijs, a=ritu MozReview-Commit-ID: AJw6yI6Onje
cdbd605ca994: Bug 1403734 - Set border radius for customize mode footer buttons. r=Gijs
Dão Gottwald <dao@mozilla.com> - Sat, 07 Oct 2017 21:28:38 +0200 - rev 432355
Push 7944 by dgottwald@mozilla.com at 2017-10-11 09:58 +0000
Bug 1403734 - Set border radius for customize mode footer buttons. r=Gijs MozReview-Commit-ID: 2ZK56nGC5Jt
19123c83cb42: Bug 1406770 - Allow dropping tabs on to the Bookmarks Toolbar Item if it is located in the nav-bar. r=Gijs, a=ritu
Jared Wein <jwein@mozilla.com> - Mon, 09 Oct 2017 11:07:45 -0400 - rev 432328
Push 7930 by ryanvm@gmail.com at 2017-10-09 19:21 +0000
Bug 1406770 - Allow dropping tabs on to the Bookmarks Toolbar Item if it is located in the nav-bar. r=Gijs, a=ritu MozReview-Commit-ID: Ehd7zCiHfsD
0e67208dfe24: Bug 1404716 - Hide GCLI in DOM fullscreen mode. r=Gijs, r=pbrosset, a=ritu
Henri Kemppainen <mozilla@guu.fi> - Wed, 04 Oct 2017 23:52:53 +0300 - rev 432309
Push 7929 by ryanvm@gmail.com at 2017-10-09 18:47 +0000
Bug 1404716 - Hide GCLI in DOM fullscreen mode. r=Gijs, r=pbrosset, a=ritu
96e446025dc6: Bug 1404495 - Back out changeset 3e7cd55f6cb9 to go back to different colors for connecting and loading on unselected tabs. r=Gijs, a=ritu
Jared Wein <jwein@mozilla.com> - Thu, 05 Oct 2017 11:00:37 -0400 - rev 432285
Push 7926 by ryanvm@gmail.com at 2017-10-09 16:55 +0000
Bug 1404495 - Back out changeset 3e7cd55f6cb9 to go back to different colors for connecting and loading on unselected tabs. r=Gijs, a=ritu MozReview-Commit-ID: JTVjsavmob6
cff708b944d7: Bug 1404206 - Part 3: Make GeckoInputConnection handle "mozAwesomebar" inputmode value as "url". r=jchen, r=gijs, a=ritu
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 29 Sep 2017 16:11:20 +0900 - rev 432271
Push 7924 by ryanvm@gmail.com at 2017-10-09 16:07 +0000
Bug 1404206 - Part 3: Make GeckoInputConnection handle "mozAwesomebar" inputmode value as "url". r=jchen, r=gijs, a=ritu Although, Firefox for Android doesn't use urlbarBindings.xml for declaring its awesome bar, for consistency with widget code for desktop OSes, GeckoInputConnection should treat "mozAwesomebar" inputmode value as "url" since Android doesn't have any special input type for "search" and we should keep current behavior. MozReview-Commit-ID: DpUnUx4E2Sp
5fc420351a7d: Bug 1404206 - Part 2: Make TSFTextStore and IMEHandler handle "mozAwesomebar" inputmode value. r=m_kato, r=gijs, a=ritu
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 29 Sep 2017 15:15:14 +0900 - rev 432270
Push 7924 by ryanvm@gmail.com at 2017-10-09 16:07 +0000
Bug 1404206 - Part 2: Make TSFTextStore and IMEHandler handle "mozAwesomebar" inputmode value. r=m_kato, r=gijs, a=ritu When "mozAwesomebar" is set to inputmode value, that means that the Smart Location Bar gets focus. In that case, we should notify IME of input scopes as "URL" because on-screen keyboard for URL has some useful additional keys but they are not hindrances even when users want to type non-URL text. On the other hand, MS-IME for Japanese and Google Japanese Input changes their open state to "closed" if we notify them of URL input scope. A lot of users complain about this behavior. Therefore, we should notify only them of "Default" input scope even when "mozAwesomebar" has focus. MozReview-Commit-ID: DIgqpR7TXQx
9d9b14f8ad09: Bug 1404206 - Part 1: Smart Location Bar should have special inputmode value, mozAwesomebar. r=smaug, r=gijs, a=ritu
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 29 Sep 2017 14:44:06 +0900 - rev 432269
Push 7924 by ryanvm@gmail.com at 2017-10-09 16:07 +0000
Bug 1404206 - Part 1: Smart Location Bar should have special inputmode value, mozAwesomebar. r=smaug, r=gijs, a=ritu Smart Location Bar (a.k.a URL bar) has some features, loading inputted URL directly, searching bookmark items and history items, and search inputted words with registered search engine. So, it does not make sense its inputmode is "url". E.g., neither showing URL specific software keyboard nor switching IME open state automatically for typing URL may not be expected in most cases. Unfortunately, there is no proper inputmode value for Smart Location Bar. Therefore, this patch uses "mozAwesomebar" value and accepts the value only in chrome documents. This value should be handled by each native IME handler properly. MozReview-Commit-ID: 7vUnbpg91F2
f82b14102685: Bug 1401152 - Disable 'add to overflow menu' in the customize mode *palette* context menu for flexible space. r=Gijs, a=ritu
Erica Wright <ewright@mozilla.com> - Thu, 21 Sep 2017 18:15:02 -0400 - rev 432171
Push 7896 by ryanvm@gmail.com at 2017-10-05 00:26 +0000
Bug 1401152 - Disable 'add to overflow menu' in the customize mode *palette* context menu for flexible space. r=Gijs, a=ritu MozReview-Commit-ID: 5sQPsxVaVYz
1c57bb1480fa: Bug 1403382 - Dragging the back button out of the toolbar in customize mode shouldn't affect the toolbar height. r=Gijs, a=sledru
Jared Wein <jwein@mozilla.com> - Mon, 02 Oct 2017 23:30:29 -0400 - rev 432163
Push 7894 by ryanvm@gmail.com at 2017-10-04 16:32 +0000
Bug 1403382 - Dragging the back button out of the toolbar in customize mode shouldn't affect the toolbar height. r=Gijs, a=sledru MozReview-Commit-ID: JOsb2y2pzqz
bc4443239c37: Bug 1396953 - Fix flexible space widget disappearing when adding to toolbar. r=Gijs, a=sledru
Maya Messinger <maya.messinger@duke.edu> - Sat, 30 Sep 2017 18:42:24 -0400 - rev 432160
Push 7894 by ryanvm@gmail.com at 2017-10-04 16:32 +0000
Bug 1396953 - Fix flexible space widget disappearing when adding to toolbar. r=Gijs, a=sledru MozReview-Commit-ID: BuYzvBX439p
90fad10968db: Bug 1401991 - Ensure that we don't hide panelviews that are already reparented to another multi-view and ensure to hide other panels consistently. r=Gijs, a=sledru
Mike de Boer <mdeboer@mozilla.com> - Fri, 29 Sep 2017 13:51:51 +0200 - rev 432159
Push 7894 by ryanvm@gmail.com at 2017-10-04 16:32 +0000
Bug 1401991 - Ensure that we don't hide panelviews that are already reparented to another multi-view and ensure to hide other panels consistently. r=Gijs, a=sledru * Harden the new `hideAllViewsExcept()` to not do erroneous things if called when the binding is already gone. * Generalize things into `hideAllViewsExcept(thisOne)`: - Clear `_viewShowing` in there and do the descriptionHeightWorkaround thing in there too, - For Photon panels, do all the 'current' attribute setting in there. To show a panel during transition, I introduced the 'in-transition' attribute. * I had to make sure not to over-eagerly dispatch 'ViewShowing' events, because that confuses some, * Move the temporary panel handling, which contains an ephemeral panelmultiview instance, internally. This cleans up the hacky, duplicate PanelUI.js code nicely. * Keep a local copy of `_transitionDetails` to ensure it's still there after transition, * Harden `_cleanupTransitionPhase()` to only clear the phase that belongs to a specific transition, _if_ that's passed in as an argument. This resolves any potential raciness that might occur when `showSubView()` is called again mid-transition. * Skip the UITour element visibility check when it's inside a panelview, because too many things need to happen and that check is too simple to be useful in that case. MozReview-Commit-ID: 5HpJKs1Ny5j
3e3b262ee435: Bug 1385882 - Intermittent browser/base/content/test/urlbar/browser_page_action_menu.js | Test timed out. r=Gijs, a=test-only
Drew Willcoxon <adw@mozilla.com> - Mon, 02 Oct 2017 10:55:00 -0700 - rev 432145
Push 7889 by ryanvm@gmail.com at 2017-10-04 00:51 +0000
Bug 1385882 - Intermittent browser/base/content/test/urlbar/browser_page_action_menu.js | Test timed out. r=Gijs, a=test-only MozReview-Commit-ID: 8uzQAPQEldP
569466abab14: Bug 1395674 - Adding subviewbutton-nav class to menu-type toolbarbuttons and display the '>' in the overflow list. r=Gijs, a=ritu
Sam Foster <sfoster@mozilla.com> - Mon, 25 Sep 2017 19:29:04 -0700 - rev 432125
Push 7887 by ryanvm@gmail.com at 2017-10-03 22:12 +0000
Bug 1395674 - Adding subviewbutton-nav class to menu-type toolbarbuttons and display the '>' in the overflow list. r=Gijs, a=ritu MozReview-Commit-ID: I1pGXA3ecxT
0fe06c5dd395: Bug 1402493 - Don't prevent switching back to Reload for top level about: loads. r=Gijs, a=ritu
Jared Wein <jwein@mozilla.com> - Wed, 27 Sep 2017 17:35:09 -0400 - rev 432082
Push 7875 by ryanvm@gmail.com at 2017-10-02 17:16 +0000
Bug 1402493 - Don't prevent switching back to Reload for top level about: loads. r=Gijs, a=ritu In the steps to reproduce of this bug, we get see a load start for about:blank that is not top level. We then see a following load complete (STATE_STOP) that has aWebProgress.isTopLevel=true. This code is really here to prevent flickering from reload->stop->reload for about:home and other about: pages. I don't see any harm in being more agressive when switching back to Reload since that is the default state. MozReview-Commit-ID: 3LygnRLcbA9
c53c961ce407: Bug 1399111 - Keep the loading indicator gray for tabs that have been unselected since load. r=Gijs, a=sledru
Jared Wein <jwein@mozilla.com> - Thu, 28 Sep 2017 14:45:29 -0400 - rev 432059
Push 7873 by ryanvm@gmail.com at 2017-10-02 15:43 +0000
Bug 1399111 - Keep the loading indicator gray for tabs that have been unselected since load. r=Gijs, a=sledru MozReview-Commit-ID: JPEy3XDsGmb
66cc570df716: Bug 1399111 - Tabs that start loading in the background and haven't been selected before completing loading will show a lighter tab burst. r=Gijs, a=sledru
Jared Wein <jwein@mozilla.com> - Wed, 27 Sep 2017 14:34:29 -0400 - rev 432058
Push 7873 by ryanvm@gmail.com at 2017-10-02 15:43 +0000
Bug 1399111 - Tabs that start loading in the background and haven't been selected before completing loading will show a lighter tab burst. r=Gijs, a=sledru MozReview-Commit-ID: FdXwaQr7Glt
ccce663812da: Bug 1403758 - Sync shield-recipe-client v76 from GitHub (commit 2419d02). r=Gijs, a=sledru
Michael Cooper <mcooper@mozilla.com> - Wed, 27 Sep 2017 16:09:56 -0700 - rev 432045
Push 7872 by ryanvm@gmail.com at 2017-10-02 15:07 +0000
Bug 1403758 - Sync shield-recipe-client v76 from GitHub (commit 2419d02). r=Gijs, a=sledru - #1070: Use the correct attribute name when comparing telemetry timestamps. https://github.com/mozilla/normandy/pull/1070 - #1071: Fix #957: Use UpdateUtils.jsm to determine the update channel. https://github.com/mozilla/normandy/pull/1071 MozReview-Commit-ID: Jdpc02PBQRv
f094ee5cc7b3: Bug 1402721 - Add/edit bookmark panel should open anchored on the page action (ellipsis) button instead of on the identity block (left side of the address bar) when the bookmarks star action is not pinned/visible. r=Gijs, a=sledru
Drew Willcoxon <adw@mozilla.com> - Mon, 25 Sep 2017 13:30:08 -0700 - rev 431912
Push 7840 by ryanvm@gmail.com at 2017-09-27 19:24 +0000
Bug 1402721 - Add/edit bookmark panel should open anchored on the page action (ellipsis) button instead of on the identity block (left side of the address bar) when the bookmarks star action is not pinned/visible. r=Gijs, a=sledru MozReview-Commit-ID: JMviXx5ov7F
654ddd2ab34b: Bug 1401314 - Flip the search box images in the preferences when Firefox is running in RTL mode. r=Gijs, a=sledru
Jared Wein <jwein@mozilla.com> - Fri, 22 Sep 2017 10:17:12 -0400 - rev 431910
Push 7840 by ryanvm@gmail.com at 2017-09-27 19:24 +0000
Bug 1401314 - Flip the search box images in the preferences when Firefox is running in RTL mode. r=Gijs, a=sledru MozReview-Commit-ID: DUGDnNDFvFc
555fadd8b835: Bug 1398531 - Toolbarbuttons are standardized with a min-height of 24px, but the zoom percentage button is text-only, thus needs a different treatment. r=Gijs, a=sledru
Mike de Boer <mdeboer@mozilla.com> - Mon, 25 Sep 2017 16:59:50 +0200 - rev 431909
Push 7840 by ryanvm@gmail.com at 2017-09-27 19:24 +0000
Bug 1398531 - Toolbarbuttons are standardized with a min-height of 24px, but the zoom percentage button is text-only, thus needs a different treatment. r=Gijs, a=sledru MozReview-Commit-ID: DaV6HqqY4X8
4e9b841f77f1: Bug 1402023 - Limit the 'Recent Activity' list in the Library to a maximum of 6 items. r=Gijs, a=sledru
Mike de Boer <mdeboer@mozilla.com> - Thu, 21 Sep 2017 18:25:41 +0200 - rev 431903
Push 7840 by ryanvm@gmail.com at 2017-09-27 19:24 +0000
Bug 1402023 - Limit the 'Recent Activity' list in the Library to a maximum of 6 items. r=Gijs, a=sledru MozReview-Commit-ID: AVHRKvAJjWe
d8d8a5dde5bb: Bug 1401383 - Remove anchor state after transition even if the transition is canceled, and always set main view as current. r=Gijs, a=sledru
Mike de Boer <mdeboer@mozilla.com> - Thu, 21 Sep 2017 22:18:07 +0200 - rev 431901
Push 7840 by ryanvm@gmail.com at 2017-09-27 19:24 +0000
Bug 1401383 - Remove anchor state after transition even if the transition is canceled, and always set main view as current. r=Gijs, a=sledru We weren't removing the 'open' attribute from the anchor if the transition didn't complete. This patch fixes this by moving the addition of 'open' into _transitionViews, and its removal into _cleanupTransitionPhase. MozReview-Commit-ID: TS0CcwsHVN
b9fd8bc899fa: Bug 1401735 - Move the toolbarbutton badge slightly down in the bookmarks toolbar. r=Gijs, a=sledru
Johann Hofmann <jhofmann@mozilla.com> - Thu, 21 Sep 2017 11:47:32 +0200 - rev 431824
Push 7820 by ryanvm@gmail.com at 2017-09-25 13:42 +0000
Bug 1401735 - Move the toolbarbutton badge slightly down in the bookmarks toolbar. r=Gijs, a=sledru MozReview-Commit-ID: Hp1t8YWtQ9r
bc83af76203e: Bug 1399177 - Pull label out of description in update popups. r=Gijs, a=sledru
Doug Thayer <dothayer@mozilla.com> - Wed, 20 Sep 2017 15:58:25 -0700 - rev 431794
Push 7814 by ryanvm@gmail.com at 2017-09-24 21:16 +0000
Bug 1399177 - Pull label out of description in update popups. r=Gijs, a=sledru The margin rules for labels mean that if the See what's new link starts its own line, the alignment looks off. We could override this, but matching the styling for "Learn more" links, which get their own line, seemed the better option. MozReview-Commit-ID: 4WK9QtRMUQs
6fae3d9c774a: Bug 1401223 - Flip badged menu icon direction under rtl r=Gijs
Doug Thayer <dothayer@mozilla.com> - Wed, 20 Sep 2017 09:03:23 -0700 - rev 431583
Push 7785 by ryanvm@gmail.com at 2017-09-21 13:39 +0000
Bug 1401223 - Flip badged menu icon direction under rtl r=Gijs When it's badged, the icon is no longer symmetrical. MozReview-Commit-ID: 2dNHiixAqdm
81457c208695: Bug 1398531 - Toolbarbuttons are standardized with a min-height of 24px, but the zoom percentage button is text-only, thus needs a different treatment. r=Gijs
Mike de Boer <mdeboer@mozilla.com> - Wed, 20 Sep 2017 15:19:44 +0200 - rev 431514
Push 7784 by ryanvm@gmail.com at 2017-09-21 00:40 +0000
Bug 1398531 - Toolbarbuttons are standardized with a min-height of 24px, but the zoom percentage button is text-only, thus needs a different treatment. r=Gijs MozReview-Commit-ID: 3PEESkH7J7T
5a1251678a2c: Bug 1388422 - Remove all traces of the Customize Mode tip panel that no longer applies. r=Gijs
Mike de Boer <mdeboer@mozilla.com> - Wed, 20 Sep 2017 14:37:53 +0200 - rev 431513
Push 7784 by ryanvm@gmail.com at 2017-09-21 00:40 +0000
Bug 1388422 - Remove all traces of the Customize Mode tip panel that no longer applies. r=Gijs MozReview-Commit-ID: IffDnXEqooR
3440f3e480eb: Bug 1388422 - Clean up all traces of the 'browser.uiCustomization.disableAnimation' pref used to disable Customize Mode transitions in unit tests. r=Gijs
Mike de Boer <mdeboer@mozilla.com> - Wed, 20 Sep 2017 14:25:58 +0200 - rev 431512
Push 7784 by ryanvm@gmail.com at 2017-09-21 00:40 +0000
Bug 1388422 - Clean up all traces of the 'browser.uiCustomization.disableAnimation' pref used to disable Customize Mode transitions in unit tests. r=Gijs MozReview-Commit-ID: 44Q9NbKEJeC
736598341c09: Bug 1379357 - Ensure that the zoom button the app menu has a fixed width to fit the 100% label, so that the buttons next to it don't move when the label gets slimmer. r=Gijs
Mike de Boer <mdeboer@mozilla.com> - Wed, 20 Sep 2017 15:13:00 +0200 - rev 431511
Push 7784 by ryanvm@gmail.com at 2017-09-21 00:40 +0000
Bug 1379357 - Ensure that the zoom button the app menu has a fixed width to fit the 100% label, so that the buttons next to it don't move when the label gets slimmer. r=Gijs MozReview-Commit-ID: Jp4ZQXamZBc
c613a3d09cc1: Bug 1380021 - Remove 5000ms timeout from browser_PageActions.js test. r=Gijs
Drew Willcoxon <adw@mozilla.com> - Tue, 19 Sep 2017 16:29:50 -0700 - rev 431478
Push 7784 by ryanvm@gmail.com at 2017-09-21 00:40 +0000
Bug 1380021 - Remove 5000ms timeout from browser_PageActions.js test. r=Gijs MozReview-Commit-ID: EQBbKIdN235
b968bfa07de0: Bug 1384078 - Prevent enter key from closing extension panels. r=Gijs, a=lizzard FIREFOX_56b13_RELBRANCH
Kris Maglione <maglione.k@gmail.com> - Tue, 19 Sep 2017 16:37:07 -0700 - rev 431387
Push 7783 by ryanvm@gmail.com at 2017-09-21 00:21 +0000
Bug 1384078 - Prevent enter key from closing extension panels. r=Gijs, a=lizzard MozReview-Commit-ID: DnpiIUc4RkH
2bd5e6f26886: Bug 1386726 - Fix alignment of banner item labels in the hamburger menu. r=Gijs
Sam Foster <sfoster@mozilla.com> - Mon, 18 Sep 2017 16:43:16 -0700 - rev 431327
Push 7782 by ryanvm@gmail.com at 2017-09-20 11:51 +0000
Bug 1386726 - Fix alignment of banner item labels in the hamburger menu. r=Gijs * The start padding should match the 12px defined for nearby toolbarbuttons: .subview-subheader, panelview .toolbarbutton-1, .subviewbutton, .widget-overflow-list .toolbarbutton-1 * Add override for OSX which uses 18px for this padding * Adjust margin for the right/end icon in banner items MozReview-Commit-ID: 81u97Wf8qXr
c0decd9037fe: Bug 1401236 - Don't reread already loaded data in `JSONFile#load`. r=Gijs
Kit Cambridge <kit@yakshaving.ninja> - Tue, 19 Sep 2017 09:59:27 -0700 - rev 431312
Push 7782 by ryanvm@gmail.com at 2017-09-20 11:51 +0000
Bug 1401236 - Don't reread already loaded data in `JSONFile#load`. r=Gijs MozReview-Commit-ID: AHD5G453GHM
0ea61fd5fecd: Bug 1384078: Prevent enter key from closing extension panels. r=Gijs
Kris Maglione <maglione.k@gmail.com> - Tue, 19 Sep 2017 16:37:07 -0700 - rev 431310
Push 7782 by ryanvm@gmail.com at 2017-09-20 11:51 +0000
Bug 1384078: Prevent enter key from closing extension panels. r=Gijs MozReview-Commit-ID: DnpiIUc4RkH
d94508124715: Bug 1401249 - Fix getStringPref usage in clicktoplay-rollout. r=Gijs
Felipe Gomes <felipc@gmail.com> - Tue, 19 Sep 2017 13:32:19 -0300 - rev 431272
Push 7781 by ryanvm@gmail.com at 2017-09-20 00:42 +0000
Bug 1401249 - Fix getStringPref usage in clicktoplay-rollout. r=Gijs getStringPref(.., undefined) actually returns null instead of undefined. MozReview-Commit-ID: H7aSQGnH8rK
df4f51e18090: Bug 1354536 - Part 3 - When the Library view is shown, populate a new 'Recent Highlights' section with at most 12 items as in about:newtab. r=Gijs
Mike de Boer <mdeboer@mozilla.com> - Tue, 19 Sep 2017 16:17:16 +0200 - rev 431266
Push 7781 by ryanvm@gmail.com at 2017-09-20 00:42 +0000
Bug 1354536 - Part 3 - When the Library view is shown, populate a new 'Recent Highlights' section with at most 12 items as in about:newtab. r=Gijs MozReview-Commit-ID: Bs1RzL0uewH
fa4c0d777076: Bug 1389966 - Make toolbarbuttons in the bookmarks toolbar adjust to toolbar height. r=Gijs
Johann Hofmann <jhofmann@mozilla.com> - Mon, 18 Sep 2017 23:41:51 +0200 - rev 431157
Push 7781 by ryanvm@gmail.com at 2017-09-20 00:42 +0000
Bug 1389966 - Make toolbarbuttons in the bookmarks toolbar adjust to toolbar height. r=Gijs Regular bookmark items can grow flexibly because they apply hover background and padding on the parent toolbarbutton element instead of its contents, like .toolbarbutton-1 does. This patch adds a few hacky overrides to fix that. MozReview-Commit-ID: 9225cIxcY3o
05b18d3ca801: Bug 1399936: Migrate active preference experiment values to new storage. r=Gijs a=lizzard FIREFOX_56b13_RELBRANCH
Michael Kelly <mkelly@mozilla.com> - Tue, 19 Sep 2017 12:21:47 -0700 - rev 431120
Push 7780 by ryanvm@gmail.com at 2017-09-19 21:16 +0000
Bug 1399936: Migrate active preference experiment values to new storage. r=Gijs a=lizzard If a user is enrolled in a preference experiment when Firefox upgrades, the pref branch for storing experiment values will be empty on startup, causing no prefs to be set. This, in turn, triggers the check in PreferenceExperiments.init for prefs that differ from their experimental value, and unenrolls the user. The solution is to store a pref flag marking if the user has been migrated. If they have not, we take a one-time hit to startup perf and load the experiment storage, saving it to the new pref storage and marking the user as migrated. Since initExperimentPrefs is now async, by the time we decide to add an observer for UI_AVAILABLE_NOTIFICATION, the event may have already fired. We now instead add the observer before the first wait, so that it is added synchronously when startup is called. In addition, startup now sets a deferred when called, and shutdown waits for it to be resolved before doing anything. This avoids issues when shutdown occurs while startup is still executing, since shutdown now waits until startup is complete. MozReview-Commit-ID: 74VHHt18qnw
b138397a1343: Bug 1401249 - Fix getStringPref usage in clicktoplay-rollout. r=Gijs a=lizzard FIREFOX_56b13_RELBRANCH
Felipe Gomes <felipc@gmail.com> - Tue, 19 Sep 2017 17:15:00 -0300 - rev 431119
Push 7780 by ryanvm@gmail.com at 2017-09-19 21:16 +0000
Bug 1401249 - Fix getStringPref usage in clicktoplay-rollout. r=Gijs a=lizzard getStringPref(.., undefined) actually returns null instead of undefined. MozReview-Commit-ID: Lor44Q891Hg
206b2ca14b91: Bug 1400024 - Clicks on Zoom label in Photon app menu shouldn't close the menu. r=Gijs
Drew Willcoxon <adw@mozilla.com> - Mon, 18 Sep 2017 13:13:13 -0700 - rev 431072
Push 7777 by ryanvm@gmail.com at 2017-09-19 13:41 +0000
Bug 1400024 - Clicks on Zoom label in Photon app menu shouldn't close the menu. r=Gijs MozReview-Commit-ID: 6zHRb27RBGw
0ad97b0a82c4: Bug 1394947 fix toggling the extension sidebars from menus, r=Gijs
Shane Caraveo <scaraveo@mozilla.com> - Mon, 11 Sep 2017 14:48:18 -0700 - rev 431070
Push 7777 by ryanvm@gmail.com at 2017-09-19 13:41 +0000
Bug 1394947 fix toggling the extension sidebars from menus, r=Gijs MozReview-Commit-ID: G2LGIzSl9Be
a952a23d3f14: Bug 1384464 - Intermittent browser/base/content/test/urlbar/browser_page_action_menu.js. r=Gijs
Drew Willcoxon <adw@mozilla.com> - Mon, 18 Sep 2017 13:01:56 -0700 - rev 431068
Push 7777 by ryanvm@gmail.com at 2017-09-19 13:41 +0000
Bug 1384464 - Intermittent browser/base/content/test/urlbar/browser_page_action_menu.js. r=Gijs MozReview-Commit-ID: A2rypvJjvcz
ff7917ed161f: Bug 1400751 - Bookmark star and Pocket animations are misaligned in touch mode. r=Gijs
Drew Willcoxon <adw@mozilla.com> - Mon, 18 Sep 2017 10:49:25 -0700 - rev 431061
Push 7777 by ryanvm@gmail.com at 2017-09-19 13:41 +0000
Bug 1400751 - Bookmark star and Pocket animations are misaligned in touch mode. r=Gijs MozReview-Commit-ID: 1znCd1vrLpF
bc0b0b1a63fe: Bug 1392066 - #stop-button and #reload-button should fill available width when in the overflow menu. r=Gijs
Sam Foster <sfoster@mozilla.com> - Fri, 15 Sep 2017 10:58:02 -0700 - rev 431058
Push 7777 by ryanvm@gmail.com at 2017-09-19 13:41 +0000
Bug 1392066 - #stop-button and #reload-button should fill available width when in the overflow menu. r=Gijs MozReview-Commit-ID: 1mglm8YmvTV
3f31cf842931: Bug 1400202 - Move URI/domain tests out of browser_UsageTelemetry.js. r=Gijs
Alessio Placitelli <alessio.placitelli@gmail.com> - Fri, 15 Sep 2017 15:12:15 +0200 - rev 430936
Push 7775 by ryanvm@gmail.com at 2017-09-19 01:22 +0000
Bug 1400202 - Move URI/domain tests out of browser_UsageTelemetry.js. r=Gijs MozReview-Commit-ID: LZYwQGhwEuN
76264c3da3f9: Bug 951965 - Make sure checking PanelUI.panel state after the popuphidden event, r=Gijs
Fischer.json <fischer.json@gmail.com> - Sun, 17 Sep 2017 18:02:53 +0800 - rev 430934
Push 7775 by ryanvm@gmail.com at 2017-09-19 01:22 +0000
Bug 951965 - Make sure checking PanelUI.panel state after the popuphidden event, r=Gijs This commit makes sure checking PanelUI.panel state is "closed" after the popuphidden event so as to avoid the intermittent fialure because of the too early checking. MozReview-Commit-ID: LinQbytw0lC
1aaa09eb300c: Bug 1387846 change print button command to print instead of print preview on all platforms r=Gijs
Maya Messinger <maya.messinger@duke.edu> - Sun, 17 Sep 2017 17:23:00 -0400 - rev 430916
Push 7775 by ryanvm@gmail.com at 2017-09-19 01:22 +0000
Bug 1387846 change print button command to print instead of print preview on all platforms r=Gijs MozReview-Commit-ID: IIxhCx4N362