searching for reviewer(Gijs)
f0f24bd868b5: Bug 1518786 - Wait until Fluent strings have been applied before sizing the window to content. r=Gijs, a=RyanVM
Jared Wein <jwein@mozilla.com> - Thu, 17 Jan 2019 11:46:54 -0500 - rev 506765
Push 10537 by ryanvm@gmail.com at Thu, 17 Jan 2019 22:30:14 +0000
Bug 1518786 - Wait until Fluent strings have been applied before sizing the window to content. r=Gijs, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D16866
8f38ca46fb44: Backed out changeset d05c6310d573 (bug 1509906) for increasing the severity of bug 1518863. r=Gijs, a=RyanVM
Ryan VanderMeulen <ryanvm@gmail.com> - Mon, 14 Jan 2019 12:08:11 -0500 - rev 506691
Push 10513 by ryanvm@gmail.com at Mon, 14 Jan 2019 17:23:31 +0000
Backed out changeset d05c6310d573 (bug 1509906) for increasing the severity of bug 1518863. r=Gijs, a=RyanVM
4195e37ecbe5: Bug 1513149 - Hovering the action buttons doesn't display the command associated with the button. r=Gijs, a=RyanVM
Paolo Amadini <paolo.mozmail@amadzone.org> - Tue, 11 Dec 2018 18:27:01 +0000 - rev 506338
Push 10372 by ryanvm@gmail.com at Thu, 20 Dec 2018 14:13:57 +0000
Bug 1513149 - Hovering the action buttons doesn't display the command associated with the button. r=Gijs, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D14172
3df85c62c1d8: Bug 1362841 - Mirror the theme icons in customize mode in RTL to match the UI. r=gijs, a=RyanVM
P Kausthubh S <spkausthubh@gmail.com> - Sat, 15 Dec 2018 09:40:19 +0000 - rev 506273
Push 10354 by ryanvm@gmail.com at Mon, 17 Dec 2018 18:06:18 +0000
Bug 1362841 - Mirror the theme icons in customize mode in RTL to match the UI. r=gijs, a=RyanVM
68faf9528d57: Bug 1504038 - Fix preference name styling on OS X on about:studies r=mythmon,Gijs
rdalal <rdalal@mozilla.com> - Fri, 07 Dec 2018 16:35:38 +0000 - rev 506070
Push 10304 by csabou@mozilla.com at Mon, 10 Dec 2018 13:40:42 +0000
Bug 1504038 - Fix preference name styling on OS X on about:studies r=mythmon,Gijs Differential Revision: https://phabricator.services.mozilla.com/D13877
9c4695c40e9d: Bug 1511454 - Migrate about:plugins to use Fluent for localization r=flod,Gijs,zbraniecki
Qinghao_Jack_Song <songqing@msu.edu> - Wed, 05 Dec 2018 16:06:15 +0000 - rev 505868
Push 10301 by archaeopteryx@coole-files.de at Thu, 06 Dec 2018 16:36:14 +0000
Bug 1511454 - Migrate about:plugins to use Fluent for localization r=flod,Gijs,zbraniecki Differential Revision: https://phabricator.services.mozilla.com/D13681
16e07c6f1e1d: Bug 1508131 - Migrate about:serviceworkers to use Fluent for localization r=Gijs,flod,zbraniecki
Qinghao_Jack_Song <songqing@msu.edu> - Tue, 04 Dec 2018 23:27:45 +0000 - rev 505824
Push 10301 by archaeopteryx@coole-files.de at Thu, 06 Dec 2018 16:36:14 +0000
Bug 1508131 - Migrate about:serviceworkers to use Fluent for localization r=Gijs,flod,zbraniecki Differential Revision: https://phabricator.services.mozilla.com/D13571
4002b751596e: Bug 1414804 - Fix test for expired certificate "helpful" messaging to users with broken system clocks. r=Gijs
Johann Hofmann <jhofmann@mozilla.com> - Tue, 04 Dec 2018 19:31:41 +0000 - rev 505756
Push 10301 by archaeopteryx@coole-files.de at Thu, 06 Dec 2018 16:36:14 +0000
Bug 1414804 - Fix test for expired certificate "helpful" messaging to users with broken system clocks. r=Gijs We initially thought we would need a new test certificate to be able to test clock skew, but I found that we can reliably produce the clock skew page by making Firefox believe that the validity range of the cert used by expired.example.com is the correct date. How we do that is described in more detail in the test comments. This patch also updates the formatter for the new clock skew page to not show hours and minutes, as it did previously on the old clock skew warnings. Differential Revision: https://phabricator.services.mozilla.com/D13690
2c9bc41949ee: Bug 1499470 - Provide option to opt-out of add-on recommendations r=mixedpuppy,flod,Gijs
Mark Striemer <mstriemer@mozilla.com> - Fri, 30 Nov 2018 14:19:04 +0000 - rev 505513
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1499470 - Provide option to opt-out of add-on recommendations r=mixedpuppy,flod,Gijs Differential Revision: https://phabricator.services.mozilla.com/D13168
87ba3805b069: Bug 1510631 - Allow items to be placed on the left of the toolbar menubar spacer. r=Gijs
Mike Conley <mconley@mozilla.com> - Wed, 28 Nov 2018 20:43:26 +0000 - rev 505008
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1510631 - Allow items to be placed on the left of the toolbar menubar spacer. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D13290
db4247c27127: Bug 1510700 wait for ContextualIdentityService before updating Discovery cookies r=Gijs
Shane Caraveo <scaraveo@mozilla.com> - Wed, 28 Nov 2018 19:14:10 +0000 - rev 504993
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1510700 wait for ContextualIdentityService before updating Discovery cookies r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D13291
ff378a3336a5: Bug 1498448 - Migrate Certificate Manager Dialog to use fluent for localization r=Gijs,flod,zbraniecki
Qinghao_Jack_Song <songqing@msu.edu> - Wed, 28 Nov 2018 10:30:06 +0000 - rev 504921
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1498448 - Migrate Certificate Manager Dialog to use fluent for localization r=Gijs,flod,zbraniecki Differential Revision: https://phabricator.services.mozilla.com/D8499
24657145bfd4: Bug 1440778 - Implement show-heartbeat as internal Normandy action r=Gijs
Michael Cooper <mcooper@mozilla.com> - Tue, 27 Nov 2018 21:42:44 +0000 - rev 504835
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1440778 - Implement show-heartbeat as internal Normandy action r=Gijs The original, server-side implementation of this action was at https://github.com/mozilla/normandy/blob/68d3e55a9d8605bda793620640d074d7e5503e37/client/actions/show-heartbeat/index.js Differential Revision: https://phabricator.services.mozilla.com/D12345
dd482dcb9a31: Bug 1440778 - Implement show-heartbeat as internal Normandy action r=Gijs
Michael Cooper <mcooper@mozilla.com> - Tue, 27 Nov 2018 19:22:19 +0000 - rev 504797
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1440778 - Implement show-heartbeat as internal Normandy action r=Gijs The original, server-side implementation of this action was at https://github.com/mozilla/normandy/blob/68d3e55a9d8605bda793620640d074d7e5503e37/client/actions/show-heartbeat/index.js Differential Revision: https://phabricator.services.mozilla.com/D12345
374a4bf1482e: Bug 1489531 Expose telemetry client_id hash to about:addons via cookie r=Gijs,chutten
Shane Caraveo <scaraveo@mozilla.com> - Mon, 26 Nov 2018 15:26:39 +0000 - rev 504427
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1489531 Expose telemetry client_id hash to about:addons via cookie r=Gijs,chutten Differential Revision: https://phabricator.services.mozilla.com/D9317
326ed3b7c894: Bug 1471811 - "ReferenceError: Services is not defined" in autocomplete.xml. r=Gijs,jorgk
Marco Bonardo <mbonardo@mozilla.com> - Mon, 26 Nov 2018 12:14:14 +0000 - rev 504404
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1471811 - "ReferenceError: Services is not defined" in autocomplete.xml. r=Gijs,jorgk Differential Revision: https://phabricator.services.mozilla.com/D12889
deed2b6607e9: Bug 1508979 - Fix global-scope pollution from browser-plugins.js. r=Gijs
Dão Gottwald <dao@mozilla.com> - Fri, 23 Nov 2018 18:07:39 +0000 - rev 504324
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1508979 - Fix global-scope pollution from browser-plugins.js. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D12528
525056685553: Bug 1508778 - [RTL] Background image overlapping the text in about:sessionrestore r=Gijs
Qinghao_Jack_Song <songqing@msu.edu> - Thu, 22 Nov 2018 19:47:27 +0000 - rev 504179
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1508778 - [RTL] Background image overlapping the text in about:sessionrestore r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D12666
c18244a41538: Bug 1505751 - Wait for menulist close for browser language handlers r=Gijs
Mark Striemer <mstriemer@mozilla.com> - Wed, 21 Nov 2018 15:36:52 +0000 - rev 504052
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1505751 - Wait for menulist close for browser language handlers r=Gijs The search handler was being called when focusing the menuitem with the keyboard on Windows. This didn't provide a good experience and left the popup open once the search started. Ensure the popup is always shown when using the keyboard and don't trigger the search until the popup is closed. Differential Revision: https://phabricator.services.mozilla.com/D12324
729cedad7137: Bug 1364957 - Fix about: scheme check for FX_PAGE_LOAD_MS_2 r=Gijs
Tim D. Smith <tdsmith@mozilla.com> - Wed, 21 Nov 2018 08:52:10 +0000 - rev 503926
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1364957 - Fix about: scheme check for FX_PAGE_LOAD_MS_2 r=Gijs We should be ignoring about: URIs for the page load time metric, since they load very quickly and aren't representative of Web page load times. Differential Revision: https://phabricator.services.mozilla.com/D12492
85c1c4e2b17e: Bug 1508980 - Add more .eslintrc.js files for dom/ and update .eslintignore. r=Gijs
Mark Banner <standard8@mozilla.com> - Wed, 21 Nov 2018 14:27:27 +0000 - rev 503902
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1508980 - Add more .eslintrc.js files for dom/ and update .eslintignore. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D12529
8f7476054232: Bug 1507875 - Remove the customizable ui toolbarpaletteitem binding;r=Gijs
Brian Grinstead <bgrinstead@mozilla.com> - Tue, 20 Nov 2018 17:01:48 +0000 - rev 503683
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1507875 - Remove the customizable ui toolbarpaletteitem binding;r=Gijs This removes the wrapping box inside the anonymous content, and replaces the anonymous label with an ::after CSS rule that sets text based on the [title] attribute. Because it doesn't replicate the anonymous wrapping box with light DOM: - Calling JS don't need to be updated (the child added via appendChild is still a direct descendant of the element). - Many CSS selectors don't need to be updated (if they were targeting the slotted children as direct descendants. However, CSS selectors that were targeting the anonymous content directly do need to be updated, since those nodes are removed. Differential Revision: https://phabricator.services.mozilla.com/D12172
51c30c756ab0: Bug 1502146 - Reduce impact of RemoteSettings synchronization on main thread r=Gijs
Mathieu Leplatre <mathieu@mozilla.com> - Tue, 20 Nov 2018 14:00:06 +0000 - rev 503639
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1502146 - Reduce impact of RemoteSettings synchronization on main thread r=Gijs Move JSON dump loading and CanonicalJSON serialization to a worker to reduce impact on main thread Differential Revision: https://phabricator.services.mozilla.com/D10064
dd005e464db2: Bug 1507301 - Migrate about:sessionrestore and about:welcomeback to use Fluent for localization r=Gijs,flod,zbraniecki
Qinghao_Jack_Song <songqing@msu.edu> - Mon, 19 Nov 2018 22:01:58 +0000 - rev 503618
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1507301 - Migrate about:sessionrestore and about:welcomeback to use Fluent for localization r=Gijs,flod,zbraniecki Differential Revision: https://phabricator.services.mozilla.com/D11994
81abb539b39c: Bug 1502146 - Reduce impact of RemoteSettings synchronization on main tread r=Gijs
Mathieu Leplatre <mathieu@mozilla.com> - Mon, 19 Nov 2018 21:56:28 +0000 - rev 503493
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1502146 - Reduce impact of RemoteSettings synchronization on main tread r=Gijs Move JSON dump loading and CanonicalJSON serialization to a worker to reduce impact on main thread Differential Revision: https://phabricator.services.mozilla.com/D10064
d765759658a2: Bug 1506816 - Check for action errors in Normandy tests, and fix revealed problems. r=Gijs
Michael Cooper <mcooper@mozilla.com> - Mon, 19 Nov 2018 18:23:54 +0000 - rev 503456
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1506816 - Check for action errors in Normandy tests, and fix revealed problems. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D12156
ae7984aa4803: Bug 1500424 - Remove customizable ui toolbar-drag binding;r=Gijs
Brian Grinstead <bgrinstead@mozilla.com> - Fri, 16 Nov 2018 17:50:04 +0000 - rev 503238
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1500424 - Remove customizable ui toolbar-drag binding;r=Gijs It was almost identical to the toolkit version, only missing a [customizing=true] check to prevent drag. Since Customization only happens in browser/ we are able to replace the toolkit version with the CUI version, and then remove the CUI version. The `#toolbar-menubar:not([autohide="true"])` selector will fall back to the `toolbar[type="menubar"]` selector in global.css to apply the toolkit one, so that is removed from browser.css. Differential Revision: https://phabricator.services.mozilla.com/D12146
6da0db82505c: Bug 1450219 - Make sure not to lose track of focus when we rebuild the inner fields. r=Gijs
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 16 Nov 2018 12:01:10 +0000 - rev 503180
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1450219 - Make sure not to lose track of focus when we rebuild the inner fields. r=Gijs Removing the inner field while focused nulls out the active element, without a blur event of course, so this means that we left the :focus state in the input set incorrectly, plus that we actually lost focus. Differential Revision: https://phabricator.services.mozilla.com/D12106
0f600f20a907: Bug 1502396 - Convert change and remove master password dialogs in about:preferences to use Fluent r=jaws,Gijs,flod
Jack Smith <jack@jackdeansmith.com> - Tue, 06 Nov 2018 21:39:17 +0000 - rev 503165
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1502396 - Convert change and remove master password dialogs in about:preferences to use Fluent r=jaws,Gijs,flod Differential Revision: https://phabricator.services.mozilla.com/D10949
e9aeeae665bd: Bug 1507444 - Add context fill opacity for windows share icon. r=Gijs
Dale Harvey <dale@arandomurl.com> - Thu, 15 Nov 2018 12:45:02 +0000 - rev 503049
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1507444 - Add context fill opacity for windows share icon. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D12002
d364b0b15fa5: Bug 1491676 - Moves permissions strings r=flod,Gijs,zbraniecki
Jack Smith <jack@jackdeansmith.com> - Wed, 14 Nov 2018 23:11:24 +0000 - rev 502882
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1491676 - Moves permissions strings r=flod,Gijs,zbraniecki Differential Revision: https://phabricator.services.mozilla.com/D9917
a7afdb6ab503: Bug 1491676 - Moves download folder strings r=flod,Gijs,zbraniecki
Jack Smith <jack@jackdeansmith.com> - Wed, 14 Nov 2018 23:10:36 +0000 - rev 502881
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1491676 - Moves download folder strings r=flod,Gijs,zbraniecki Depends on D8554 Differential Revision: https://phabricator.services.mozilla.com/D8928
b7b03bffac5e: Bug 1491676 - Moves out of space warning strings r=flod,Gijs,zbraniecki
Jack Smith <jack@jackdeansmith.com> - Wed, 14 Nov 2018 23:09:50 +0000 - rev 502880
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1491676 - Moves out of space warning strings r=flod,Gijs,zbraniecki Depends on D8553 Differential Revision: https://phabricator.services.mozilla.com/D8554
dc9fd82a26a5: Bug 1491676 - Moves master password dialog strings r=flod,Gijs,zbraniecki
Jack Smith <jack@jackdeansmith.com> - Wed, 14 Nov 2018 23:08:51 +0000 - rev 502879
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1491676 - Moves master password dialog strings r=flod,Gijs,zbraniecki Depends on D8552 Differential Revision: https://phabricator.services.mozilla.com/D8553
d933706067df: Bug 1507117 - aboutPerformance.js, add a null check before accessing row.nextSibling when removing a subtree, r=Gijs.
Florian Quèze <florian@queze.net> - Wed, 14 Nov 2018 14:46:45 +0100 - rev 502821
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1507117 - aboutPerformance.js, add a null check before accessing row.nextSibling when removing a subtree, r=Gijs.
986918003af9: Bug 1502410 - Don't use deleteBranch in Normandy r=Gijs,adw
Michael Cooper <mcooper@mozilla.com> - Wed, 14 Nov 2018 16:47:14 +0000 - rev 502649
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1502410 - Don't use deleteBranch in Normandy r=Gijs,adw nsIPrefBranch.deleteBranch doesn't work as documented when the preference's default value was set very early after Firefox has started, such as when Normandy sets startup branches. This is filed as bug 1505941. In order to work around this problem, this patch makes Normandy never use deleteBranch, except in tests where it is safe to do so. With this patch, an experiment that is run on the default branch for a preference that does not have a default value in the tree cannot be promptly unenrolled, instead we must wait until the preference is naturally cleared when Firefox restarts. This is better than never unenrolling though. Differential Revision: https://phabricator.services.mozilla.com/D11383
ff9ba8756263: Bug 1507045 - Remove the customizable ui toolbar binding;r=Gijs
Brian Grinstead <bgrinstead@mozilla.com> - Wed, 14 Nov 2018 10:28:20 +0000 - rev 502620
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1507045 - Remove the customizable ui toolbar binding;r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D11841
325bce8bcb07: Bug 1505734 - Remove logic from CustomizableUI toolbar XBL constructor;r=Gijs
Brian Grinstead <bgrinstead@mozilla.com> - Wed, 14 Nov 2018 00:46:20 +0000 - rev 502554
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1505734 - Remove logic from CustomizableUI toolbar XBL constructor;r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D11665
731be0d1f1ff: Bug 1498522 - Change the 'Highlight All' keybinding back to using 'a', instead of the new 'l' on all platforms, except OSX. r=Gijs,flod
Mike de Boer <mdeboer@mozilla.com> - Tue, 13 Nov 2018 18:27:11 +0000 - rev 502517
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1498522 - Change the 'Highlight All' keybinding back to using 'a', instead of the new 'l' on all platforms, except OSX. r=Gijs,flod Differential Revision: https://phabricator.services.mozilla.com/D8528
75905c21f416: Bug 1498444 - Migrate Sanitize Dialogs to use Fluent for localization r=Gijs,flod,zbraniecki
Qinghao_Jack_Song <songqing@msu.edu> - Tue, 13 Nov 2018 17:58:43 +0000 - rev 502516
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1498444 - Migrate Sanitize Dialogs to use Fluent for localization r=Gijs,flod,zbraniecki Differential Revision: https://phabricator.services.mozilla.com/D8130
0eacaa309ef7: Bug 1498451 - Migrate Device Manager Dialog of Preferences Section to use Fluent for localization r=Gijs,flod,zbraniecki
Qinghao_Jack_Song <songqing@msu.edu> - Mon, 12 Nov 2018 19:34:21 +0000 - rev 502425
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1498451 - Migrate Device Manager Dialog of Preferences Section to use Fluent for localization r=Gijs,flod,zbraniecki Differential Revision: https://phabricator.services.mozilla.com/D7978
05331fb8f533: Bug 1500098 - Reopen multi-selected tabs in container. r=Gijs
Abdoulaye O. Ly <ablayelyfondou@gmail.com> - Mon, 12 Nov 2018 18:43:48 +0000 - rev 502337
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1500098 - Reopen multi-selected tabs in container. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D11145
93f251e48d4d: Bug 1506128 - Add share icon rule for url bar. r=Gijs
Dale Harvey <dale@arandomurl.com> - Mon, 12 Nov 2018 10:49:52 +0000 - rev 502301
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1506128 - Add share icon rule for url bar. r=Gijs MozReview-Commit-ID: IrlcPL93wrF Differential Revision: https://phabricator.services.mozilla.com/D11551
57806d472b17: Bug 1429488 - Part 5: Support persisting moz-extension resources. r=Gijs
Jan Henning <jh+bugzilla@buttercookie.de> - Mon, 22 Oct 2018 22:08:01 +0200 - rev 501979
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1429488 - Part 5: Support persisting moz-extension resources. r=Gijs Bug 1344926 integrated static themes more closely into the existing infra- structure for lightweight themes and also intended the static theme's image data to be persisted to disk as well. While the headerURL image file is in fact successfully copied out of the extension archive into the profile, the persist progress listener being used isn't equipped to properly handle this case and therefore the success callback is never executed. As a result - the callback passed to _persistImages in the LWTManager isn't executed, either, although because setting the fallbackThemeData passes in an empty callback anyway, no one noticed. - the persist operation never actually completes, so subsequent calls to currentThemeForDisplay() always return the original moz-extension:// image URI and never the persisted file from the profile folder. For Android we definitively require a working callback in order to be able to forward the fixed-up theme data once the image data has been persisted, so the persistProgressListener's logic is modified accordingly. Additionally, because as far as the LWTManager is concerned, WE static themes are only fallback themes and a call to LWTManager.currentTheme will therefore never return a WE static theme, the LWTPersister's logic to check whether the theme, whose files have just been successfully persisted, is still the current theme, needs to be modified. Differential Revision: https://phabricator.services.mozilla.com/D10729
b0ebb63e720d: Bug 1501295 - Extend FX_TAB_REMOTE_NAVIGATION_DELAY_MS probe lifetime another 6 months. data-review=chutten, r=Gijs
Mike Conley <mconley@mozilla.com> - Sat, 10 Nov 2018 00:17:10 +0000 - rev 501936
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1501295 - Extend FX_TAB_REMOTE_NAVIGATION_DELAY_MS probe lifetime another 6 months. data-review=chutten, r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D11496
bd4297faba36: Bug 1502410 - Don't use deleteBranch in Normandy r=Gijs
Michael Cooper <mcooper@mozilla.com> - Fri, 09 Nov 2018 19:12:39 +0000 - rev 501902
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1502410 - Don't use deleteBranch in Normandy r=Gijs nsIPrefBranch.deleteBranch doesn't work as documented when the preference's default value was set very early after Firefox has started, such as when Normandy sets startup branches. This is filed as bug 1505941. In order to work around this problem, this patch makes Normandy never use deleteBranch, except in tests where it is safe to do so. With this patch, an experiment that is run on the default branch for a preference that does not have a default value in the tree cannot be promptly unenrolled, instead we must wait until the preference is naturally cleared when Firefox restarts. This is better than never unenrolling though. Differential Revision: https://phabricator.services.mozilla.com/D11383
90b08b7a2987: Bug 1506123 - Remove unused toolbaritem-tabsmenu class. r=Gijs
Dão Gottwald <dao@mozilla.com> - Fri, 09 Nov 2018 16:25:37 +0000 - rev 501894
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1506123 - Remove unused toolbaritem-tabsmenu class. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D11473
55f917d4f483: Bug 1506112 - Replace customize-context-autoHide class with meaningful id. r=Gijs
Dão Gottwald <dao@mozilla.com> - Fri, 09 Nov 2018 16:23:52 +0000 - rev 501876
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1506112 - Replace customize-context-autoHide class with meaningful id. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D11469
b3da3f53f804: Bug 1493594 - replace customizationTarget XBL property by CustomizableUI method, r=gijs
Alexander Surkov <surkov.alexander@gmail.com> - Thu, 08 Nov 2018 13:45:22 +0700 - rev 501520
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1493594 - replace customizationTarget XBL property by CustomizableUI method, r=gijs
dbc2bc8f8747: Bug 1502182 - In Normandy, never close IndexedDB databases, and be explicit about objectStore modes r=Gijs,asuth
Michael Cooper <mcooper@mozilla.com> - Wed, 07 Nov 2018 23:21:52 +0000 - rev 501478
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1502182 - In Normandy, never close IndexedDB databases, and be explicit about objectStore modes r=Gijs,asuth I suspect that the root cause of bug 1502182 is that we try open a database connection before the old one is fully closed. Instead of dealing with complicatedasync bookkeeping to make sure this doesn't happen, this patch simply never closes the database connection. I don't think any of the benefits of closing IndexedDB databases apply to Normandy, and it isn't a significant cost to simply keep them open. Additionally, the patch distinguishes between readonly and readwrite transactions with the database. This was originally done to try and fix the bug. When it didn't help, I decided to leave the change in because it is a beneficial change anyways. Differential Revision: https://phabricator.services.mozilla.com/D10629