0788981ad326: Bug 1432409 part 2 - Make RemotePrintJobChild::OnStatusChange no-op if initialization failed. r=dholbert, a=lizzard default tip
Jonathan Watt <jwatt@jwatt.org> - Mon, 19 Feb 2018 23:25:30 +0000 - rev 452480
Push 8740 by jwatt@jwatt.org at 2018-02-20 23:40 +0000
Bug 1432409 part 2 - Make RemotePrintJobChild::OnStatusChange no-op if initialization failed. r=dholbert, a=lizzard After the part 1 fix, we can still (asynchronously) call some generic cleanup code that tries to let the parent process's RemotePrintJobParent know that printing failed under the stack: RemotePrintJobChild::OnStatusChange nsPrintData::DoOnStatusChange nsPrintJob::FirePrintingErrorEvent nsPrintJob::CleanupOnFailure We crash on trying to use the RemotePrintJobChild to message the parent process since the delete message from the parent has been processed. This change makes RemotePrintJobChild::OnStatusChange check that it's initialized before trying to send any messages. Pushing to CLOSED TREE since this passed a full Try build and is a topcrash we want to land for beta ASAP. MozReview-Commit-ID: FfizRMj2s2m
9002f06257c6: Bug 1432409 part 1 - Prevent nsDeviceContextSpecProxy using RemotePrintJobChild if initialization fails. r=dholbert, a=lizzard
Jonathan Watt <jwatt@jwatt.org> - Fri, 16 Feb 2018 14:53:26 +0000 - rev 452479
Push 8740 by jwatt@jwatt.org at 2018-02-20 23:40 +0000
Bug 1432409 part 1 - Prevent nsDeviceContextSpecProxy using RemotePrintJobChild if initialization fails. r=dholbert, a=lizzard When RemotePrintJobChild::InitializePrint sends a message to the parent process to ask it to initialize printing it spins the event loop and waits for a reply. If the parent fails to initialize printing it will send back an error message followed immediately by a second message telling the child process to delete its RemotePrintJobChild. The error message causes the nested event loop to terminate and blocks RemotePrintJobChild::InitializePrint. We then do various async things to clean up, some of which can try to post messages to the parent process's RemotePrintJobParent. This is a problem since the delete message is pending in the child process's event loop resulting in a race between the code that wants to use the RemotePrintJobChild to send a message to the parent process, and the delete event that will make us crash if anyone tries to use the RemotePrintJobChild. This patch makes sure that if nsDeviceContextSpecProxy's BeginDocument returns failure (remote print job initialization failed) that its EndDocument and AbortDocument methods are then no-ops and will not try to use its RemotePrintJobChild. (BeginPage and EndPage are not changed since they are not called if BeginDocument returns an error result.) MozReview-Commit-ID: 2H6GHjngX7R
04ec73c33ff1: No bug - Tagging daeb05a6586b5c3ec5b7c4ba1a980f50e3620937 with FENNEC_59_0b11_BUILD1, FENNEC_59_0b11_RELEASE a=release CLOSED TREE
ffxbld <release@mozilla.com> - Tue, 20 Feb 2018 13:33:28 -0800 - rev 452478
Push 8739 by ffxbld at 2018-02-20 21:33 +0000
No bug - Tagging daeb05a6586b5c3ec5b7c4ba1a980f50e3620937 with FENNEC_59_0b11_BUILD1, FENNEC_59_0b11_RELEASE a=release CLOSED TREE
07e556351538: No bug - Tagging daeb05a6586b5c3ec5b7c4ba1a980f50e3620937 with DEVEDITION_59_0b11_BUILD1, DEVEDITION_59_0b11_RELEASE a=release CLOSED TREE
ffxbld <release@mozilla.com> - Tue, 20 Feb 2018 08:42:56 -0800 - rev 452477
Push 8738 by ffxbld at 2018-02-20 16:43 +0000
No bug - Tagging daeb05a6586b5c3ec5b7c4ba1a980f50e3620937 with DEVEDITION_59_0b11_BUILD1, DEVEDITION_59_0b11_RELEASE a=release CLOSED TREE
992102c7b304: No bug - Tagging daeb05a6586b5c3ec5b7c4ba1a980f50e3620937 with FIREFOX_59_0b11_BUILD1, FIREFOX_59_0b11_RELEASE a=release CLOSED TREE
ffxbld <release@mozilla.com> - Tue, 20 Feb 2018 08:40:24 -0800 - rev 452476
Push 8737 by ffxbld at 2018-02-20 16:40 +0000
No bug - Tagging daeb05a6586b5c3ec5b7c4ba1a980f50e3620937 with FIREFOX_59_0b11_BUILD1, FIREFOX_59_0b11_RELEASE a=release CLOSED TREE
57794dfccbc9: Automatic version bump. CLOSED TREE NO BUG a=release
ffxbld <release@mozilla.com> - Tue, 20 Feb 2018 08:40:21 -0800 - rev 452475
Push 8737 by ffxbld at 2018-02-20 16:40 +0000
Automatic version bump. CLOSED TREE NO BUG a=release
ccfffa359277: Bug 1398796 - Do uptake monitoring in TC r=mtabara a=release
Rail Aliiev <rail@mozilla.com> - Thu, 15 Feb 2018 08:49:45 -0500 - rev 452474
Push 8736 by raliiev@mozilla.com at 2018-02-20 14:39 +0000
Bug 1398796 - Do uptake monitoring in TC r=mtabara a=release MozReview-Commit-ID: 5xqEQUWOmqf
9d31aa0f363a: no bug - Bumping Firefox l10n changesets DONTBUILD r=release a=l10n-bump
L10n Bumper Bot <release+l10nbumper@mozilla.com> - Tue, 20 Feb 2018 06:19:53 -0800 - rev 452473
Push 8735 by ffxbld at 2018-02-20 14:20 +0000
no bug - Bumping Firefox l10n changesets DONTBUILD r=release a=l10n-bump it -> 8c08e30d3abc ms -> c352e012d6fb nb-NO -> f9b18631cf3d nl -> c8a3fb78ddaa pt-PT -> e774cc32d23d sr -> f3dc4f9aa469 zh-TW -> 2764f6388e71
81b054c4ca25: no bug - Bumping Fennec l10n changesets DONTBUILD r=release a=l10n-bump
L10n Bumper Bot <release+l10nbumper@mozilla.com> - Tue, 20 Feb 2018 06:19:46 -0800 - rev 452472
Push 8735 by ffxbld at 2018-02-20 14:20 +0000
no bug - Bumping Fennec l10n changesets DONTBUILD r=release a=l10n-bump ms -> 74389069c117 nb-NO -> f9b18631cf3d pt-PT -> e774cc32d23d sr -> f3dc4f9aa469 zh-TW -> 2764f6388e71
f54837c4f0cf: no bug - Bumping Firefox l10n changesets DONTBUILD r=release a=l10n-bump
L10n Bumper Bot <release+l10nbumper@mozilla.com> - Mon, 19 Feb 2018 04:19:38 -0800 - rev 452471
Push 8734 by ffxbld at 2018-02-19 12:19 +0000
no bug - Bumping Firefox l10n changesets DONTBUILD r=release a=l10n-bump be -> 5fb0795808f5 bg -> 04d256797524 bn-BD -> 4d509a83f083 cy -> e47621ee79b1 de -> 02c659825899 es-AR -> e4bdbd28c5e8 es-CL -> 863501399e2d es-ES -> 229a007261c4 fr -> 2d891af90a76 hy-AM -> c9a9fb04b1f7 it -> c029da64bc79 nl -> be5b495f1610 ru -> aa2f441b578f te -> 87e59388eb88 vi -> c9933ca008d2 zh-CN -> 529181e7e655
ff4c754c850f: no bug - Bumping Fennec l10n changesets DONTBUILD r=release a=l10n-bump
L10n Bumper Bot <release+l10nbumper@mozilla.com> - Mon, 19 Feb 2018 04:19:32 -0800 - rev 452470
Push 8734 by ffxbld at 2018-02-19 12:19 +0000
no bug - Bumping Fennec l10n changesets DONTBUILD r=release a=l10n-bump be -> 92995aea2538 cy -> e47621ee79b1 de -> 79f313bb03ed es-ES -> 229a007261c4 nl -> be5b495f1610 sl -> 4b691946e1e3 te -> 1b25093ca5b3 vi -> 3df76188b8ea zh-CN -> 529181e7e655
daeb05a6586b: Backed out changeset 5a92ce6cddb6 (bug 1438349) for bc test failures on in-content/tests/browser_spotlight.js a=backout DEVEDITION_59_0b11_BUILD1 DEVEDITION_59_0b11_RELEASE FENNEC_59_0b11_BUILD1 FENNEC_59_0b11_RELEASE FIREFOX_59_0b11_BUILD1 FIREFOX_59_0b11_RELEASE
Gurzau Raul <rgurzau@mozilla.com> - Mon, 19 Feb 2018 13:48:11 +0200 - rev 452469
Push 8733 by rgurzau@mozilla.com at 2018-02-19 11:48 +0000
Backed out changeset 5a92ce6cddb6 (bug 1438349) for bc test failures on in-content/tests/browser_spotlight.js a=backout
4a1f0de7b492: bug 1437120 - Ensure pings sent after net shutdown are persisted to disk r=Dexter a=jcristau
Chris H-C <chutten@mozilla.com> - Tue, 13 Feb 2018 15:52:28 -0500 - rev 452468
Push 8732 by rgurzau@mozilla.com at 2018-02-19 11:42 +0000
bug 1437120 - Ensure pings sent after net shutdown are persisted to disk r=Dexter a=jcristau bug 1397293 introduced a mechanism by which we would bail out early in trying to send a ping if we were trying to send it after the network had been torn down. Unfortunately, it did so indistinguishably from the case where we weren't allowed to send pings, so we neglected to save the ping (as "pending") and just archived it. This change cleanly rejects the ping, and correctly tests that the rejected ping is persisted, not just ephemerally hanging in memory for but a few moments longer. MozReview-Commit-ID: 2g8cpeBEzSE
bbb6b07c92f9: Bug 1435172 - Translation error in New Tab. r=dmose a=jcristau
Ed Lee <edilee@mozilla.com> - Fri, 16 Feb 2018 16:37:45 -0800 - rev 452467
Push 8732 by rgurzau@mozilla.com at 2018-02-19 11:42 +0000
Bug 1435172 - Translation error in New Tab. r=dmose a=jcristau MozReview-Commit-ID: 5Sm7XB7Fz6c
de941fea28b4: Bug 1431242 - Use popupnotification's built-in bolding for webextension prompts. r=aswan,johannh a=jcristau
Prathiksha <prathikshaprasadsuman@gmail.com> - Fri, 19 Jan 2018 23:34:25 +0530 - rev 452466
Push 8732 by rgurzau@mozilla.com at 2018-02-19 11:42 +0000
Bug 1431242 - Use popupnotification's built-in bolding for webextension prompts. r=aswan,johannh a=jcristau MozReview-Commit-ID: 52AtWUlJj4p
5a92ce6cddb6: Bug 1438349 - Disable credit card support for Form Autofill in Beta 59+. r=Dolske a=lizzard
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Wed, 14 Feb 2018 16:29:28 -0800 - rev 452465
Push 8731 by rgurzau@mozilla.com at 2018-02-19 10:24 +0000
Bug 1438349 - Disable credit card support for Form Autofill in Beta 59+. r=Dolske a=lizzard MozReview-Commit-ID: fhS44Dk5bL
73e1a4362495: Bug 1438342 - Fix context menu for media elements in GV. r=snorp a=lizzard
Dylan Roeh <droeh@mozilla.com> - Wed, 14 Feb 2018 15:49:52 -0600 - rev 452464
Push 8731 by rgurzau@mozilla.com at 2018-02-19 10:24 +0000
Bug 1438342 - Fix context menu for media elements in GV. r=snorp a=lizzard We're currently determining whether a node is a media element by checking if the node's classname is HTMLMediaElement; but that's an abstract class and thus the condition is never satisfied. This checks against the concrete HTMLVideoElement and HTMLAudioElement classes instead.
88e30cb3bd25: Bug 1437832 - Part 4: Remove unused function from PeerConnectionImpl r=jib a=lizzard
Byron Campen [:bwc] <docfaraday@gmail.com> - Tue, 13 Feb 2018 14:40:49 -0600 - rev 452463
Push 8730 by ncsoregi@mozilla.com at 2018-02-19 10:18 +0000
Bug 1437832 - Part 4: Remove unused function from PeerConnectionImpl r=jib a=lizzard MozReview-Commit-ID: DJPLOWdm2IA
9f0b85bbc92d: Bug 1437832 - Part 3: Remove unused function from PeerConnectionImpl.webidl r=jib,smaug a=lizzard
Byron Campen [:bwc] <docfaraday@gmail.com> - Tue, 13 Feb 2018 14:40:21 -0600 - rev 452462
Push 8730 by ncsoregi@mozilla.com at 2018-02-19 10:18 +0000
Bug 1437832 - Part 3: Remove unused function from PeerConnectionImpl.webidl r=jib,smaug a=lizzard MozReview-Commit-ID: Bwu99JCUao2
f42de8d75322: Bug 1437832 - Part 2: Use the same C++ logic for replaceTrack, removeTrack, and addTrack (when on a pre-existing transceiver). r+jib r=jib a=lizzard
Byron Campen [:bwc] <docfaraday@gmail.com> - Tue, 13 Feb 2018 13:25:19 -0600 - rev 452461
Push 8730 by ncsoregi@mozilla.com at 2018-02-19 10:18 +0000
Bug 1437832 - Part 2: Use the same C++ logic for replaceTrack, removeTrack, and addTrack (when on a pre-existing transceiver). r+jib r=jib a=lizzard MozReview-Commit-ID: KQSlagkmAZ
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 tip