f624f2d92deeb4aa1803fd71d79728eb6e194ddb: Bug 1457336: Mark a few assertions as expected in test_bug451540.xul. rs=mikedeboer
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 29 May 2018 16:35:56 +0200 - rev 474699
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Bug 1457336: Mark a few assertions as expected in test_bug451540.xul. rs=mikedeboer This series exposes an existing bug in nsFindIterator where it cannot rewind into NAC properly. This nested iterator setup is going to change heavily as part of making it work on Shadow DOM, so just punt on this for now. MozReview-Commit-ID: Aq8XfXjQw6f
7e61d2ab8f6cc85a7ff8c55b63af6558bc7a49e1: Bug 1457336: Forget the last matched character when switching blocks. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 29 May 2018 16:26:31 +0200 - rev 474698
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Bug 1457336: Forget the last matched character when switching blocks. r=mats This fixes browser/components/extensions/test/browser/file_find_frames.html with my patches. We were relying on traversing suppressed whitespace to match the whole word properly there. You can see the bug with the following test-case: <p>Banana 0</p><p>Banana 1</p> If you try to match "banana" using "Whole word", you'll only find the first word, because we keep c = '0'. If there's a newline between the two paragraphs, like in the test, before my patch we we would traverse it (even though it's suppressed whitespace) and keep c = '\n', which makes the match succeed. Fix it forgetting the state of the match completely, including c. That test was firing a lot of "GetOffsetTo() called on frames from different documents" assertions... That's probably worth looking into as a followup. MozReview-Commit-ID: AzId7YWQcJI
0908cce1810811a16468f1e6b1a8d35d49f3d24c: Bug 1457336: Skip only undisplayed nodes, not invisible nodes. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 22 May 2018 11:27:02 +0200 - rev 474697
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Bug 1457336: Skip only undisplayed nodes, not invisible nodes. r=mats MozReview-Commit-ID: 5KgV1lqmim3
54883080c613f1fa5d1d403ed2e66b52b0c9a50e: Bug 1457336: Make some functions static. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 22 May 2018 11:18:50 +0200 - rev 474696
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Bug 1457336: Make some functions static. r=mats This patch should have no change in behavior. MozReview-Commit-ID: AOAZ09g78fr
559ed29895270993c797ea7a4b98c162a36d0a1c: Bug 1457336: Make the debug find code less noisy. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 22 May 2018 11:08:47 +0200 - rev 474695
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Bug 1457336: Make the debug find code less noisy. r=mats Not sure how useful it really is compared to rr but... MozReview-Commit-ID: 4II28NYDCNo
cd88693578ed999440ce74cebf9b2f16f7be6bde: Bug 1457336: Remove dead code. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 22 May 2018 10:54:18 +0200 - rev 474694
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Bug 1457336: Remove dead code. r=mats There's nothing referencing this macro... MozReview-Commit-ID: 5NzVOFAOQMw
39674d54da6554c344f13d3b972eab4798a8d794: Bug 1457336: Teach nsFind about display in general. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 27 Apr 2018 01:55:48 +0200 - rev 474693
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Bug 1457336: Teach nsFind about display in general. r=mats I ended up not using the nsIFrame methods both for consistency with the plain text serializer and because of include hell due to nsStyleStructInlines / nsIFrameInlines. Find doesn't care about nodes with no frames anyway, so it didn't seem worth doing the fallback if there's no style information. I'll file a bug for IsHTMLBlock. MozReview-Commit-ID: 3T317a4xCB
dfa7b43a4a5e2c2835955bd95810f9606a9956ed: Bug 1457286: Teach nsFind about display: contents. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 26 Apr 2018 22:38:31 +0200 - rev 474692
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Bug 1457286: Teach nsFind about display: contents. r=mats MozReview-Commit-ID: LODyc8yuuSs
fa0f453c5be94cdbba6e4f0083d9c6fe7546d033: Bug 1459900 - Adapt ValType to accomodate reference types. r=luke
Lars T Hansen <lhansen@mozilla.com> - Thu, 24 May 2018 15:42:15 +0200 - rev 474691
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Bug 1459900 - Adapt ValType to accomodate reference types. r=luke
88e72cd30f4bac2728d48fdc99ff0922fa41525b: bug 1464345, ensure all CustomElementReaction implementations traverse their member variables, r=mrbkap
Olli Pettay <Olli.Pettay@helsinki.fi> - Wed, 30 May 2018 13:24:44 +0300 - rev 474690
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
bug 1464345, ensure all CustomElementReaction implementations traverse their member variables, r=mrbkap
e95948e4ac6bd6ed2973a7a07e2eeff60a2e3e8e: Bug 1441029, give up early on invalid 'is attribute values, r=mrbkap
Olli Pettay <Olli.Pettay@helsinki.fi> - Wed, 30 May 2018 12:41:20 +0300 - rev 474689
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Bug 1441029, give up early on invalid 'is attribute values, r=mrbkap
f7a6b594d8000c12e44a7df96e2b962cd31f7df4: Bug 1465175 - Remove mozAutoDocConditionalContentUpdateBatch, r=dbaron
Olli Pettay <Olli.Pettay@helsinki.fi> - Wed, 30 May 2018 12:40:07 +0300 - rev 474688
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Bug 1465175 - Remove mozAutoDocConditionalContentUpdateBatch, r=dbaron
efd5c0553e738b8268ccd7e15447c521c80630f9: Bug 1462285 - Remove const nsIChannel in XULBrowserWindow.onStateChange. r=dao
ls05 <lucasuriano@live.it> - Thu, 24 May 2018 15:46:58 +0200 - rev 474687
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Bug 1462285 - Remove const nsIChannel in XULBrowserWindow.onStateChange. r=dao
9fc0e4096849fcee3a72b41bbf9a40ab509f06be: Bug 1464477 - Crash [@ JSObject::getClass] with wasm. r=lth.
Julian Seward <jseward@acm.org> - Wed, 30 May 2018 10:15:29 +0200 - rev 474686
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Bug 1464477 - Crash [@ JSObject::getClass] with wasm. r=lth. OpIter<Policy>::readMem{Copy,Fill} have to do with memory operations. But they don't verify that the current module actually has a valid memory. If indeed there is no memory, the generated code segfaults. This patch causes verification to fail for modules without memories that use BulkMem.{Copy,Fill}. It also fixes a testcase whose lack of memory is exposed by the C++ fix.
a2fd9b7493a1d028685856220f246242a1a1b316: Merge mozilla-central to inbound. a=merge CLOSED TREE
Csoregi Natalia <ncsoregi@mozilla.com> - Wed, 30 May 2018 12:28:56 +0300 - rev 474685
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Merge mozilla-central to inbound. a=merge CLOSED TREE
bbb045179d4f1e45f7001a157171bdca1d0f1901: Bug 1460382: Make element-backed pseudos inherit from NAC subtree roots and other NAC inherit from their parents. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 10 May 2018 18:48:08 +0200 - rev 474684
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Bug 1460382: Make element-backed pseudos inherit from NAC subtree roots and other NAC inherit from their parents. r=heycam Currently, NAC always inherits from the closest non-NAC ancestor element, regardless of whether it is for an element-backed pseudo or not. This patch changes the inheritance so that for element-backed pseudos, we inherit from the closest native anonymous root's parent, and for other NAC we inherit from the parent. This prevents the following two issues and allows us to remove the NODE_IS_NATIVE_ANONYMOUS flag: * Avoiding inheriting from the non-NAC ancestor in XBL bindings bound to NAC. - This is no longer a problem since we apply the rule only if we're a pseudo-element, and all pseudo-elements are in native anonymous subtrees. - This also allows to remove the hack that propagates the NODE_IS_NATIVE_ANONYMOUS flag from the ::cue pseudo-element from BindToTree. * Inheriting from the wrong thing if we're a nested NAC subtree. - We no longer look past our NAC subtree, with the exception of ::-moz-number-text's pseudo-elements, for which we do want to propagate ::placeholder to. A few rules from forms.css have been modified because they're useless or needed to propagate stuff to the anonymous form control in input[type="number"] which previously inherited from the input itself. MozReview-Commit-ID: IDKYt3EJtSH
0b2331837a98975bb8a4afaade02948a011f8aa1: Bug 1465066: Cleanup transform animation. r=hiro
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 29 May 2018 15:09:00 +0200 - rev 474683
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Bug 1465066: Cleanup transform animation. r=hiro MozReview-Commit-ID: D9rq8CZIgf5
9791b3b0efc940d1ec5fa07d3e1dd82222135b42: Bug 1465107: Remove isStyledByServo. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 29 May 2018 17:56:47 +0200 - rev 474682
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Bug 1465107: Remove isStyledByServo. r=xidorn MozReview-Commit-ID: 8HWBH9kWyxV
695729f6c9a6231c7eddfa231b4eff8de0e2610b: Bug 1465107: Remove stylo mentions from wptrunner. r=jgraham
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 29 May 2018 17:23:18 +0200 - rev 474681
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Bug 1465107: Remove stylo mentions from wptrunner. r=jgraham MozReview-Commit-ID: D21P4kHOxzi
5a263f066765a3f8f2ae85e3ba58fdd9b40a6a89: Bug 1465107: Remove stylo mentions from the mochitest runner. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 29 May 2018 17:24:14 +0200 - rev 474680
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Bug 1465107: Remove stylo mentions from the mochitest runner. r=xidorn MozReview-Commit-ID: B430ssKhJbz
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip