f5c1a7734493d3cf9e1ded5731bba0528b01155f: bug 1483651 - Dereference symlinks inside vendored Python packages. r=gps
Ted Mielczarek <ted@mielczarek.org> - Wed, 10 Oct 2018 19:59:52 +0000 - rev 496346
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
bug 1483651 - Dereference symlinks inside vendored Python packages. r=gps At least one Python package that got vendored via `mach vendor python` contains a symlink, which hg.mozilla.org rejects. This change makes it so symlinks get replaced with the contents of the file they point to. Differential Revision: https://phabricator.services.mozilla.com/D4135
ec133330b1ec04135b786d0d3dc9a2fe4460d874: bug 1481612 - Add more actions to virtualenv_packages.txt and use them to include the unpacked Windows psutil wheel. r=gps
Ted Mielczarek <ted@mielczarek.org> - Wed, 10 Oct 2018 19:53:47 +0000 - rev 496345
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
bug 1481612 - Add more actions to virtualenv_packages.txt and use them to include the unpacked Windows psutil wheel. r=gps This patch adds two new actions to virtualenv_packages.txt processing: windows and !windows. The former processes the rest of the action only on Windows, and the latter processes it only on non-Windows. These new features are used in virtualenv_packages.txt to use the path to the unpacked Windows psutil wheel when on Windows, and build psutil from source and use that path on other platforms. This fixes the long-standing problem of not having psutil available on most Windows systems (since they don't have the right set of Visual C++ build tools). Differential Revision: https://phabricator.services.mozilla.com/D3437
7243432584616e49d01a0b8910518b359d5aab99: bug 1481612 - vendor an unpacked win64 wheel of psutil 5.4.3. r=gps
Ted Mielczarek <ted@mielczarek.org> - Wed, 10 Oct 2018 19:54:25 +0000 - rev 496344
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
bug 1481612 - vendor an unpacked win64 wheel of psutil 5.4.3. r=gps This change uses the previously added `--with-windows-wheel` option to vendor a win64 wheel of psutil. This patch was produced by running: `mach vendor python --with-windows-wheel psutil==5.4.3`. We vendor this wheel unpacked so that we can insert it into sys.path in mach without needing a virtualenv in which to install a wheel with pip, since we have a chicken-and-egg problem there where configure creates the virtualenv but we'd like to be able to use psutil before we run configure. Differential Revision: https://phabricator.services.mozilla.com/D3436
60407ad1392236779a537033965c59e3170416f3: bug 1481612 - Add a --with-windows-wheel option to mach vendor python. r=gps
Ted Mielczarek <ted@mielczarek.org> - Wed, 10 Oct 2018 19:54:36 +0000 - rev 496343
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
bug 1481612 - Add a --with-windows-wheel option to mach vendor python. r=gps This option is very single-purpose: it's intended to let us vendor an unpacked wheel for psutil on Windows. To that end the mach command will error if you try to use it for anything but vendoring a single package. The mach command will vendor source packages as it currently does, and then run `pip download` again with some hardcoded parameters to fetch the right wheel for Python 2.7 on win64 and unpack it to a `package-platform` directory under `third_party/python`. I don't expect this to be used for anything but psutil, but it should make life simpler for anyone that wants to update our vendored copy of psutil in the future. Differential Revision: https://phabricator.services.mozilla.com/D3435
aafdbf2213ec4463e830f810dbb71016f5e49c5f: bug 1481612 - Re-vendor psutil 5.4.3 using `mach vendor python`. r=chmanchester,gps
Ted Mielczarek <ted@mielczarek.org> - Wed, 10 Oct 2018 19:47:58 +0000 - rev 496342
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
bug 1481612 - Re-vendor psutil 5.4.3 using `mach vendor python`. r=chmanchester,gps psutil was previously vendored manually, so re-vendor it using our new tooling to make for smaller diffs in follow-up patches. This mostly just winds up adding some extra files that must have been left out of the manual vendoring, but it also updates the third_party/python/requirements.{in,txt}. Differential Revision: https://phabricator.services.mozilla.com/D3434
161743a69d9a74f2cc5ea7cfc2e8f65c56a4ec2a: Bug 1492127 - Split browser_blockingIndexedDb.js into browser_blockingIndexedDb.js and browser_blockingIndexedDbInWorkers.js to give it more breathing room timeout-wise r=baku
Ehsan Akhgari <ehsan@mozilla.com> - Wed, 10 Oct 2018 19:19:09 +0000 - rev 496341
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1492127 - Split browser_blockingIndexedDb.js into browser_blockingIndexedDb.js and browser_blockingIndexedDbInWorkers.js to give it more breathing room timeout-wise r=baku Depends on D8175 Differential Revision: https://phabricator.services.mozilla.com/D8176
bea77a4e96999378c7c8dc1dbc90bbc585171ca9: Bug 1479912 - Don't rasterize blobs in parallel when there isn't a lot of blobs. r=jrmuizel
Nicolas Silva <nsilva@mozilla.com> - Wed, 10 Oct 2018 18:12:00 +0000 - rev 496340
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1479912 - Don't rasterize blobs in parallel when there isn't a lot of blobs. r=jrmuizel Differential Revision: https://phabricator.services.mozilla.com/D8263
ad50275695e8d42a36e5f3151be4ee955a5185c2: Bug 1497972 - Use LookupForAdd in ImageLoader::LoadImage. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 10 Oct 2018 19:09:59 +0000 - rev 496339
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1497972 - Use LookupForAdd in ImageLoader::LoadImage. r=mats I think it's not really that awkward :) Differential Revision: https://phabricator.services.mozilla.com/D8268
9752f179b9c3007eca80f96585dcfd3d951ae222: Bug 1494069 - [lint] Explicitly list out objdirs rather than depend on 'obj*' in the global exclude, r=rwood
Andrew Halberstadt <ahalberstadt@mozilla.com> - Fri, 05 Oct 2018 19:48:53 +0000 - rev 496338
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1494069 - [lint] Explicitly list out objdirs rather than depend on 'obj*' in the global exclude, r=rwood When using globs in exclude directorives, FileFinder will return every *file* that gets matched. This is can be thousands of files in the case of an objdir. While we now collapse these files down to highest possible directories, this collapse operation can still take a noticeable amount of time (0.6s). This simply scans topsrcdir for files that start with 'obj' to avoid the glob. This also moves the '_activate_virtualenv' call to the top of the function because in CI, this will cause an objdir to be created (to store the virtualenv). If this happens *after* calculating the global excludes, we won't catch it since it doesn't exist yet. This will result in the objdir's virtualenv being linted and erroneous failures. Depends on D7739 Differential Revision: https://phabricator.services.mozilla.com/D7740
fe0fb280dbfc24091da4fd2627c6d514fbbab13f: Bug 1494069 - [mozlint] Collapse exclude paths into their smallest possible set, r=egao
Andrew Halberstadt <ahalberstadt@mozilla.com> - Tue, 09 Oct 2018 19:26:23 +0000 - rev 496337
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1494069 - [mozlint] Collapse exclude paths into their smallest possible set, r=egao Often we specify globs in our exclude patterns, e.g: exclude: - **/node_modules - obj* However, these globs get expanded out to *every* file that matches them. This can sometimes be thousands or even tens of thousands of files. We then pass these paths on to the underlying linters and tell them to exclude them all. This causes a lot of overhead and slows down performance. This commit implements a "collapse" function. Given a set of paths, it'll collapse them into the smallest set of parent directories that contain the original set, and that don't contain any extra files. For example, given a directory structure like this: a -- foo.txt -- b -- bar.txt -- baz.txt -- c -- ham.txt -- d -- spam.txt Then the following will happen: >>> collapse(['a/foo.txt', 'a/b/bar.txt', 'a/c/ham.txt', 'a/c/d/spam.txt']) ['a/foo.txt', 'b/bar.txt', 'c'] Since all files under directory 'c' are specified by the original set (both 'c/ham.txt' and 'c/d/spam.txt'), we can collapse it down to just 'c'. However not all files under 'b' are specified (we're missing 'a/b/baz.txt'), so we can't collapse 'b' (and by extension also can't collapse 'a'). If we had included 'a/b/baz.txt': >>> collapse(['a/foo.txt', 'a/b/bar.txt', 'a/b/baz.txt', 'a/c/ham.txt', 'a/c/d/spam.txt']) ['a'] In both cases, the smallest set of paths that contains the original set (and only the original set) is computed. The collapse function has a little bit of overhead but it's not too bad. For example collapsing all files matched by '**/node_modules' takes ~0.015s. Collapsing two full objdirs, takes ~0.6s. But a follow up commit is planned to make sure we stop using 'obj*' to reduce that overhead. Depends on D7738 Differential Revision: https://phabricator.services.mozilla.com/D7739
a2956764213e874d77c1541d71a48c3fffb5725d: Bug 1494069 - Vendor scandir==1.9.0 to third_party/python, r=davehunt
Andrew Halberstadt <ahalberstadt@mozilla.com> - Wed, 10 Oct 2018 19:21:07 +0000 - rev 496336
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1494069 - Vendor scandir==1.9.0 to third_party/python, r=davehunt Scandir is a faster implementation of os.listdir since it caches file metadata as it works. Using listdir and then calling things like os.path.isfile after the fact will result in multiple system calls. Whereas with scandir, there will only be a single system call per file. Scandir is part of the stdlib in Python 3.6+, so the following can be used for Python 2/3 compatible code: try from os import scandir, walk except ImportError: from scandir import scandir, walk Differential Revision: https://phabricator.services.mozilla.com/D7738
2084a929ec4cbf31dda4df9935ba4bb38002a6bd: Bug 1492866 - add accessible relations to accessibility panel sidebar. r=pbro
Yura Zenevich <yura.zenevich@gmail.com> - Wed, 10 Oct 2018 19:18:03 +0000 - rev 496335
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1492866 - add accessible relations to accessibility panel sidebar. r=pbro MozReview-Commit-ID: 5u8SRnlnFyN Differential Revision: https://phabricator.services.mozilla.com/D7208
da3163c05c7ee076a6f91c25d4fe5bf5bcb13429: Bug 1494401 - Split browser_blockingWorkers.js into three separate tests to give it more breathing room timeout-wise r=baku
Ehsan Akhgari <ehsan@mozilla.com> - Wed, 10 Oct 2018 19:19:07 +0000 - rev 496334
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1494401 - Split browser_blockingWorkers.js into three separate tests to give it more breathing room timeout-wise r=baku Differential Revision: https://phabricator.services.mozilla.com/D8175
81dd098adbd8984f9491eae22dac152cf4fb2d71: Bug 1492977: Mark returns-false-for-retry functions as Pure r=tcampbell
Iain Ireland <iireland@mozilla.com> - Wed, 10 Oct 2018 19:18:10 +0000 - rev 496333
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1492977: Mark returns-false-for-retry functions as Pure r=tcampbell Differential Revision: https://phabricator.services.mozilla.com/D7942
2c21c87e773ee1bfd796079fe5ffe06c2057b9ae: Bug 1497686 - Better error message when a jsapi-test fails with an exception pending. r=jwalden
Jason Orendorff <jorendorff@mozilla.com> - Wed, 10 Oct 2018 17:47:54 +0000 - rev 496332
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1497686 - Better error message when a jsapi-test fails with an exception pending. r=jwalden Differential Revision: https://phabricator.services.mozilla.com/D8154
71160e8bcfb743129388fa3d3948a8d036263785: Bug 1496362 - Limit control of tracelogger to only the gecko profiler and the previous environment variables implementation that triggers tracelogger only on startup. r=sfink
Denis Palmeiro <dpalmeiro@mozilla.com> - Wed, 10 Oct 2018 18:36:53 +0000 - rev 496331
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1496362 - Limit control of tracelogger to only the gecko profiler and the previous environment variables implementation that triggers tracelogger only on startup. r=sfink Tracelogger is currently not setup to be toggled on and off while in the shell. Removing access to the "jit.enable-tracelogger" will force the tracelogger to be invoked either through the new tracelogger API which is intended to be used by the profiler, or through setting the environment variables TLDIR, TLOPTIONS, and TLLOG. Differential Revision: https://phabricator.services.mozilla.com/D8250
6bfe39bf5e4dd380f6caa96e0e65ab9cdb149a71: Bug 1497505 - Update the accesskeys of the bookmark tab(s) and (un)pin tab(s) to make them consistent regardless of the state. r=flod
Jared Wein <jwein@mozilla.com> - Wed, 10 Oct 2018 18:07:55 +0000 - rev 496330
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1497505 - Update the accesskeys of the bookmark tab(s) and (un)pin tab(s) to make them consistent regardless of the state. r=flod I have not changed the entity names since the meaning of the strings has not changed. Differential Revision: https://phabricator.services.mozilla.com/D8262
0df87bbe161e757b7fee9a0213ef07a62bf77ae9: Bug 1497259 - 3. Control GV logging through pref; r=droeh
Jim Chen <nchen@mozilla.com> - Wed, 10 Oct 2018 17:36:13 +0000 - rev 496329
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1497259 - 3. Control GV logging through pref; r=droeh Use the "geckoview.logging" pref to control GV logging. Differential Revision: https://phabricator.services.mozilla.com/D8052
20cd9ac747da9b457d594fb385f13ace7bffbff2: Bug 1497259 - 2. Don't log auto-fill values; r=droeh
Jim Chen <nchen@mozilla.com> - Wed, 10 Oct 2018 17:36:11 +0000 - rev 496328
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1497259 - 2. Don't log auto-fill values; r=droeh Auto-fill values can contain personal information and must not appear in the log. Differential Revision: https://phabricator.services.mozilla.com/D8051
50b9d2e6ac5f0d14822601bcf403b8f80ce5e3d4: Bug 1497259 - 1. Fix log module names; r=droeh
Jim Chen <nchen@mozilla.com> - Wed, 10 Oct 2018 17:36:03 +0000 - rev 496327
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1497259 - 1. Fix log module names; r=droeh Fix the GV log module names so they are all under the GeckoView group. Differential Revision: https://phabricator.services.mozilla.com/D8050
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip