f170801fe92173e56b1aecc27c271eb6ff3cf3cf: Bug 1352791 - Disable browser/base/content/test/alerts/browser_notification_do_not_disturb.js on windows for frequent failures. r=me, a=test-only
Joel Maher <jmaher@mozilla.com> - Mon, 23 Oct 2017 10:43:40 -0400 - rev 438505
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1352791 - Disable browser/base/content/test/alerts/browser_notification_do_not_disturb.js on windows for frequent failures. r=me, a=test-only
32faa962a6056f8c774a4bc8af9fc4f8b6b18498: Backed out changeset 6fa6cfe0199c (bug 1403131) for mass reftest failures. r=backout on a CLOSED TREE
Sebastian Hengst <archaeopteryx@coole-files.de> - Mon, 23 Oct 2017 16:39:24 +0200 - rev 438504
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Backed out changeset 6fa6cfe0199c (bug 1403131) for mass reftest failures. r=backout on a CLOSED TREE
6fa6cfe0199ca95e3a37f35f59ba047849e2ae80: Bug 1403131 - Run linters against mozharness scripts and configs. r=rail
Steve Armand <stevea1@mac.com> - Mon, 23 Oct 2017 09:46:15 -0400 - rev 438503
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1403131 - Run linters against mozharness scripts and configs. r=rail
25bc10affd99b854d971b27f3111050616ab22d5: Bug 1411084 - Use RAII for mutex locking in mozjemalloc. r=njn
Mike Hommey <mh+mozilla@glandium.org> - Fri, 06 Oct 2017 17:49:40 +0900 - rev 438502
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1411084 - Use RAII for mutex locking in mozjemalloc. r=njn This leaves out a few manual Lock/Unlock calls.
c70360f53ed97dd3b68cfabacd47cdec6342b8f8: Bug 1362761 : Remove Compact from NIGHTLY build for debug purpose. r=francois
DimiL <dlee@mozilla.com> - Wed, 11 Oct 2017 16:56:06 +0800 - rev 438501
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1362761 : Remove Compact from NIGHTLY build for debug purpose. r=francois We suspect nsTArray Compact may cause a crash issue during SafeBrowsing update. Temporarily remove it from NIGHTLY build, if crash still shows at NIGHTLY build, we will restore it back. MozReview-Commit-ID: 2wjbMykEbJ8
c8fea1a40065b9cd9c68266cbea408f9cb1bb305: Bug 1385461 - Document the reason for wire_format.cc in SOURCES. r=glandium
Francois Marier <francois@mozilla.com> - Thu, 12 Oct 2017 17:27:56 -0700 - rev 438500
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1385461 - Document the reason for wire_format.cc in SOURCES. r=glandium wire_format.cc needs to be out of UNIFIED_SOURCES because it won't get the GetMessage undef from common.h: https://github.com/google/protobuf/blob/b04e5cba356212e4e8c66c61bbe0c3a20537c5b9/src/google/protobuf/stubs/common.h#L76-L91 which works around windows.h containing a define for GetMessage() that turns it into GetMessageA(). This removes the need for the customization added in bug 1024774: https://hg.mozilla.org/mozilla-central/diff/8f5b5bbc27af/toolkit/components/protobuf/m-c-changes.patch#l1.25 MozReview-Commit-ID: CrpgEQCBWhf
cd5b5f3af51751a3aaeba564d5faaa21fb0641f4: Bug 1385461 - Document the reason for the json_escaping.h-including cc files in SOURCES. r=glandium
Francois Marier <francois@mozilla.com> - Thu, 12 Oct 2017 17:27:49 -0700 - rev 438499
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1385461 - Document the reason for the json_escaping.h-including cc files in SOURCES. r=glandium Because a namespace is improperly closed outside of the header guard in json_escaping.h: https://github.com/google/protobuf/blob/b04e5cba356212e4e8c66c61bbe0c3a20537c5b9/src/google/protobuf/util/internal/json_escaping.h#L91 we can't put any of the files that include json_escaping.h in UNIFIED_SOURCES without fixing this in the upstream source. This should be fixed in the next upstream release: https://github.com/google/protobuf/pull/3744 MozReview-Commit-ID: sc98xgrUfx
2b5488022b9fc0d412abfdb0259533bb05ab0e8f: Bug 1385461 - Document the reason for the time.h-including cc files in SOURCES. r=glandium
Francois Marier <francois@mozilla.com> - Tue, 17 Oct 2017 15:53:54 -0700 - rev 438498
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1385461 - Document the reason for the time.h-including cc files in SOURCES. r=glandium On Windows, GetCurrentTime() is an alias for GetTickCount(): DWORD WINAPI GetTickCount(void); which comes from winbase.h: https://msdn.microsoft.com/en-us/library/windows/desktop/ms724408(v=vs.85).aspx In order to add the files that use time.h to UNIFIED_SOURCES, we'd have to add a hack similar to the one that's in util/time_util.h: https://github.com/google/protobuf/blob/b04e5cba356212e4e8c66c61bbe0c3a20537c5b9/src/google/protobuf/util/time_util.h#L94-L96 In the interest of patching upstream source as little as possible, we leave these files in SOURCES instead. MozReview-Commit-ID: BHCtTCQw9EU
aca83df2ce2ea49465468a5ae3bd617fdff95dc6: Bug 1385461 - Upgrade to the latest version of the protobuf library. r=dimi,fitzgen,glandium,mattwoodrow,mossop
Francois Marier <francois@mozilla.com> - Wed, 18 Oct 2017 15:02:05 -0700 - rev 438497
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1385461 - Upgrade to the latest version of the protobuf library. r=dimi,fitzgen,glandium,mattwoodrow,mossop The tarball that was imported is the 3.4.1 release: https://github.com/google/protobuf/releases/tag/v3.4.1 https://github.com/google/protobuf/releases/download/v3.4.1/protobuf-cpp-3.4.1.tar.gz This drops all of the customizations that are no longer needed, which includes a few issues that were fixed upstream: - r512.patch from bug 892856: https://searchfox.org/mozilla-central/rev/bab9dbe9c4ef71f71fb07e53b701fb2dfde277d9/toolkit/components/protobuf/r512.patch https://github.com/google/protobuf/blob/b04e5cba356212e4e8c66c61bbe0c3a20537c5b9/src/google/protobuf/io/zero_copy_stream_impl.cc#L43 - vs2013.patch, also from bug 892856: https://searchfox.org/mozilla-central/rev/bab9dbe9c4ef71f71fb07e53b701fb2dfde277d9/toolkit/components/protobuf/vs2013.patch https://github.com/google/protobuf/blob/b04e5cba356212e4e8c66c61bbe0c3a20537c5b9/src/google/protobuf/wire_format_lite_inl.h#L39 - sparc64 fixes in m-c-changes.patch from bug 1275204: https://hg.mozilla.org/integration/mozilla-inbound/rev/21d692e82582 https://github.com/google/protobuf/blob/b04e5cba356212e4e8c66c61bbe0c3a20537c5b9/src/google/protobuf/stubs/platform_macros.h#L68 The LOGLEVEL_ERROR hack in m-c-changes.patch from bug 1024774 and bug 1320179 was replaced by a NOGDI define in moz.build as suggested by upstream: https://github.com/google/protobuf/pull/3745/files#r144915445 The other customizations that were dropped came from bug 1024774. The patch for OpenBSD/32-bit will likely be fixed upstream in a future release: https://github.com/google/protobuf/pull/3747#issuecomment-336581244 Upgrading the protobuf library also required re-generating all of the existing .pb.h and pb.cc files (they are neither forward nor backward-compatible) and making adjustments to the build config to make it compile (and silence warnings). text_format.cc can now be compiled as part of UNIFIED_SOURCES. MozReview-Commit-ID: 7F2IqFmwQnN
8f2f523109dc6391f5d31f493f8b73dc5fb75798: Bug 1385461 - Add script to regenerate all .pb.cc and .pb.h files. r=mossop
Francois Marier <francois@mozilla.com> - Thu, 12 Oct 2017 16:25:33 -0700 - rev 438496
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1385461 - Add script to regenerate all .pb.cc and .pb.h files. r=mossop MozReview-Commit-ID: LR0knKFfL7
12c2e68e674d9c0d4903849d308233d36742e164: Bug 1385461 - Fix upgrade script to avoid excluding bytestream files. r=mossop
Francois Marier <francois@mozilla.com> - Thu, 12 Oct 2017 17:27:32 -0700 - rev 438495
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1385461 - Fix upgrade script to avoid excluding bytestream files. r=mossop I had to fix the globbing pattern in the upgrade script which would otherwise exclude "bytestream.*" from the tree because its name contains the string "test". MozReview-Commit-ID: 1J48i0oxVz2
c46d9e05ec125bf8a1bebbd6bada4c2c8a7ffa62: Bug 1385461 - Move URL Classifier protobuf files to match other components. r=dimi
Francois Marier <francois@mozilla.com> - Thu, 12 Oct 2017 17:27:36 -0700 - rev 438494
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1385461 - Move URL Classifier protobuf files to match other components. r=dimi MozReview-Commit-ID: 5N1iOpocVd8
d29dc7075531df37a0901ec07b80f83cfae507c1: Bug 1385461 - Re-sync LayerScopePacket.proto with the generated files. r=mattwoodrow
Francois Marier <francois@mozilla.com> - Wed, 11 Oct 2017 16:15:57 -0700 - rev 438493
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1385461 - Re-sync LayerScopePacket.proto with the generated files. r=mattwoodrow This got out of sync in bug 1317862 and bug 1337130: https://hg.mozilla.org/mozilla-central/rev/f2d4190eaaf8 https://hg.mozilla.org/mozilla-central/rev/48b29a84e4e5 MozReview-Commit-ID: H9PWK4O0GX
aa02fa00af6f2d7495a6c9193ce812ce622b0393: Bug 1410906 - Store ThemeGeometry for display item instead of frame r=mattwoodrow
Miko Mynttinen <mikokm@gmail.com> - Mon, 23 Oct 2017 18:07:36 +0200 - rev 438492
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1410906 - Store ThemeGeometry for display item instead of frame r=mattwoodrow MozReview-Commit-ID: 6x7GRRTEVja
09f25b91132eb1f2391f2dabe1569cbd31a7c655: Bug 1395151 - Don't apply ancestors' opacity if the opacity item has an async opacity animation. r=birtles,mattwoodrow
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Mon, 23 Oct 2017 19:26:40 +0900 - rev 438491
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1395151 - Don't apply ancestors' opacity if the opacity item has an async opacity animation. r=birtles,mattwoodrow MozReview-Commit-ID: KsxukpGrH6P
b6101f641ea7d7967126be028170cdb8494d5e84: bug 1410043 remove over-zealous graph-thread assert in SetCurrentDriver() r=pehrsons
Karl Tomlinson <karlt+@karlt.net> - Fri, 20 Oct 2017 17:59:19 +1300 - rev 438490
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
bug 1410043 remove over-zealous graph-thread assert in SetCurrentDriver() r=pehrsons The reverts to accepting ownership of the monitor regardless of the thread, as accepted prior to https://hg.mozilla.org/mozilla-central/rev/e3f39de40209#l1.25 As indicated in the SetCurrentDriver() documentation, it can be called on the main thread during Revive() before another graph thread is started. At that point mLifecycleState = LIFECYCLE_RUNNING, and so it is not easy to adjust AssertOnGraphThreadOrNotRunning() to accept this situation without making it much more liberal. An alternative would be to change the Revive() methods to set mDriver directly, but that would differ from the usual driver-switching pattern. MozReview-Commit-ID: 9O5qakPVML9
10027a261e8a8427fb6eae3fd60914628a519661: Bug 1407735 - Make the JS loader XPCOM component use a singleton. r=kmag
Andrew McCreight <continuation@gmail.com> - Mon, 23 Oct 2017 13:53:58 -0700 - rev 438489
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1407735 - Make the JS loader XPCOM component use a singleton. r=kmag mozJSComponentLoader is created using XPCOM. However, you can only call it once or it'll crash. This patch fixes that by using a singleton macro. MozReview-Commit-ID: Bq2k7nv9dKA
9e434f5e600da187b745b4baaa6822a728a4c0be: Bug 1379332 followup: Skip this bug's crashtests on Android to avoid triggering "boolean preference...not known or wrong type" error there. (test-only, no review)
Daniel Holbert <dholbert@cs.stanford.edu> - Mon, 23 Oct 2017 15:28:00 -0400 - rev 438488
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1379332 followup: Skip this bug's crashtests on Android to avoid triggering "boolean preference...not known or wrong type" error there. (test-only, no review) MozReview-Commit-ID: 6G8euT0w0A9
6a9ca63ae2b5921b0e9f0f31ce80fe0adffa04e7: Backed out changeset 09f2bfedb4db for landing with the wrong bug number in the commit message.
Ryan VanderMeulen <ryanvm@gmail.com> - Mon, 23 Oct 2017 18:35:21 -0400 - rev 438487
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Backed out changeset 09f2bfedb4db for landing with the wrong bug number in the commit message.
76300bd1f7c18286fd6e280df454e97755ff6524: Bug 1400238 - Notify TabParent when the GTK client offset changes. r=karlt
Botond Ballo <botond@mozilla.com> - Wed, 18 Oct 2017 13:29:47 -0400 - rev 438486
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1400238 - Notify TabParent when the GTK client offset changes. r=karlt MozReview-Commit-ID: 1TacAhl6c2M
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip