f0bfa5f4300c0ac6d505cf16fde1c8f7f0a8c3d0: Bug 1513707 - [release 108] Fix tab context menu item size checks (#7420). r=davidwalsh
Jason Laster <jlaster@mozilla.com> - Wed, 12 Dec 2018 16:34:13 -0500 - rev 507888
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1513707 - [release 108] Fix tab context menu item size checks (#7420). r=davidwalsh
6cc7f2b947410d566e9a8b4fcd91765959f09517: Bug 1513707 - [release 108] Fix 7361 - Why Paused should wrap (#7422). r=davidwalsh
Jason Laster <jlaster@mozilla.com> - Wed, 12 Dec 2018 16:33:44 -0500 - rev 507887
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1513707 - [release 108] Fix 7361 - Why Paused should wrap (#7422). r=davidwalsh
c383e570567a24f1a75518cc0c698f1ff5685f22: Bug 1513707 - [release 108] Remove 4px gap between the source file name and the primary pane separator (#7421). r=davidwalsh
Jason Laster <jlaster@mozilla.com> - Wed, 12 Dec 2018 16:33:20 -0500 - rev 507886
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1513707 - [release 108] Remove 4px gap between the source file name and the primary pane separator (#7421). r=davidwalsh
4666c210aa93dec761ee8893b0b31fa32283ad3b: Bug 1511013 [wpt PR 14294] - [html] Add more protocol handlers tests: properly escape brackets.
Sebastian Hengst <archaeopteryx@coole-files.de> - Fri, 14 Dec 2018 20:47:14 +0200 - rev 507885
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1511013 [wpt PR 14294] - [html] Add more protocol handlers tests: properly escape brackets.
d9e2ee18925b37da06bb63c956acc165ab303837: Bug 1488162 - Remove suppressGC hacks from wasm code. r=lth.
Julian Seward <jseward@acm.org> - Fri, 14 Dec 2018 13:02:35 +0100 - rev 507884
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1488162 - Remove suppressGC hacks from wasm code. r=lth. This patch removes GCRuntime::temporaryAbortIfWasmGc() and SuppressGC (in WasmStubs.cpp) and also all the bits of C++ that they guard. It also removes the seven associated test cases. I verified that each of the seven tests corresponds to one or more of the removed C++ fragments, so it is safe to remove them.
5ca49059949b3c73db196be7280cfd9472631492: Bug 1476251 - Generate stack maps in the Wasm Baseline compiler. r=lth.
Julian Seward <jseward@acm.org> - Fri, 14 Dec 2018 13:00:44 +0100 - rev 507883
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1476251 - Generate stack maps in the Wasm Baseline compiler. r=lth. This is a first implementation of stack map generation and usage for wasm baseline. It is intended to be a relatively simple starting point for testing and refinement. With the patch in place, it is possible to run Wasm test cases that involve GC objects and garbage collection. The general way the patch works is: * During compilation, all state to do with generating stack maps is held in a new struct, StackMapGenerator. The BaseCompiler updates various fields in StackMapGenerator as it goes, and can call StackMapGenerator::createStackMap to create a map. The StackMapGenerator holds various integer and Maybe-integer fields, but most importantly it maintains a MachineStackTracker, which is a vector of booleans which track the pointerness of each word in the current frame except for pointers corresponding to stack-resident ref-typed entries in the compiler's evaluation stack. When we want to create a stack map, BaseCompiler calls one of its four different ::createStackMap functions. These are simple wrappers which add various default and other parameters and call onwards to StackMapGenerator::createStackMap, which does the actual work. * StackMapGenerator::createStackMap works by augmenting the MachineStackTracker with pointers that are implied to exist as a result of stack-resident ref-typed entries in the compiler's evaluation stack (BaseCompiler::stk_). The resulting entries are then copied off into a bit vector (a wasm::StackMap) for storage. Extra entries may be added for the case where a trap exit stub's not-really-a-frame may be pushed over the current frame. The presence of a ref-typed DebugFrame, if any, in the map, is also noted. * All stack maps created also cover those words above the current frame's return address, that are used to pass parameters in memory to this function. In other words, the incoming argument area for a function is covered by that function's stackmap. The alignment padding that may be above that area *isn't* however included; that belongs (logically) to the caller. * For places where a function may invoke the wasm trap exit stub (by executing an illegal instruction), a composite map is created. This contains entries for the stack entries that would exist in the absence of the stub, but also contains extra entries for the save area that the stub will push "on top" of the normal frame. To describe the layout of the save area, a new routine, wasm::GenerateTrapExitMachineState, generates a description of the area from which the stackmap component for the save area is computed. * Completed stackmaps are temporarily stored in BaseCompiler::stackMaps_. They are further processed in WasmGenerator.cpp: - ModuleGenerator::linkCompiledCode biases them by the module offset and moves them to the metadataTier_. - ModuleGenerator::finishMetadata sorts and sanity checks them - ModuleGenerator::finish biases them again, so as to give them their final code addresses, and checks (in debug builds) that they are associated with plausible instructions. * When it comes to GC time, TraceJitActivations iterates over activations, and TraceJitActivation iterates over individual frames. The latter calculates, in each frame, the address of the next instruction to be executed in that frame. It hands this, and, effectively, the stack pointer value, to new function Instance::traceFrame. * Instance::traceFrame does what you'd expect -- looks up the map, using Code::lookupStackMap. Then it scans the frame, doing as many sanity checks as it reasonably can on the way. There are heuristic (but safe) checks to ensure that the maps sync with the actual stack values, and also that the map sizes are correct. * There are 3 new test files: stackmaps1.js -- tests unwinding w/ maps, for direct/indirect calls only. stackmaps2.js -- as stackmaps1.js but in the presence of many interrupts stackmaps3.js -- tries hard to generate many cells which are held live only from the stack, whilst dealing with interrupts * New types: MachineStackTracker -- as described above StackMapGenerator -- as described above struct wasm::StackMap -- a single stack map -- basically a bit vector class wasm::StackMaps -- a mapping from code addr to wasm::StackMap * The zero value pushed by GenerateTrapExit has been changed to 1337 and had been given a symbolic name. This isn't entirely frivolous: detecting the zero in Instance::traceFrame is a useful sanity check, but zeroes occur relatively frequently in the stack. 1337 is much less likely to randomly appear. It's not pointer aligned and denotes "page zero" so seems relatively safe. Supporting changes: * JitFrameIter and WasmFrameIter have a new method, returnAddressToFp(), which produces the address of the next instruction to be executed for both JS and Wasm frames. * For all call instructions generated, the relevant MacroAssembler routines have been modified so as to return a CodeOffset to guarantees to refer to the first byte of the instruction immediately following the call. This is so as to ensure that the stack map refers to the correct instruction even in the case where the MacroAssembler routine adds further instruction after the actual call instruction. * Stackmap generation can fail due to lack of memory. So all call chains that can lead to a call to StackMapGenerator::createStackMap now return a MOZ_MUST_USE bool and must detect and handle OOMs in the normal way. * struct BaseCompiler::Stk (evaluation stack elements) has been lifted out to the top level and placed above struct StackMapGenerator, since StackMapGenerator needs to be able to inspect stack entries.
7e88127111fe72ae74ed3d975d2566cfc01f6c69: Bug 1513149 - Hovering the action buttons doesn't display the command associated with the button. r=Gijs
Paolo Amadini <paolo.mozmail@amadzone.org> - Tue, 11 Dec 2018 18:27:01 +0000 - rev 507882
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1513149 - Hovering the action buttons doesn't display the command associated with the button. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D14172
f20886290ab025ba6b26c7093ade7e6ce19f2dd9: Bug 1513547, ensure selection objects created for autocopy are cleared as soon as possible, r=ehsan
Olli Pettay <Olli.Pettay@helsinki.fi> - Thu, 13 Dec 2018 15:07:19 +0200 - rev 507881
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1513547, ensure selection objects created for autocopy are cleared as soon as possible, r=ehsan
bcd3b9fa9eace5c02ff292a3cf5a0476280e582d: Bug 1497698 - Partial Implementation of PatchJump(). r=nbp
Sean Stangl <sean.stangl@gmail.com> - Thu, 13 Dec 2018 15:36:00 +0200 - rev 507880
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1497698 - Partial Implementation of PatchJump(). r=nbp
7ba89c2d426df93c36e8c5550f65f69d4db1dc1d: Bug 1497219 - Mochitest for PaymentRequest in not fully active document. r=baku
Eden Chuang <echuang@mozilla.com> - Fri, 14 Dec 2018 15:06:30 +0100 - rev 507879
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1497219 - Mochitest for PaymentRequest in not fully active document. r=baku
2738bb9f6d54d34aa1742c50da7f6f120d9577a9: Bug 1497219 - Rejecting PaymentRequest::API calls when the PaymentRequest is not in fully active document. r=baku
Eden Chuang <echuang@mozilla.com> - Wed, 05 Dec 2018 15:01:45 -0500 - rev 507878
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1497219 - Rejecting PaymentRequest::API calls when the PaymentRequest is not in fully active document. r=baku PaymentRequest API is not supported when the PaymentRequest is not in the fully active document. Adding bool a PaymentRequest::InFullyActiveDocument() method to check if the PaymentRequest is in fully active document. This method should be called at the start of any PaymentRequest APIs. If the PaymentRequest is not in fully active document, ignoring the API call and throw the NS_ERROR_DOM_ABORT_ERR if needed.
610a04b74c8742efd24a4b8cc96da25ee482748a: Bug 1513891 - Extra metadata updates, a=testonly
James Graham <james@hoppipolla.co.uk> - Fri, 14 Dec 2018 16:28:20 +0000 - rev 507877
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1513891 - Extra metadata updates, a=testonly
117411b9bc37722a3be46e020345a4d939dd8e34: Merge mozilla-central to mozilla-inbound. a=merge on a CLOSED TREE
Razvan Maries <rmaries@mozilla.com> - Fri, 14 Dec 2018 18:35:20 +0200 - rev 507876
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Merge mozilla-central to mozilla-inbound. a=merge on a CLOSED TREE
b35c7bd52b7aa0659e3c0260ad0fd3d2ec71383e: Bug 1513891 - [wpt-sync] Update expectation for text-space-collapse-preserve-breaks-001.xht to fail on Windows. a=Wr-fix
Sebastian Hengst <archaeopteryx@coole-files.de> - Fri, 14 Dec 2018 18:13:41 +0200 - rev 507875
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1513891 - [wpt-sync] Update expectation for text-space-collapse-preserve-breaks-001.xht to fail on Windows. a=Wr-fix
466d0030af6d5528864fa88ff1a733f77a65d867: Bug 1511013 [wpt PR 14294] - [html] Add more protocol handlers tests: update test expectations. r=jgraham-on-IRC
Sebastian Hengst <archaeopteryx@coole-files.de> - Fri, 14 Dec 2018 18:05:05 +0200 - rev 507874
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1511013 [wpt PR 14294] - [html] Add more protocol handlers tests: update test expectations. r=jgraham-on-IRC
9670d2fdc1660e6c43ce0e6adb0cc0aba1461d8a: Bug 1475896 - Add telemetry for GC marking rate. r=jonco, data-review=chutten
Yoshi Cheng-Hao Huang <allstars.chh@gmail.com> - Mon, 19 Nov 2018 16:06:08 +0100 - rev 507873
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1475896 - Add telemetry for GC marking rate. r=jonco, data-review=chutten
ca19ff7f1891dd8a29300d145747d77d6efdd505: No bug - update push-apk rollout comment. r=jlorenzo DONTBUILD
Julien Cristau <jcristau@mozilla.com> - Fri, 14 Dec 2018 15:23:37 +0100 - rev 507872
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
No bug - update push-apk rollout comment. r=jlorenzo DONTBUILD
fd4d12eb1b977214161da38fcb3902f7fafce17c: Bug 1463462 - Dump more information when gray marking checks fail r=sfink
Jon Coppeard <jcoppeard@mozilla.com> - Thu, 06 Dec 2018 16:28:15 -0500 - rev 507871
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1463462 - Dump more information when gray marking checks fail r=sfink
d5542a14b416d3d7e4e846368ceb37d6714827aa: Bug 1463462 - Add zeal mode to test incremental gray marking r=sfink
Jon Coppeard <jcoppeard@mozilla.com> - Thu, 06 Dec 2018 16:28:15 -0500 - rev 507870
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1463462 - Add zeal mode to test incremental gray marking r=sfink
42f073dedf5fd708e118833b4ddf63a19907485a: Bug 1463462 - Delay gray marking assertions when we are doing incremental gray marking r=sfink
Jon Coppeard <jcoppeard@mozilla.com> - Thu, 06 Dec 2018 16:28:14 -0500 - rev 507869
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1463462 - Delay gray marking assertions when we are doing incremental gray marking r=sfink
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip