e83673877a64eddbdffa97495daf0b105b262bed: Bug 1412722 - Remove RedBlackTree sentinel. r=njn
Mike Hommey <mh+mozilla@glandium.org> - Sat, 28 Oct 2017 08:36:32 +0900 - rev 440158
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1412722 - Remove RedBlackTree sentinel. r=njn The sentinel was taking as much space as one element of the tree, while only really used for its RedBlackTreeNode, wasting space. This results in some decrease in struct sizes, for example on 64-bits linux: - arena_bin_t: 80 -> 56 - arena_t (excluding mBins): 224 -> 144 - arena_t + dynamic size of mBins: 3024 -> 2104 It also decreases the size of several globals: - gChunksBySize, gChunksByAddress, huge: 64 -> 8 - gArenaTree: 312 -> 8
ab99364834406790d4e2415646c7f89db0f10ad0: Bug 1411963 - Drop assertion about GetBaseValue not returning null in nsSMILCompositor::ComposeAttribute; r=dholbert
Brian Birtles <birtles@gmail.com> - Tue, 31 Oct 2017 16:22:04 +0900 - rev 440157
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1411963 - Drop assertion about GetBaseValue not returning null in nsSMILCompositor::ComposeAttribute; r=dholbert This assertion was originally added in bug 1353208 because in that bug we changed the type of nsSMILCompositor::mCachedBaseValue from nsAutoPtr<nsSMILValue> to just nsSMILValue. When using nsAutoPtr, mCachedBaseValue had two null states: one where the pointer is null, and one where the pointed-to nsSMILValue is null. Coalescing these two states simplifies the code but there is one case where the difference is significant as described in the commit message for that changeset (mozilla-central changeset ad7060dae117): "There's a subtle difference in behavior with regards to the first sample. Previously we would compare the (initially) null mCachedBaseValue pointer with the passed-in nsSMILValue and set mForceCompositing to true. With this patch, however, we will only set mForceCompositing to true if the passed-in mCachedBaseValue is not null." That is, if the base value we get back is a null nsSMILValue, previously we would set mForceCompositing to true unconditionally, but with the changes in bug 1353208 we would only set that to true if the passed-in nsSMILValue was not null. We believed that would never matter since the passed-in nsSMILValue would never be null if we called GetBaseValue. Quoting from that same commit message: "... if we do call GetBaseValue the result should not be a null nsSMILValue (except in some OOM cases where we don't really care if we miss a sample). This patch adds an assertion to check that GetBaseValue does, in fact, return a non-null value. (I checked the code and this appears to be the case. Even in error cases we typically return an empty nsSMILValue of a non-null type. For example, the early return in nsSMILCSSProperty::GetBaseValue() does this.)" We added an assertion to validate that assumption but the crashtest included in this patch demonstrates a case where it does not hold (specifically, when nsStyleUtil::CSPAllowsInlineStyle returns false, nsCSSProperty::GetBaseValue will return a null nsSMILValue). That would seem to suggest that there is at least one case where we might fail to set mForceIsCompositing to true and hence fail to update style on this first sample (and presumably thereonwards too since future comparisons of mCachedBaseValue will compare equal). However, for the case of an initial sample mForceCompositing should already be set to true since set we update mForceCompositing in nsSMILCompositor::GetFirstFuncToAffectSandwich() and will make it true if *anything* in the animation function has changed and at this point, the initial sample, *everything* will have changed. Hence, I believe dropping this assertion is acceptable. I have confirmed that in the crashtest in this patch, during the first sample mForceCompositing is set to true. I would create a reftest to test the behavior on the first sample but, at least for the specific case where inline style is disabled due to CSP, not updating style *is* the expected behavior so there will be no difference in behavior regardless of whether or not the mForceCompositing flag is set. MozReview-Commit-ID: Li0pZEH2PNl
dd8e8d73d99f08a1360d23fcbf001eaf5e29667b: merge mozilla-central to autoland. r=merge a=merge
Sebastian Hengst <archaeopteryx@coole-files.de> - Wed, 01 Nov 2017 00:38:25 +0100 - rev 440156
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
merge mozilla-central to autoland. r=merge a=merge
bc4844e422304f4c6d8c60c767e06c9adcfd9375: Bug 1412743: Test this. r=jfkthame
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 31 Oct 2017 14:36:42 +0100 - rev 440155
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1412743: Test this. r=jfkthame MozReview-Commit-ID: 8bTVRFk3FVe
4101da1396b0a735e4adb7f422cba5456716eaf8: Bug 1321854 add logging for intermittent, r=mixedpuppy
Shane Caraveo <scaraveo@mozilla.com> - Tue, 31 Oct 2017 15:46:13 -0700 - rev 440154
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1321854 add logging for intermittent, r=mixedpuppy MozReview-Commit-ID: 6Wo1CYLVtgL
788e64fb4fd49f61a871a9cdad29a79ad347d3e9: No bug - Revendor rust dependencies
Servo VCS Sync <servo-vcs-sync@mozilla.com> - Tue, 31 Oct 2017 22:39:54 +0000 - rev 440153
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
No bug - Revendor rust dependencies
d480e881831442f22b9f5ba736707f1760bca9e1: Bug 1412486: Revendor rust dependencies. r=me
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 31 Oct 2017 23:32:11 +0100 - rev 440152
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1412486: Revendor rust dependencies. r=me MozReview-Commit-ID: 5mVyHlwTia1
15e762586892c473ff00fd4844c2d2ef3353f4a1: servo: Merge #19040 - Add support for filtering WebGL extensions based on WebGL version (from MortimerGoro:webgl2_extensions); r=emilio
Imanol Fernandez <mortimergoro@gmail.com> - Tue, 31 Oct 2017 16:14:59 -0500 - rev 440151
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
servo: Merge #19040 - Add support for filtering WebGL extensions based on WebGL version (from MortimerGoro:webgl2_extensions); r=emilio <!-- Please describe your changes on the following line: --> Add support for filtering WebGL extensions based on WebGL version --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [x] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 63af764fc5349e213c42d2007b0bff5d310b3422
305151029850dfa1917fad737af7340e9063e6f6: Bug 1413254 - Write a JSON file with normalized data; r=jmaher
Gregory Szorc <gps@mozilla.com> - Tue, 31 Oct 2017 10:57:14 -0700 - rev 440150
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1413254 - Write a JSON file with normalized data; r=jmaher The new file contains changes that optimize for final file size: * The components are stored as an integer index/key into a map instead of strings. * Paths are stored in hierarchical dicts. * No indentation is used. These changes significantly redude redundancy in string data. For every file in the repo, the raw JSON size is decreased from 27,074,607 to 7,643,529 bytes. MozReview-Commit-ID: 58FWSct8W39
2a5a17388410f1c5d229c9f8eb2cf25726a0492e: Bug 1413254 - Fail Bugzilla CI task if file is missing component annotation; r=jmaher
Gregory Szorc <gps@mozilla.com> - Tue, 31 Oct 2017 10:37:18 -0700 - rev 440149
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1413254 - Fail Bugzilla CI task if file is missing component annotation; r=jmaher We want all files in the repo to be annotated with a Bugzilla component. This change will cause the CI task to fail if files are missing annotations. MozReview-Commit-ID: Kn6dheQqEsk
f4c31bb587d5012392cb137ab68f499b9776f4cb: Bug 1413254 - Establish dedicated mach command for Bugzilla metadata validation; r=jmaher
Gregory Szorc <gps@mozilla.com> - Tue, 31 Oct 2017 10:30:15 -0700 - rev 440148
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1413254 - Establish dedicated mach command for Bugzilla metadata validation; r=jmaher Previously, the CI task invoked 2 mach commands and performed manual gzip compressed. This was sub-optimal for a few reasons: * Redundant moz.build evaluation made execution slower * Potential for shell expansion to interfere with wildcards * Made it harder to change exit code By moving all logic into a mach command, we eliminate all the issues around using shell. Behavior of the new command and the CI task should be backwards compatible. MozReview-Commit-ID: HUFvLteKLOO
89c77901b957b1149d013951317c957c1c58bb4c: Bug 1410652 - Let WebDriver:SwitchToFrame take a web element. r=whimboo
Andreas Tolfsen <ato@sny.no> - Sat, 21 Oct 2017 19:30:27 +0100 - rev 440147
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1410652 - Let WebDriver:SwitchToFrame take a web element. r=whimboo The "element" field on the WebDriver:SwitchToFrame command request's body takes a string web element reference UUID as input. This patch changes it so that it can also take a web element JSON Object. The old behaviour can be removed with Firefox 60. MozReview-Commit-ID: JcTD3MRxjOe
b48a22103f3f4cefc13f6db52a82cdca765b67eb: Bug 1410652 - Use invalid argument error for web element deserialisation. r=whimboo
Andreas Tolfsen <ato@sny.no> - Tue, 24 Oct 2017 17:42:32 +0100 - rev 440146
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1410652 - Use invalid argument error for web element deserialisation. r=whimboo For user input we will want to return the appropriate invalid argument error. For internal input using TypeError is fine. MozReview-Commit-ID: AlOnZuhaczN
a6e574e19c3df8e8e61ba43225b793a219e03ccd: Bug 1410652 - Fix various API documentation in element module. r=whimboo
Andreas Tolfsen <ato@sny.no> - Tue, 24 Oct 2017 17:38:55 +0100 - rev 440145
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1410652 - Fix various API documentation in element module. r=whimboo MozReview-Commit-ID: AaGnolglX5n
bf841cb4ea9af88c797275517935f5497b9e7e63: Bug 1410652 - Fix API docs of assert functions. r=whimboo
Andreas Tolfsen <ato@sny.no> - Tue, 24 Oct 2017 17:32:26 +0100 - rev 440144
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1410652 - Fix API docs of assert functions. r=whimboo MozReview-Commit-ID: HktgnHoCGZV
ee7541fb487ab41b9bd2a35c73aeb018d91081e7: Bug 1398972 - Update Histograms.json r=liuche
Doug Thayer <dothayer@mozilla.com> - Tue, 31 Oct 2017 11:39:18 -0700 - rev 440143
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1398972 - Update Histograms.json r=liuche Since the user can now block Flash and ask the browser to remember that decision, the histogram that collects user's choices on this has to be updated with a fourth option. MozReview-Commit-ID: J4r6nJIiaeQ
89a32423f47130786385c3418e1c6cd59e75e8d8: Bug 1398972 - Plugin doorhanger test cleanup r=Felipe
Doug Thayer <dothayer@mozilla.com> - Tue, 31 Oct 2017 11:40:20 -0700 - rev 440142
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1398972 - Plugin doorhanger test cleanup r=Felipe MozReview-Commit-ID: BNIFILtPWwP
1bbe0eb92a751bb893fee7dcefa696739a658a55: Bug 1398972 - Remove plugin doorhanger XBL r=Felipe
Doug Thayer <dothayer@mozilla.com> - Fri, 20 Oct 2017 15:01:24 -0700 - rev 440141
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1398972 - Remove plugin doorhanger XBL r=Felipe MozReview-Commit-ID: 6BI6ChGxQwa
91806d4db6441a4d4c2d7d79867057b996d81631: Bug 1398972 - Replace usage of plugin doorhanger XBL binding r=Felipe
Doug Thayer <dothayer@mozilla.com> - Tue, 31 Oct 2017 11:40:04 -0700 - rev 440140
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1398972 - Replace usage of plugin doorhanger XBL binding r=Felipe Migrated to simply use PopupNotifications.jsm. Additionally, this changes the behavior to always have two buttons and a remember checkbox. When selecting allow with remember, it will behave like the always allow option previously, but when selecting block with remember, it will move that page into a quiet mode with respect to Flash - i.e., no plugin overlays will show anymore, and instead you will just see the plugin icon in the URL bar, which you can continue to interact with as before. MozReview-Commit-ID: EUFlI7nM09t
08b6c9db493b2feb411f0667353be11733313e1d: Bug 1405811 - Move host compilation flags to mozbuild. r=mshal
Chris Manchester <cmanchester@mozilla.com> - Mon, 02 Oct 2017 11:41:41 -0700 - rev 440139
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1405811 - Move host compilation flags to mozbuild. r=mshal MozReview-Commit-ID: 7I5IHM65eaU
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip