dafeeb65bdf5d0dbabe3e4dfd24139c78795431c: Bug 1636279 - Part 2: Unify WindowContext new document state updating code, r=farre
Nika Layzell <nika@thelayzells.com> - Fri, 08 May 2020 20:42:06 +0000 - rev 592709
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1636279 - Part 2: Unify WindowContext new document state updating code, r=farre When a new document is loaded in a WindowContext, various pieces of state need to be updated in the parent process. This is currently done in an ad-hoc manner in nsGlobalWindowOuter::SetNewDocument. This change moves the updating logic into a common method on WindowGlobalChild. Differential Revision: https://phabricator.services.mozilla.com/D74325
a21ee20e9e600a5771d62d956b50d0bf7057301e: Bug 1636279 - Part 1: Streamline WindowContext initialization, r=farre
Nika Layzell <nika@thelayzells.com> - Fri, 08 May 2020 20:44:12 +0000 - rev 592708
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1636279 - Part 1: Streamline WindowContext initialization, r=farre This should make the flow of how data gets into the initial WindowContext state more clear, and allows the setting of initial synced WindowContext fields. Differential Revision: https://phabricator.services.mozilla.com/D74324
fdcf103b375fc5c5956274da878809baa0cda97c: Bug 1636186 - Remove unnecessary CookieJarSettingsArgs data from WindowContext, r=timhuang
Nika Layzell <nika@thelayzells.com> - Fri, 08 May 2020 20:10:56 +0000 - rev 592707
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1636186 - Remove unnecessary CookieJarSettingsArgs data from WindowContext, r=timhuang The entire CookieJarSettingsArgs is currently being synced into every content process, when only two fields of that structure are actually needed. Those two fields are extracted from the CookieJarSettingsArgs and synchronized separately to avoid leaking information such as principals into every content process. Differential Revision: https://phabricator.services.mozilla.com/D74258
0b00e6f0d4a0d521572c1bb96faaa5f72415ef3e: Bug 1624056 - Properly vendor mp4parse-rust. r=kinetik
Jon Bauman <jbauman@mozilla.com> - Sat, 09 May 2020 00:36:48 +0000 - rev 592706
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1624056 - Properly vendor mp4parse-rust. r=kinetik This requires --build-peers-said-large-imports-were-ok since third_party/rust/mp4parse/src/lib.rs is 113KB. This code is just moving from media/mp4parse-rust to third_party/rust, so it's not really adding to net code size. Differential Revision: https://phabricator.services.mozilla.com/D74488
804dc7924101573ca673d3eb16ca28bd29235b96: Bug 1636061. Rollup popups on direct manipulation event. r=NeilDeakin
Timothy Nikkel <tnikkel@gmail.com> - Fri, 08 May 2020 23:20:38 +0000 - rev 592705
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1636061. Rollup popups on direct manipulation event. r=NeilDeakin Direct Manipulation uses a different input model from processing messages that Windows sends. Windows asks us if we want to start a direct manipulation session by sending us the DM_POINTERHITTEST message, and we call SetContact if we do. After that Windows won't send us messages until the user ends the gesture. Instead Direct Manipulation will update a transform (that's invisible to the user). We pull that transform and turn it into pan and pinch gestures. So DealWithPopups is not called and popups don't get rolled up. Instead I call it in the function where we send all events that come from dmanip. Differential Revision: https://phabricator.services.mozilla.com/D74215
93ab81106303cced13bb5a36fda5e695d86a85d7: Bug 1630912. Handle sending Direct Manipulation input events properly. r=kats
Timothy Nikkel <tnikkel@gmail.com> - Fri, 08 May 2020 23:20:31 +0000 - rev 592704
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1630912. Handle sending Direct Manipulation input events properly. r=kats The old code didn't handle content prevent defaulting the input. The pinch gesture code doesn't seem to fully work properly, it will allow a little pinch zooming before halting it if content is prevent defaulting it. Not sure what is up yet. Differential Revision: https://phabricator.services.mozilla.com/D73220
c6a3a55f67a1665f02a7fd72009e91cd6b8ba36c: Bug 1630912. Add a small state machine and code to send pinch and pan events from direct manipulation. r=kats
Timothy Nikkel <tnikkel@gmail.com> - Fri, 08 May 2020 23:20:23 +0000 - rev 592703
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1630912. Add a small state machine and code to send pinch and pan events from direct manipulation. r=kats We can't just get pinch events, we need to handle both. This state machine code is basically copied from Chrome's implementation. Differential Revision: https://phabricator.services.mozilla.com/D71307
05015d1e83157be817eb8d48b610291eec15960a: Bug 1630912. Hook up direct manipulation object to vsync. r=kats
Timothy Nikkel <tnikkel@gmail.com> - Fri, 08 May 2020 23:20:05 +0000 - rev 592702
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1630912. Hook up direct manipulation object to vsync. r=kats Differential Revision: https://phabricator.services.mozilla.com/D71306
321438a68aab3d4faff5fa3ed5dac29e02a59d9f: Bug 1630912. Create the necessary direct manipulation objects. r=aklotz
Timothy Nikkel <tnikkel@gmail.com> - Fri, 08 May 2020 23:19:58 +0000 - rev 592701
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1630912. Create the necessary direct manipulation objects. r=aklotz Differential Revision: https://phabricator.services.mozilla.com/D71305
b1bd509220e999f0184962a19e098ddda8603038: Bug 1630912. Add PT_TOUCHPAD to touchinjection_sdk80.h. r=aklotz
Timothy Nikkel <tnikkel@gmail.com> - Fri, 08 May 2020 23:19:38 +0000 - rev 592700
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1630912. Add PT_TOUCHPAD to touchinjection_sdk80.h. r=aklotz We need this in a later patch. Differential Revision: https://phabricator.services.mozilla.com/D71304
f9f85e3ccde7bfa277eaa6049828bd630864abff: Bug 1630912. Add a simple way to observe vsync on the mainthread. r=jrmuizel
Kartikaya Gupta <kgupta@mozilla.com> - Fri, 08 May 2020 23:19:31 +0000 - rev 592699
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1630912. Add a simple way to observe vsync on the mainthread. r=jrmuizel I had to mess with the refcounting of Display (and hence destructors) because we create a NewRunnableMethod inside Display that holds a pointer to |this|. There are versions of NewRunnableMethod that don't take a ref but I'm not sure of the lifetime of Display, so easier to just take a ref since several of the subclasses are already refcounted. Differential Revision: https://phabricator.services.mozilla.com/D71303
49df0c8504b8521913eca4fc6163017e0133e6bb: Bug 1635001 - P3. Fix APZ controller thread-safety access. r=kats
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 08 May 2020 20:46:09 +0000 - rev 592698
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1635001 - P3. Fix APZ controller thread-safety access. r=kats The APZ was keeping a raw pointer to the controller thread. This was a dangerous exercise. This was okay on desktop, as the controller thread was the main thread and would have outlived everything else. On Android however it's the UI thread and it could get deleted before we received a last input event. So we use a strong pointer instead to prevent the thread from being deleted and as such, we now needs to explicitly clear it on shutdown. This requires the various methods in APZThreadUtils to be made thread-safe so that the controller thread can be shutdown mid-air. Differential Revision: https://phabricator.services.mozilla.com/D73830
40c6722e7cdecb831aaf33579d8c8204e0435145: Bug 1635001 - P2. Don't use MessageLoop threads with APZ. r=kats,geckoview-reviewers,snorp
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 08 May 2020 20:46:13 +0000 - rev 592697
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1635001 - P2. Don't use MessageLoop threads with APZ. r=kats,geckoview-reviewers,snorp It is unclear on why MessageLoop was ever used with this code. Differential Revision: https://phabricator.services.mozilla.com/D73829
3bd4793e6d0915df37854f7f23873dc999e073eb: Bug 1635001 - P1. Make threading model clearer when dispatching tasks on the controller thread. r=kats
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 08 May 2020 20:46:11 +0000 - rev 592696
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1635001 - P1. Make threading model clearer when dispatching tasks on the controller thread. r=kats RemoteContentController::PostDelayedTask must be called on the controller thread; and all the 3 implementations are doing is dispatching the task on the current MessageLoop. The naming and that the method was pure virtual made it a bit confusing as it gave the impression we would dispatch the task on the controller's internal thread, which wasn't the case. So we make a generic implementation and assert to the documented use. Differential Revision: https://phabricator.services.mozilla.com/D73828
33d3d4104e4687e1a49542b982a8c435850f74a6: Bug 1634253 - P9. Disable intermittently failing test on win64 debug and asan. r=Gijs
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 08 May 2020 23:31:21 +0000 - rev 592695
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1634253 - P9. Disable intermittently failing test on win64 debug and asan. r=Gijs The test is a permafail without any of those changes on all my windows machine so I've been unable to diagnostic what could happen. The test was also to be nominated for disabling to be too high failure rates. https://bugzilla.mozilla.org/show_bug.cgi?id=1411477#c99 According to :kats, the test was never rewritten to use the new APZ. Disabling on the platform where there's high intermittent failure (about 70%) Differential Revision: https://phabricator.services.mozilla.com/D74391
426e7df37812f618b815e6963cc6465aec0360ba: Bug 1634253 - P8. Remove use of MessageLoop in Canvas. r=mattwoodrow
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 08 May 2020 20:20:39 +0000 - rev 592694
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1634253 - P8. Remove use of MessageLoop in Canvas. r=mattwoodrow MessagePool brings no benefit over the traditional nsIThread. Additonally, replace some incorrect use of RefPtr for xpcom objects. Differential Revision: https://phabricator.services.mozilla.com/D73827
091a01b12001078220207115c934f3df0f896343: Bug 1634253 - P7. Re-enable BackgroundHangMonitor on Compositor thread. r=froydnj
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 08 May 2020 20:20:41 +0000 - rev 592693
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1634253 - P7. Re-enable BackgroundHangMonitor on Compositor thread. r=froydnj We re-enable the option to have a BackgroundHangMonitor on the compositor thread that was removed earlier.. Differential Revision: https://phabricator.services.mozilla.com/D73826
728ba655194f682510149c0107cbe8e335f306e6: Bug 1634253 - P6. Remove MessageLoop use from gfx. r=kats,mattwoodrow
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 08 May 2020 20:20:44 +0000 - rev 592692
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1634253 - P6. Remove MessageLoop use from gfx. r=kats,mattwoodrow Differential Revision: https://phabricator.services.mozilla.com/D73825
eef89c57b57a36ecebeb658a82f5de70d25f8315: Bug 1634253 - P5. Make threading model clearer. r=kats
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 08 May 2020 20:20:25 +0000 - rev 592691
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1634253 - P5. Make threading model clearer. r=kats CompositorBridgeParent::ScheduleTask was always called from the compositor thread ; so make it explicit that we are dispatching the task to the compositor thread. We inline the method instead. Differential Revision: https://phabricator.services.mozilla.com/D73824
366e40b91676c097242555e1a1275610c1f5fa14: Bug 1634253 - P4. Have NS_NewNamedThread take a already_Refed<nsIRunnable. r=froydnj
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 08 May 2020 20:20:28 +0000 - rev 592690
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1634253 - P4. Have NS_NewNamedThread take a already_Refed<nsIRunnable. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D73823
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip