d49aaecd32a35e710de0e12bb93f2541efa7cd73: Bug 1130203 - Remove retry button in share overlay retry toast. r=margaret a=sylvestre
Michael Comella <michael.l.comella@gmail.com> - Tue, 24 Mar 2015 17:16:00 -0700 - rev 258355
Push 4648 by michael.l.comella@gmail.com at Wed, 08 Apr 2015 16:26:38 +0000
Bug 1130203 - Remove retry button in share overlay retry toast. r=margaret a=sylvestre Toasts are unclickable (http://stackoverflow.com/a/20698525) so this button never actually did anything. If we want to add this functionality, we'd have to use a new toasting API (dialog was suggested) and potentially create a new Activity (so it can be shown over another underlying Activity). We could implement this but it'd be better to spend time creating system notifications to show tab sending progress (bug 1145434).
994526939c21c5993dae6bc2de2c97abd4784504: Bug 1130203 - Add drop shadow to overlay share dialog result toast. r=margaret a=sylvestre
Michael Comella <michael.l.comella@gmail.com> - Mon, 23 Mar 2015 20:04:18 -0700 - rev 258354
Push 4648 by michael.l.comella@gmail.com at Wed, 08 Apr 2015 16:26:38 +0000
Bug 1130203 - Add drop shadow to overlay share dialog result toast. r=margaret a=sylvestre
dcadb357269253ff50c38b977a66f49f03283c53: Bug 1130203 - Review: Finish off share overlay nits. r=trivial a=sylvestre
Michael Comella <michael.l.comella@gmail.com> - Mon, 23 Mar 2015 11:28:56 -0700 - rev 258353
Push 4648 by michael.l.comella@gmail.com at Wed, 08 Apr 2015 16:26:38 +0000
Bug 1130203 - Review: Finish off share overlay nits. r=trivial a=sylvestre Changes include code alignment and clarifying comments.
ce7199dbb0afabe2af56b0b46737267760f8b9b3: Bug 1130203 - Review: Remove single use styles in share overlay. r=trivial a=sylvestre
Michael Comella <michael.l.comella@gmail.com> - Mon, 23 Mar 2015 11:25:17 -0700 - rev 258352
Push 4648 by michael.l.comella@gmail.com at Wed, 08 Apr 2015 16:26:38 +0000
Bug 1130203 - Review: Remove single use styles in share overlay. r=trivial a=sylvestre
dd5f8068b392a148db0af000884f7e33784b9a8b: Bug 1130203 - Reset the first item background drawable state onResume. r=mhaigh a=sylvestre
Michael Comella <michael.l.comella@gmail.com> - Thu, 19 Mar 2015 18:08:48 -0700 - rev 258351
Push 4648 by michael.l.comella@gmail.com at Wed, 08 Apr 2015 16:26:38 +0000
Bug 1130203 - Reset the first item background drawable state onResume. r=mhaigh a=sylvestre The Activity can be re-used in Android L (bug 1137928) so we have to reset any changed state.
8a05ce8c5ff7cd0784af98a8df85f2211d5fd5ce: Bug 1130203 - Clean up share overlay toast styles. r=mhaigh a=sylvestre
Michael Comella <michael.l.comella@gmail.com> - Thu, 19 Mar 2015 17:47:30 -0700 - rev 258350
Push 4648 by michael.l.comella@gmail.com at Wed, 08 Apr 2015 16:26:38 +0000
Bug 1130203 - Clean up share overlay toast styles. r=mhaigh a=sylvestre
abff0e24007817a766f62f53f30ab3f19b220cce: Bug 1130203 - Update ShareOverlay icon padding & assets. r=mhaigh a=sylvestre
Michael Comella <michael.l.comella@gmail.com> - Thu, 19 Mar 2015 11:54:11 -0700 - rev 258349
Push 4648 by michael.l.comella@gmail.com at Wed, 08 Apr 2015 16:26:38 +0000
Bug 1130203 - Update ShareOverlay icon padding & assets. r=mhaigh a=sylvestre This had the added benefit of reusing the OverlayDialogButton for the send tab item rows instead of having a simple implementation, as it was before.
f2cbe1ec6d5a8f84d7f5ae34e4391bcfd08e22a9: Bug 1130203 - Update share overlay row pressed color & color names. r=mhaigh a=sylvestre
Michael Comella <michael.l.comella@gmail.com> - Wed, 18 Mar 2015 17:17:08 -0700 - rev 258348
Push 4648 by michael.l.comella@gmail.com at Wed, 08 Apr 2015 16:26:38 +0000
Bug 1130203 - Update share overlay row pressed color & color names. r=mhaigh a=sylvestre Switched over to using Fennec color palette rather than specific duplicate colors.
49441819b75a6ae1bf32c10e95238cf392407696: Bug 1130203 - Clean up style inheritance in share overlay. r=mhaigh a=sylvestre
Michael Comella <michael.l.comella@gmail.com> - Wed, 18 Mar 2015 16:59:18 -0700 - rev 258347
Push 4648 by michael.l.comella@gmail.com at Wed, 08 Apr 2015 16:26:38 +0000
Bug 1130203 - Clean up style inheritance in share overlay. r=mhaigh a=sylvestre
1c2ce96f9359c8c32f14a57b8ae63c4f65fad9ed: Bug 1130203 - Remove unused share overlay layout. r=mhaigh a=sylvestre
Michael Comella <michael.l.comella@gmail.com> - Wed, 18 Mar 2015 16:34:48 -0700 - rev 258346
Push 4648 by michael.l.comella@gmail.com at Wed, 08 Apr 2015 16:26:38 +0000
Bug 1130203 - Remove unused share overlay layout. r=mhaigh a=sylvestre
b731c0df23aa34ecf5691f2396ea4125bb1a181c: Bug 1130203 - Remove excess LinearLayout from ShareOverlay. r=mhaigh a=sylvestre
Michael Comella <michael.l.comella@gmail.com> - Wed, 18 Mar 2015 16:28:02 -0700 - rev 258345
Push 4648 by michael.l.comella@gmail.com at Wed, 08 Apr 2015 16:26:38 +0000
Bug 1130203 - Remove excess LinearLayout from ShareOverlay. r=mhaigh a=sylvestre
8691a7ac4c9585244e4e39d583f42173dd1b493b: Bug 1130302 - Move ShareOverlayButton.Text to ShareOverlayTextAppearance.Button. r=mhaigh a=sylvestre
Michael Comella <michael.l.comella@gmail.com> - Wed, 18 Mar 2015 16:22:15 -0700 - rev 258344
Push 4648 by michael.l.comella@gmail.com at Wed, 08 Apr 2015 16:26:38 +0000
Bug 1130302 - Move ShareOverlayButton.Text to ShareOverlayTextAppearance.Button. r=mhaigh a=sylvestre It's good practice to separate TextAppearance from View attr.
41eba60614f8468570ff16a6ef343e2f94c6b41f: Bug 1130203 - Rename TextAppearance.ShareOverlay to ShareOverlayTextAppearance. r=mhaigh a=sylvestre
Michael Comella <michael.l.comella@gmail.com> - Wed, 18 Mar 2015 16:08:48 -0700 - rev 258343
Push 4648 by michael.l.comella@gmail.com at Wed, 08 Apr 2015 16:26:38 +0000
Bug 1130203 - Rename TextAppearance.ShareOverlay to ShareOverlayTextAppearance. r=mhaigh a=sylvestre This is more clear because we don't intentionally inherit from TextAppearance.
ca3650a73fdfbd63355a5c752ed6b4ea65572fb4: Bug 1130203 - Update share overlay text colors to match mocks. r=mhaigh a=sylvestre
Michael Comella <michael.l.comella@gmail.com> - Tue, 17 Mar 2015 17:55:27 -0700 - rev 258342
Push 4648 by michael.l.comella@gmail.com at Wed, 08 Apr 2015 16:26:38 +0000
Bug 1130203 - Update share overlay text colors to match mocks. r=mhaigh a=sylvestre
c3ec8ada4705df04834d6fe5b9166173c1273c9a: Bug 1130203 - Set width for share overlay. r=mhaigh a=sylvestre
Michael Comella <michael.l.comella@gmail.com> - Fri, 27 Feb 2015 16:25:11 -0800 - rev 258341
Push 4648 by michael.l.comella@gmail.com at Wed, 08 Apr 2015 16:26:38 +0000
Bug 1130203 - Set width for share overlay. r=mhaigh a=sylvestre
5dd03a21c3768f978452f45babc07b9d9201152d: Bug 1130203 - Round the corners of the first item in the share overlay. r=mhaigh a=sylvestre
Michael Comella <michael.l.comella@gmail.com> - Tue, 17 Mar 2015 17:47:38 -0700 - rev 258340
Push 4648 by michael.l.comella@gmail.com at Wed, 08 Apr 2015 16:26:38 +0000
Bug 1130203 - Round the corners of the first item in the share overlay. r=mhaigh a=sylvestre
feb7a6808bfb9c9f2581f15c1c15f2b35e61e5eb: Bug 1130203 - Add @dimen/button_corner_radius and replace corner radius use in code. r=mhaigh a=sylvestre
Michael Comella <michael.l.comella@gmail.com> - Fri, 27 Feb 2015 14:55:32 -0800 - rev 258339
Push 4648 by michael.l.comella@gmail.com at Wed, 08 Apr 2015 16:26:38 +0000
Bug 1130203 - Add @dimen/button_corner_radius and replace corner radius use in code. r=mhaigh a=sylvestre Note that this does not include fxaccount_* which needs to exist in fxaccount_dimens so it can be used in the detached sync repo.
9a5a288095252c753568cbbb84d3c459aa207d54: Bug 1130203 - Remove dividers in share overlay. r=mhaigh a=sylvestre
Michael Comella <michael.l.comella@gmail.com> - Thu, 26 Feb 2015 18:35:56 -0800 - rev 258338
Push 4648 by michael.l.comella@gmail.com at Wed, 08 Apr 2015 16:26:38 +0000
Bug 1130203 - Remove dividers in share overlay. r=mhaigh a=sylvestre
8002be97de82412e331875bd7a87f35a815fbaff: Bug 1130203 - Move share overlay title styles into styles.xml and revise to match mocks. r=mhaigh a=sylvestre
Michael Comella <michael.l.comella@gmail.com> - Thu, 26 Feb 2015 17:33:36 -0800 - rev 258337
Push 4648 by michael.l.comella@gmail.com at Wed, 08 Apr 2015 16:26:38 +0000
Bug 1130203 - Move share overlay title styles into styles.xml and revise to match mocks. r=mhaigh a=sylvestre
57a21c5e110057113a6bc71ba279b26d3f0b7f15: Bug 1130203 - Remove Firefox logo from share overlay. r=mhaigh a=sylvestre
Michael Comella <michael.l.comella@gmail.com> - Wed, 25 Feb 2015 17:10:17 -0800 - rev 258336
Push 4648 by michael.l.comella@gmail.com at Wed, 08 Apr 2015 16:26:38 +0000
Bug 1130203 - Remove Firefox logo from share overlay. r=mhaigh a=sylvestre
(0) -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip