d08b388c879a0b003129293f64ef2c67769b44ab: Bug 993137 - Make color picker tests less fragile. r=mounir
Jan Keromnes <janx@linux.com> - Sat, 15 Nov 2014 03:11:00 +0100 - rev 240297
Push 4311 by raliiev@mozilla.com at Mon, 12 Jan 2015 19:37:41 +0000
Bug 993137 - Make color picker tests less fragile. r=mounir
c386915cdeda12e86236d529829052a21a444851: Bug 1100221 - eliminate unused GetOrMakeFont for Android. r=m_kato
John Daggett <jdaggett@mozilla.com> - Mon, 17 Nov 2014 16:48:51 +0900 - rev 240296
Push 4311 by raliiev@mozilla.com at Mon, 12 Jan 2015 19:37:41 +0000
Bug 1100221 - eliminate unused GetOrMakeFont for Android. r=m_kato
d6cef8f84cb52ad5ff9ba873f65b4bf95162478a: Bug 1092826 - Cu. and Ci. is undefined errors in PrintUtils since Bug 1082575 (regression) r=mconley
Philip Chee <philip.chee@gmail.com> - Mon, 17 Nov 2014 14:56:55 +0800 - rev 240295
Push 4311 by raliiev@mozilla.com at Mon, 12 Jan 2015 19:37:41 +0000
Bug 1092826 - Cu. and Ci. is undefined errors in PrintUtils since Bug 1082575 (regression) r=mconley
2748f3c6b225d63651e1b991f4b01ba7a026e9f7: Bug 1083670 - Move API tests for CSS Animations and CSS Transitions into separate directories; r=dbaron
Brian Birtles <birtles@gmail.com> - Mon, 17 Nov 2014 13:46:01 +0900 - rev 240294
Push 4311 by raliiev@mozilla.com at Mon, 12 Jan 2015 19:37:41 +0000
Bug 1083670 - Move API tests for CSS Animations and CSS Transitions into separate directories; r=dbaron
1be1a3bc5cb63bbffb670082d932b8d30dd948fe: Bug 1081007 - Fix relationship between Play/PlayFromJS/PlayFromStyle etc.; r=dholbert
Brian Birtles <birtles@gmail.com> - Mon, 17 Nov 2014 13:46:01 +0900 - rev 240293
Push 4311 by raliiev@mozilla.com at Mon, 12 Jan 2015 19:37:41 +0000
Bug 1081007 - Fix relationship between Play/PlayFromJS/PlayFromStyle etc.; r=dholbert The existing relationship between the particular versions of AnimationPlayer::Play* (particularly in the CSSAnimationPlayer) subclass are confusing because, for example, CSSAnimationPlayer::PlayFromStyle needs to be careful to *not* call Play on CSSAnimationPlayer, but only on the parent object (since otherwise we reset the sticky pause behavior). This patch reworks this relationship by adding a protected DoPlay method that performs the common pausing behavior. Play/PlayFromJS/PlayFromStyle then add flushing, sticky pausing etc. as necessary. This patch also removes the UpdateFlags enum and parameters previously used to control whether we forced an update to style. This is no longer necessary since we no longer call 'Play' from style. Instead we make Play always post restyles. If we come across a case where we want to call Play and *not* post restyles, we can re-add the flags then. Roughly the same arrangement is true for Pause except that we don't currently flush styles for CSS animations in PauseFromJS since it currently won't make any observable difference.
de062f18d6e178aadc8f3ca864ca72c0cd9117c9: Bug 1073336 part 16 - Factor out animation-layer related information to a common database; r=dbaron
Brian Birtles <birtles@gmail.com> - Mon, 17 Nov 2014 13:46:00 +0900 - rev 240292
Push 4311 by raliiev@mozilla.com at Mon, 12 Jan 2015 19:37:41 +0000
Bug 1073336 part 16 - Factor out animation-layer related information to a common database; r=dbaron
375663351ae7ad66b91e8ef91a1a52a41960bca9: Bug 1073336 part 15 - Switch AnimationPlayer to using less aggressive update mechanism; r=dbaron
Brian Birtles <birtles@gmail.com> - Mon, 17 Nov 2014 13:46:00 +0900 - rev 240291
Push 4311 by raliiev@mozilla.com at Mon, 12 Jan 2015 19:37:41 +0000
Bug 1073336 part 15 - Switch AnimationPlayer to using less aggressive update mechanism; r=dbaron
4bc90c3a9fd82ee44a8922f05331aba781d445e0: Bug 1073336 part 14c - Check for a null style refresh time in AnimationPlayerCollection::CanThrottleTransformChanges; r=dbaron
Brian Birtles <birtles@gmail.com> - Mon, 17 Nov 2014 13:46:00 +0900 - rev 240290
Push 4311 by raliiev@mozilla.com at Mon, 12 Jan 2015 19:37:41 +0000
Bug 1073336 part 14c - Check for a null style refresh time in AnimationPlayerCollection::CanThrottleTransformChanges; r=dbaron We often set mStyleRuleRefreshTime to null to ensure styles get updated. However, CanThrottleTransformChanges doesn't check for this case and blindly does subtraction using this value. Until now we've got away with this but now that we set mStyleRuleRefreshTime to null when making changes via the API this case crops up in different circumstances and we can trip over it. This patch simply adds a null check before using mStyleRuleRefreshTime in CanThrottleTransformChanges. All other cases where we operate on mStyleRuleRefreshTime check for null.
3c5e1c6d06c3c59d9a1a61028f41ec9c774c3679: Bug 1073336 part 14b - Make ElementRestyler detect changes to the animation generation; r=dbaron
Brian Birtles <birtles@gmail.com> - Mon, 17 Nov 2014 13:46:00 +0900 - rev 240289
Push 4311 by raliiev@mozilla.com at Mon, 12 Jan 2015 19:37:41 +0000
Bug 1073336 part 14b - Make ElementRestyler detect changes to the animation generation; r=dbaron For some kinds of changes we need to update the layer tree even though there is no change to style. For example, if an animation is paused via the Web Animations API, we need to remove the animation from the layer even though the style will not change. This patch detects such changes by making ElementRestyler check for an out-of-date animation generation on layers. This is complicated by the fact that we currently maintain *two* animation generation numbers: one for the set of animations and one for the set of transitions, but we only have *one* animation generation number on each layer. This is a known issue (bug 847286). As a result, until bug 847286 is fixed, we need to be careful to compare against the greater of the two numbers.
3ab8b0f5f2c7e7aa0ab72e622aa1b74b001583d5: Bug 1073336 part 14a - Update animation generation when changing animations via the API; r=dbaron
Brian Birtles <birtles@gmail.com> - Mon, 17 Nov 2014 13:45:59 +0900 - rev 240288
Push 4311 by raliiev@mozilla.com at Mon, 12 Jan 2015 19:37:41 +0000
Bug 1073336 part 14a - Update animation generation when changing animations via the API; r=dbaron
52a3c36054d602faf5ce1f84447e26efac7a78ca: Bug 1073336 part 13 - Add AnimationPlayer::PostUpdate; r=dbaron
Brian Birtles <birtles@gmail.com> - Mon, 17 Nov 2014 13:45:59 +0900 - rev 240287
Push 4311 by raliiev@mozilla.com at Mon, 12 Jan 2015 19:37:41 +0000
Bug 1073336 part 13 - Add AnimationPlayer::PostUpdate; r=dbaron Adds a method for notifying the collection of changes to one of its players.
80cffa4575c6e34bf94526df05d7d055ae4eb1bc: Bug 1073336 part 12 - Add AnimationPlayer::GetCollection(); r=dbaron
Brian Birtles <birtles@gmail.com> - Mon, 17 Nov 2014 13:45:59 +0900 - rev 240286
Push 4311 by raliiev@mozilla.com at Mon, 12 Jan 2015 19:37:41 +0000
Bug 1073336 part 12 - Add AnimationPlayer::GetCollection(); r=dbaron This patch adds a method to animation players that looks up the AnimationPlayerCollection to which the player belongs.
0758acd887497d5a4dee16dcdd2cc881d38904cc: Bug 1073336 part 11 - Move GetAnimationPlayers to base CommonAnimationManager class; r=dbaron
Brian Birtles <birtles@gmail.com> - Mon, 17 Nov 2014 13:45:59 +0900 - rev 240285
Push 4311 by raliiev@mozilla.com at Mon, 12 Jan 2015 19:37:41 +0000
Bug 1073336 part 11 - Move GetAnimationPlayers to base CommonAnimationManager class; r=dbaron nsAnimationManager provides GetAnimationPlayers while nsTransitionManager provides GetElementTransitions. Both perform the same function, namely, fetching (and optionally creating if it does not exist) the AnimationPlayerCollection for the specified element/pseudo. Furthermore, both take the same arguments. This patch aligns the method names and makes this a virtual method on the base class CommonAnimationManager so that it can be used generically from a pointer to a CommonAnimationManager.
9d2e86d4bab6a685aab9429dedad05f2f12b8f7b: Bug 1073336 part 10 - Add AnimationPlayer::GetAnimationManager(); r=dbaron
Brian Birtles <birtles@gmail.com> - Mon, 17 Nov 2014 13:45:58 +0900 - rev 240284
Push 4311 by raliiev@mozilla.com at Mon, 12 Jan 2015 19:37:41 +0000
Bug 1073336 part 10 - Add AnimationPlayer::GetAnimationManager(); r=dbaron This patch introduces an abstract method to AnimationPlayer to fetch the manager object associated with the player. This method is implemented separate by CSSAnimationPlayer and CSSTransitionPlayer to return the nsAnimationManager or nsTransitionManager accordingly.
319ee0b01e09f297d12a7dbbad3e916a6844478f: Bug 1073336 part 9 - Add protected AnimationPlayer::GetPresContext(); r=dbaron
Brian Birtles <birtles@gmail.com> - Mon, 17 Nov 2014 13:45:58 +0900 - rev 240283
Push 4311 by raliiev@mozilla.com at Mon, 12 Jan 2015 19:37:41 +0000
Bug 1073336 part 9 - Add protected AnimationPlayer::GetPresContext(); r=dbaron This patch adds a further getter to find the pres context associated with an animation player's target element, if any.
720613a03d00928f64813a2970523125c02312e2: Bug 1073336 part 8 - Add protected AnimationPlayer::GetRenderedDocument(); r=dbaron
Brian Birtles <birtles@gmail.com> - Mon, 17 Nov 2014 13:45:58 +0900 - rev 240282
Push 4311 by raliiev@mozilla.com at Mon, 12 Jan 2015 19:37:41 +0000
Bug 1073336 part 8 - Add protected AnimationPlayer::GetRenderedDocument(); r=dbaron In order for AnimationPlayer objects to be able to notify their collection/manager, the can either store an extra pointer member, or they can navigate to the collection as follows: player->source(animation)->target(element)->document ->presShell->presContext->manager->collection This patch adds a getter for the first part of this journey up to the document.
c48020bd79cc7f36d1b2d957c11540a56237c9f1: Bug 1073336 part 7 - Move style flushing to CSSAnimationPlayer and CSSTransitionPlayer; r=dbaron
Brian Birtles <birtles@gmail.com> - Mon, 17 Nov 2014 13:45:58 +0900 - rev 240281
Push 4311 by raliiev@mozilla.com at Mon, 12 Jan 2015 19:37:41 +0000
Bug 1073336 part 7 - Move style flushing to CSSAnimationPlayer and CSSTransitionPlayer; r=dbaron Previously AnimationPlayer::Play() and AnimationPlayer::PlayState() would flush styles as part of their operation. This, however, is only needed when the player corresponds to a CSS Animation or CSS Transition. Now that we have concrete subclasses for each of these cases we can move style flushing to the subclasses and remove it from the base class (which is expected to be shared with animations that are not dependent on style).
9c15165070c98e0903d3db0c2d28e770b5513dae: Bug 1073336 part 6 - Add CSSTransitionPlayer; r=dbaron
Brian Birtles <birtles@gmail.com> - Mon, 17 Nov 2014 13:45:57 +0900 - rev 240280
Push 4311 by raliiev@mozilla.com at Mon, 12 Jan 2015 19:37:41 +0000
Bug 1073336 part 6 - Add CSSTransitionPlayer; r=dbaron In order to be able to find the collection a player belongs to from its source content, we first need to be able to determine which manager--the animation manager or transition manager--to look up. We eventually plan to push transition event dispatch down to a CSS transitions-specific subclass of AnimationPlayer, so this seems like a suitable point to introduce this class. Using this subclass we can define a virtual GetManager method that will return the appropriate animation/transition manager for the player.
0b0be39b51ba05bf0f515380b3b2547f6f844398: Bug 1073336 part 5 - Add AnimationPlayerCollection::PlayerUpdated; r=dbaron
Brian Birtles <birtles@gmail.com> - Mon, 17 Nov 2014 13:45:57 +0900 - rev 240279
Push 4311 by raliiev@mozilla.com at Mon, 12 Jan 2015 19:37:41 +0000
Bug 1073336 part 5 - Add AnimationPlayerCollection::PlayerUpdated; r=dbaron
bdee5b74fd2b18e44f8644f7010d4ca8e7c78118: Bug 1073336 part 4 - Add CommonAnimationManager::CollectionUpdated; r=dbaron
Brian Birtles <birtles@gmail.com> - Mon, 17 Nov 2014 13:45:57 +0900 - rev 240278
Push 4311 by raliiev@mozilla.com at Mon, 12 Jan 2015 19:37:41 +0000
Bug 1073336 part 4 - Add CommonAnimationManager::CollectionUpdated; r=dbaron Adds a method to the animation manager base class to handle changes to one of its associated collections.
(0) -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip