c8aa9b29b27834382b0b9ce67114927c2f348925: Bug 1271998 - Part 2 - Make our URL bar scrollable. r=jwu
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 27 Aug 2017 17:31:13 +0200 - rev 429520
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Bug 1271998 - Part 2 - Make our URL bar scrollable. r=jwu Limited space for URLs on mobile browsers has given rise to a class of phishing attacks that rely on a carefully crafted URL with a long subdomain being cut off such as to give the impression of another, legitimate URL [1]. We've experimented in the past with avoiding this by showing only the base domain or the EV certificate owner, but had to revert to the old behaviour because of users complaining about not being able to see as much of the URL as formerly possible. Making the displayed URL scrollable is therefore a nice solution: It allows us to choose the initial scroll position such as to put the focus on the base domain, while giving users the freedom to easily view all the rest of the URL without having to enter editing mode. To make the URL scrollable, we wrap the TextView with a HorizontalScrollView. Alternatively, it would have been possible to use a ScrollingMovementMethod with the TextView, however that way - flinging the text doesn't work out of the box - dragging the text around is still detected as a normal long-press as well and triggers the context menu [1]. E.g. https://manage-myaccount.paypal.com-webapps.verifcheck.com/signin/ (see https://twitter.com/ericlaw/status/900429796240277504 for an example screenshot). MozReview-Commit-ID: LPEXQA2kBvD
fe02dfd16dc37b13888abd56e279b2d5b08a8d9e: Bug 1271998 - Part 1 - Provide a ScrollView with a more efficient fadingEdge implementation. r=jwu
Jan Henning <jh+bugzilla@buttercookie.de> - Thu, 31 Aug 2017 20:06:33 +0200 - rev 429519
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Bug 1271998 - Part 1 - Provide a ScrollView with a more efficient fadingEdge implementation. r=jwu Our previous iteration of a more efficient fadingEdge implementation in FadedMultiColorTextView works by blending the text with a chosen colour. By choosing the same colour as the parent view onto which the TextView is placed, it was thus possible to achieve the impression of fading. With our new URL bar design this is no longer possible quite as easily, since the image used for a lightweight theme will now be displayed behind the URL itself as well. Since the implementation would have also needed more work to make it compatible with scrolling text or being placed in a ScrollView anyway, the fading effect is now achieved directly via the ScrollView instead. Android's built-in fadingEdge implementation calls Canvas.saveLayer (with CLIP_TO_LAYER_SAVE_FLAG omitted!) during a View's onDraw in order to fade out the contents of its children while preserving the background provided by its parents. This saveLayer call is rather expensive and is quite noticeable on a GPU profile even today. Therefore, we implement a more efficient variety of fadingEdges that paints over its children's content in onDrawForeground. To avoid any background content from being faded out, the whole view then has to be placed on a separate layer, however this is still much more efficient than calling Canvas.saveLayer and doesn't show up noticeably in a GPU profile. Prior to Marshmallow, onDrawForeground is not available, so we have to override draw instead in order to be able to paint over the content drawn by the ScrollView's descendants. This means that e.g. scrollbars would be faded out as well, but as we don't intend on showing a scrollbar within the context of this bug, it is an acceptable compromise. MozReview-Commit-ID: DCDPt6ogs0h
d509047f7935f8cdd4f5bad571c52966fa95ba3b: Bug 1271998 - Part 0 - Clean up imports. r=JanH
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 27 Aug 2017 19:58:16 +0200 - rev 429518
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Bug 1271998 - Part 0 - Clean up imports. r=JanH MozReview-Commit-ID: 5y5C77jFYUg
064df3f608f52f4cd3287b1bf392b8a1b1403e04: servo: Merge #18206 - stylo: store specified value of grid layout repeat() function (from ferjm:bug1382369.grid.repeat.function); r=wafflespeanut
Fernando Jiménez Moreno <ferjmoreno@gmail.com> - Mon, 11 Sep 2017 02:32:38 -0500 - rev 429517
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
servo: Merge #18206 - stylo: store specified value of grid layout repeat() function (from ferjm:bug1382369.grid.repeat.function); r=wafflespeanut - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix [Bug 1382369](https://bugzilla.mozilla.org/show_bug.cgi?id=1382369) Source-Repo: https://github.com/servo/servo Source-Revision: 8129cf5563ba91f420f51a09cff9d9a317683ba6
1ace2189941fdcf4926b08ffaf5521a418d04ee8: merge mozilla-central to autoland. r=merge a=merge
Sebastian Hengst <archaeopteryx@coole-files.de> - Mon, 11 Sep 2017 11:20:16 +0200 - rev 429516
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
merge mozilla-central to autoland. r=merge a=merge
8c9d50f961f55d6c144cbbedfa94a6126ea0dab7: Backed out changeset 109e5bafd7a3 (bug 1398623) for asserting during a11y's e.g. accessible/tests/mochitest/states/test_expandable.xul. r=backout
Sebastian Hengst <archaeopteryx@coole-files.de> - Mon, 11 Sep 2017 09:45:18 +0200 - rev 429515
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Backed out changeset 109e5bafd7a3 (bug 1398623) for asserting during a11y's e.g. accessible/tests/mochitest/states/test_expandable.xul. r=backout
86465f8cfaf3404b7ed15f7a2f74b9e2e54f8121: Bug 1395876 - Initialize TSF modules after we create first normal window r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 08 Sep 2017 16:26:54 +0900 - rev 429514
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Bug 1395876 - Initialize TSF modules after we create first normal window r=m_kato Currently, we initialize TSF modules when there is only message window (this started from bug 1341915). At this time, QQ Input (Simplified Chinese TIP) fails to initialize itself. Therefore, we should put off to initialize TSF modules after creating first normal window. Then, initialize its IMC and input context for the window. IMEHandler::InitInputContext() should be called when each normal window is created. Therefore, calling Initialize() from it can guarantee there is at least one normal window when Initialize() is called. MozReview-Commit-ID: IfR4y3pYv6J
c65dfa68df8da69f30e8f58715383de179a51397: Bug 1394758 - Part 2. WSRunObject::InsertBreak should convert space to NBSP when current position is first text run object. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Mon, 04 Sep 2017 15:01:16 +0900 - rev 429513
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Bug 1394758 - Part 2. WSRunObject::InsertBreak should convert space to NBSP when current position is first text run object. r=masayuki After applying part 1 fix, it doesn't pass test_bug430392.html like the following.. 1. content is <span contenteditable=false>A</span>[caret] ; 2. [VK_RETURN] 3. content is <span contenteditable=false>A</span><br>; <- whitespace is removed Since we started to treat readonly text nodes as WSType::special with previous patch, WSRunObject::InsertBreak doesn't convert space (after caret) to NBSP because WSRunObject::InsertBreak does it only when inserted position isn't first text run object. So even if this is first text run object, space after caret should be converted to NBSP. MozReview-Commit-ID: Hj0i3wm45c3
adcfea5cd531baec52c58f8659c35fe02ac2a56c: Bug 1394758 - Part 1. non-editable text node should be treated as WSType::special, not WSType::text. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Mon, 11 Sep 2017 15:52:05 +0900 - rev 429512
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Bug 1394758 - Part 1. non-editable text node should be treated as WSType::special, not WSType::text. r=masayuki This bug occurs that WSRunObject::PrepareToDeleteRangePriv() calls WSRunObject::ConvertToNBSP for non-editable text node. Actually, even if text node isn't editable, WSFragment::mType becomes WSType::text now. So, whitespace only node at the end of contenteditable=false is treated as WSType::normalWS, i.e., treated as editable. So text node in contenteditable=false should treated as WSType::special which means a non-editable inline object. Then, WSRunObject won't create object chunk of WSType::normalWS for text node in contenteditable=false. MozReview-Commit-ID: GOjxax8KvDD
109e5bafd7a34423f6ed3ae03fcd277004fa41a5: Bug 1398623 - Remove several unused variables in nsSprocketLayout::PopulateBoxSizes r=xidorn
sajattack <sajattack@gmail.com> - Sun, 10 Sep 2017 22:33:13 -0700 - rev 429511
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Bug 1398623 - Remove several unused variables in nsSprocketLayout::PopulateBoxSizes r=xidorn MozReview-Commit-ID: 3VXaVgBhgTL
02c78441c03d5d004e57596a130856861a30188a: No bug, Automated HPKP preload list update from host bld-linux64-spot-306 - a=hpkp-update
ffxbld - Mon, 11 Sep 2017 10:29:02 -0700 - rev 429510
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
No bug, Automated HPKP preload list update from host bld-linux64-spot-306 - a=hpkp-update
6f62bdad9e9673767c7239e05801921ff9fa5d82: No bug, Automated HSTS preload list update from host bld-linux64-spot-306 - a=hsts-update
ffxbld - Mon, 11 Sep 2017 10:28:58 -0700 - rev 429509
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
No bug, Automated HSTS preload list update from host bld-linux64-spot-306 - a=hsts-update
f9a5e9ed62103c84e4cde915f4d08f1ce71be83e: merge mozilla-inbound to mozilla-central. r=merge a=merge
Sebastian Hengst <archaeopteryx@coole-files.de> - Mon, 11 Sep 2017 11:18:49 +0200 - rev 429508
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
merge mozilla-inbound to mozilla-central. r=merge a=merge MozReview-Commit-ID: 6kLhBocgiua
1b55231e6628e70f0c2ee2b2cb40a1e9861ac4b4: Bug 1206770 - Add --cpu-count with correct documentation, make --thread-count an alias of --cpu-count. r=luke
Lars T Hansen <lhansen@mozilla.com> - Fri, 08 Sep 2017 15:41:02 +0200 - rev 429507
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Bug 1206770 - Add --cpu-count with correct documentation, make --thread-count an alias of --cpu-count. r=luke
e7ce80185031ac5c037bbcbca3ff6566ef9e0718: Bug 1146817 - Improve implementation of non-access-atomic safe-for-races accesses. r=sstangl
Lars T Hansen <lhansen@mozilla.com> - Fri, 08 Sep 2017 14:24:04 +0200 - rev 429506
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Bug 1146817 - Improve implementation of non-access-atomic safe-for-races accesses. r=sstangl
2b64aee9198d90d181d6b6d5870f57762d47f76f: Bug 1397653 - Update tests within docshell/ to comply with new toplevel data: URI navigation policy. r=smaug
Christoph Kerschbaumer <ckerschb@christophkerschbaumer.com> - Sun, 10 Sep 2017 13:22:12 +0200 - rev 429505
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Bug 1397653 - Update tests within docshell/ to comply with new toplevel data: URI navigation policy. r=smaug
9b2a93197d2ba3a04d05644c55f3432c2dba5866: Bug 1397628 - Don't auto-atomize strings passed from script. r=kmag.
Nicholas Nethercote <nnethercote@mozilla.com> - Thu, 07 Sep 2017 14:37:56 +1000 - rev 429504
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Bug 1397628 - Don't auto-atomize strings passed from script. r=kmag. If you pass a string from script to an IDL method that takes an nsIAtom, XPConnect will automagically atomize the string for you. But nsIAtom is no longer scriptable (see the blockers for bug 1392883, especially bug 1396694). So the code to convert can be removed.
9dcca3ac0aaa19800a3f0c6a7c4ead1d9dfa14d8: Bug 1374112 part 3 - Use AllocateFCItem/FreeFCItem exclusively for allocating FrameConstructionItems. r=dholbert
Mats Palmgren <mats@mozilla.com> - Mon, 11 Sep 2017 00:27:12 +0200 - rev 429503
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Bug 1374112 part 3 - Use AllocateFCItem/FreeFCItem exclusively for allocating FrameConstructionItems. r=dholbert MozReview-Commit-ID: 7TqWZeTV91J
8bc4d3b25dfb1f7092b6bfd471ff94f88e2ca573: Bug 1374112 part 2 - Introduce nsCSSFrameConstructor::AllocateFCItem/FreeFCItem for allocating FrameConstructionItems from an arena/free list. r=dholbert
Mats Palmgren <mats@mozilla.com> - Mon, 11 Sep 2017 00:27:12 +0200 - rev 429502
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Bug 1374112 part 2 - Introduce nsCSSFrameConstructor::AllocateFCItem/FreeFCItem for allocating FrameConstructionItems from an arena/free list. r=dholbert MozReview-Commit-ID: 5VVhEQOZMlU
7ee14a111f8cc625e3f23516b7f7af15de66407b: Bug 1374112 part 1 - Move the mUndisplayedItems field to the start to avoid alignment spill after a bool. r=dholbert
Mats Palmgren <mats@mozilla.com> - Mon, 11 Sep 2017 00:27:11 +0200 - rev 429501
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Bug 1374112 part 1 - Move the mUndisplayedItems field to the start to avoid alignment spill after a bool. r=dholbert MozReview-Commit-ID: 297LgoUFwJL
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip