c76f0ce30414aaac75bde463dd51f9e564e45300: Bug 1082486 - Part 4 - Check whether nsCaret shows in the scroll frame. r=roc
Ting-Yu Lin <tlin@mozilla.com> - Thu, 16 Oct 2014 22:03:00 +0200 - rev 235510
Push 4311 by raliiev@mozilla.com at Mon, 12 Jan 2015 19:37:41 +0000
Bug 1082486 - Part 4 - Check whether nsCaret shows in the scroll frame. r=roc This patch check whether nsCaret shows in scroll frame. If yes, touch caret will show, and its position will be clamp to scroll frame as before. Otherwise, we hide it since the nsCaret will not be seen in this case.
2ec24bc9a5dd981f9db241322d92ea8ab5fde5dd: Bug 1082486 - Part 5 - Hide touch caret when PresShell is suppressing painting. r=roc
Ting-Yu Lin <tlin@mozilla.com> - Thu, 16 Oct 2014 05:08:00 +0200 - rev 235509
Push 4311 by raliiev@mozilla.com at Mon, 12 Jan 2015 19:37:41 +0000
Bug 1082486 - Part 5 - Hide touch caret when PresShell is suppressing painting. r=roc When loading an html, painting is suppressed in PresShell. Therefore the rect of nsCaret or the rect of nearest ancestor scroll frames will not be correct. Touch caret will hide incorrectly because it cannot get the necessary rect to calculate its position. I added a condition in IsDisplayable() to skip when painting is suppressed. Touch caret should sync its visibility with nsCaret again when painting is unsuppressed, and those rects needed by touch caret should be ready then.
b66bcf105809c23610c6e9ad247efb7e2ad102d0: Bug 1082486 - Part 3 - Refactor UpdatePosition(). r=roc
Ting-Yu Lin <tlin@mozilla.com> - Wed, 15 Oct 2014 03:05:00 +0200 - rev 235508
Push 4311 by raliiev@mozilla.com at Mon, 12 Jan 2015 19:37:41 +0000
Bug 1082486 - Part 3 - Refactor UpdatePosition(). r=roc GetTouchCaretPosition() is needed in a later patch.
a1c2b6323e6ea305c2952aaa41a0f517210d735e: Bug 1082486 - Part 2 - Make GetCanvasFrame() returns nsCanvasFrame*. r=roc
Ting-Yu Lin <tlin@mozilla.com> - Tue, 14 Oct 2014 03:07:00 +0200 - rev 235507
Push 4311 by raliiev@mozilla.com at Mon, 12 Jan 2015 19:37:41 +0000
Bug 1082486 - Part 2 - Make GetCanvasFrame() returns nsCanvasFrame*. r=roc PresShell::GetCanvasFrame() already returns nsCanvasFrame*, and it's needed to access nsCanvasFrame's method in a later patch.
c39e875e01f3ba63ea2f1d1e91d00c96a42f3051: Bug 1082486 - Part 1 - Clean up for Mozilla coding style. r=roc
Ting-Yu Lin <tlin@mozilla.com> - Tue, 14 Oct 2014 03:07:00 +0200 - rev 235506
Push 4311 by raliiev@mozilla.com at Mon, 12 Jan 2015 19:37:41 +0000
Bug 1082486 - Part 1 - Clean up for Mozilla coding style. r=roc Also, check mVisible before calling UpdatePosition() in SyncVisibilityWithCaret().
169ea979fe84920f0d09d5e5fe4608b5de0d7e67: Bug 1082199 - Recompute stats in jemalloc_stats when using jemalloc3. r=glandium
Guilherme Goncalves <guilherme.p.gonc@gmail.com> - Fri, 17 Oct 2014 15:55:00 +0200 - rev 235505
Push 4311 by raliiev@mozilla.com at Mon, 12 Jan 2015 19:37:41 +0000
Bug 1082199 - Recompute stats in jemalloc_stats when using jemalloc3. r=glandium
70868ad1299f9cbd61a209789405568c1b174450: Bug 1078327 - Test for correct detecting capturing content. r=smaug
Lebedev Maksim <Alessarik@gmail.com> - Fri, 17 Oct 2014 00:47:00 +0200 - rev 235504
Push 4311 by raliiev@mozilla.com at Mon, 12 Jan 2015 19:37:41 +0000
Bug 1078327 - Test for correct detecting capturing content. r=smaug
458b83f2eaf411620e9ce2be80cd39c9ebd46697: Bug 1078327 - Add check for correct detecting capturing content. r=smaug
Lebedev Maksim <Alessarik@gmail.com> - Mon, 06 Oct 2014 09:16:00 +0200 - rev 235503
Push 4311 by raliiev@mozilla.com at Mon, 12 Jan 2015 19:37:41 +0000
Bug 1078327 - Add check for correct detecting capturing content. r=smaug
d2cbf090111f66eb9f5265578ba0ab855ec4fff9: Bug 1069037 - Prevent touch events from piling up on the main thread. r=mwu
Mason Chang <mchang@mozilla.com> - Thu, 16 Oct 2014 14:02:00 +0200 - rev 235502
Push 4311 by raliiev@mozilla.com at Mon, 12 Jan 2015 19:37:41 +0000
Bug 1069037 - Prevent touch events from piling up on the main thread. r=mwu
6250e897cd5dc474167a52d80310800576bdd79c: Bug 932698 - hold a wakelock when we receive key events. r=mwu
Viral Wang <vwang@mozilla.com> - Fri, 17 Oct 2014 03:44:00 +0200 - rev 235501
Push 4311 by raliiev@mozilla.com at Mon, 12 Jan 2015 19:37:41 +0000
Bug 932698 - hold a wakelock when we receive key events. r=mwu
27bc3dbcaff532c3f91eb7eea4e4ff38152e7edd: Bug 670334 - Set a minimum size for mfence's fences and separators. r=karlt
James Kitchener <jkitch.bug@internode.on.net> - Fri, 17 Oct 2014 18:01:00 +0200 - rev 235500
Push 4311 by raliiev@mozilla.com at Mon, 12 Jan 2015 19:37:41 +0000
Bug 670334 - Set a minimum size for mfence's fences and separators. r=karlt
f564fff0642cfbd82f7192d7e2d8b00610e16091: Bug 622859 - Reject EV certificates with key sizes below RSA 2048. r=briansmith
Cykesiopka <cykesiopka.bmo@gmail.com> - Sat, 18 Oct 2014 15:18:00 +0200 - rev 235499
Push 4311 by raliiev@mozilla.com at Mon, 12 Jan 2015 19:37:41 +0000
Bug 622859 - Reject EV certificates with key sizes below RSA 2048. r=briansmith
92f19cf15b2dfe0683669b9f07dbeafc3e4c071c: Bug 622859 - Tests for bug 622859. r=briansmith,keeler
Cykesiopka <cykesiopka.bmo@gmail.com> - Thu, 16 Oct 2014 05:22:00 +0200 - rev 235498
Push 4311 by raliiev@mozilla.com at Mon, 12 Jan 2015 19:37:41 +0000
Bug 622859 - Tests for bug 622859. r=briansmith,keeler
b3b581cda9405581e89480d211c472693661a39d: Bug 1078122 part 9 - Move queuing of CSS animation events to CSSAnimationPlayer; r=dholbert
Brian Birtles <birtles@gmail.com> - Mon, 20 Oct 2014 13:55:47 +0900 - rev 235497
Push 4311 by raliiev@mozilla.com at Mon, 12 Jan 2015 19:37:41 +0000
Bug 1078122 part 9 - Move queuing of CSS animation events to CSSAnimationPlayer; r=dholbert This patch moves the code for queuing CSS animation events from nsAnimationManager to CSSAnimationPlayer. In doing so, it also moves the mLastNotification member and associated enum values.
1a66dbf7d8e10bb1393d6f6ab07b2120db563880: Bug 1078122 part 8 - Use the new GetTarget overload in AnimationPlayer; r=dholbert
Brian Birtles <birtles@gmail.com> - Mon, 20 Oct 2014 13:55:47 +0900 - rev 235496
Push 4311 by raliiev@mozilla.com at Mon, 12 Jan 2015 19:37:41 +0000
Bug 1078122 part 8 - Use the new GetTarget overload in AnimationPlayer; r=dholbert
6e807f0f41c6d41321777daea6479fb5da65cfd5: Bug 1078122 part 7 - Add method to Animation to get the target element and pseudo; r=dholbert
Brian Birtles <birtles@gmail.com> - Mon, 20 Oct 2014 13:55:47 +0900 - rev 235495
Push 4311 by raliiev@mozilla.com at Mon, 12 Jan 2015 19:37:41 +0000
Bug 1078122 part 7 - Add method to Animation to get the target element and pseudo; r=dholbert
082d6d6cf6acc5ddf442784cf425da0f68efd20e: Bug 1078122 part 6 - Store the previous finished state; r=dholbert
Brian Birtles <birtles@gmail.com> - Mon, 20 Oct 2014 13:55:47 +0900 - rev 235494
Push 4311 by raliiev@mozilla.com at Mon, 12 Jan 2015 19:37:41 +0000
Bug 1078122 part 6 - Store the previous finished state; r=dholbert AnimationPlayer::CanThrottle determines if an animation player has just finished by inspecting the value of mLastNotification. This is problematic for two reasons: 1. mLastNotification is intended to be used for events (as the XXX comment notes) 2. mLastNotification is specific to CSS Animations and should be moved to CSSAnimationPlayer. To address this, this patch adds an extra member mIsPreviousStateFinished. The Web Animations spec already defines animation players as having such a member: http://w3c.github.io/web-animations/#previous-finished-state We set it to true when we calculate the style for an animation that has finished. This differs slightly from the code it is replacing as explained below. In the case of CSS Animations we perform the following sequence of steps on each sample. 1. EnsureStyleRuleFor (calls CanThrottle, and maybe ComposeStyle) 2. GetEventsForCurrentTime In the existing code, we update mLastNotification in (2) which happens on every sample, even throttled samples. In this patch, however, we update mIsPreviousStateFinished in (1) during the ComposeStyle step which only happens for unthrottled samples. So, as of this patch, in CanThrottle, we ask "have we newly entered the finished state since the last *unthrottled* sample?", whereas previously we simply looked for a change since the last sample, throttled or not. However, if the answer to the question is "yes", then we'll run an unthrottled sample and update mIsPreviousStateFinished so these should be functionally equivalent. Another subtle difference is that this patch looks at the player's finished state rather than the animation phase of its source content, and these will produce different results in the case where the player is paused. However, since paused animations are not run on the compositor, this should not matter. In the case of CSS Transitions, AnimationPlayer::CanThrottle() is not currently used and so mIsPreviousStateFinished is irrelevant. Ultimately, both the existing and the new code is somewhat fragile but hopefully this will be addressed by: * Replacing mIsPreviousStateFinished with inspecting whether the finished promise is settled (bug 1074630), * Merging more of the code in nsAnimationManager and nsTransitionManager and applying a unified approach to sampling that better accommodates these considerations.
4d628be8f7d031c0514df23fb7b1caec4f335410: Bug 1078122 part 5 - Move CSSAnimationPlayer to nsAnimationManager; r=dholbert
Brian Birtles <birtles@gmail.com> - Mon, 20 Oct 2014 13:55:46 +0900 - rev 235493
Push 4311 by raliiev@mozilla.com at Mon, 12 Jan 2015 19:37:41 +0000
Bug 1078122 part 5 - Move CSSAnimationPlayer to nsAnimationManager; r=dholbert This patch takes the CSSAnimationPlayer object, currently defined in dom/animation/AnimationPlayer.{cpp,h}, and moves it to layout/style/nsAnimationManager.{cpp,h} where the rest of the CSS Animations-specific code lives. At the same time it extends the scope of the mozilla namespace block in nsAnimationManager.h to also include the AnimationEventInfo and EventArray types since these classes, which don't have an ns* prefix, probably should be in the mozilla namespace anyway.
93c56f764bc31ea07df24baa8f6fa6e83df79658: Bug 1078122 part 4 - Make the mSource and mTimeline members of AnimationPlayer protected; r=dholbert
Brian Birtles <birtles@gmail.com> - Mon, 20 Oct 2014 13:55:46 +0900 - rev 235492
Push 4311 by raliiev@mozilla.com at Mon, 12 Jan 2015 19:37:41 +0000
Bug 1078122 part 4 - Make the mSource and mTimeline members of AnimationPlayer protected; r=dholbert
d54306da529f6918f79a9e43c5e0a61883cee453: Bug 1078122 part 3 - Move animation value building down to the Animation objects; r=dholbert
Brian Birtles <birtles@gmail.com> - Mon, 20 Oct 2014 13:55:46 +0900 - rev 235491
Push 4311 by raliiev@mozilla.com at Mon, 12 Jan 2015 19:37:41 +0000
Bug 1078122 part 3 - Move animation value building down to the Animation objects; r=dholbert This patch extracts the logic for calculating animation styles from AnimationPlayerCollection and puts the bulk of it into the Animation objects. Some of the initial logic surrounding the animation player state (e.g. is it paused or not, etc.) is put into AnimationPlayer. In future we may shift this logic even further down to the AnimationEffect objects but currently we don't create such objects unless necessary.
(0) -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip