c6ecca7fc9882c9a7dfc91b9095775fb56ff9dad: Backed out changeset 56d817208b35 (bug 1451079) for failing browser_ext_runtime_setUninstallURL.js CLOSED TREE
Ciure Andrei <aciure@mozilla.com> - Thu, 28 Feb 2019 05:38:41 +0200 - rev 519470
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Backed out changeset 56d817208b35 (bug 1451079) for failing browser_ext_runtime_setUninstallURL.js CLOSED TREE
d2181b1364441d22e422e93fd910ea2d5f5410a5: Bug 1511247 - Disabled devtools/client/accessibility/test/browser/browser_accessibility_panel_highlighter_multi_tab.js on Linux64 debug for frequent failures r=jmaher
Dorel Luca <dluca@mozilla.com> - Wed, 27 Feb 2019 15:39:45 +0000 - rev 519469
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1511247 - Disabled devtools/client/accessibility/test/browser/browser_accessibility_panel_highlighter_multi_tab.js on Linux64 debug for frequent failures r=jmaher Differential Revision: https://phabricator.services.mozilla.com/D21375
b03d042670c0d5241e8e57e5af9706e2a57b4c08: Bug 1531201 - Don't assume all frames' time is greater than 0. r=gerald
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 28 Feb 2019 02:34:04 +0000 - rev 519468
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1531201 - Don't assume all frames' time is greater than 0. r=gerald We now allow frames to have a negative time (so that they can be decoded and trimmed). Differential Revision: https://phabricator.services.mozilla.com/D21474
4dcf351df9b8a01752a62002e0985aab9033ac1e: Bug 1520831. Fix handling of Symbol-named properties on objects with named setters. r=qdot
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 19 Feb 2019 19:08:32 +0000 - rev 519467
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1520831. Fix handling of Symbol-named properties on objects with named setters. r=qdot Per spec these should just go directly to the expando object; we were ignoring them instead. Differential Revision: https://phabricator.services.mozilla.com/D16930
4d9ae84e669496a00d0d26b5f40ad9b9a9dd077d: Bug 1531086 - Remove some null checks in Element.h and Attr.cpp. r=qdot
Andrew McCreight <continuation@gmail.com> - Thu, 28 Feb 2019 01:37:49 +0000 - rev 519466
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1531086 - Remove some null checks in Element.h and Attr.cpp. r=qdot |new| is infallible, so these checks are not needed. I also modernized the ref pointers in these macros a bit. Differential Revision: https://phabricator.services.mozilla.com/D21432
56d817208b35b3b1c16833b3dcd7ad80a7297371: Bug 1451079 - Adding fix for setting empty url to set uninstall url during runtime. r=zombie
sagarwala <shailja.agarwala21@gmail.com> - Thu, 28 Feb 2019 02:15:12 +0000 - rev 519465
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1451079 - Adding fix for setting empty url to set uninstall url during runtime. r=zombie The bug indicated that the setUninstallURL did not honor empty url during runtime. Steps to reproduce: 1. Install an extension, uninstall URL is set 2. Update the extension, changing the uninstall URL string to null (empty) 3. Uninstall the extension Differential Revision: https://phabricator.services.mozilla.com/D18499
1d1443507be4aedaa6a868acf08e5086d607a9e0: Bug 1375476 - Support font-style / font-weight and font-size on <option> elements. r=mconley
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 28 Feb 2019 01:44:52 +0000 - rev 519464
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1375476 - Support font-style / font-weight and font-size on <option> elements. r=mconley And cleanup / make the code a bit more generic while at it. Differential Revision: https://phabricator.services.mozilla.com/D20463
bb37a041dbebaf73746e0ba8822eadd27945ec67: Bug 1531173 - Drop nsIContentViewer.scrollToNode. r=emilio
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Thu, 28 Feb 2019 01:31:47 +0000 - rev 519463
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1531173 - Drop nsIContentViewer.scrollToNode. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D21458
03d6fa61c83594e678952a3f8bc275e9b5e3a614: Backed out changeset 32c7dc092efd (bug 1119063) for failing test_autocomplete_new_password.html CLOSED TREE
Ciure Andrei <aciure@mozilla.com> - Thu, 28 Feb 2019 03:36:04 +0200 - rev 519462
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Backed out changeset 32c7dc092efd (bug 1119063) for failing test_autocomplete_new_password.html CLOSED TREE
a01586b62cf510bb165057e0bea9a45cc76e961e: Bug 1489308 part 10. Remove some document.open handling in outer window that's no longer needed. r=mccr8
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 27 Feb 2019 05:36:38 +0000 - rev 519461
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1489308 part 10. Remove some document.open handling in outer window that's no longer needed. r=mccr8 Differential Revision: https://phabricator.services.mozilla.com/D18077
5fbeaa1c39971f0f41bc7cd04610234f27fc18a2: Bug 1489308 part 9. Remove now-unused wyciwyg bits. r=mccr8
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 28 Feb 2019 01:09:48 +0000 - rev 519460
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1489308 part 9. Remove now-unused wyciwyg bits. r=mccr8 Differential Revision: https://phabricator.services.mozilla.com/D17327
8e1196296ad4ff8e525194bce2eb9f043ee60834: Bug 1489308 part 8. Remove unneeded JSContext args on open/write/writeln. r=mccr8
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 27 Feb 2019 05:12:13 +0000 - rev 519459
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1489308 part 8. Remove unneeded JSContext args on open/write/writeln. r=mccr8 Differential Revision: https://phabricator.services.mozilla.com/D17326
2166dac4d26c4b562dc673d73a42e8f693bbacc8: Bug 1489308 part 7. Remove now-unused mDidDocumentOpen member. r=mccr8
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 27 Feb 2019 05:11:19 +0000 - rev 519458
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1489308 part 7. Remove now-unused mDidDocumentOpen member. r=mccr8 This was only used to check for cases when document.open changed the global and hence elements being inserted into the document need a new reflector. Since document.open no longer changes the global (as of part 5 of the patches for this bug), this code is no longer needed. Differential Revision: https://phabricator.services.mozilla.com/D17325
c1113b00d864eaf617be6fbc3966b73c2af3e1c4: Bug 1489308 part 6. Remove now-unused mWillReparent member. r=mccr8
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 27 Feb 2019 05:10:51 +0000 - rev 519457
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1489308 part 6. Remove now-unused mWillReparent member. r=mccr8 Differential Revision: https://phabricator.services.mozilla.com/D17324
6504b5468b32786ec2f492e0dc6cd2ed3f1cf55d: Bug 1489308 part 5. Align the work we do on document.open with the spec. r=mccr8,smaug
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 27 Feb 2019 23:24:48 +0000 - rev 519456
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1489308 part 5. Align the work we do on document.open with the spec. r=mccr8,smaug The main behavior changes are: 1) We no longer create a new Window when doing document.open(). We use the same Window but remove all the event listeners on it and on the existing DOM tree before removing the document's existing kids. 2) We no longer create a new session history entry. The existing one always gets replaced instead. 3) We now support document.open on documents that are not in a Window. The reasons for the various test changes are as follows: The change to browser_modifiedclick_inherit_principal.js is because we no longer set the docshell to a wyciwyg URL when document.open() happens and the test was depending on that to terminate. browser_wyciwyg_urlbarCopying.js is being removed because it's trying to test wyciwyg URIs, which no longer exist. The changes in docshell/test/navigation are because document.open() no longer affects session history. One of the tests was testing the interactions there and is being removed; another is being repurposed to just test that document.open() does not affect history.length. The change to test_x-frame-options.html is because document.open() now removes event listeners on the window, which it didn't use to do (and in the specific case in this test reused the existing inner too, so the listener was still around in practice). The new behavior matches other browsers. The removal of test_bug172261.html is because document.open() no longer affects session history, so you can't go back across it or forward to the "opened" state, so the situation that test is trying to test no longer exists. The changes to test_bug255820.html are because reloading a document after document.open() will now just load the URL of the document that was the entry document for the open() call, not reload the written content. So there's not much point testing reload behavior, and in this test it was just reloading the toplevel test file inside the frames. The change to test_bug346659.html is because now we no longer create a new Window on document.open(). The change to test_bug1232829.html is because document.open() (implicit in this test) no longer adds history entries, so the back() was just leaving the test page instead of going back across the document.open(). The test is a crashtest in practice, so might still be testing something useful about how document.open() interacts with animations. The change to test_bug715739.html is because the URL of the document after document.open() is now the URL of the entry document, not a wyciwyg URL, so reload() has different behavior than it used to. The change to test_bug329869.html is because now when we go back we're reloading the original document we had, not doing a wyciwyg load, and the security info now doesn't include the untrusted script. The changes to the wpt expectations are removing a bunch of expected failures now that we pass those tests and disabling some tests that are fundamentally racy and hence fail randomly. The latter all have github issues filed for the test problem. The change to testing/web-platform/tests/common/object-association.js is fixing tests that were not matching the spec (and were failing in other browsers). The change to parser-uses-registry-of-owner-document.html is fixing tests that were not matching the spec (and were failing in other browsers). The change to document-write.tentative.html is because the test was buggy: it was using the same iframe element for all its tests and racing loads from some tests against API calls from other tests, etc. It's a wonder it ever managed to pass, independent of these patches (and in fact it doesn't pass according to wpt.fyi data, even in Firefox). The changes in html/browsers/history/the-history-interface are because document.open() no longer adds history entries. The test was failing in all other browsers for the same reason. The changes in html/browsers/history/the-location-interface are because reloading a document.open()-created thing now loads the URL of the page that was the entry document for the open() call. The test was failing in all other browsers. The change to reload_document_open_write.html is because we now reload the url of the document that entered the script that called open() when we reload, not the written content. Other browsers were failing this test too; Gecko with the old document.open implementation was the only one that passed. The change to http-refresh.py is to fix a test bug: it was not returning a Content-Type header, so we were putting up helper app dialogs, etc. The change to test_ext_contentscript.js is because we no create a new global for document.open() calls. Kris Maglione OKed this part. Differential Revision: https://phabricator.services.mozilla.com/D17323
015db4a424d9f817a7dbaee4e520e81f20430727: Bug 1489308 part 4. Allow UpdateURLAndHistory to work even if there's no root session history. r=smaug
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 27 Feb 2019 05:10:11 +0000 - rev 519455
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1489308 part 4. Allow UpdateURLAndHistory to work even if there's no root session history. r=smaug This can happen when someone does a document.open() on a document that has no session history. Differential Revision: https://phabricator.services.mozilla.com/D17322
b393e04da7e97d49c577c5537c1f62cb0cc6b91e: Bug 1489308 part 3. Add a public RemoveAllListeners method on EventListenerManager. r=smaug
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 27 Feb 2019 05:08:50 +0000 - rev 519454
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1489308 part 3. Add a public RemoveAllListeners method on EventListenerManager. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D17321
f2b0ceb55cedd2cffea476c0ff187d4b283ec4e2: Bug 1489308 part 2. Allow UpdateURLAndHistory to work even if mOSHE is null, if we're doing a replace. r=smaug
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 27 Feb 2019 06:01:57 +0000 - rev 519453
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1489308 part 2. Allow UpdateURLAndHistory to work even if mOSHE is null, if we're doing a replace. r=smaug We're going to end up hitting this if someone does a document.open() before mOSHE has been set. We shouldn't need to worry about mLSHE, because the document.open() will cancel the corresponding load. Differential Revision: https://phabricator.services.mozilla.com/D17319
6f00a2d89b5fa9785dac8ea8d4f47dfe17827702: Bug 1489308 part 1. Factor out part of nsDocShell::AddState into a separate method. r=qdot
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 27 Feb 2019 05:56:23 +0000 - rev 519452
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1489308 part 1. Factor out part of nsDocShell::AddState into a separate method. r=qdot This implements the "URL and history update steps" from the HTML spec. See <https://html.spec.whatwg.org/multipage/history.html#url-and-history-update-steps>. Differential Revision: https://phabricator.services.mozilla.com/D17318
2624b1bdee9b2bab41ca9a8c784cf0a7f14c2b7e: Bug 1531160 - Add the original NS_tsnprintf and use a new name for the new function. r=mhowell
Robert Strong <robert.bugzilla@gmail.com> - Thu, 28 Feb 2019 00:33:12 +0000 - rev 519451
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1531160 - Add the original NS_tsnprintf and use a new name for the new function. r=mhowell Differential Revision: https://phabricator.services.mozilla.com/D21468
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 tip