bfd2df1d0bcc1f218fb58447e2017a0c34be4f6e: no bug - Bumping Fennec l10n changesets r=release a=l10n-bump DONTBUILD
L10n Bumper Bot <release+l10nbumper@mozilla.com> - Sun, 13 Jan 2019 12:00:12 -0800 - rev 506669
Push 10504 by ffxbld at Sun, 13 Jan 2019 20:00:25 +0000
no bug - Bumping Fennec l10n changesets r=release a=l10n-bump DONTBUILD be -> 269bdaeb7eda lt -> c7f673f25362
bbf16718dd8a70c0f513e006c38f472997195508: no bug - Bumping Firefox l10n changesets r=release a=l10n-bump DONTBUILD
L10n Bumper Bot <release+l10nbumper@mozilla.com> - Sun, 13 Jan 2019 09:00:24 -0800 - rev 506668
Push 10503 by ffxbld at Sun, 13 Jan 2019 17:00:33 +0000
no bug - Bumping Firefox l10n changesets r=release a=l10n-bump DONTBUILD ca -> 348777063f79 cs -> 3623c90f1a16 fi -> f4b5ef271b7e fr -> d6ce7abe31c4 hi-IN -> 82b3cf04a834 rm -> bfa4e7287b7a ru -> 8897d1067abe zh-CN -> 4af335908d1b
3b22a833324cc83cb87efe78415ddd5f340037f9: no bug - Bumping Fennec l10n changesets r=release a=l10n-bump DONTBUILD
L10n Bumper Bot <release+l10nbumper@mozilla.com> - Sun, 13 Jan 2019 09:00:19 -0800 - rev 506667
Push 10503 by ffxbld at Sun, 13 Jan 2019 17:00:33 +0000
no bug - Bumping Fennec l10n changesets r=release a=l10n-bump DONTBUILD ca -> 348777063f79 fi -> 0d7e72e06d66 fr -> d6ce7abe31c4 hi-IN -> 82b3cf04a834 pt-PT -> 4bbba0a6ffa4 rm -> bfa4e7287b7a ru -> 8897d1067abe
8acdc547561d64b77d649461909207249274961e: Bug 1517078 - Enable browser languages section in prefs on release and beta. r=jaws, a=RyanVM
Mark Striemer <mstriemer@mozilla.com> - Fri, 11 Jan 2019 21:55:16 +0000 - rev 506666
Push 10502 by ryanvm@gmail.com at Sat, 12 Jan 2019 23:41:05 +0000
Bug 1517078 - Enable browser languages section in prefs on release and beta. r=jaws, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D15738
6ca5c3a1e5b4e21cc4677288354c00072156be2a: Bug 1519428 - Fix XML error in Wikipedia searchplugin for zh-TW. r=mkaply, a=RyanVM
Francesco Lodolo (:flod) <flod@lodolo.net> - Fri, 11 Jan 2019 16:17:38 +0000 - rev 506665
Push 10502 by ryanvm@gmail.com at Sat, 12 Jan 2019 23:41:05 +0000
Bug 1519428 - Fix XML error in Wikipedia searchplugin for zh-TW. r=mkaply, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D16322
45793c591e2d44e512cca27b6573fb38022fab88: Bug 1515046 - Let reps invoke the right getter when it's shadowed. r=nchevobbe, a=RyanVM
Oriol Brufau <oriol-bugzilla@hotmail.com> - Sat, 12 Jan 2019 18:33:55 -0500 - rev 506664
Push 10502 by ryanvm@gmail.com at Sat, 12 Jan 2019 23:41:05 +0000
Bug 1515046 - Let reps invoke the right getter when it's shadowed. r=nchevobbe, a=RyanVM Depends on D15788 Differential Revision: https://phabricator.services.mozilla.com/D15789
d5ed432f8da4733c3ab2b8f4ed0a139a4b637d6d: Bug 1515046 - Add receiverId parameter in objectClient.getPropertyValue. r=nchevobbe, a=RyanVM
Oriol Brufau <oriol-bugzilla@hotmail.com> - Sat, 12 Jan 2019 18:32:55 -0500 - rev 506663
Push 10502 by ryanvm@gmail.com at Sat, 12 Jan 2019 23:41:05 +0000
Bug 1515046 - Add receiverId parameter in objectClient.getPropertyValue. r=nchevobbe, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D15788
7bfd0ddce88e35eb5be95af2f62d7a50208b0741: Bug 1515447 - Add receiver parameter to Debugger.Object's getProperty and setProperty. r=jimb, a=RyanVM
Oriol Brufau <oriol-bugzilla@hotmail.com> - Fri, 28 Dec 2018 19:07:15 +0000 - rev 506662
Push 10502 by ryanvm@gmail.com at Sat, 12 Jan 2019 23:41:05 +0000
Bug 1515447 - Add receiver parameter to Debugger.Object's getProperty and setProperty. r=jimb, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D15018
5b52f9f8300439f6f58beead39f28ee22faf4863: Bug 1517071 - Clear AsyncWaitRunnable::mStream when cancelled. r=froydnj, a=RyanVM
Andrew McCreight <continuation@gmail.com> - Fri, 11 Jan 2019 16:57:51 +0000 - rev 506661
Push 10501 by ryanvm@gmail.com at Sat, 12 Jan 2019 21:41:05 +0000
Bug 1517071 - Clear AsyncWaitRunnable::mStream when cancelled. r=froydnj, a=RyanVM AsyncWaitRunnable holds a strong reference to its stream, and NonBlockingAsyncInputStream holds a strong reference to the runnable. The cycle gets broken in the RunAsyncWaitCallback() method of the stream, but if the runnable is cancelled then we leak them both. This patch fixes that by clearing the pointer to the stream when the runnable is cancelled, breaking the cycle. Differential Revision: https://phabricator.services.mozilla.com/D16248
d566c5f82f8b4d53ed05bc8836ea0b9d7dee051c: Bug 1519137 - Add lazy pref getter for content blocking before initializing blockers. r=ewright, a=RyanVM
Johann Hofmann <jhofmann@mozilla.com> - Thu, 10 Jan 2019 17:51:31 +0000 - rev 506660
Push 10501 by ryanvm@gmail.com at Sat, 12 Jan 2019 21:41:05 +0000
Bug 1519137 - Add lazy pref getter for content blocking before initializing blockers. r=ewright, a=RyanVM This was causing some prefs that blockers were accessing not to be set yet. Differential Revision: https://phabricator.services.mozilla.com/D16208
138a3eb773c865898c1f43e53aa9b3b39e2f38d4: Bug 1519209 - Disable NSS_ALLOW_SSLKEYLOGFILE in beta and release. r=glandium, a=RyanVM
Eric Rahm <erahm@mozilla.com> - Thu, 10 Jan 2019 13:14:41 -0800 - rev 506659
Push 10501 by ryanvm@gmail.com at Sat, 12 Jan 2019 21:41:05 +0000
Bug 1519209 - Disable NSS_ALLOW_SSLKEYLOGFILE in beta and release. r=glandium, a=RyanVM This disables NSS_ALLOW_SSLKEYLOGFILE in beta in release in order to avoid shutdown hangs until the NSS project has time to fix the root cause of the issue.
75bae5cabb1c83c4a0333663d1db9c4079130880: Bug 1517577 - DataTransferItemList::Add should use nsVariantCC. r=nika, a=RyanVM
Andrew McCreight <continuation@gmail.com> - Thu, 10 Jan 2019 19:23:43 +0000 - rev 506658
Push 10501 by ryanvm@gmail.com at Sat, 12 Jan 2019 21:41:05 +0000
Bug 1517577 - DataTransferItemList::Add should use nsVariantCC. r=nika, a=RyanVM nsVariant isn't cycle collected, so this can cause a leak. Differential Revision: https://phabricator.services.mozilla.com/D16124
7ddc13a7de8d8d42546f96b5a14379c4ca49dfde: Bug 1514498 - Hide rather than collapse scrollbar thumb when scrollbar is disabled. r=NeilDeakin, a=RyanVM
Xidorn Quan <me@upsuper.org> - Thu, 10 Jan 2019 14:15:30 +0000 - rev 506657
Push 10501 by ryanvm@gmail.com at Sat, 12 Jan 2019 21:41:05 +0000
Bug 1514498 - Hide rather than collapse scrollbar thumb when scrollbar is disabled. r=NeilDeakin, a=RyanVM Collapsing thumb causes frame of scrollbar to cache an incorrect pref size, which makes it not able to appear in certain cases. This patch changes it to use "visibility: hidden" instead so that the thumb is hidden but still contributes to the width of scrollbar. An alternative would be also change the code in nsScrollbarFrame to set something other than collapsed attribute instead, but I'm not sure whether doing that is any better than just adding a rule. We need the rule anyway regardless of what we set on the element. Differential Revision: https://phabricator.services.mozilla.com/D15244
80ab023e1d8eb9f1fbc7d26e3774ef9aebb7dcdb: no bug - Bumping Firefox l10n changesets r=release a=l10n-bump DONTBUILD
L10n Bumper Bot <release+l10nbumper@mozilla.com> - Sat, 12 Jan 2019 13:00:19 -0800 - rev 506656
Push 10500 by ffxbld at Sat, 12 Jan 2019 21:00:25 +0000
no bug - Bumping Firefox l10n changesets r=release a=l10n-bump DONTBUILD da -> aa0c4049abaa
371b3ceabd5ad8568cff2af7255543e2a141d6d2: no bug - Bumping Fennec l10n changesets r=release a=l10n-bump DONTBUILD
L10n Bumper Bot <release+l10nbumper@mozilla.com> - Sat, 12 Jan 2019 13:00:14 -0800 - rev 506655
Push 10500 by ffxbld at Sat, 12 Jan 2019 21:00:25 +0000
no bug - Bumping Fennec l10n changesets r=release a=l10n-bump DONTBUILD da -> aa0c4049abaa
da0b07a8386c07b7b4c54a5c001fbedc64fa79eb: Bug 1515459 - Check if we reenter CreateShimError. r=mayhemer, a=RyanVM
Dragana Damjanovic <dd.mozilla@gmail.com> - Tue, 08 Jan 2019 20:40:35 +0000 - rev 506654
Push 10499 by ryanvm@gmail.com at Sat, 12 Jan 2019 20:11:30 +0000
Bug 1515459 - Check if we reenter CreateShimError. r=mayhemer, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D15297
60be2a80ee0e8c213d16a192780a9f70ac6f5d5a: Bug 1517433 - Do not assert on over-long float printf. r=froydnj, a=RyanVM
Tom Tromey <tom@tromey.com> - Wed, 09 Jan 2019 15:50:27 +0000 - rev 506653
Push 10499 by ryanvm@gmail.com at Sat, 12 Jan 2019 20:11:30 +0000
Bug 1517433 - Do not assert on over-long float printf. r=froydnj, a=RyanVM mozilla::PrintfTarget::cvt_f release asserts that the desired printf fit into a statically-sized buffer. However, this may not be the case if the user requested a larger width or precision. Handle this unusual case by allocating a temporary buffer. MozReview-Commit-ID: 2WicecHDzDR Differential Revision: https://phabricator.services.mozilla.com/D15989
694ef5b65db8c5e3570e6e1a9bee47608b4d3ba9: Bug 1514501 - Fix screen selection and scaling for fullscreen. r=jmathies, a=RyanVM
Adam Gashlin <agashlin@mozilla.com> - Wed, 09 Jan 2019 16:35:40 +0000 - rev 506652
Push 10499 by ryanvm@gmail.com at Sat, 12 Jan 2019 20:11:30 +0000
Bug 1514501 - Fix screen selection and scaling for fullscreen. r=jmathies, a=RyanVM I needed to scale the layout device pixels coming from Windows before passing them to ScreenForRect(). Also, I'm using GetRect() directly instead of GetRectDisplayPix() * scale now, to avoid an unnecessary double scale & round which was making fullscreen windows off by one pixel in many cases. Differential Revision: https://phabricator.services.mozilla.com/D15604
9a0b078546bd21aabdc056dfb6a08e8594565d88: Bug 1509271 - Ensure that `UpdateRootFrameMetrics` is called even if the GeckoView embedding app is not using the `AndroidDynamicToolbarAnimator`. r=kats, a=RyanVM
Emily Toop <etoop@mozilla.com> - Tue, 08 Jan 2019 18:04:16 +0000 - rev 506651
Push 10499 by ryanvm@gmail.com at Sat, 12 Jan 2019 20:11:30 +0000
Bug 1509271 - Ensure that `UpdateRootFrameMetrics` is called even if the GeckoView embedding app is not using the `AndroidDynamicToolbarAnimator`. r=kats, a=RyanVM When selected text in `geckoview_example`, the text selection toolbar was always positioned in the top left corner of the screen, regardless of where in the page the text was selected. The cause of the bug was that UpdateRootFrameMetrics was being called only if the app utilised the `AndroidDynamicToolbar`. This caused the `mViewportZoom` value inside `GeckoSession` to always be 0. When using the `clientToFrameMatrix` function to place the text selection toolbar on screen, the generated matrix was incorrect as the zoom value was 0, causing the resulting frame to be offset by the zoom value. By ensuring that `UpdateRootFrameMetrics` is called inside `AsyncCompositionManager`even when there is no `AndroidDynamicToolbarAnimator` this zoom value is correctly set and the resulting frame for the text selection toolbar is correctly placed. Differential Revision: https://phabricator.services.mozilla.com/D15941
35180dd24536b073adc5fb42946a80c556f6a5d0: Bug 1505720 - Crash [@ java.lang.NullPointerException: at org.mozilla.gecko.fxa.authenticator.AndroidFxAccount.renameAccountIfNecessary(AndroidFxAccount.java)]. r=Grisha, a=RyanVM
Andrei Lazar <andrei.a.lazar@softvision.ro> - Tue, 08 Jan 2019 10:28:20 +0000 - rev 506650
Push 10499 by ryanvm@gmail.com at Sat, 12 Jan 2019 20:11:30 +0000
Bug 1505720 - Crash [@ java.lang.NullPointerException: at org.mozilla.gecko.fxa.authenticator.AndroidFxAccount.renameAccountIfNecessary(AndroidFxAccount.java)]. r=Grisha, a=RyanVM Refreshing account (triggered by signing in) can cause a NullPointerException after quickly signing out. This defect consists in bad sync between the signing in state and signing out state. Differential Revision: https://phabricator.services.mozilla.com/D14269
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 tip