b9198b3db38954c871092f3530af8bd9c7efd759: Bug 1386052: Join PageMetadata table with Top Sites query. r=Grisha
Michael Comella <michael.l.comella@gmail.com> - Tue, 01 Aug 2017 16:02:50 -0700 - rev 422309
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Bug 1386052: Join PageMetadata table with Top Sites query. r=Grisha This bug does not request that this join is used so I tested this by adding a breakpoint in StreamRecyclerAdapter.swapTopSites cursor and querying the cursor for the desired fields directly. I also verified this does not crash when accessing the old top sites and AS top sites. Since I now SELECT a subset of columns (rather than *), I verified I've SELECTed all the used columns: - For AS, we bind in TopSite.fromCursor: https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/activitystream/homepanel/model/TopSite.java#21 - For old top sites, we bind in TopSitesPanel.CursorLoaderCallbacks.onLoadFinished. This fans out to three methods: mListAdapter.swapCursor, mGridAdapter.swapCursor, and updateUiFromCursor, the latter which only gets the count. https://dxr.mozilla.org/mozilla-central/rev/52285ea5e54c73d3ed824544cef2ee3f195f05e6/mobile/android/base/java/org/mozilla/gecko/home/TopSitesPanel.java#692 - mListAdapter = VisitedAdapter, mGridAdapter = TopSitesGridAdapter, via TopSitesPanel.onActivityCreated: https://dxr.mozilla.org/mozilla-central/rev/52285ea5e54c73d3ed824544cef2ee3f195f05e6/mobile/android/base/java/org/mozilla/gecko/home/TopSitesPanel.java#292 - VisitedAdapter.bindView: https://dxr.mozilla.org/mozilla-central/rev/52285ea5e54c73d3ed824544cef2ee3f195f05e6/mobile/android/base/java/org/mozilla/gecko/home/TopSitesPanel.java#549 - TopSitesGridAdapter.bindView: https://dxr.mozilla.org/mozilla-central/rev/52285ea5e54c73d3ed824544cef2ee3f195f05e6/mobile/android/base/java/org/mozilla/gecko/home/TopSitesPanel.java#620 - Both adapters don't use any columns I haven't specified. They also call out to TwoLinePageRow.updateFromCursor: https://dxr.mozilla.org/mozilla-central/rev/52285ea5e54c73d3ed824544cef2ee3f195f05e6/mobile/android/base/java/org/mozilla/gecko/home/TwoLinePageRow.java#318 Which also doesn't use new columns. MozReview-Commit-ID: 9bdeHWLWQbh
13f138fbb0bbed96fa87e25c2d8f90e38373bd34: Bug 1386052: Update testBrowserDatabaseHelperUpgrades from new info. r=Grisha
Michael Comella <michael.l.comella@gmail.com> - Wed, 02 Aug 2017 13:47:57 -0700 - rev 422308
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Bug 1386052: Update testBrowserDatabaseHelperUpgrades from new info. r=Grisha Grisha showed me the link from Android API level to SQLite version and presumably all 3.7.* releases are forwards compatible so we can relax the requirement of which version of Android the test DBs need to be created on: I updated the comment accordingly. MozReview-Commit-ID: Fhu95671kSK
35b56190a1a92454e1ef7e235f1b8cfa7fe3dc84: Bug 1386052: add Combined.HISTORY_GUID; upgrade db to 38. r=Grisha
Michael Comella <michael.l.comella@gmail.com> - Tue, 01 Aug 2017 14:21:54 -0700 - rev 422307
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Bug 1386052: add Combined.HISTORY_GUID; upgrade db to 38. r=Grisha This will be used to join with the PageMetadata table so we can extract PageMetadata values in our top sites queries. MozReview-Commit-ID: EmwjyFM1qUf
91ac0a2b022ceff57b7a1666ab595d387bc9d2ce: Bug 1386052: Correct PageMetadata.HISTORY_GUID foreign key. r=Grisha
Michael Comella <michael.l.comella@gmail.com> - Tue, 01 Aug 2017 14:02:32 -0700 - rev 422306
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Bug 1386052: Correct PageMetadata.HISTORY_GUID foreign key. r=Grisha This change is fixing an issue unrelated to this bug. It was using Visits.HISTORY_GUID, which is not in the table and thus doesn't make sense for the first clause of the foreign key constraint. Visits & its replacement have the same value so the behavior should not change. MozReview-Commit-ID: 8EbJh586DN3
b98350e98fec310b82fe6e86db38275d0eca3de3: Bug 1384341 - Set a minimum size for the animation area so animations that are larger than toolbar buttons don't get clipped. r=mconley
Jared Wein <jwein@mozilla.com> - Wed, 26 Jul 2017 14:20:28 -0400 - rev 422305
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Bug 1384341 - Set a minimum size for the animation area so animations that are larger than toolbar buttons don't get clipped. r=mconley MozReview-Commit-ID: 2n141CGVogi
39dde16cec1d45bb49bfd97344558aaac06d38dd: Bug 1355426 - Fix browser_bug495058.js to not wait for MozAfterPaint in non-remote browser case. r=jaws
Mike Conley <mconley@mozilla.com> - Wed, 02 Aug 2017 14:05:53 -0400 - rev 422304
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Bug 1355426 - Fix browser_bug495058.js to not wait for MozAfterPaint in non-remote browser case. r=jaws I'm not sure why the non-remote browser case needed to wait for MozAfterPaint. In the remote browser case, we do wait for MozAfterPaint in the content area before focusing the URL bar, but in the non-e10s case, we just focus it right away. MozReview-Commit-ID: gNsk8Oh6JO
f418889f0d1900a1f806c0af23528bc03540e6ab: Bug 1355426 - Update browser_hide_removing.js to wait for TabClose instead of TabSelect. r=jaws
Mike Conley <mconley@mozilla.com> - Mon, 31 Jul 2017 18:26:11 -0400 - rev 422303
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Bug 1355426 - Update browser_hide_removing.js to wait for TabClose instead of TabSelect. r=jaws browser_hide_removing.js assumes that when a tab is closed, the next tab to be displayed will fire its TabSelect event _after_ the closed tab has been marked as "closed". Bug 1355426 makes it so that the tab selection occurs earlier, so this test has been updated to use the TabClose event instead. MozReview-Commit-ID: 17rdlNaotq
30d54e94a67e4ec8a29015ad44a5021e8b108c78: Bug 1355426 - Make tabbrowser binding call blurTab earlier when removing tab. r=dao
Mike Conley <mconley@mozilla.com> - Mon, 31 Jul 2017 15:01:39 -0400 - rev 422302
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Bug 1355426 - Make tabbrowser binding call blurTab earlier when removing tab. r=dao MozReview-Commit-ID: JVIAs58p7wW
46a4358a226649b85af3959da393408b4bd7af4d: Bug 1385783 - Insert the elfhack code before the first executable section. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Wed, 02 Aug 2017 16:39:12 +0900 - rev 422301
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Bug 1385783 - Insert the elfhack code before the first executable section. r=froydnj The lld linker creates separate segments for purely executable sections (such as .text) and sections preceding those (such as .rel.dyn). Neither gold nor bfd ld do that, and just put all those sections in the same executable segment. Since elfhack is putting its executable code between the two relocation sections, it ends up in a non-executable segment, leading to a crash when it's time to run that code. We thus insert the elfhack code before the first executable section instead of between the two relocation sections (which is where the elfhack data lies, and stays).
bd0ea10b4001fe17080ba2b70668f4b40fc9f20a: Bug 1385783 - Don't assume both elfhack sections are next to each other. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Wed, 02 Aug 2017 16:05:07 +0900 - rev 422300
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Bug 1385783 - Don't assume both elfhack sections are next to each other. r=froydnj
fa668d22d5f9f0be54458c17cf3d20f16e206e9b: Bug 1386332 - Clarify nightly l10n signing tasks. r=dustin
Justin Wood <Callek@gmail.com> - Tue, 01 Aug 2017 13:03:15 -0400 - rev 422299
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Bug 1386332 - Clarify nightly l10n signing tasks. r=dustin MozReview-Commit-ID: LcdSb5kKUAC
ae12a3c8ed3b48451c348ed89b2231c488660884: Bug 1386332 - Clarify signing tasks. r=dustin
Justin Wood <Callek@gmail.com> - Tue, 01 Aug 2017 13:23:12 -0400 - rev 422298
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Bug 1386332 - Clarify signing tasks. r=dustin MozReview-Commit-ID: 3v0gXy4PXfy
a076d62d11f43f1ae89a943d3a80cc2cc270d959: Bug 1386332 - Clarify repackage tasks. r=dustin
Justin Wood <Callek@gmail.com> - Tue, 01 Aug 2017 12:29:37 -0400 - rev 422297
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Bug 1386332 - Clarify repackage tasks. r=dustin MozReview-Commit-ID: LwWRhqZ7cZb
8ffe0d09a8145dc668bc5798fd5afc6bf16a4d82: Bug 1386332 - Clarify repackage-signing tasks. r=dustin
Justin Wood <Callek@gmail.com> - Tue, 01 Aug 2017 12:13:37 -0400 - rev 422296
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Bug 1386332 - Clarify repackage-signing tasks. r=dustin MozReview-Commit-ID: BAgZWf6ril5
844a3788ac169e8d4100407e67ea941976e65102: Bug 1386332 - Clarify checksums signing naming. r=dustin
Justin Wood <Callek@gmail.com> - Tue, 01 Aug 2017 12:02:15 -0400 - rev 422295
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Bug 1386332 - Clarify checksums signing naming. r=dustin MozReview-Commit-ID: BY0yAjMwXhe
6e01a4b5201658054c547e8ccd48b6deb2108f05: Bug 1386332 - fix beetmover naming. r=dustin
Justin Wood <Callek@gmail.com> - Tue, 01 Aug 2017 11:58:40 -0400 - rev 422294
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Bug 1386332 - fix beetmover naming. r=dustin MozReview-Commit-ID: ATv2fwEKHbv
90a2a894fe44b5c126e2dbc9ceab1a57f3a60c4a: Bug 1386332 - Fix up label and description in nightly task graph entries. r=dustin
Justin Wood <Callek@gmail.com> - Fri, 28 Jul 2017 16:02:18 -0400 - rev 422293
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Bug 1386332 - Fix up label and description in nightly task graph entries. r=dustin MozReview-Commit-ID: GjZ8qeAlQLY
24eaf9aca85c2bf6664ea92d295003f9c0be835b: Bug 1368202 - convert uses of "defer" to "new Promise" in client/inspector r=tromey
Nicolas Ouellet-Payeur <nicolaso@google.com> - Thu, 03 Aug 2017 00:28:05 -0700 - rev 422292
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Bug 1368202 - convert uses of "defer" to "new Promise" in client/inspector r=tromey MozReview-Commit-ID: lXAVyomDlV
8ecab1d291bf2edba0fb2175f5dccf72a9942e42: Bug 1384943 - add initial implementation of SourceMapServiceWrapper; r=bgrins
Tom Tromey <tom@tromey.com> - Mon, 31 Jul 2017 15:57:07 -0600 - rev 422291
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Bug 1384943 - add initial implementation of SourceMapServiceWrapper; r=bgrins This adds a simple wrapper for the source map service. This wrapper logs errors using console.error, preserving the status quo from before this series. MozReview-Commit-ID: 2ckUZaerrcJ
dbe9ba9aafde485e007d29bcb344b55c60b02e69: Bug 1384943 - import bundles from devtools-source-map 0.10.0; r=bgrins
Tom Tromey <tom@tromey.com> - Fri, 28 Jul 2017 10:55:43 -0600 - rev 422290
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Bug 1384943 - import bundles from devtools-source-map 0.10.0; r=bgrins MozReview-Commit-ID: HfnDfd15IPB
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip