b87e63c76691fab43c6a4084a9c8470e9e2a1f3f: Bug 1361041: Avoid posting ReconstructFrame hints to an uninitialized PresShell. r=bz
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 01 May 2017 18:59:50 +0200 - rev 403988
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1361041: Avoid posting ReconstructFrame hints to an uninitialized PresShell. r=bz The call that's causing the crash seems to be [1], that is, we're trying to recreate frames for the root element, which should always have a frame created at the initialization of the PresShell. So the function I removed in that bug had something like the following: if (!mDidInitialize) { // Nothing to do here. In fact, if we proceed and aContent is the // root we will crash. return NS_OK; } Which PostRecreateFramesFor doesn't guard against (because I thought it was not needed, per tryserver results). Sounds a lot like we do need that check, though I'd like to have a testcase where it happens :( [1]: http://searchfox.org/mozilla-central/rev/3dc6ceb42746ab40f1441e1e659ffb8f62ae78e3/layout/base/nsCSSFrameConstructor.cpp#2420 MozReview-Commit-ID: Lh6SohNmmI6
b9ae5e4533dd0e82da1b37bb18fcbfc167c6c9ee: Bug 1304508 - Remove final references to pymake in mozharness; r=ted
Gregory Szorc <gps@mozilla.com> - Wed, 26 Apr 2017 13:41:00 -0700 - rev 403987
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1304508 - Remove final references to pymake in mozharness; r=ted We shouldn't be running pymake any more. So code to work around its behavior is no longer necessary and can be removed. Good riddance. MozReview-Commit-ID: AlV6ZLiA6WB
2fd15ad7081ed792c231819c668b8ca1cdf85949: Bug 1304508 - Remove references to pymake in mozharness configs; r=ted
Gregory Szorc <gps@mozilla.com> - Wed, 26 Apr 2017 13:31:40 -0700 - rev 403986
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1304508 - Remove references to pymake in mozharness configs; r=ted Now that mozharness is calling `mach build` to invoke the "check" target, there are no more consumers of the "enable_pymake" config option. So we remove it from the configs. We also remove definitions of the "make" executable referring to pymake. The only call sites I could find for "query_exe('make')" are in testing/mozharness/scripts/mobile_l10n.py. So most of these definitions of the "make" executable appear to be a cargo cult or left over from a previous rewrite (the code we just changed to stop calling "make" wasn't using query_exe). Since mobile_l10n.py is still using query_exe() to find the make executable, there's a chance switching away from pymake (if this patch even does that - I don't think we touched a config file related to that script) could break something. I'm fine with teasing out that bug. MozReview-Commit-ID: 7HR6ShAKcoV
4e61e69a383ca79a9b84c78eb2eb53e5958333e3: Bug 1304508 - Use mach for running "check" target; r=ted
Gregory Szorc <gps@mozilla.com> - Mon, 24 Apr 2017 18:24:48 -0700 - rev 403985
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1304508 - Use mach for running "check" target; r=ted We switch mozharness to use `mach build` to invoke the "check" make target instead of using `make` itself. Because `mach` is the interface that everyone should use and `make` is an implementation detail. My editor also snuck in a change to normalize a CRLF line ending. MozReview-Commit-ID: 4gdE6oeK0Lz
26433db5f06188d46e0f18f3144758a18bcc8eaa: Bug 1304508 - Support passing --keep-going to make; r=chmanchester,ted
Gregory Szorc <gps@mozilla.com> - Wed, 21 Sep 2016 13:41:34 -0700 - rev 403984
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1304508 - Support passing --keep-going to make; r=chmanchester,ted mozharness is currently making a manual `make -k` invocation. We don't want automation calling `make` directly. So teach `mach build` to accept a --keep-going argument that results in `make -k`. MozReview-Commit-ID: H3lJ4r8S4vj
71c2fb6144b20345351dd6a06505d8ea2cc4c527: Bug 1304508 - Remove makefile mkdir testing; r=ted
Gregory Szorc <gps@mozilla.com> - Wed, 26 Apr 2017 13:27:37 -0700 - rev 403983
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1304508 - Remove makefile mkdir testing; r=ted Several years ago, joey starting writing a handful of unit tests for primitives in our make files. IIRC a lot of the impetus behind this work was to flush out bugs between GNU make and pymake. AFAICT the only survivor of these tests today is check_mkdir.py. The test is a one-off and has been a bit fragile over the years, contributing technical debt along the way. And as part of removing the last references to pymake in automation, it is once again showing itself and failing in a way that has to do with the way the test is written and not an issue with the code it is testing. Enough is enough. This commit removes the test and eliminates the technical debt. I don't think it will be missed. MozReview-Commit-ID: 3OzurtFbcyD
53fe5a8977e37c29eac76364853bf6736b97acc1: Bug 1361078: Remove unnecessary fast path in Element::GetPseudoElementType. r=dbaron
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 01 May 2017 18:12:06 +0200 - rev 403982
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1361078: Remove unnecessary fast path in Element::GetPseudoElementType. r=dbaron A more general fast path was added in bug 1355353. MozReview-Commit-ID: HGe9WaojoYw
3ef61ecb82e252cf707f704e1babaa97e707d77a: Bug 1356457 - Fix and enable test_ext_proxy.html r=jmaher
Matthew Wein <mwein@mozilla.com> - Mon, 01 May 2017 11:25:04 -0400 - rev 403981
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1356457 - Fix and enable test_ext_proxy.html r=jmaher I was able to fix the issue by only letting the background script send one error message per test. This isn't an ideal fix because it doesn't get to the bottom of why a second error message is sometimes sent, but it should be a good placeholder while the underlying issue is researched. MozReview-Commit-ID: 21uZL3r4zVS
22265d6d1424634c7422fc3f9f59255dac85fe28: Bug 1341102: Adjust expectations for servo/servo#16672. r=emilio
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 01 May 2017 18:06:32 +0200 - rev 403980
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1341102: Adjust expectations for servo/servo#16672. r=emilio MozReview-Commit-ID: 62z9JiY9m1N
2c488ee373abc8d227f86905779831d09d88d464: Bug 1334430 - Keep the Synced Tabs panel open when not opening a tab in the current tab. r=markh
Edouard Oger <eoger@fastmail.com> - Sat, 22 Apr 2017 21:24:20 -0400 - rev 403979
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1334430 - Keep the Synced Tabs panel open when not opening a tab in the current tab. r=markh MozReview-Commit-ID: 6KNGjtp1yPN
717ed8f6b2ee4da76509f8909614c042de86ec68: Bug 1360659 - stylo: Support other unit types in computed angle r=emilio
Nazım Can Altınova <canaltinova@gmail.com> - Fri, 28 Apr 2017 18:33:00 +0300 - rev 403978
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1360659 - stylo: Support other unit types in computed angle r=emilio MozReview-Commit-ID: 7pwoXpHAxlz
8baa872d36ba8c72322d611076bfe71339edb0e6: servo: Merge #16674 - Preserve units in computed Angle (from canaltinova:angle-unit); r=emilio
Nazım Can Altınova <canaltinova@gmail.com> - Mon, 01 May 2017 09:45:04 -0500 - rev 403977
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
servo: Merge #16674 - Preserve units in computed Angle (from canaltinova:angle-unit); r=emilio <!-- Please describe your changes on the following line: --> It was converting all angles to radians before. But other browsers preserves the angle units. Fixed that behavior. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #16594 and [Bug 1360659](https://bugzilla.mozilla.org/show_bug.cgi?id=1360659) <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 0abd5bbabd19695a5a42437dc42ab3bdf76f6150
538011159bb16c24c8d3d63f91288dba2daa6510: Bug 1360892 Make Graphite Telemetry Opt-Out r=bsmedberg
Tom Ritter <tom@mozilla.com> - Sun, 30 Apr 2017 01:44:20 -0500 - rev 403976
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1360892 Make Graphite Telemetry Opt-Out r=bsmedberg In Bug 1331915 we added Telemetry for Graphite. However, because our Beta and Opt-In population is very skewed by locale, and we explicitly want to understand locale-specific usage, we want to make this item enabled by default. MozReview-Commit-ID: GrPN0XxrIe7
d83c72d16c77dbb9588e5e5224a13a00d88a607f: Bug 1341102: Update expectations for servo/servo#16673. r=emilio
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 01 May 2017 16:47:39 +0200 - rev 403975
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1341102: Update expectations for servo/servo#16673. r=emilio MozReview-Commit-ID: 3647fXHGel5
68a09a9097cf6a87174814d33228751b8dc04e19: servo: Merge #16672 - Implement -moz-force-broken-image-icon in geckolib (from nox:moz-force-broken-image-icon); r=emilio
Anthony Ramine <n.oxyde@gmail.com> - Mon, 01 May 2017 08:14:34 -0500 - rev 403974
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
servo: Merge #16672 - Implement -moz-force-broken-image-icon in geckolib (from nox:moz-force-broken-image-icon); r=emilio Source-Repo: https://github.com/servo/servo Source-Revision: b7f06d2c20d34bd0ee96d31f070623d6e46b8dda
cd5cb972fd565f2b69e5cef9c9cbdc81286accc5: Bug 1360844 - Test browserContainersGroup according to privacy.userContext.ui.enabled state, r=jaws
Fischer.json <fischer.json@gmail.com> - Fri, 28 Apr 2017 17:31:59 +0800 - rev 403973
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1360844 - Test browserContainersGroup according to privacy.userContext.ui.enabled state, r=jaws The browserContainersGroup is behind privacy.userContext.ui.enabled so have to test it according the pref state. MozReview-Commit-ID: 5GxJJh2Mi6S
84e997772d210f393af56878c84505f48f85d401: servo: Merge #16673 - Fix AlignFlags::to_css (from nox:align); r=emilio
Anthony Ramine <n.oxyde@gmail.com> - Mon, 01 May 2017 07:00:36 -0500 - rev 403972
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
servo: Merge #16673 - Fix AlignFlags::to_css (from nox:align); r=emilio Source-Repo: https://github.com/servo/servo Source-Revision: 9b72d909f989329201d4593972445689f55d59f1
65b4e02611f0afc105f1cfd30e3ec305527edf93: Bug 1356867 - Add scheme column to netmonitor. r=ntim
Vangelis Katsikaros <vkatsikaros@gmail.com> - Mon, 01 May 2017 12:11:46 +0300 - rev 403971
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1356867 - Add scheme column to netmonitor. r=ntim MozReview-Commit-ID: 8ZkD9WRd0VQ
d6c34e2c4bc73c1950094c24308108d7c7269890: Bug 1360776 - Pass AnimationValueMap raw pointer instead of Arc to Gecko_GetAnimationRule(). r=emilio
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Mon, 01 May 2017 18:45:41 +0900 - rev 403970
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1360776 - Pass AnimationValueMap raw pointer instead of Arc to Gecko_GetAnimationRule(). r=emilio MozReview-Commit-ID: 5o8NuJolG2R
d92dd41f970f8e03db00e012c20e8e84e0b56bf1: servo: Merge #16671 - Pass AnimationValueMap raw pointer (from hiikezoe:animation-values-map); r=emilio
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Mon, 01 May 2017 05:51:48 -0500 - rev 403969
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
servo: Merge #16671 - Pass AnimationValueMap raw pointer (from hiikezoe:animation-values-map); r=emilio This is a PR for https://bugzilla.mozilla.org/show_bug.cgi?id=1360776 - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because it's for stylo. Source-Repo: https://github.com/servo/servo Source-Revision: 7088969c2814688cc331d0e1385e352f76a54b5f
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip