b79682d0b9357d73f7dfb6016623ca4b5709d480: Backed out changeset fb911884876f (bug 1366294)
Sebastian Hengst <archaeopteryx@coole-files.de> - Fri, 21 Jul 2017 15:19:56 +0200 - rev 418931
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Backed out changeset fb911884876f (bug 1366294)
1f566354cea1c40981e78db8986e52d31e22c876: Backed out changeset ccf043ec6160 (bug 1366294)
Sebastian Hengst <archaeopteryx@coole-files.de> - Fri, 21 Jul 2017 15:19:51 +0200 - rev 418930
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Backed out changeset ccf043ec6160 (bug 1366294)
dbb8be04d8ce79bc43dae791a46ed81ebcda016c: Backed out changeset 43fb00c0f96d (bug 1366294)
Sebastian Hengst <archaeopteryx@coole-files.de> - Fri, 21 Jul 2017 15:19:46 +0200 - rev 418929
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Backed out changeset 43fb00c0f96d (bug 1366294)
6da4ecf79a4b61cc0e10457b59541ac8fb26a39f: Backed out changeset 0ed44ecf9062 (bug 1366294)
Sebastian Hengst <archaeopteryx@coole-files.de> - Fri, 21 Jul 2017 15:19:41 +0200 - rev 418928
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Backed out changeset 0ed44ecf9062 (bug 1366294)
9f869d8dc3e36c3e8376e9651d3304e95809814f: Backed out changeset 09043ee913d4 (bug 1366294)
Sebastian Hengst <archaeopteryx@coole-files.de> - Fri, 21 Jul 2017 15:19:36 +0200 - rev 418927
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Backed out changeset 09043ee913d4 (bug 1366294)
724d5d0cef066e4716af07ba8f60ac65703c33cc: Backed out changeset 140948f5b955 (bug 1366294)
Sebastian Hengst <archaeopteryx@coole-files.de> - Fri, 21 Jul 2017 15:19:31 +0200 - rev 418926
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Backed out changeset 140948f5b955 (bug 1366294)
e87d51f223d9bf9ff03a6dfcef7e949945c1a098: Backed out changeset fb40775d1451 (bug 1366294)
Sebastian Hengst <archaeopteryx@coole-files.de> - Fri, 21 Jul 2017 15:19:26 +0200 - rev 418925
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Backed out changeset fb40775d1451 (bug 1366294)
2c1ee57abd493421609a89e40aeb44702859ecc1: Backed out changeset e7a3ac603f7c (bug 1366294)
Sebastian Hengst <archaeopteryx@coole-files.de> - Fri, 21 Jul 2017 15:19:21 +0200 - rev 418924
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Backed out changeset e7a3ac603f7c (bug 1366294)
94944363e7402c42e1be4ba0092b3de56df45f1c: Backed out changeset 217ad633fbf7 (bug 1379146) for failing spidermonkey cgc's js/src/jit-test/tests/debug/inspect-wrapped-promise.js on Linux x64 debug. r=backout on a CLOSED TREE
Sebastian Hengst <archaeopteryx@coole-files.de> - Fri, 21 Jul 2017 15:18:58 +0200 - rev 418923
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Backed out changeset 217ad633fbf7 (bug 1379146) for failing spidermonkey cgc's js/src/jit-test/tests/debug/inspect-wrapped-promise.js on Linux x64 debug. r=backout on a CLOSED TREE
e7a3ac603f7c6389c60eb70e6a595b2e24858b7f: bug 1366294 - Part 13 - Fix telemetry-using tests. r=Dexter
Chris H-C <chutten@mozilla.com> - Mon, 17 Jul 2017 11:28:55 -0400 - rev 418922
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
bug 1366294 - Part 13 - Fix telemetry-using tests. r=Dexter Some tests were using "secret" APIs to get at telemetry knowledge from various processes in various ways. Adjust them so that they work with the new ways of doing things. MozReview-Commit-ID: 2iBL00HVGyg
fb40775d14517a387f3520e59515e119c70f2830: bug 1366294 - Part 12 - Clean up after onesself. r=gfritzsche
Chris H-C <chutten@mozilla.com> - Fri, 14 Jul 2017 15:02:54 -0400 - rev 418921
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
bug 1366294 - Part 12 - Clean up after onesself. r=gfritzsche Without the StatisticsRecorder cleaning up after us we need to now manually delete the Histograms we create. MozReview-Commit-ID: 8jrPPBQmU0Z
140948f5b9555f9ff94503e671730e3afaede284: bug 1366294 - Part 11 - Fix OSX Build. r=gfritzsche
Chris H-C <chutten@mozilla.com> - Thu, 06 Jul 2017 17:05:30 -0400 - rev 418920
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
bug 1366294 - Part 11 - Fix OSX Build. r=gfritzsche MozReview-Commit-ID: DSljXr8ZRhy
09043ee913d4d4c3ccee9187834aa33c54905393: bug 1366294 - Part 10 - Nail down count histogram semantics. r=gfritzsche
Chris H-C <chutten@mozilla.com> - Tue, 04 Jul 2017 10:12:23 -0400 - rev 418919
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
bug 1366294 - Part 10 - Nail down count histogram semantics. r=gfritzsche Previously we assumed count histograms were always present in payloads. This was an erroneous assumption as count histograms were only 0 if they were session histograms, or if they were from subsession histograms from subsessions _after_ a subsession when they held a non-0 value. So let's just treat count histograms as normal histograms from now on, without any of this "sometimes 0" nonsense. This simplifies the code, tests, and our understanding... and _should_ have few/zero downstream effects since the existing behaviour was so poorly-understood (though exactly tested). MozReview-Commit-ID: BH108ksygGw
0ed44ecf9062ac9486cd379870e2376f3a8b119a: bug 1366294 - Part 9 - Fix Windows Build. r=gfritzsche
Chris H-C <chutten@mozilla.com> - Wed, 28 Jun 2017 11:00:41 -0700 - rev 418918
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
bug 1366294 - Part 9 - Fix Windows Build. r=gfritzsche MozReview-Commit-ID: 8P2W8fD2xNi
43fb00c0f96d9df2cac763744eed061298763a57: bug 1366294 - Part 8 - Include a message on telemetry testfails. r=gfritzsche
Chris H-C <chutten@mozilla.com> - Fri, 23 Jun 2017 16:39:59 -0400 - rev 418917
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
bug 1366294 - Part 8 - Include a message on telemetry testfails. r=gfritzsche I just added some short identifiable messages to help identify which part of the test failed. MozReview-Commit-ID: 3AX2iucGiRx
ccf043ec6160e90aeded92607d64451445c701fa: bug 1366294 - Part 7 - Use keyed histogram snaphots to build payloads. r=gfritzsche
Chris H-C <chutten@mozilla.com> - Fri, 23 Jun 2017 16:38:21 -0400 - rev 418916
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
bug 1366294 - Part 7 - Use keyed histogram snaphots to build payloads. r=gfritzsche TelemetrySession's getKeyedHistograms asks for each keyed histogram individually. This is inefficient and doesn't work well with the storage refactor. So, plumb through a subsession keyed histogram snapshot API and convert TelemetrySession over to using it. MozReview-Commit-ID: Af9dTqw99UA
fb911884876f97c01889b68c14e6be40af0f6939: bug 1366294 - Part 6 - Update test_TelemetryHistograms for new snapshots format r=gfritzsche
Chris H-C <chutten@mozilla.com> - Fri, 23 Jun 2017 15:15:11 -0400 - rev 418915
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
bug 1366294 - Part 6 - Update test_TelemetryHistograms for new snapshots format r=gfritzsche MozReview-Commit-ID: FN6y1zTqFt4
f80a1985bca7e0574c9ee0f8f3bc0ebd73bfbebd: bug 1366294 - Part 5 - Send appropriately-structured Telemetry data to JS r=gfritzsche
Chris H-C <chutten@mozilla.com> - Tue, 20 Jun 2017 15:03:10 -0400 - rev 418914
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
bug 1366294 - Part 5 - Send appropriately-structured Telemetry data to JS r=gfritzsche Previously we were doing bad string manipulation nonsense. Now when asked for snapshots C++ can return a properly-formated Object tree. MozReview-Commit-ID: HAvIbgzUvMU
8c0cbcd04cc46b6341b09bb7e409d3e0d6bbeb93: bug 1366294 - Part 4 - Small cleanups to previous patches. r=gfritzsche
Chris H-C <chutten@mozilla.com> - Fri, 23 Jun 2017 16:42:21 -0400 - rev 418913
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
bug 1366294 - Part 4 - Small cleanups to previous patches. r=gfritzsche MozReview-Commit-ID: 7PioVNfUUNZ
ed0027bb11873885af83557bcfe1163256d12d76: Bug 1366294 - Part 3 - Refactor TelemetryHistogram storage. r=chutten
Georg Fritzsche <georg.fritzsche@googlemail.com> - Thu, 08 Jun 2017 16:15:38 +0700 - rev 418912
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Bug 1366294 - Part 3 - Refactor TelemetryHistogram storage. r=chutten Previously we used the base::StatisticsRecorder object for storage by name. This is keyed by histogram name, which doesn't match our storage reality anymore. Instead we use a name to refer to a set of histogram instances that record data from different processes, as well as separating session and subsession data. In this re-write, we instead introduce the following lookup paths (managed in TelemetryHistogram.cpp): - Main storage: - (histogramId, processId, sessionOrSubsession) -> Histogram* - (histogramId, processId) -> KeyedHistogram* (this handles subsessions internally) - Lookup: - (histogramName) -> histogramId - (HistogramID) -> bool (is recording enabled for this histogram?) This is wrapped with a few lookup functions. This also allows us to keep HistogramIDs in the JS histogram instances now, instead of pointers to Histogram instances. That means Histogram instance life-time management is now properly contained inside TelemetryHistogram.cpp. MozReview-Commit-ID: 5yijGv7mc89
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip