b684185c1c542c75868adf0b7d16293d3cc6b1c7: Backed out 4 changesets (bug 1055658) for M5 bustage on a CLOSED TREE
Nigel Babu <nigelbabu@gmail.com> - Mon, 12 Jan 2015 10:43:11 +0530 - rev 249016
Push 4489 by raliiev@mozilla.com at Mon, 23 Feb 2015 15:17:55 +0000
Backed out 4 changesets (bug 1055658) for M5 bustage on a CLOSED TREE Backed out changeset 3cbd9323c896 (bug 1055658) Backed out changeset 99e071295c42 (bug 1055658) Backed out changeset 55119d19e4c5 (bug 1055658) Backed out changeset e82f640cb53f (bug 1055658)
e341d9d84469c1e4c93df41799b5edefaab09fbe: Bug 1120159 - Replace nonstandard expression closure with an arrow function in file:// directory listing. r=mcmanus
Chris Peterson <cpeterson@mozilla.com> - Sat, 10 Jan 2015 23:20:22 -0800 - rev 249015
Push 4489 by raliiev@mozilla.com at Mon, 23 Feb 2015 15:17:55 +0000
Bug 1120159 - Replace nonstandard expression closure with an arrow function in file:// directory listing. r=mcmanus
3cbd9323c8963df4f15b83a19e6efa7a74a2c23e: Bug 1055658 part 4 - Revert RubyReflowState. r=dbaron
Xidorn Quan <quanxunzhen@gmail.com> - Mon, 12 Jan 2015 14:31:55 +1100 - rev 249014
Push 4489 by raliiev@mozilla.com at Mon, 23 Feb 2015 15:17:55 +0000
Bug 1055658 part 4 - Revert RubyReflowState. r=dbaron
99e071295c420e0eb237b287be1546975148ba73: Bug 1055658 part 3 - Add reftests for ruby annotation relative positioning. r=dbaron
Xidorn Quan <quanxunzhen@gmail.com> - Mon, 12 Jan 2015 14:31:55 +1100 - rev 249013
Push 4489 by raliiev@mozilla.com at Mon, 23 Feb 2015 15:17:55 +0000
Bug 1055658 part 3 - Add reftests for ruby annotation relative positioning. r=dbaron
55119d19e4c5f127b19b28c930c12a8ab4dc3e5b: Bug 1055658 part 2 - Add relative positioning support for ruby annotations. r=dbaron
Xidorn Quan <quanxunzhen@gmail.com> - Mon, 12 Jan 2015 14:31:55 +1100 - rev 249012
Push 4489 by raliiev@mozilla.com at Mon, 23 Feb 2015 15:17:55 +0000
Bug 1055658 part 2 - Add relative positioning support for ruby annotations. r=dbaron
e82f640cb53fa9765f4fefcacdb6d351fe6cf887: Bug 1055658 part 1 - Move code for applying relative position to an independent method. r=dbaron
Xidorn Quan <quanxunzhen@gmail.com> - Mon, 12 Jan 2015 14:31:55 +1100 - rev 249011
Push 4489 by raliiev@mozilla.com at Mon, 23 Feb 2015 15:17:55 +0000
Bug 1055658 part 1 - Move code for applying relative position to an independent method. r=dbaron
de7cd37e48e8a718eff35ff63dfe1d7dd207ff3c: Bug 1118087 - Correctly sync decode even if an imgFrame is partially decoded. r=tn
Seth Fowler <seth@mozilla.com> - Sun, 11 Jan 2015 19:28:02 -0800 - rev 249010
Push 4489 by raliiev@mozilla.com at Mon, 23 Feb 2015 15:17:55 +0000
Bug 1118087 - Correctly sync decode even if an imgFrame is partially decoded. r=tn
225fd7ea8fc6cb4e1f5e5f0fc21c43facfa4c419: Bug 1119033 - Don't try to evict when we don't have any initialized decoders. r=ajones
Matt Woodrow <mwoodrow@mozilla.com> - Mon, 12 Jan 2015 15:35:35 +1300 - rev 249009
Push 4489 by raliiev@mozilla.com at Mon, 23 Feb 2015 15:17:55 +0000
Bug 1119033 - Don't try to evict when we don't have any initialized decoders. r=ajones
a0954dd9d40ae52531631bba4116f7531175d60d: Bug 1105066 - Seek after switching reader; r=mattwoodrow
Anthony Jones <ajones@mozilla.com> - Mon, 12 Jan 2015 15:10:15 +1300 - rev 249008
Push 4489 by raliiev@mozilla.com at Mon, 23 Feb 2015 15:17:55 +0000
Bug 1105066 - Seek after switching reader; r=mattwoodrow
db991158a2fed494e4d36093a620536470b6b6a7: Bug 1105066 - Chain seeks in MediaSourceReader so that we seek audio to the same time as video; r=kentuckyfriedtakahe
Matt Woodrow <mwoodrow@mozilla.com> - Mon, 12 Jan 2015 11:05:08 +1300 - rev 249007
Push 4489 by raliiev@mozilla.com at Mon, 23 Feb 2015 15:17:55 +0000
Bug 1105066 - Chain seeks in MediaSourceReader so that we seek audio to the same time as video; r=kentuckyfriedtakahe
f433e2cda30722dde9556bc96ab34a15dac6a6b1: Bug 1105066 - Make SeekPromise return the time we actually seeked to; r=kentuckyfriedtakahe
Matt Woodrow <mwoodrow@mozilla.com> - Mon, 12 Jan 2015 10:57:14 +1300 - rev 249006
Push 4489 by raliiev@mozilla.com at Mon, 23 Feb 2015 15:17:55 +0000
Bug 1105066 - Make SeekPromise return the time we actually seeked to; r=kentuckyfriedtakahe
0cbf1255694dbd5fe91a8fed3dfdc4955445336b: Bug 1111463 part 3 - Fix ruby reftests for default styles. r=dbaron
Xidorn Quan <quanxunzhen@gmail.com> - Mon, 12 Jan 2015 12:52:19 +1100 - rev 249005
Push 4489 by raliiev@mozilla.com at Mon, 23 Feb 2015 15:17:55 +0000
Bug 1111463 part 3 - Fix ruby reftests for default styles. r=dbaron
82612d0c8c73cb1b0d3713ca4d18f0f793bddd99: Bug 1111463 part 2 - Add styles in html.css and ua.css. r=dbaron
Xidorn Quan <quanxunzhen@gmail.com> - Mon, 12 Jan 2015 12:52:19 +1100 - rev 249004
Push 4489 by raliiev@mozilla.com at Mon, 23 Feb 2015 15:17:55 +0000
Bug 1111463 part 2 - Add styles in html.css and ua.css. r=dbaron
70e558ca91634f889d6557960f6baad8c9607256: Bug 1111463 part 1 - Invalidate html.css when ruby pref changes. r=dbaron
Xidorn Quan <quanxunzhen@gmail.com> - Mon, 12 Jan 2015 12:52:19 +1100 - rev 249003
Push 4489 by raliiev@mozilla.com at Mon, 23 Feb 2015 15:17:55 +0000
Bug 1111463 part 1 - Invalidate html.css when ruby pref changes. r=dbaron
26f5729d5ccc245abe201fb339b6b16351c148b4: Bug 1120252 - Avoid trying to get the APZCTreeManager if APZ isn't enabled. r=mattwoodrow
Kartikaya Gupta <kgupta@mozilla.com> - Sun, 11 Jan 2015 20:39:36 -0500 - rev 249002
Push 4489 by raliiev@mozilla.com at Mon, 23 Feb 2015 15:17:55 +0000
Bug 1120252 - Avoid trying to get the APZCTreeManager if APZ isn't enabled. r=mattwoodrow
ebb112ced42c29f85fdd5947d25c921c24441ddd: Bug 1119117. Don't clip nsDisplayOpacity items, since some of its descendants maybe should not be clipped with the nsDisplayOpacity clip. r=mattwoodrow
Robert O'Callahan <robert@ocallahan.org> - Sun, 11 Jan 2015 00:12:33 +1300 - rev 249001
Push 4489 by raliiev@mozilla.com at Mon, 23 Feb 2015 15:17:55 +0000
Bug 1119117. Don't clip nsDisplayOpacity items, since some of its descendants maybe should not be clipped with the nsDisplayOpacity clip. r=mattwoodrow
98e34be1fb44344c1173d9d3c981b3e5a2da4762: Revert one of the assertion additions in Bug 1110277 patch 3 since it fires, causing orange. r=orange
L. David Baron <dbaron@dbaron.org> - Sun, 11 Jan 2015 16:58:42 -0800 - rev 249000
Push 4489 by raliiev@mozilla.com at Mon, 23 Feb 2015 15:17:55 +0000
Revert one of the assertion additions in Bug 1110277 patch 3 since it fires, causing orange. r=orange Example stack, from editor/libeditor/tests/browserscope/test_richtext2.html : ###!!! ASSERTION: should only call on first continuation/ib-sibling: 'nsLayoutUtils::IsFirstContinuationOrIBSplitSibling(this)', file /builds/slave/m-in-l64-d-0000000000000000000/build/src/layout/base/../generic/nsIFrame.h, line 875 #01: AdjustAppendParentForAfterContent [layout/base/nsCSSFrameConstructor.cpp:6059] #02: nsCSSFrameConstructor::ContentAppended(nsIContent*, nsIContent*, bool) [layout/base/nsCSSFrameConstructor.cpp:7155] #03: PresShell::ContentAppended(nsIDocument*, nsIContent*, nsIContent*, int) [layout/base/nsPresShell.cpp:4520] #04: nsNodeUtils::ContentAppended(nsIContent*, nsIContent*, int) [dom/base/nsNodeUtils.cpp:132] #05: nsINode::doInsertChildAt(nsIContent*, unsigned int, bool, nsAttrAndChildArray&) [dom/base/nsINode.cpp:1544] #06: nsINode::ReplaceOrInsertBefore(bool, nsINode*, nsINode*, mozilla::ErrorResult&) [dom/base/nsINode.cpp:2209] #07: mozilla::dom::NodeBinding::appendChild [obj-firefox/dom/bindings/NodeBinding.cpp:600]
1bbebe9fec17e88234845d8da22c8b44f394121b: Bug 1110277 patch 3 - Look for the GenConPseudos() property on the first continuation/ib-split so that we can find it when looking for the ::after frame. r=bzbarsky
L. David Baron <dbaron@dbaron.org> - Sun, 11 Jan 2015 15:43:11 -0800 - rev 248999
Push 4489 by raliiev@mozilla.com at Mon, 23 Feb 2015 15:17:55 +0000
Bug 1110277 patch 3 - Look for the GenConPseudos() property on the first continuation/ib-split so that we can find it when looking for the ::after frame. r=bzbarsky The change to GetAfterFrameForContent prevents the reframe that is part of the chain of events leading to this bug, and thus fixes the bug on its own. The change to GetBeforeFrameForContent seems desirable for symmetry. Note that patch 6 also independently fixes the reported bug. This probably needs somewhat careful review. We should examine: (1) what the rules for calling nsLayoutUtils::GetBeforeFrame and nsLayoutUtils::GetAfterFrame are, and whether both (or neither) need to be patched. (2) What the rules are for which frame the GenConProperty() lives on, and whether we should adjust nsIFrame::GetGenConPseudos() to either do something more intelligent, or assert about callers. (We should probably clean up some of these things in a followup bug.) Since the symptom of this bug is (once patch 4 is in the tree) only causing extra reframes, it can only be tested using the new API (from bug 1115691) for observing reframes. I confirmed that the test for this bug fails without the patch and passes with the patch (as noted by the removal of its todo annotation). This patch fixes the assertion on layout/generic/crashtests/600100.xhtml, though I haven't investigated why.
fbbafc2a957318cc4fa2c2dbfd774124ccf597be: Bug 1110277 patch 2 - Add nsLayoutUtils::LastContinuationOrIBSplitSibling(). r=bzbarsky
L. David Baron <dbaron@dbaron.org> - Sun, 11 Jan 2015 15:43:10 -0800 - rev 248998
Push 4489 by raliiev@mozilla.com at Mon, 23 Feb 2015 15:17:55 +0000
Bug 1110277 patch 2 - Add nsLayoutUtils::LastContinuationOrIBSplitSibling(). r=bzbarsky This is used in patch 3.
86088b6c69e8414e6a9845fc7985de6dbbf6f16e: Bug 1110277 patch 1 - Consider the ib-split chain when checking for ::before and ::after in order to reframe when they're missing. r=bzbarsky
L. David Baron <dbaron@dbaron.org> - Sun, 11 Jan 2015 15:43:10 -0800 - rev 248997
Push 4489 by raliiev@mozilla.com at Mon, 23 Feb 2015 15:17:55 +0000
Bug 1110277 patch 1 - Consider the ib-split chain when checking for ::before and ::after in order to reframe when they're missing. r=bzbarsky This patch is not needed to fix the bug, but it seems like it's probably desirable. It's not needed for this bug because MaybeReframeForBeforePseudo and MaybeReframeForAfterPseudo are already called (by ElementRestyler::RestyleChildren) on only the first and last continuation or ib-split sibling with the same style. So this patch should only actually change anything for cases like a block-in-inline split whose initial inline part is inside of a ::first-line (where different parts of the block-in-inline split chain have different style). Since the symptom of this bug is (once patch 6 is in the tree) only causing extra reframes, it can only be tested using the new API (from bug 1115691) for observing reframes. I confirmed that the test for this bug fails without the patch and passes with the patch (as noted by the removal of its todo annotation).
(0) -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip