b63992dfe51dec6006fe1d07b98902a398e20129: Bug 1475033 part 8 - Add some basic tests for scrollbar-width. r=heycam
Xidorn Quan <me@upsuper.org> - Tue, 07 Aug 2018 16:06:28 +1000 - rev 487151
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1475033 part 8 - Add some basic tests for scrollbar-width. r=heycam MozReview-Commit-ID: IZ9j7UIZDqe
dbfd2f2016a4538b96863a16a96ffe43a6e9eceb: Bug 1475033 part 7 - Implement scrollbar-width: thin for Windows. r=jimm
Xidorn Quan <me@upsuper.org> - Mon, 06 Aug 2018 15:18:27 +1000 - rev 487150
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1475033 part 7 - Implement scrollbar-width: thin for Windows. r=jimm Since Windows doesn't provide native thin scrollbar variant, this patch tries to synthesize one by doing the following: * force to use custom scrollbar, and * hide the scrollbar button by giving them zero size, and * cut the thickness of scrollbar by half. Half thickness is picked randomly, but it seems to work fine. A third of the size also looks fine, but maybe a bit harder to drag. Note: Universal Windows Platform apps seem to have an overlay style of scrollbar by default, but I cannot find any Windows API to render that, so that may be a builtin component of UWP. We may want to do that at some point, but this is probably good enough for now. MozReview-Commit-ID: KfHjy8WdweT
1972d9de2b1014ffd032565578d4ca1d5016e846: Bug 1475033 part 6 - Have scrollbar auto colors resolve to the corresponding colors on Windows 10. r=jimm
Xidorn Quan <me@upsuper.org> - Mon, 06 Aug 2018 15:13:17 +1000 - rev 487149
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1475033 part 6 - Have scrollbar auto colors resolve to the corresponding colors on Windows 10. r=jimm So that we can use custom scrollbar for thin scrollbar. MozReview-Commit-ID: FCHzV5MJbx
76149510c0f0a2f7843bacb06239106f1013bd4e: Bug 1475033 part 5 - Remove scrollbarbutton min-{width,height} rule. r=jimm
Xidorn Quan <me@upsuper.org> - Mon, 06 Aug 2018 14:21:40 +1000 - rev 487148
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1475033 part 5 - Remove scrollbarbutton min-{width,height} rule. r=jimm Almost all widgets provide a non-overridable size for scrollbar buttons, so it makes no sense to specify min size for them. It is probably a layout bug that min size properties can override the value returned by GetMinimumWidgetSize even if aIsOverridable is set to false, but removing this rule is simpler than locating and fixing the issue in layout code :) MozReview-Commit-ID: 58pmxQaHlGe
665ba9179f6f06ab22a23c606c3dd141c63c6cea: Bug 1475033 part 4 - Implement scrollbar-width: none. r=mstange
Xidorn Quan <me@upsuper.org> - Mon, 06 Aug 2018 09:23:33 +1000 - rev 487147
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1475033 part 4 - Implement scrollbar-width: none. r=mstange MozReview-Commit-ID: 97AOILxYSw0
ca30b641d0ab0b867f4a9181620075e3221075d9: Bug 1475033 part 3 - Add scrollbar-width property. r=heycam
Xidorn Quan <me@upsuper.org> - Wed, 01 Aug 2018 14:13:41 +1000 - rev 487146
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1475033 part 3 - Add scrollbar-width property. r=heycam MozReview-Commit-ID: CmCbaZosUrU
4e51b28e6b281164afc6b7269aad6b1736f2ddac: Bug 1475033 part 2 - Add a ShowScrollbar enum to be used in ScrollReflowInput. r=mstange
Xidorn Quan <me@upsuper.org> - Fri, 03 Aug 2018 17:44:15 +1000 - rev 487145
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1475033 part 2 - Add a ShowScrollbar enum to be used in ScrollReflowInput. r=mstange Overflow properties have two semantics nowadays: 1. controlling whether the scrollbar should be shown; 2. controlling whether the content is scrollable. However, with the scrollbar-width property being added, scrollability and presence of scrollbar no longer binds together. This change attempts to draw a boundary between value of overflow and presence of scrollbar by making it clear that for ScrollReflowInput, we only care about whether scrollbar should be shown. This should make it easier to reason about further changes involving presence of scrollbar. MozReview-Commit-ID: 2E964z0SkW4
d301e82323de6816535b01ba5d2990e2ac57eb5a: Bug 1475033 part 1 - Rename nsChangeHint_CSSOverflowChange to nsChangeHint_ScrollbarChange. r=heycam
Xidorn Quan <me@upsuper.org> - Fri, 03 Aug 2018 16:42:33 +1000 - rev 487144
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1475033 part 1 - Rename nsChangeHint_CSSOverflowChange to nsChangeHint_ScrollbarChange. r=heycam Prepare for scrollbar-width which should trigger the same kind of change. MozReview-Commit-ID: 1n9Y9bobBkJ
a28cf4300f126a9ae4960035c991d9280c9830d6: Bug 1483144 - Make HTMLEditor::GetSelectionContainer() protected r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 16 Aug 2018 15:12:51 +0000 - rev 487143
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1483144 - Make HTMLEditor::GetSelectionContainer() protected r=m_kato HTMLEditor::GetSelectionContainer() is a public method, but it's not used by outer classes. So, we can make it a protected member. Additionally, this patch cleans up the method. - Renames to GetSelectionContainerElement() for making clearer what will be returned. - Makes it const. - Makes it take Selection reference since most callers already have Selection. - Makes it use RangeBoundary to access start point and end point of range since nsRange::StartOffset() and nsRange::EndOffset() may be slow. - Makes it not use GetSelectedElement() since it requires unnecessary additional cost and the condition to call it means it uses only the first path in GetSelectedElement() which just returns start node of the range. - Makes it output warning when it returns nullptr since it reaches nullptr only when illegal cases, e.g., Selection is in orphan node. Differential Revision: https://phabricator.services.mozilla.com/D3461
fd90e385d65bc4eeb960adaae509458504bbead8: Bug 1483132 - Make EditorBase::AreNodesSameType() non-virtual r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 16 Aug 2018 10:29:20 +0000 - rev 487142
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1483132 - Make EditorBase::AreNodesSameType() non-virtual r=m_kato EditorBase::AreNodesSameType() is overridden only by HTMLEditor and the implementation is enough simple to re-implement in EditorBase. Additionally, this is called from condition of a loop in JoinNodesDeepWithTransaction(). So, the virtual call cost may make damage to the performance. Differential Revision: https://phabricator.services.mozilla.com/D3460
ef882e3e4b6bb67e0bfef77939d1bd1addc68998: Bug 1483127 - Use NS_IMETHODIMP at definition of HTMLEditor::SetIsCSSEnabled() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 16 Aug 2018 10:05:06 +0000 - rev 487141
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1483127 - Use NS_IMETHODIMP at definition of HTMLEditor::SetIsCSSEnabled() r=m_kato HTMLEditor::SetIsCSSEnabled() is an XPCOM but it's defined with nsresult. Differential Revision: https://phabricator.services.mozilla.com/D3459
c7cba947e5046220f9a3678b465df6db769c58f7: Bug 1483119 - Get rid of HTMLEditor::GetURLForStyleSheet() since unused r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 16 Aug 2018 10:03:49 +0000 - rev 487140
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1483119 - Get rid of HTMLEditor::GetURLForStyleSheet() since unused r=m_kato Differential Revision: https://phabricator.services.mozilla.com/D3458
f3e7a7dd30a59ebe893fe37caaeb63e63485127d: Bug 1482023 - Create HTMLEditor::EnableStyleSheetInternal() for internal use r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 16 Aug 2018 10:03:46 +0000 - rev 487139
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1482023 - Create HTMLEditor::EnableStyleSheetInternal() for internal use r=m_kato HTMLEditor::EnableStyleSheet() is an XPCOM method but it's used internally. Therefore, we should create non-virtual method for internal use. Differential Revision: https://phabricator.services.mozilla.com/D3456
4c023e0cd20fde4784d6d974718f659b115ab7de: Bug 1482022 - Create HTMLEditor::RemoveOverrideStyleSheetInternal() for internal use r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 16 Aug 2018 10:01:23 +0000 - rev 487138
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1482022 - Create HTMLEditor::RemoveOverrideStyleSheetInternal() for internal use r=m_kato HTMLEditor::RemoveOverrideStyleSheet() is an XPCOM method but used internally. So, we should create non-virtual method for this. Additionally, it calls GetStyleSheetForURL() and RemoveStyleSheetFromList(), but they search index of internal override style sheet array redundantly. Moreover, RemoveStyleSheetFromList() returns error only when given URL is not found, but RemoveOverrideStyleSheet() which is the only one caller, ignores the error. Therefore, for saving the redundant cost, this patch makes RemoveStyleSheetFromList() return removing StyleSheet which is retrieved with the call of GetStyleSheetForURL(). So, RemoveOverrideStyleSheetInternal() stops calling GetStyleSheetForURL(). Differential Revision: https://phabricator.services.mozilla.com/D3455
fb3e5d2dd1d7c918fab39b3ef32908928eb299ec: Bug 1478576 - A mochitest for system font change notification. r=froydnj,jimm,karlt
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Tue, 07 Aug 2018 11:58:36 +0900 - rev 487137
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1478576 - A mochitest for system font change notification. r=froydnj,jimm,karlt The test case in this patch fails without the proper fix in the first patch in this patch series. In this patch two new nsIDOMWindowUtils APIs are introduced to change the system font settins in tests. Currently the APIs work only on GTK+ platform. Also to work the test case properly we need to open a new XUL window because we don't propagate font changes into descendant documents yet (bug 1478212). MozReview-Commit-ID: 4OLxEkEuF8d
f74ba700aff02f4716ffb9ce1c07efcc9657fa12: Bug 1478576 - Use nsBaseWidget::NotifyThemeChanged for dark/liehgt theme changes on Windows 10. r=mhowell
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Tue, 07 Aug 2018 11:56:22 +0900 - rev 487136
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1478576 - Use nsBaseWidget::NotifyThemeChanged for dark/liehgt theme changes on Windows 10. r=mhowell Now nsBaseWidget::NotifyThemeChanged properly notifies to the pres shell. MozReview-Commit-ID: Kmd68ckHanl
e1392716e580fa5dcce0ceaf27b5d7d89cddd84a: Bug 1478576 - Drop GetXULWindow() check in nsBaseWidget::NotifyPresShell. r=karlt
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Tue, 07 Aug 2018 11:56:18 +0900 - rev 487135
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1478576 - Drop GetXULWindow() check in nsBaseWidget::NotifyPresShell. r=karlt In these days, it's common to not create a child widget, so if there is GetXULWindow() check the notifications are not propagated to the proper pres shell. Even in the case there is a child widget, which means both of the parent and the child widgets notify to the same pres shell, but NotifySizeMoveDone is fairly cheap, and the other two notifications (SysColorChanged and ThemeChanged) are queued and will be processed later together, so it will not be a big deal. MozReview-Commit-ID: 2t23kVZzXgS
2d5b4c59078e5fb0919ffeabb955b9f78c37174c: Bug 1482021 - Create HTMLEditor::AddOverrideStyleSheetInternal() for internal use r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 16 Aug 2018 09:26:09 +0000 - rev 487134
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1482021 - Create HTMLEditor::AddOverrideStyleSheetInternal() for internal use r=m_kato HTMLEditor::AddOverrideStyleSheet() is an XPCOM method but it's called internally. So, we should create non-virtual method for it and call it for internal use. Differential Revision: https://phabricator.services.mozilla.com/D3454
93877b72e6777bd8ea019a3693904cd2b3779f38: Bug 1473392 - Change failure condition for all mochitest tests. r=jmaher
Greg Mierzwinski <gmierz1@live.ca> - Wed, 15 Aug 2018 14:47:38 +0000 - rev 487133
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1473392 - Change failure condition for all mochitest tests. r=jmaher This patch changes the failure condition of all mochitest tests to only take the number of failures (given by self.countfail) into account. With this change, mochitest test chunks will only fail if the failure count is not 0. This fixes a case where the TODO tests were considered as failures when no passing tests were run along side them. Differential Revision: https://phabricator.services.mozilla.com/D3340
9961965127f838781dcb1a28633269078d25fb57: Backed out 1 changesets (bug 1478637) for browser_trackingUI_animation_2.js failures CLOSED TREE
Ciure Andrei <aciure@mozilla.com> - Fri, 17 Aug 2018 02:57:57 +0300 - rev 487132
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Backed out 1 changesets (bug 1478637) for browser_trackingUI_animation_2.js failures CLOSED TREE Backed out changeset 85496f02e642 (bug 1478637)
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip