b5ebdb085efaf31a4f00159334c2d23679e5fa27: Bug 1486732 - Remove useless nsXBLBinding::mIsShadowRootBinding. r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 28 Aug 2018 13:10:11 +0200 - rev 488743
Push 9734 by shindli@mozilla.com at Thu, 30 Aug 2018 12:18:07 +0000
Bug 1486732 - Remove useless nsXBLBinding::mIsShadowRootBinding. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D4434
a47f6d2d38a4d7e46770f43a137d456fa02525ba: Bug 1486536 - Crashtest. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 27 Aug 2018 21:07:59 +0200 - rev 488742
Push 9734 by shindli@mozilla.com at Thu, 30 Aug 2018 12:18:07 +0000
Bug 1486536 - Crashtest. r=heycam Differential Revision: https://phabricator.services.mozilla.com/D4362
15d80c644e1e8e07c5196d58f6707611c8fac4b0: Bug 1486536 - Explicitly flush the StyleSet from FlushPendingNotifications. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 27 Aug 2018 20:44:20 +0200 - rev 488741
Push 9734 by shindli@mozilla.com at Thu, 30 Aug 2018 12:18:07 +0000
Bug 1486536 - Explicitly flush the StyleSet from FlushPendingNotifications. r=heycam When CSS rules change, we usually do this implicitly from FlushUserFontSet & co. However there's a code path that dirties the stylist but not the CSS rules, and that's when the compat mode changes and we're an SVG document. I don't think that can get hit (easily, at least?), but it's pretty easy to do so and I think this is cleaner too. This fixes that case so the stylist can't assert in that case either, and so that we still rebuild the cascade data so that the hash maps use the right keys for a given quirks-mode. Differential Revision: https://phabricator.services.mozilla.com/D4361
15e5faa7e1d9a290118f9c05c1480d1f6f3b9a6b: Bug 1486536 - Make nsPresContext::CompatibilityModeChanged() properly call PresShell::ApplicableStylesChanged. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 27 Aug 2018 20:59:11 +0200 - rev 488740
Push 9734 by shindli@mozilla.com at Thu, 30 Aug 2018 12:18:07 +0000
Bug 1486536 - Make nsPresContext::CompatibilityModeChanged() properly call PresShell::ApplicableStylesChanged. r=heycam We usually rely on this call happening soon enough that it doesn't matter, but from document.write it can matter actually. This is the call that makes this work the same way as other sheet addition / removals. This would fix cases where counter styles / @font-face rules in quirk.css wouldn't get properly updated in some cases. Hopefully we don't have any of those. Differential Revision: https://phabricator.services.mozilla.com/D4360
20a43066e367897769f5c155b1daba955cfaeea7: Bug 1486166 - Set the tooltip text on the parent of the urlbar input. r=dao
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 25 Aug 2018 07:11:27 +0200 - rev 488739
Push 9734 by shindli@mozilla.com at Thu, 30 Aug 2018 12:18:07 +0000
Bug 1486166 - Set the tooltip text on the parent of the urlbar input. r=dao The reason bug 1440682 broke this was because I moved all the code to nsXULElement. However, there was a way for non-XUL elements to get XUL tooltips before that, which was via the RestyleManager mechanism to handle attribute mutations. So the behavior before that patch was that non-XUL elements that got the attribute dynamically added or removed before that patch got their tooltips, like the HTML input in the toolbar, but if you specified the attributes statically in the markup, or while the element was somehow outside of the document or what not, it would never work. Given that, this looks completely unintentional, and the fact that this ever worked was a bit lucky. Chances are we eventually want tooltip support for HTML elements in chrome documents, but it is pretty likely that we want to use the HTML tooltip infrastructure instead of nsXULTooltipListener, which is kind of an odd thing. Thus, for now patch the code so that it sets it on the container of the <input>, which is a XUL box that takes the same space as the <input>, instead of moving all the XUL tooltip support to work on non-XUL elements. Also, while at it, remove references to inputtooltiptext, since I didn't find a single reference in the code that would set this attribute ever. Differential Revision: https://phabricator.services.mozilla.com/D4294
d5203d9dc33b2f829f621c30e99dbfa5a4bed32c: Bug 1425700 - Make the counters non-atomic counters and merge afterwards. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 21 Aug 2018 12:31:11 +0200 - rev 488738
Push 9734 by shindli@mozilla.com at Thu, 30 Aug 2018 12:18:07 +0000
Bug 1425700 - Make the counters non-atomic counters and merge afterwards. r=bholley This was consistently faster in the benchmark (even when counters were disabled, which was slightly suspicious, but...). Anyway, it's not really much code, most of it is FFI copy-pasta. Differential Revision: https://phabricator.services.mozilla.com/D3874
42822c922dcfd2664b3a5d357a6b8d1f792c5d85: Bug 1425700 - Add a parsing benchmarks with use counters. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 20 Aug 2018 23:38:15 +0200 - rev 488737
Push 9734 by shindli@mozilla.com at Thu, 30 Aug 2018 12:18:07 +0000
Bug 1425700 - Add a parsing benchmarks with use counters. r=bholley That way we have a simple baseline to measure overhead. Differential Revision: https://phabricator.services.mozilla.com/D3839
bc3f9356906bd462f3941e2ec6510a145aa65b2d: Bug 1425700 - Add a test for the use counters. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 20 Aug 2018 22:07:19 +0200 - rev 488736
Push 9734 by shindli@mozilla.com at Thu, 30 Aug 2018 12:18:07 +0000
Bug 1425700 - Add a test for the use counters. r=heycam Mostly testing that they work, and that they record what we expect them to record, that is, the actual property that was parsed, and not the properties that it'd resolve or expand to. That may be another tricky part for CSSOM, I think style setters would fail an alias test if implemented with the current setup (we do the property lookup in C++). Differential Revision: https://phabricator.services.mozilla.com/D3829
5449572186472bfc8ed0a48e6b08e6bc4e2424a6: Bug 1425700 - Hook the use counters into StyleSheet parsing. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 20 Aug 2018 19:03:11 +0200 - rev 488735
Push 9734 by shindli@mozilla.com at Thu, 30 Aug 2018 12:18:07 +0000
Bug 1425700 - Hook the use counters into StyleSheet parsing. r=heycam Still not hooked into telemetry, I talked with :janerik and :gfritzsche about that, but test incoming! This intentionally doesn't handle CSSOM and such for now, will file followups for those, though should be trivial. I want to unify / clean up how we do the use counters and the error reporting stuff for CSSOM, since the current function call still shows up in profiles, but that should be a follow-up. Differential Revision: https://phabricator.services.mozilla.com/D3828
8efef28be72c1ab7e433248924b9459beb2e1b33: Bug 1425700 - Add a very simple use counter implementation. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 16 Aug 2018 16:38:56 +0200 - rev 488734
Push 9734 by shindli@mozilla.com at Thu, 30 Aug 2018 12:18:07 +0000
Bug 1425700 - Add a very simple use counter implementation. r=heycam As simple as I could make it, for now. We can improve on this. Differential Revision: https://phabricator.services.mozilla.com/D3827
4c623a756c06017d341d956ce5a8633baf3f7fc8: Bug 1486456 - [wdspec] Add basic tests for "Get Element rect". r=ato
Henrik Skupin <mail@hskupin.info> - Mon, 27 Aug 2018 16:26:11 +0200 - rev 488733
Push 9734 by shindli@mozilla.com at Thu, 30 Aug 2018 12:18:07 +0000
Bug 1486456 - [wdspec] Add basic tests for "Get Element rect". r=ato
514f97264e6c75713ff3828931c5415a69697ca7: Bug 1485485 - make bootstrap accept rustc/cargo in known-good locations; r=chmanchester
Nathan Froyd <froydnj@mozilla.com> - Tue, 28 Aug 2018 09:31:48 -0400 - rev 488732
Push 9734 by shindli@mozilla.com at Thu, 30 Aug 2018 12:18:07 +0000
Bug 1485485 - make bootstrap accept rustc/cargo in known-good locations; r=chmanchester moz.configure looks for rustc/cargo on PATH and in ~/.cargo/bin. Bootstrap only looks on PATH and not in ~/.cargo/bin, though it is smart enough to complain if rustc/cargo can't be found on PATH and you have them in ~/.cargo/bin. Bootstrap should look in both places by default, and be content if it finds them wherever they are, so long as moz.configure can find them.
1642245157667814068b0d39d3b03d74801cca8a: Bug 1485701 - make the interceptor code compilable, if not functional, on aarch64 windows; r=aklotz
Nathan Froyd <froydnj@mozilla.com> - Tue, 28 Aug 2018 09:27:57 -0400 - rev 488731
Push 9734 by shindli@mozilla.com at Thu, 30 Aug 2018 12:18:07 +0000
Bug 1485701 - make the interceptor code compilable, if not functional, on aarch64 windows; r=aklotz
dd857ab01989843d0feae7eb4525b374e6a34439: Bug 1486040 - make WindowsDllBlocklist.h functional for aarch64 windows; r=aklotz
Nathan Froyd <froydnj@mozilla.com> - Tue, 28 Aug 2018 09:27:57 -0400 - rev 488730
Push 9734 by shindli@mozilla.com at Thu, 30 Aug 2018 12:18:07 +0000
Bug 1486040 - make WindowsDllBlocklist.h functional for aarch64 windows; r=aklotz
3568c72a41cc0ffd616ad107dace0c9253d293d7: Bug 1486039 - use a more-portable idiom for pausing in SpinEvent::Wait; r=aklotz
Nathan Froyd <froydnj@mozilla.com> - Tue, 28 Aug 2018 09:27:57 -0400 - rev 488729
Push 9734 by shindli@mozilla.com at Thu, 30 Aug 2018 12:18:07 +0000
Bug 1486039 - use a more-portable idiom for pausing in SpinEvent::Wait; r=aklotz YieldProcessor is apparently defined to do the same thing on x86 as our custom macros, but includes implementations for non-x86 processors.
793be675465bde66c019439cb1ec4dc4c4653607: Bug 1486020 - eliminate warning spam about ICU RTTI with MSVC; r=chmanchester
Nathan Froyd <froydnj@mozilla.com> - Tue, 28 Aug 2018 09:22:39 -0400 - rev 488728
Push 9734 by shindli@mozilla.com at Thu, 30 Aug 2018 12:18:07 +0000
Bug 1486020 - eliminate warning spam about ICU RTTI with MSVC; r=chmanchester
b09a2762f0e5533dab80401953121580134a2c6e: Bug 1485347 - Part 2: Remove CheckScriptDataIntegrity. r=jandem
Ted Campbell <tcampbell@mozilla.com> - Thu, 23 Aug 2018 16:59:21 -0400 - rev 488727
Push 9734 by shindli@mozilla.com at Thu, 30 Aug 2018 12:18:07 +0000
Bug 1485347 - Part 2: Remove CheckScriptDataIntegrity. r=jandem This diagnostic did not provide value and should be removed to allow further cleanup. MozReview-Commit-ID: 49XJM0G7NAP
a6aa090e485ef4e81fc6e090e12ab6d2019f21aa: Bug 1485347 - Part 1: Remove nTypeSets argument from JSScript::partiallyInit. r=jandem
Ted Campbell <tcampbell@mozilla.com> - Wed, 22 Aug 2018 14:28:02 -0400 - rev 488726
Push 9734 by shindli@mozilla.com at Thu, 30 Aug 2018 12:18:07 +0000
Bug 1485347 - Part 1: Remove nTypeSets argument from JSScript::partiallyInit. r=jandem MozReview-Commit-ID: I6xBHG8FLlq
481d502afc69d7d120b2d80a2b881bcea25c2661: Bug 1486528 - Remove some unnecessary nsIMemory imports. r=njn
Marco Castelluccio <mcastelluccio@mozilla.com> - Mon, 27 Aug 2018 16:38:18 +0200 - rev 488725
Push 9734 by shindli@mozilla.com at Thu, 30 Aug 2018 12:18:07 +0000
Bug 1486528 - Remove some unnecessary nsIMemory imports. r=njn
1132c5e406a2a6220f71f54668401a22e6eff3a5: Bug 1486495 - [wdspec] Create basic tests for "Get Element CSS Value" command.
Henrik Skupin <mail@hskupin.info> - Mon, 27 Aug 2018 21:10:28 +0200 - rev 488724
Push 9734 by shindli@mozilla.com at Thu, 30 Aug 2018 12:18:07 +0000
Bug 1486495 - [wdspec] Create basic tests for "Get Element CSS Value" command.
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip