Bug 1418156 - Move the PLDHashTable ops into PrefHashEntry. r=glandium MozReview-Commit-ID: HJfjz2PzW0I

Bug 1418156 - Merge PrefTypeFlags into PrefHashEntry. r=glandium PrefTypeFlags is a class with a lot of smarts (i.e. methods). PrefHashEntry is a class with little smarts. This is silly, because PrefTypeFlags is essentially an internal implementation detail of PrefHashEntry. This patch merges PrefTypeFlags into PrefHashEntry, so that PrefHashEntry has all the smarts. This means lots of `pref->mPrefFlags.Foo()` calls become `pref->Foo()`. The patch also changes the representation of the type and flags within PrefHashEntry to use bitfields, which avoids the need for a Flags type and is much simpler than the old approach. MozReview-Commit-ID: 4Yt9OtBzh9e

Bug 1418156 - Don't zero newly added PrefHashEntrys. r=glandium They are guaranteed to be zeroed already by PLDHashTable. MozReview-Commit-ID: LBeGa9ABYc3

Bug 1418156 - Remove forward declaration of PrefHashEntry. r=glandium MozReview-Commit-ID: 1KRWnjp9VW4

Bug 1416980 - Remove nsIExtendedExpatSink. r=erahm. Because none of the expat users need it.

Merge mozilla-central to mozilla-inbound. r=merge a=merge on a CLOSED TREE

Bug 1418244 - Add missing headers to MSE SourceBufferResource and TrackBuffersManager. r=cpearce

Bug 1418220 - Drop AnimationUtils::IsCoreAPIEnabled(ForCaller) and use nsContentUtils::AnimationsAPICoreEnabled / nsDocument::IsWebAnimationsEnabled instead; r=hiro The difference between nsDocument::IsWebAnimationsEnabled and nsContentUtils::AnimationsAPICoreEnabled is that the former checks the caller type and treats the preference as set for system callers which is particularly needed for enabling things like the getProperties() API for DevTools etc. Generally in API-facing call sites we have a JS context / CallerType and so we want to distinguish between system callers and non-system callers. However, for a few internal uses--specifically filling-in missing keyframes--we don't care about the caller type and always follow the pref setting. That may or not be quite what we want, but this patch doesn't change that except for one call site: KeyframeUtils::GetKeyframesFromObject. This patch changes GetKeyframesFromObject from *not* checking the caller type to checking the caller type. That seems to be the correct behavior here since this is called from KeyframeEffectReadOnly::SetKeyframes(JSContext*, JS::Handle<JSObject*>, ErrorResult&) (i.e. a JS API-facing call site) where we *should* enable the full API when the caller is chrome code. MozReview-Commit-ID: FQJBk3zytwd

Bug 1418872 - Move ControlCharVisibilityDefault() out of nsCSSParser. r=TYLin MozReview-Commit-ID: EkNq7lREGgA

servo: Merge #19282 - Use macro to impl From for font variant (from CYBAI:use-macro-for-font-variant); r=canaltinova As I discussed in #19277, I'd like to change the implementation for `From` of font variant to use macro, `impl_gecko_keyword_conversions`. r? @emilio --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes update `From` impl for font variant to use macro `impl_gecko_keyword_conversions`. - [x] These changes do not require tests Source-Repo: https://github.com/servo/servo Source-Revision: 63bd783c55ab0c0f9abb1a8fa07f20932c77b764

Bug 1418059 - Stop eagerly CSS animations on the root of display:none subtree. r=birtles Otherwise we do update keyframes data unnecessarily. MozReview-Commit-ID: ys4BEF1kxX

Bug 1417376 Part 3 - Pass nsPoint parameters by const references instead of values. r=mats It's good to save some copy constructor calls. MozReview-Commit-ID: 6TveqwkOvc0

Bug 1417376 Part 2 - Pass nsPoint parameters by const references instead of references. r=mats MozReview-Commit-ID: 6TveqwkOvc0

Bug 1417376 Part 1 - Change nsPoint parameter to pass by value for DoAutoScroll(). r=mats This private method DoAutoScroll() modifies aPoint inside of it, and none of other callers (StartAutoScrollTimer() and nsAutoScrollTimer::Notify()) read aPoint afterwards, so we make aPoint pass by value rather than pass by non-const-reference. This is necessary for later parts. MozReview-Commit-ID: 9PtxFXIka7X

servo: Merge #19292 - style: Add comment about -moz-control-character-visibility initial value (from heycam:moz-cc-comment); r=KiChjang Source-Repo: https://github.com/servo/servo Source-Revision: cea3fd62297e5e61fb6676ff53b2988d378d3c86

Bug 1370040 - Use the public API -[NSVisualEffectView setMaskImage:] instead of the private API -[NSWindow _cornerMask]. r=spohl The idea is the following: Behind-window vibrancy is mostly rendered by the window server. For a given vibrant region of a window, the window server renders a vibrancy "backdrop", which is a blurred version of everything that's behind that region, modified with a color tint and blended in some way. Then it puts our actual window contents on top of that background. The backdrop's shape is usually a rectangle. If we don't want it to be a rectangle, we need to tell the window server about the shape that we want it to be. We can't just "draw" a different shape in our own rendering, because our own rendering is merely placed on top of the backdrop - but here we want to modify the shape of the backdrop itself. NSVisualEffectView lets us set a mask image on the view. If this view is the content view of a window, then the view will automatically communicate the mask image to the window server. Traditionally, our popup windows have had a ChildView as their content view. If we now want an NSVisualEffectView to be the content view of the window, then we need to nest the ChildView inside that NSVisualEffectView. But this NSVisualEffectView is only needed when the window is vibrant and the vibrancy backdrop needs to have a certain shape. This is the case for our menus which need to have rounded corners. If the window transitions to being non-vibrant, or not needing a special shape, then we can go back to the way our window's NSView hierarchy has worked traditionally. So we need to reparent NSViews during those transitions. MozReview-Commit-ID: Bo2VzjhhR0A

Bug 1415090. P5 - remove MediaCacheStream::NotifyChannelRecreated(). r=bechen,gerald NotifyDataEnded() runs off the main thread which might set mChannelEnded wrongly after NotifyChannelRecreated reset it on the main thread. We should reset the flags in NotifyDataStarted() which indicate a new load has begun. MozReview-Commit-ID: Gi6PFXwMJqc

Bug 1415090. P4 - don't modify mResourceID off the main thread. r=bechen,gerald There are some works to do when we allow a stream whose download ends abnormally to continue sharing the resource: 1. Abort Read() when download error happens. We might still have a chance to get all the data successfully. However, it doesn't really matter since the stream data is incomplete and we will encounter decode errors sooner or later. 2. Update() needs to check mChannelEnded since an ended stream will not download data needed by other streams. MozReview-Commit-ID: LGCecQ5rpzq

Bug 1415090. P3 - run MediaCacheStream::NotifyDataEnded() off the main thread. r=bechen,gerald Since NotifyDataEnded() run its code asynchronously, it is possible that a new channel is created and NotifyDataStarted() is called before NotifyDataEndedInternal() has a chance to run. We check the load ID to exit the function if necessary. We also need to fix data races when running NotifyDataEndedInternal() off the main thread in next patches. MozReview-Commit-ID: IIAc7dxHike

Bug 1415090. P2 - move the "reopen on error" code from ChannelMediaResource::OnStopRequest() to MediaCacheStream::NotifyDataEnded(). r=bechen,gerald MozReview-Commit-ID: BA1tSk6ZqPS