ae358307197611743d4d46cd3afe3727976b5a6f: Bug 1418456: followup: undo last-minute cleanup that busts the build. r=me
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 20 Nov 2017 13:07:53 +0100 - rev 444443
Push 8527 by Callek@gmail.com at Thu, 11 Jan 2018 21:05:50 +0000
Bug 1418456: followup: undo last-minute cleanup that busts the build. r=me MozReview-Commit-ID: LmIeW4SMz7B
5e9db66be7d409930d71ee9785f869f4dd435ce4: Bug 1418456: Get rid of unstyled children only traversals. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 17 Nov 2017 21:13:48 +0100 - rev 444442
Push 8527 by Callek@gmail.com at Thu, 11 Jan 2018 21:05:50 +0000
Bug 1418456: Get rid of unstyled children only traversals. r=heycam They're useless now, provided we remove the hack to not traverse XBL-bound elements on initial styling. This also allows us to get rid of the fallback case. MozReview-Commit-ID: AvBVdyF1wb6
24dea2c09495e8da41e962206c469ee68503999f: Bug 1418456: Remove the last call to StyleNewlyBoundElement. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 17 Nov 2017 21:12:49 +0100 - rev 444441
Push 8527 by Callek@gmail.com at Thu, 11 Jan 2018 21:05:50 +0000
Bug 1418456: Remove the last call to StyleNewlyBoundElement. r=heycam If the element has no data, it's pointless to reconstruct frames on it, or post a reconstruct. There's no need to particularly force to have data in this case. MozReview-Commit-ID: Lo24XQfLN0j
391937d9f0d7c9dfecec618747eef04ed379901f: Bug 1418456: Clear subtree element data when applying an XBL binding. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 17 Nov 2017 20:52:29 +0100 - rev 444440
Push 8527 by Callek@gmail.com at Thu, 11 Jan 2018 21:05:50 +0000
Bug 1418456: Clear subtree element data when applying an XBL binding. r=heycam We not only need to care about children getting inserted in the flat tree, but also about children moving _out_ of the flat tree. In particular, as of right now we may leave stale data on elements when they disappear from the flattened tree. We're lucky enough that in 99% of the situations we enter in[1] and that clears all the stuff, including servo data. But my assertions for bug 1414999 caught the template / observes case. Thus, just clear the whole bound element subtree data, and restyle it in the end, no need for StyleNewChildren. This matches what we do for shadow DOM (though in the shadow DOM case we do it async in DestroyFramesForAndRestyle). [1]: https://searchfox.org/mozilla-central/rev/9bab9dc5a9472e3c163ab279847d2249322c206e/dom/xbl/nsXBLBinding.cpp#368 MozReview-Commit-ID: 69A0aR0AFfU
b51a8a602b78cd321a88ff770714b3be15b2d650: servo: Merge #19296 - style: Get rid of unstyled children only traversals (from emilio:bye-unstyled-only); r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 20 Nov 2017 04:18:30 -0600 - rev 444439
Push 8527 by Callek@gmail.com at Thu, 11 Jan 2018 21:05:50 +0000
servo: Merge #19296 - style: Get rid of unstyled children only traversals (from emilio:bye-unstyled-only); r=heycam They're useless now, provided we remove the hack to not traverse XBL-bound elements on initial styling. Bug: 1418456 Reviewed-by: heycam MozReview-Commit-ID: AvBVdyF1wb6 Source-Repo: https://github.com/servo/servo Source-Revision: e4cfff8364cebd0ae2236cc8c39ba93072b35148
01225b5242f5f32134e086f19dbe8923e7a96a9f: Bug 1412394 - Remove window listeners explicitly during shutdown. r=jib
Andreas Pehrson <pehrsons@mozilla.com> - Mon, 06 Nov 2017 15:27:36 +0100 - rev 444438
Push 8527 by Callek@gmail.com at Thu, 11 Jan 2018 21:05:50 +0000
Bug 1412394 - Remove window listeners explicitly during shutdown. r=jib Currently we run the risk of missing MediaManager::OnNavigation() at shutdown in some cases. When it happens, cleanup of window listeners is delayed to MediaManager::Shutdown(). Triggering window listener shutdown through the destructor doesn't work when the destructor is invoked by WindowTable::Clear(), as clearing out the window listener's SourceListeners will trigger a call back into WindowTable::Remove() to remove the now empty window listener. This is not allowed by the hash table implementation. This patch fixes this by changing strategy from cleanup-in-dtor to explicit-cleanup-before-dtor and making a non-clean state in the dtor an error. MozReview-Commit-ID: C9FryVlv28d
f8acbd315ca8c5f8d5a04e2870ad7214499c71eb: Bug 1412394 - Delay blocking MediaManager::PostTask until media thread shutdown. r=jib
Andreas Pehrson <pehrsons@mozilla.com> - Thu, 02 Nov 2017 16:27:33 +0100 - rev 444437
Push 8527 by Callek@gmail.com at Thu, 11 Jan 2018 21:05:50 +0000
Bug 1412394 - Delay blocking MediaManager::PostTask until media thread shutdown. r=jib This delays setting sInShutdown (renamed to sHasShutdown for better semantics) until all that remains of shutdown is to shut down the media thread. From JS this is no change as JS cannot run until Shutdown() is done. The difference is that we let members and still-active listeners get destroyed and cause any members that are media-thread only (in this case devices), to shut down before the thread goes away. MozReview-Commit-ID: 5NTWwh8Umn8
482f8d5746bafe0a83a614ae2688e8f4b5e30b8e: Bug 1412394 - Re-enable the crashing test. r=jib
Andreas Pehrson <pehrsons@mozilla.com> - Thu, 02 Nov 2017 16:22:38 +0100 - rev 444436
Push 8527 by Callek@gmail.com at Thu, 11 Jan 2018 21:05:50 +0000
Bug 1412394 - Re-enable the crashing test. r=jib MozReview-Commit-ID: I9GXN0rYV5a
8794becbd0cbab8a7222f34d66b8167a77fa6743: Backed out 3 changesets (bug 1406253)for build bustage in dom/base/nsCopySupport.cpp r=backout on a CLOSED TREE
Noemi Erli <nerli@mozilla.com> - Mon, 20 Nov 2017 13:34:29 +0200 - rev 444435
Push 8527 by Callek@gmail.com at Thu, 11 Jan 2018 21:05:50 +0000
Backed out 3 changesets (bug 1406253)for build bustage in dom/base/nsCopySupport.cpp r=backout on a CLOSED TREE Backed out changeset 284f3cc2880c (bug 1406253) Backed out changeset aecb3d509a39 (bug 1406253) Backed out changeset 9ce01198e8a1 (bug 1406253)
f345598ccaf977902d23b84b7dced9710e88929f: Bug 1339731 - Refactor some duplicated codes and remove the unused method. r=lchang,ralin
Sean Lee <selee@mozilla.com> - Mon, 20 Nov 2017 09:19:51 +0800 - rev 444434
Push 8527 by Callek@gmail.com at Thu, 11 Jan 2018 21:05:50 +0000
Bug 1339731 - Refactor some duplicated codes and remove the unused method. r=lchang,ralin MozReview-Commit-ID: 5BHR2sJBASl
d494b07e2d36f105dc358fbf81bd2ad50704c08a: Bug 1339731 - Refactor FormAutofillHandler to support multiple section machanism. r=lchang,ralin
Sean Lee <selee@mozilla.com> - Mon, 20 Nov 2017 08:21:30 +0800 - rev 444433
Push 8527 by Callek@gmail.com at Thu, 11 Jan 2018 21:05:50 +0000
Bug 1339731 - Refactor FormAutofillHandler to support multiple section machanism. r=lchang,ralin MozReview-Commit-ID: D9g5fKTeTaL
284f3cc2880c32f0646bcfad14f513dc9b8e4a07: Bug 1406253 - Part 3: use currentRequstFinalURI in context menu and add a test case. r=dao
Samael Wang <freesamael@gmail.com> - Tue, 14 Nov 2017 19:19:27 +0800 - rev 444432
Push 8527 by Callek@gmail.com at Thu, 11 Jan 2018 21:05:50 +0000
Bug 1406253 - Part 3: use currentRequstFinalURI in context menu and add a test case. r=dao If the image request gets redirect on loading, HTMLImageElement.currentURI (which corresponds to nsIImageLoadingContent.currentURI) would return the original URI before redirect, making "Save Image" in the context menu use incorrect URI and filename. Use currentRequestFinalURI instead to get redirected URI. MozReview-Commit-ID: Bd7Q36sH93b
aecb3d509a39cf61df2a934494bece60e552d13b: Bug 1406253 - Part 2: Implement nsIImageLoadingContent.currentRequestFinalURI. r=bz
Samael Wang <freesamael@gmail.com> - Tue, 14 Nov 2017 18:20:03 +0800 - rev 444431
Push 8527 by Callek@gmail.com at Thu, 11 Jan 2018 21:05:50 +0000
Bug 1406253 - Part 2: Implement nsIImageLoadingContent.currentRequestFinalURI. r=bz ImageLoadingContent.currentURI returns the "URI" of currentRequest, which is the URI used to start that request. Some consumers need to know the final URI of that request instead. If the image request gets redirected on loading (e.g. an add-on intercepts the request), currentRequestFinalURI will be the redirected URI, while currentURI would be the original URI before redirect. MozReview-Commit-ID: 9lX063uAIp1
9ce01198e8a128e4c53a4adbfd643dbb857ad38b: Bug 1406253 - Part 1: Rename imgIRequest.currentURI to finalURI to prevent confusion. r=bz
Samael Wang <freesamael@gmail.com> - Mon, 13 Nov 2017 16:31:24 +0800 - rev 444430
Push 8527 by Callek@gmail.com at Thu, 11 Jan 2018 21:05:50 +0000
Bug 1406253 - Part 1: Rename imgIRequest.currentURI to finalURI to prevent confusion. r=bz The "current URL" in the spec: https://html.spec.whatwg.org/multipage/embedded-content.html#dom-img-currentsrc maps to imgIRequest.URI, not currentURI. Rename imgIRequest.currentURI to finalURI to prevent such confusion. MozReview-Commit-ID: CjBh2V4z8K9
48d015dec45aea204878154bbb00f99965b78b71: Bug 1392947 - Add more credit card expiration date matching patterns to enhance prediction. r=lchang,seanlee
Ray Lin <ralin@mozilla.com> - Wed, 15 Nov 2017 17:33:01 +0800 - rev 444429
Push 8527 by Callek@gmail.com at Thu, 11 Jan 2018 21:05:50 +0000
Bug 1392947 - Add more credit card expiration date matching patterns to enhance prediction. r=lchang,seanlee MozReview-Commit-ID: 3WyU6wSC8wD
43c41cec8feefc2305268d549b839b9ad6247937: servo: Merge #19294 - style: Collect more debugging info when collecting rules of detached pseudos (from emilio:debug-detached-pseudo); r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 20 Nov 2017 02:29:59 -0600 - rev 444428
Push 8527 by Callek@gmail.com at Thu, 11 Jan 2018 21:05:50 +0000
servo: Merge #19294 - style: Collect more debugging info when collecting rules of detached pseudos (from emilio:debug-detached-pseudo); r=heycam Called Option::unwrap() on a None value is not a helpful crash message. This will hopefully help figure out what is causing bug 1418856. Source-Repo: https://github.com/servo/servo Source-Revision: af6c2f93b9ff91f4c3e5758d9b27173e49928bed
224bb68f1fc934d9030f5b9c93407679083201c5: Bug 1413162 - Set width to manageAddresses and manageCreditCards dialogs and move button styles to common stylesheets. r=flod,jaws,lchang
Scott Wu <scottcwwu@gmail.com> - Mon, 13 Nov 2017 18:36:35 +0800 - rev 444427
Push 8527 by Callek@gmail.com at Thu, 11 Jan 2018 21:05:50 +0000
Bug 1413162 - Set width to manageAddresses and manageCreditCards dialogs and move button styles to common stylesheets. r=flod,jaws,lchang Increased the dialog width and align html button styles with XUL button styles (padding, min-width) in common stylesheets. MozReview-Commit-ID: Czzu0Ar6JfP
589acfe789d8cf8ee113baa86af29018ffb6b43c: Bug 1418885 - [Form Autofill] Ensure all computed fields are removed after normalizing and strip trailing newlines in "street-address". r=steveck
Luke Chang <lchang@mozilla.com> - Mon, 20 Nov 2017 13:59:21 +0800 - rev 444426
Push 8527 by Callek@gmail.com at Thu, 11 Jan 2018 21:05:50 +0000
Bug 1418885 - [Form Autofill] Ensure all computed fields are removed after normalizing and strip trailing newlines in "street-address". r=steveck MozReview-Commit-ID: Llhi9AZ3T8H
619507d38af9544df797105241bf7008b8a8ed55: Merge mozilla-central to mozilla-autoland. r=merge a=merge CLOSED TREE
Margareta Eliza Balazs <ebalazs@mozilla.com> - Mon, 20 Nov 2017 11:47:28 +0200 - rev 444425
Push 8527 by Callek@gmail.com at Thu, 11 Jan 2018 21:05:50 +0000
Merge mozilla-central to mozilla-autoland. r=merge a=merge CLOSED TREE
ae73805527947837137ac0ce89a011fb6ae178a8: Bug 1405008 - Make WebIDE warn when connecting to old runtimes. r=jdescottes
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 02 Oct 2017 22:40:32 +0200 - rev 444424
Push 8527 by Callek@gmail.com at Thu, 11 Jan 2018 21:05:50 +0000
Bug 1405008 - Make WebIDE warn when connecting to old runtimes. r=jdescottes MozReview-Commit-ID: KQc2b1ohksA
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip