ad61044a4ba8ce0077c8ad6a415a0555fd8fac7c: Bug 1417327 part 3: Accessible handler: Fix cache for IAccessible::accDefaultAction and use it for IAccessibleAction::name(0). r=MarcoZ a=gchang
James Teh <jteh@mozilla.com> - Thu, 16 Nov 2017 16:51:28 +1000 - rev 442520
Push 8239 by archaeopteryx@coole-files.de at Mon, 27 Nov 2017 10:55:23 +0000
Bug 1417327 part 3: Accessible handler: Fix cache for IAccessible::accDefaultAction and use it for IAccessibleAction::name(0). r=MarcoZ a=gchang 1. Bug 1363595 added support for retrieving accDefaultAction from the cache, but the value was never cached in the first place. This would have meant that accDefaultAction was returning nothing to clients. 2. Since accDefaultAction is the name of the first action, we can also use this cached value for IAccessibleAction::name for index 0. MozReview-Commit-ID: 6PGRH45kKdB
5b467b5636efa46906af107b824ecfb4787cc971: Bug 1417327 part 2: Accessible handler: Cache IAccessibleTableCell row/column indexes/extents. r=MarcoZ a=gchang
James Teh <jteh@mozilla.com> - Thu, 16 Nov 2017 11:47:28 +1000 - rev 442519
Push 8239 by archaeopteryx@coole-files.de at Mon, 27 Nov 2017 10:55:23 +0000
Bug 1417327 part 2: Accessible handler: Cache IAccessibleTableCell row/column indexes/extents. r=MarcoZ a=gchang MozReview-Commit-ID: 8hMzyJZ5zFI
403ec09d449e557972cf017f4f094e76e7009c95: Bug 1417327 part 1: Accessible handler: Cache IAccessibleAction::nActions. r=MarcoZ a=gchang
James Teh <jteh@mozilla.com> - Wed, 15 Nov 2017 17:27:05 +1000 - rev 442518
Push 8239 by archaeopteryx@coole-files.de at Mon, 27 Nov 2017 10:55:23 +0000
Bug 1417327 part 1: Accessible handler: Cache IAccessibleAction::nActions. r=MarcoZ a=gchang MozReview-Commit-ID: EJIhSxSiQGq
7ebf334c8ed4fd51c3dc738a2274ed7485f7e5fc: Bug 1416986 part 4: AccessibleHandler: Don't fall through to the proxy for IAccessibleHyperlink. r=aklotz a=gchang
James Teh <jteh@mozilla.com> - Wed, 15 Nov 2017 12:32:52 +1000 - rev 442517
Push 8239 by archaeopteryx@coole-files.de at Mon, 27 Nov 2017 10:55:23 +0000
Bug 1416986 part 4: AccessibleHandler: Don't fall through to the proxy for IAccessibleHyperlink. r=aklotz a=gchang The handler's implementation of IAHyperlink just forwards calls through to the proxy. However, it exists because we want the cache to be used when a hyperlink is retrieved. When querying from the handler to IAHyperlink, we should use the same implementation. This is mostly about consistency/correctness, especially as we're increasing complexity. MozReview-Commit-ID: AwYibrFzUyf
30014722ca5303b725978d66fb651273a0cbc85c: Bug 1416986 part 3: AccessibleHandler: Avoid cross-process QI calls for interfaces which we know don't exist. r=aklotz a=gchang
James Teh <jteh@mozilla.com> - Wed, 15 Nov 2017 12:28:45 +1000 - rev 442516
Push 8239 by archaeopteryx@coole-files.de at Mon, 27 Nov 2017 10:55:23 +0000
Bug 1416986 part 3: AccessibleHandler: Avoid cross-process QI calls for interfaces which we know don't exist. r=aklotz a=gchang The proxy manager caches interfaces marshaled in the payload and returns them on QI without a cross-process call. However, it doesn't know about interfaces which don't exist. We can determine this from the payload, since interfaces which don't exist will have a null pointer. We use this information to avoid querying the proxy in this case. MozReview-Commit-ID: FnzDetmTiPP
9d771f65f35d6bcfcd7a412aff6f60061482cbe9: Bug 1416986 part 2: Include interfaces the client is likely to request in the accessible handler payload. r=aklotz a=gchang
James Teh <jteh@mozilla.com> - Wed, 15 Nov 2017 12:18:18 +1000 - rev 442515
Push 8239 by archaeopteryx@coole-files.de at Mon, 27 Nov 2017 10:55:23 +0000
Bug 1416986 part 2: Include interfaces the client is likely to request in the accessible handler payload. r=aklotz a=gchang Now that virtual buffers have to render across processes, we want to eliminate as many cross-process calls as possible. This includes QueryInterface calls, since buffers query for several interfaces on every node they visit. To avoid these cross-process QI calls, we include interfaces clients are likely to request in the handler payload. This way, they get marshaled in the single call used to retrieve the object. This patch does the following: 1. Passes the interceptor when building the payload. We need this so we can get interceptors for other interfaces. 2. Splits the payload into two main parts: a static part and a dynamic part. The (new) static part contains the interface pointers. The dynamic part contains the rest. This is necessary because the refresh call cannot pass the interceptor, but the interceptor is needed to build the static part. Also, re-building the static part is pointless when refreshing. 3. Includes the interface pointers in the payload (BuildStaticIA2Data). The pointers also have to be cleaned up after marshaling. 4. Releases the interface pointers in the handler after the payload is received. We do this because they're aggregated by the proxy manager as they're unmarshaled. MozReview-Commit-ID: 6VRLMNScgwW
ee921fb100b395920f8a5cdcb0c92f070d56aa33: Bug 1416986 part 1: Allow an mscom Handler to signal that it knows an interface is definitely not available. r=aklotz a=gchang
James Teh <jteh@mozilla.com> - Wed, 15 Nov 2017 09:59:44 +1000 - rev 442514
Push 8239 by archaeopteryx@coole-files.de at Mon, 27 Nov 2017 10:55:23 +0000
Bug 1416986 part 1: Allow an mscom Handler to signal that it knows an interface is definitely not available. r=aklotz a=gchang If QueryHandlerInterface returns E_NOINTERFACE, the proxy will be queried for the interface. However, the handler might know that the interface is definitely not available and could thus avoid a pointless cross-process call. To facilitate this, the handler can now return S_FALSE to signal that the proxy should not be queried, thus immediately returning E_NOINTERFACE to the client. MozReview-Commit-ID: 4RtBsA9BTOV
24ed530c9a036f8a706743b8f93f2b7f493256be: Backed out changeset 023371c245a7 (bug 1226616) for not working as intended a=backout
Ciure Andrei <aciure@mozilla.com> - Mon, 27 Nov 2017 12:27:12 +0200 - rev 442513
Push 8238 by aciure@mozilla.com at Mon, 27 Nov 2017 10:33:36 +0000
Backed out changeset 023371c245a7 (bug 1226616) for not working as intended a=backout
780900bb90913f473e7722568dc62fa22e82d3aa: Bug 1413287: Ensure that interceptors do not marshal a handler payload unless they are the outermost marshal request; r=Jamie a=gchang
Aaron Klotz <aklotz@mozilla.com> - Tue, 31 Oct 2017 14:37:00 -0600 - rev 442512
Push 8238 by aciure@mozilla.com at Mon, 27 Nov 2017 10:33:36 +0000
Bug 1413287: Ensure that interceptors do not marshal a handler payload unless they are the outermost marshal request; r=Jamie a=gchang MozReview-Commit-ID: 2rDreOpdwvy
99df250531e1b7aaa6d1cffa825a8beacb084e41: Bug 1409677 - Adjust kCommonAliasedLineWidthRangeMax to 1 in WebGL resistFingerprint mode; r=cfu,jgilbert a=gchang
Daosheng Mu <daoshengmu@gmail.com> - Mon, 20 Nov 2017 17:19:22 +0800 - rev 442511
Push 8238 by aciure@mozilla.com at Mon, 27 Nov 2017 10:33:36 +0000
Bug 1409677 - Adjust kCommonAliasedLineWidthRangeMax to 1 in WebGL resistFingerprint mode; r=cfu,jgilbert a=gchang MozReview-Commit-ID: 4gusUhU9VMI
a66f23b1940632778b6447d967469bb97c2e72ab: Bug 1409133 - Avoid shrinking tabs through ::before elements when moving them. r=dao a=gchang
Johann Hofmann <jhofmann@mozilla.com> - Tue, 14 Nov 2017 13:09:38 +0100 - rev 442510
Push 8238 by aciure@mozilla.com at Mon, 27 Nov 2017 10:33:36 +0000
Bug 1409133 - Avoid shrinking tabs through ::before elements when moving them. r=dao a=gchang As mentioned in the comment: Note that this doesn't perfectly solve the issue (dragged tabs may still resize very slightly) on some DPI settings with uneven scaling factors on Windows, because of bug 477157. We consider the fix in this patch good enough for now. MozReview-Commit-ID: BbpxLVq8AEb
14022278b66d392fdf203cf4bc08fee82b47d286: Bug 1404176 - Remove aborted print preview browser before bailing out. r=mconley a=gchang
Matheus Longaray <mlongaray@hp.com> - Mon, 13 Nov 2017 17:17:57 +0100 - rev 442509
Push 8238 by aciure@mozilla.com at Mon, 27 Nov 2017 10:33:36 +0000
Bug 1404176 - Remove aborted print preview browser before bailing out. r=mconley a=gchang This patch clears out set of print preview browsers before bailing out when there is an error while putting the document into print preview mode. MozReview-Commit-ID: 20cm4DCktQk
725b718e10c8374b5be64c41635581cf41866e6e: Bug 1397173 - Apply dark overlay style when only error occurs in mobile video controls. r=jolin a=gchang
Ray Lin <ralin@mozilla.com> - Wed, 22 Nov 2017 14:11:54 +0800 - rev 442508
Push 8238 by aciure@mozilla.com at Mon, 27 Nov 2017 10:33:36 +0000
Bug 1397173 - Apply dark overlay style when only error occurs in mobile video controls. r=jolin a=gchang MozReview-Commit-ID: CsVK90kmLlT
9724cc63f11a67d6ab9f7f4c4849d5e857e2ce97: no bug - Bumping Firefox l10n changesets DONTBUILD r=release a=l10n-bump
L10n Bumper Bot <release+l10nbumper@mozilla.com> - Mon, 27 Nov 2017 02:20:45 -0800 - rev 442507
Push 8237 by ffxbld at Mon, 27 Nov 2017 10:20:56 +0000
no bug - Bumping Firefox l10n changesets DONTBUILD r=release a=l10n-bump bg -> 8a0741e5f9af bs -> 391af61ce268 cy -> 1cef80e3bf70 ff -> d7a1cea11477 fi -> 0166d6eecd9c fy-NL -> cc9179a45527 ga-IE -> bf66310c0312 gd -> 2d65db07c66f hr -> e2faec5ff2ce hsb -> 23a4be0d5638 hu -> c81ee93d7622 id -> 8a1606dcec35 is -> 2ea9cc247311 ka -> 6d8d17f605a5 kab -> 1afba505394f kk -> 406e6625d590 km -> e43a5c2374fb ko -> 30692c673f5d lij -> 0bdad2cf2883 lt -> bce902b53bc6 my -> 697db1e6863d te -> a89702dd75e4
168cc6fc9f82604937187b106e830f80d4e7f736: no bug - Bumping Fennec l10n changesets DONTBUILD r=release a=l10n-bump
L10n Bumper Bot <release+l10nbumper@mozilla.com> - Mon, 27 Nov 2017 02:20:39 -0800 - rev 442506
Push 8237 by ffxbld at Mon, 27 Nov 2017 10:20:56 +0000
no bug - Bumping Fennec l10n changesets DONTBUILD r=release a=l10n-bump bs -> 391af61ce268 cy -> 1cef80e3bf70 fi -> 0166d6eecd9c fy-NL -> cc9179a45527 ga-IE -> bf66310c0312 hu -> c81ee93d7622 id -> 8a1606dcec35 is -> 2ea9cc247311 ka -> fd916f0f5398 kk -> 406e6625d590 lo -> 8b7d4d19a75b lt -> bce902b53bc6 ltg -> f214b0c64207 oc -> ced9142c1c2e sl -> 06f6c7c99de2 trs -> 42a17c31b288
47c97637717fc01e6abcf769bb00ce3cc7a16276: Bug 1397049 - Fix debugger 'this' in functions with let. r=jorendorff a=gchang
Ted Campbell <tcampbell@mozilla.com> - Thu, 16 Nov 2017 00:39:36 -0500 - rev 442505
Push 8236 by apavel@mozilla.com at Mon, 27 Nov 2017 10:06:01 +0000
Bug 1397049 - Fix debugger 'this' in functions with let. r=jorendorff a=gchang When the debugger evaluates code in the debuggee frame, the parser may fail to detect we are in a function context and will compute 'this' incorrectly as a result. This patch fixes the environment chain traversal around DebugEnvironmentProxy to more accurately determine the binding type of 'this' within a function. MozReview-Commit-ID: GzRDOJLK8fx
33e95d96edd254f38dcd29bae7f9974ebfeea703: Bug 1396833 - Fix tab drag&drop not finishing due to CSS transform not kicking in r=mconley a=gchang
Tim Taubert <ttaubert@mozilla.com> - Wed, 22 Nov 2017 08:15:09 +0100 - rev 442504
Push 8236 by apavel@mozilla.com at Mon, 27 Nov 2017 10:06:01 +0000
Bug 1396833 - Fix tab drag&drop not finishing due to CSS transform not kicking in r=mconley a=gchang Summary: In very rare situations, the right number of tabs and the right drop position will lead to the drop event handler trying to start a translateX() transform and then wait for the transitionend event that will never fire. If the old and the new translateX values are too close together (e.g. 1259.1000061035156 and 1259.0999450683594) then the layout engine won't actually start a transform. A simple solution is to round translateX values before comparing them and deciding whether to initiate a transition. Reviewers: mconley Reviewed By: mconley Bug #: 1396833 Differential Revision: https://phabricator.services.mozilla.com/D265
35e083bb82efff62d48a0ca947816ab44d38eb81: Bug 1389836 - Don't recreate mHandlerInfo for every little change. r=bz a=gchang
Blake Kaplan <mrbkap@gmail.com> - Tue, 14 Nov 2017 15:37:47 -0800 - rev 442503
Push 8236 by apavel@mozilla.com at Mon, 27 Nov 2017 10:06:01 +0000
Bug 1389836 - Don't recreate mHandlerInfo for every little change. r=bz a=gchang There are non-cost reference return values on IPDL structs. We should take advantage of them in order not to recopy everything everytime something changes. MozReview-Commit-ID: D4hG2moE3f
f459b78ab427b120ceb6320565dfe77b77247414: Bug 1389836 - Push extensions from MIME info objects to the child. r=bz a=gchang
Blake Kaplan <mrbkap@gmail.com> - Wed, 01 Nov 2017 17:49:22 -0700 - rev 442502
Push 8236 by apavel@mozilla.com at Mon, 27 Nov 2017 10:06:01 +0000
Bug 1389836 - Push extensions from MIME info objects to the child. r=bz a=gchang It would be really nice to push all of this back up to the parent or to at least make it asynchronous. I think it should be possible since we control when we send the DOM events, but for the moment this should work. With this patch, I extend ProxyMIMEInfo and HandlerInfo with information about the available extensions for a given MIME type. On Linux, at least, we read the system (in my case GNOME) registry in the child and handlers.json in the parent finally merging them again in the child (in ContentHandlerService::FillHandlerInfo). Even though I was unable to get my mochitest to work, it did work well enough that I could verify that this patch was getting all of the proper extensions to the nsContentAreaDragDrop.cpp code. MozReview-Commit-ID: AR3VayMUiDN
67fcff4eba056e11c052240794788c4fca2595c2: Bug 1389836 - Put HandlerServiceChild in the proper namespace. r=bz a=gchang
Blake Kaplan <mrbkap@gmail.com> - Wed, 25 Oct 2017 14:58:50 -0700 - rev 442501
Push 8236 by apavel@mozilla.com at Mon, 27 Nov 2017 10:06:01 +0000
Bug 1389836 - Put HandlerServiceChild in the proper namespace. r=bz a=gchang Non ns-prefixed classes are supposed to be in either the mozilla namespace or a sub namespace (such as dom, css, or others). MozReview-Commit-ID: 8bF6bP49NLG
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip