ac6a27516edb47b4505aeb7d9b28a6607a3ca1b2: Bug 1190172 part 3 - Remove old method variants; r=ehsan
Aryeh Gregor <ayg@aryeh.name> - Sat, 23 Apr 2016 19:25:54 +0900 - rev 332522
Push 6048 by kmoir@mozilla.com at Mon, 06 Jun 2016 19:02:08 +0000
Bug 1190172 part 3 - Remove old method variants; r=ehsan
643bf6006fea9dd538675a8b3e3c0617e84f3d29: Bug 1190172 part 2 - Clean up nsHTMLEditor::ClearStyle; r=ehsan
Aryeh Gregor <ayg@aryeh.name> - Sat, 23 Apr 2016 19:25:29 +0900 - rev 332521
Push 6048 by kmoir@mozilla.com at Mon, 06 Jun 2016 19:02:08 +0000
Bug 1190172 part 2 - Clean up nsHTMLEditor::ClearStyle; r=ehsan
7207f05dd558cd5cde2d354a51f7d04cc800decf: Bug 1190172 part 1 - Clean up nsHTMLEditor::SplitStyleAbovePoint; r=ehsan
Aryeh Gregor <ayg@aryeh.name> - Sat, 23 Apr 2016 19:25:04 +0900 - rev 332520
Push 6048 by kmoir@mozilla.com at Mon, 06 Jun 2016 19:02:08 +0000
Bug 1190172 part 1 - Clean up nsHTMLEditor::SplitStyleAbovePoint; r=ehsan
bf13f411417bbb226757530162162215c5f964bc: Bug 1156062 part 12 - Clean up nsHTMLEditRules::GetAlignment; r=masayuki
Aryeh Gregor <ayg@aryeh.name> - Sat, 23 Apr 2016 19:24:13 +0900 - rev 332519
Push 6048 by kmoir@mozilla.com at Mon, 06 Jun 2016 19:02:08 +0000
Bug 1156062 part 12 - Clean up nsHTMLEditRules::GetAlignment; r=masayuki
e9577aa83ab06d2182cd88325a435ebd930e2ba1: Bug 1156062 part 11 - Clean up nsHTMLEditRules::Before/AfterEdit; r=masayuki
Aryeh Gregor <ayg@aryeh.name> - Sat, 23 Apr 2016 19:23:50 +0900 - rev 332518
Push 6048 by kmoir@mozilla.com at Mon, 06 Jun 2016 19:02:08 +0000
Bug 1156062 part 11 - Clean up nsHTMLEditRules::Before/AfterEdit; r=masayuki
a530f2e280a48ff03ffb45c0bb0eb5fedb26b2a0: Bug 1156062 part 10 - Clean up MarginPropertyAtomForIndent; r=masayuki
Aryeh Gregor <ayg@aryeh.name> - Sat, 23 Apr 2016 19:23:20 +0900 - rev 332517
Push 6048 by kmoir@mozilla.com at Mon, 06 Jun 2016 19:02:08 +0000
Bug 1156062 part 10 - Clean up MarginPropertyAtomForIndent; r=masayuki
1e142031ab51ed18a6526766707151fdc9e8ed71: Bug 1156062 part 9 - Clean up nsHTMLEditRules::WillAlign
Aryeh Gregor <ayg@aryeh.name> - Sat, 23 Apr 2016 19:22:48 +0900 - rev 332516
Push 6048 by kmoir@mozilla.com at Mon, 06 Jun 2016 19:02:08 +0000
Bug 1156062 part 9 - Clean up nsHTMLEditRules::WillAlign
9e0cca233833e1cd574e7d73dcfa9d341c8b5e83: Bug 1156062 part 8 - Clean up nsHTMLEditRules::JoinBlocks; r=ehsan
Aryeh Gregor <ayg@aryeh.name> - Sat, 23 Apr 2016 19:20:20 +0900 - rev 332515
Push 6048 by kmoir@mozilla.com at Mon, 06 Jun 2016 19:02:08 +0000
Bug 1156062 part 8 - Clean up nsHTMLEditRules::JoinBlocks; r=ehsan
beab3af262e39c6e77eba2c032794a89c4d95493: Bug 1257759 part.10 PluginInstanceChild should consume WM_*CHAR messages which follow consumed WM_*KEYDOWN or WM_*KEYUP message r=jimm
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 22 Apr 2016 14:22:03 +0900 - rev 332514
Push 6048 by kmoir@mozilla.com at Mon, 06 Jun 2016 19:02:08 +0000
Bug 1257759 part.10 PluginInstanceChild should consume WM_*CHAR messages which follow consumed WM_*KEYDOWN or WM_*KEYUP message r=jimm nsWindow for Windows cannot decide if a preceding WM_*KEYDOWN or WM_*KEYUP which is a preceding message of WM_*CHAR is consumed because nsWindow cannot know if WM_*CHAR message came from same window which received the preceding WM_*KEYDOWN or WM_*KEYUP. Therefore, PluginInstanceChild should do that. MozReview-Commit-ID: 1uuZ0nTJ5Xb
1bf2088320755b225f40a7b90ba0381460550421: Bug 1257759 part.9 Implement nsWindow::OnKeyEventInPluginProcess() on Windows r=jimm
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 15 Apr 2016 17:02:36 +0900 - rev 332513
Push 6048 by kmoir@mozilla.com at Mon, 06 Jun 2016 19:02:08 +0000
Bug 1257759 part.9 Implement nsWindow::OnKeyEventInPluginProcess() on Windows r=jimm Implementing nsWindow::OnWindowedPluginKeyEvent() on Windows. This patch makes NativeKey class dispatches eKeyDownOnPlugin and eKeyUpOnPlugin when the method is called. MozReview-Commit-ID: L8yRZvDaQKR
52cc5374ec1b31933061d385a01bf6b27dec7648: Bug 1257759 part.8 nsXBLWindowKeyHandler should handle eKeyDownOnPlugin and eKeyUpOnPlugin events only with reserved shortcut key handlers r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Sat, 23 Apr 2016 02:12:54 +0900 - rev 332512
Push 6048 by kmoir@mozilla.com at Mon, 06 Jun 2016 19:02:08 +0000
Bug 1257759 part.8 nsXBLWindowKeyHandler should handle eKeyDownOnPlugin and eKeyUpOnPlugin events only with reserved shortcut key handlers r=smaug eKeyDownOnPlugin (mozkeydownonplugin) and eKeyUpOnPlugin (mozkeyuponplugin) should execute if the key combination is reserved by the linked <command> element. Note that there is no eKeyPressOnPlugin. Therefore, eKeyDownOnPlugin may execute shortcut key handler which is registered as a keypress event handler. MozReview-Commit-ID: CpjsFW02y26
502b6b849493d82d320ff091a440ab144c79ac62: Bug 1257759 part.7 Add new internal events which represent key events on plugin r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Sat, 23 Apr 2016 01:22:49 +0900 - rev 332511
Push 6048 by kmoir@mozilla.com at Mon, 06 Jun 2016 19:02:08 +0000
Bug 1257759 part.7 Add new internal events which represent key events on plugin r=smaug If a plugin process posts native key events to the widget, it needs to check if the key combination is reserved by chrome because if it's reserved by chrome, the reserved shortcut key handler should be executed and the event shouldn't be handled by the focused plugin. This patches add eKeyDownOnPlugin and eKeyUpOnPlugin. nsXBLWindowKeyHandler will listen to them and handle them as normal keydown and keypress or keyup event. Note that these events won't be fired on content in the default event group and won't be sent to the remote process. MozReview-Commit-ID: H5OKPLtVdr6
2b6daf0220a4d81cdb4825f7261b5627c80c8f00: Bug 1257759 part.6 Keep event order between keyboard events and IME events in a plugin process r=jimm
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 14 Apr 2016 17:28:49 +0900 - rev 332510
Push 6048 by kmoir@mozilla.com at Mon, 06 Jun 2016 19:02:08 +0000
Bug 1257759 part.6 Keep event order between keyboard events and IME events in a plugin process r=jimm On Windows, applications cannot handle IME messages asynchronously. Therefore, we cannot put off to send IME messages to plugin even if there are some pending keyboard events which were posted to the parent process. This patch makes PluginInstanceChild consume all key events which are returned from the parent process during IME composition. And when an IME composition is committed, mark pending key events as outdated. MozReview-Commit-ID: 7P3LEJ6pDir
1952b7fec843cbb6e1b402c7a0e2a42ba9ba335f: Bug 1257759 part.5 PluginInstanceChild should post received native key event to chrome process if the key combination may be a shortcut key r=jimm
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 19 Apr 2016 20:09:37 +0900 - rev 332509
Push 6048 by kmoir@mozilla.com at Mon, 06 Jun 2016 19:02:08 +0000
Bug 1257759 part.5 PluginInstanceChild should post received native key event to chrome process if the key combination may be a shortcut key r=jimm When PluginInstanceChild receives native key events, it should post the events to the chrome process first for checking if the key combination is reserved. However, posting all key events to the chrome process may make damage to the performance of text input. Therefore, this patch starts to post a key event whose key combination may be a shortcut key. However, for avoiding to shuffle the event order, it posts following key events until all posted key events are handled by the chrome process. For receiving response from widget, this patch defines nsIKeyEventInPluginCallback. It's specified by nsIWidget::OnWindowedPluginKeyEvent() for ensuring the caller will receive the reply. Basically, the caller of nsIWidget::OnWindowedPluginKeyEvent() should reply to the child process. However, if the widget is a PuppetWidget, it cannot return the result synchronously. Therefore, PuppetWidget::OnWindowedPluginKeyEvent() returns NS_SUCCESS_EVENT_HANDLED_ASYNCHRONOUSLY and stores the callback to mKeyEventInPluginCallbacks. Then, TabParent::HandledWindowedPluginKeyEvent() will call PuppetWidget::HandledWindowedPluginKeyEvent(). MozReview-Commit-ID: G6brOU26NwQ
6d2f821d43475cc6c1f75844fae3b8f8a7308b11: Bug 1257759 part.4 Rename WidgetGUIEvent::PluginEvent to NativeEventData for using this class to send native event from plugin process to content and/or chrome process r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 05 Apr 2016 14:23:13 +0900 - rev 332508
Push 6048 by kmoir@mozilla.com at Mon, 06 Jun 2016 19:02:08 +0000
Bug 1257759 part.4 Rename WidgetGUIEvent::PluginEvent to NativeEventData for using this class to send native event from plugin process to content and/or chrome process r=smaug PluginInstanceChild needs to send native key event to the chrome process via a content process. So, IPC needs a platform independent class/struct which can store native event. This purpose is exactly same as the purpose of WidgetGUIEvent::PluginEvent. Therefore, we can use it for this case too. This patch renames WidgetGUIEvent::PluginEvent to NativeEventData but this patch does NOT remove WidgetGUIEvent::PluginEvent. Instead of that, it's defined as an alias of NativeEventData since PluginEvent is clearer name for the original purpose and it's used by plugin module. MozReview-Commit-ID: 3nrHfb8gk8m
8ced614c9a1ff986eb1be374b75f96d545c5a8a1: Bug 1257759 part.3 ModifierKeyState should be available in plugin module r=jimm
Masayuki Nakano <masayuki@d-toybox.com> - Sat, 09 Apr 2016 15:45:06 +0900 - rev 332507
Push 6048 by kmoir@mozilla.com at Mon, 06 Jun 2016 19:02:08 +0000
Bug 1257759 part.3 ModifierKeyState should be available in plugin module r=jimm Before posting native key message from PluginInstanceChild, we need to check if the key combination could be a shortcut key, i.e., we need to check if Ctrl or Alt key is pressed. ModifierKeyState is a good class for checking it but it should be defined in an independent header file. This patch separates the definition of ModifierKeyState to mozilla/widget/WinModifierKeyState.h and implement MaybeMatchShortcutKey() for PluginInstanceChild. MozReview-Commit-ID: ZjLnJx02Ou
b7a49478bfcb151d3adfa3b37e92abff29ac3d94: Bug 1257759 part.2 Separate Windows' message and related definitions from nsWindowDefs.h to mozilla/widget/WinMessages.h r=jimm
Masayuki Nakano <masayuki@d-toybox.com> - Sat, 09 Apr 2016 15:15:31 +0900 - rev 332506
Push 6048 by kmoir@mozilla.com at Mon, 06 Jun 2016 19:02:08 +0000
Bug 1257759 part.2 Separate Windows' message and related definitions from nsWindowDefs.h to mozilla/widget/WinMessages.h r=jimm This patch separates Windows' message definition and related definitions from nsWindowDefs.h to mozilla/widget/WinMessages.h because the definitions are useful in plugin module but nsWindowDefs.h cannot be included from plugin module since it depends on some headers in under widget. MozReview-Commit-ID: KNUAffLMKT1
f9ca78699bae28da5a8ec8c0d13f556350f441b3: Bug 1257759 part.1 Use switch-case at the first message handling in PluginInstanceChild::PluginWindowProcInternal() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 18 Mar 2016 16:39:42 +0900 - rev 332505
Push 6048 by kmoir@mozilla.com at Mon, 06 Jun 2016 19:02:08 +0000
Bug 1257759 part.1 Use switch-case at the first message handling in PluginInstanceChild::PluginWindowProcInternal() r=m_kato PluginInstanceChild::PluginWindowProcInternal() should use switch-case statement at checking each message because adding new message handler may make damage to the performance and switch-case statement is easier to read for Windows message handler. MozReview-Commit-ID: KfL0LtHL6GV
02a332642272c61550235152f0e7ff89a139faac: Bug 1156062 part 7 - Clean up nsHTMLEditRules::StandardBreakImpl; r=ehsan
Aryeh Gregor <ayg@aryeh.name> - Sat, 23 Apr 2016 18:32:13 +0900 - rev 332504
Push 6048 by kmoir@mozilla.com at Mon, 06 Jun 2016 19:02:08 +0000
Bug 1156062 part 7 - Clean up nsHTMLEditRules::StandardBreakImpl; r=ehsan
e6a6d2316a3b9972fb2cb77f82837bdd95283cc7: Bug 1156062 part 6 - Clean up nsHTMLEditRules::WillInsertBreak; r=ehsan
Aryeh Gregor <ayg@aryeh.name> - Sat, 23 Apr 2016 18:32:04 +0900 - rev 332503
Push 6048 by kmoir@mozilla.com at Mon, 06 Jun 2016 19:02:08 +0000
Bug 1156062 part 6 - Clean up nsHTMLEditRules::WillInsertBreak; r=ehsan
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip