abc1d64c569b3ea3ffa0a00b441fea94884fa60f: No bug - Tagging da9f01df3bef6c8e34104875b4c5453b59e63155 with FIREFOX_68_0b13_BUILD1 a=release CLOSED TREE DONTBUILD
Mozilla Releng Treescript <release+treescript@mozilla.org> - Mon, 24 Jun 2019 17:22:11 +0000 - rev 534007
Push 11492 by ffxbld at Mon, 24 Jun 2019 17:22:20 +0000
No bug - Tagging da9f01df3bef6c8e34104875b4c5453b59e63155 with FIREFOX_68_0b13_BUILD1 a=release CLOSED TREE DONTBUILD
5a248051d252bf6152f8b32834294c4fa5cff491: No bug - Tagging da9f01df3bef6c8e34104875b4c5453b59e63155 with DEVEDITION_68_0b13_BUILD1 a=release CLOSED TREE DONTBUILD
Mozilla Releng Treescript <release+treescript@mozilla.org> - Mon, 24 Jun 2019 17:15:42 +0000 - rev 534006
Push 11491 by ffxbld at Mon, 24 Jun 2019 17:15:52 +0000
No bug - Tagging da9f01df3bef6c8e34104875b4c5453b59e63155 with DEVEDITION_68_0b13_BUILD1 a=release CLOSED TREE DONTBUILD
dead08d3f55c81b333abee35ff42e5856904aebe: No bug - Manually bump the Fennec Beta version number. a=release FENNEC_68_0b13_BUILD1 FENNEC_68_0b13_RELEASE
Julien Cristau <jcristau@mozilla.com> - Mon, 24 Jun 2019 19:04:17 +0200 - rev 534005
Push 11490 by jcristau@mozilla.com at Mon, 24 Jun 2019 17:04:55 +0000
No bug - Manually bump the Fennec Beta version number. a=release
da9f01df3bef6c8e34104875b4c5453b59e63155: Bug 1555627 - Set a learn more link on net error pages. r=prathiksha a=ritu DEVEDITION_68_0b13_BUILD1 DEVEDITION_68_0b13_RELEASE FIREFOX_68_0b13_BUILD1 FIREFOX_68_0b13_RELEASE
Johann Hofmann <jhofmann@mozilla.com> - Thu, 20 Jun 2019 23:26:43 +0000 - rev 534004
Push 11489 by malexandru@mozilla.com at Mon, 24 Jun 2019 13:35:34 +0000
Bug 1555627 - Set a learn more link on net error pages. r=prathiksha a=ritu Bug 1284835 removed the hard-coded learn more link on cert and net error pages, which worked for cert error pages because they explicitly set their own learn more links, but net error pages were relying on the default href to be set. This wasn't revealed until bug 1530348 made about:neterror part of the new error pages. The solution is simply to explicitly set the correct learn more link to net error pages. Note that in the case of PR_END_OF_FILE errors, we were not previously showing a "learn more" link. That was not intentional, as far as I can tell, but was caused by the bug fixed in bug 1477875. Differential Revision: https://phabricator.services.mozilla.com/D35163
c369003558cb91db6e7828c4e0c74ff32da47ff1: Bug 1559317 - ensure outline is not visible when tbody gets focus on :active. r=mtigley a=ritu
Yura Zenevich <yura.zenevich@gmail.com> - Thu, 20 Jun 2019 20:43:58 +0000 - rev 534003
Push 11489 by malexandru@mozilla.com at Mon, 24 Jun 2019 13:35:34 +0000
Bug 1559317 - ensure outline is not visible when tbody gets focus on :active. r=mtigley a=ritu Depends on D35065 Differential Revision: https://phabricator.services.mozilla.com/D35066
902d1b155d7bdbaeb3b08e3a2a06721aeb18d4c3: Bug 1559316 - ensure badge background does not turn white when tbody gets focus on :active. r=mtigley a=ritu
Yura Zenevich <yura.zenevich@gmail.com> - Thu, 20 Jun 2019 20:43:35 +0000 - rev 534002
Push 11489 by malexandru@mozilla.com at Mon, 24 Jun 2019 13:35:34 +0000
Bug 1559316 - ensure badge background does not turn white when tbody gets focus on :active. r=mtigley a=ritu Differential Revision: https://phabricator.services.mozilla.com/D35065
edc925e0821a1066f0b354a486cfffe34b40e4f2: Bug 1559094 - Restore old behavior for background-size: cover + zero-sized background positioning area. r=dholbert a=ritu
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 23 Jun 2019 10:08:16 +0000 - rev 534001
Push 11489 by malexandru@mozilla.com at Mon, 24 Jun 2019 13:35:34 +0000
Bug 1559094 - Restore old behavior for background-size: cover + zero-sized background positioning area. r=dholbert a=ritu This restores our previous and per-spec behavior. Comparing only ratios was not correct in the case one of the dimensions was zero and thus not scaled. Differential Revision: https://phabricator.services.mozilla.com/D35571
8fb74fcbc12c83a230f700196e83193e6749d740: Bug 1557056 - Use extended function only for self-hosted function that needs to store canonical name in extended slot. r=jandem a=ritu
Tooru Fujisawa <arai_a@mac.com> - Wed, 19 Jun 2019 20:00:24 +0000 - rev 534000
Push 11489 by malexandru@mozilla.com at Mon, 24 Jun 2019 13:35:34 +0000
Bug 1557056 - Use extended function only for self-hosted function that needs to store canonical name in extended slot. r=jandem a=ritu Differential Revision: https://phabricator.services.mozilla.com/D34983
60e8af0747b4ae12b440b3e406ffedd4ccc71d5f: Bug 1559264 - Quantumbar: Don't call setValueFromResult when opening the history popup. r=dao a=ritu
Drew Willcoxon <adw@mozilla.com> - Fri, 21 Jun 2019 18:37:27 +0000 - rev 533999
Push 11489 by malexandru@mozilla.com at Mon, 24 Jun 2019 13:35:34 +0000
Bug 1559264 - Quantumbar: Don't call setValueFromResult when opening the history popup. r=dao a=ritu The problem is that on switching back to the first tab (see the bug), userTypedValue is non-null when URLBarSetURI is called. Therefore the proxy state can't be valid. Something about bug 1529931 caused userTypedValue to go from null to non-null in this case. Details below, but the summary is that we shouldn't be calling UrlbarInput.setValueFromResult when opening the history popup, because setValueFromResult sets userTypedValue. Before bug 1529931, result.autofill would always be undefined for the first result in the history popup, because we didn't allow UnifiedComplete to return an autofill result for the search triggered by the history popup. After that bug, UnifiedComplete could return an autofill result in that case -- and it likely would since the first result in the history popup has a very high frecency, which also makes it eligible for autofill. The problem with having an autofill result in the history popup is that it triggers the input.setValueFromResult() call in UrlbarController.receiveResults [1], and setValueFromResult sets userTypedValue. So when the user opens the history popup, userTypedValue gets set to a non-null value (input._lastSearchString). The fix is to not allow autofill for the history popup. After making that fix on revision https://hg.mozilla.org/mozilla-central/rev/5e2a3b886e64, the bug went away. However, after I made that fix on a fresh tree, the bug still happened. It turns out that input.setValueFromResult still ends up getting called, by UrlbarView._selectItem [2], which is called when results are received [3]. The fix for this afaict is just to pass `updateInput: false` to _selectItem. The autofill-related fix doesn't seem to be necessary at all anymore (likely due to the substantial changes to autofill since that bug landed), but I left it in anyway since it seems right to not allow autofill results for the history popup. One other useful bit of info is that userTypedValue is set to null by tabbrowser on page load [4], so that's how userTypedValue has a null value when the bug manifests and it goes from null to non-null. [1] https://hg.mozilla.org/mozilla-central/file/5e2a3b886e647af1968b9e52a6672bdeee2a0d6f/browser/components/urlbar/UrlbarController.jsm#l150 [2] https://searchfox.org/mozilla-central/rev/da14c413ef663eb1ba246799e94a240f81c42488/browser/components/urlbar/UrlbarView.jsm#685 [3] https://searchfox.org/mozilla-central/rev/da14c413ef663eb1ba246799e94a240f81c42488/browser/components/urlbar/UrlbarView.jsm#220 [4] https://searchfox.org/mozilla-central/rev/da14c413ef663eb1ba246799e94a240f81c42488/browser/base/content/tabbrowser.js#5118 Differential Revision: https://phabricator.services.mozilla.com/D35505
3d562db5d1ed358a18da5bbe160c1da4864ef6c0: Bug 1528481 - Possible use after free in Http2Session::RecvPushPromise() if we have a usable entry in the cache for the resource. r=dragana, a=ritu
Michal Novotny <michal.novotny@gmail.com> - Fri, 14 Jun 2019 22:54:06 +0000 - rev 533998
Push 11488 by jcristau@mozilla.com at Mon, 24 Jun 2019 08:10:20 +0000
Bug 1528481 - Possible use after free in Http2Session::RecvPushPromise() if we have a usable entry in the cache for the resource. r=dragana, a=ritu If we find a usable cache entry, the stream is closed and release in CachePushCheckCallback::OnCacheEntryCheck(). This patch converts raw pointer to a weak pointer, so we can simply check if the object still exists after AsyncOpenURI() finishes. Differential Revision: https://phabricator.services.mozilla.com/D33945
4174d76d91945a7261f81d7666eee4b2b35cb027: Bug 1547266 - Make sure Http2PushedStream is used only on socket thread. r=dragana, a=ritu
Michal Novotny <michal.novotny@gmail.com> - Tue, 18 Jun 2019 23:36:54 +0000 - rev 533997
Push 11488 by jcristau@mozilla.com at Mon, 24 Jun 2019 08:10:20 +0000
Bug 1547266 - Make sure Http2PushedStream is used only on socket thread. r=dragana, a=ritu Raw pointer to Http2PushedStream is passed to nsHttpChannel and nsHttpTransaction to get it back to a new Http2Stream in the Http2Session. As a result Http2PushedStream's methods can be called on a wrong thread and possibly on already freed object. This patch uses Http2PushedStreamWrapper instead, which takes care about thread safety and checks if the object is still alive. Differential Revision: https://phabricator.services.mozilla.com/D33511
fd384ae3e04ea04fada7a72d9b2362862c0a3898: Bug 1558549 - Update to NSS_3_44_1_RTM. a=ritu UPGRADE_NSS_RELEASE
J.C. Jones <jjones@mozilla.com> - Mon, 24 Jun 2019 10:01:40 +0200 - rev 533996
Push 11488 by jcristau@mozilla.com at Mon, 24 Jun 2019 08:10:20 +0000
Bug 1558549 - Update to NSS_3_44_1_RTM. a=ritu UPGRADE_NSS_RELEASE
2bee7577b5a687ef6da1cd27852da85d28af2395: Bug 1560527 - Enable make backend verbose mode automatically rather than relying on mach setting it. r=froydnj a=ritu
Mike Hommey <mh+mozilla@glandium.org> - Fri, 21 Jun 2019 13:15:30 +0000 - rev 533995
Push 11487 by nbeleuzu@mozilla.com at Mon, 24 Jun 2019 00:32:41 +0000
Bug 1560527 - Enable make backend verbose mode automatically rather than relying on mach setting it. r=froydnj a=ritu This makes running without mach more consistent. e.g. running `make -C $objdir/toolkit/library/rust target` makes the cargo log verbose, and adding `-s` makes it less verbose. Differential Revision: https://phabricator.services.mozilla.com/D35521
29b838345c241ca20986a6dba9843d3f5fc4d09a: Bug 1560336 - Stop using the toolbaritem-combined-buttons class for the Firefox account menu item. r=Gijs a=ritu
Dão Gottwald <dao@mozilla.com> - Thu, 20 Jun 2019 18:56:08 +0000 - rev 533994
Push 11487 by nbeleuzu@mozilla.com at Mon, 24 Jun 2019 00:32:41 +0000
Bug 1560336 - Stop using the toolbaritem-combined-buttons class for the Firefox account menu item. r=Gijs a=ritu Differential Revision: https://phabricator.services.mozilla.com/D35434
4dc07e652294ff5ed28e6cd4b210ec20b162f07b: Bug 1559686 - Reimplement the inputHistory feature in the Quantum Bar. r=adw a=ritu
Marco Bonardo <mbonardo@mozilla.com> <mbonardo@mozilla.com> - Thu, 20 Jun 2019 18:21:01 +0000 - rev 533993
Push 11487 by nbeleuzu@mozilla.com at Mon, 24 Jun 2019 00:32:41 +0000
Bug 1559686 - Reimplement the inputHistory feature in the Quantum Bar. r=adw a=ritu Differential Revision: https://phabricator.services.mozilla.com/D35364
872d45245a4a46d5826e60913a09d412641ca592: no bug - Bumping Firefox l10n changesets r=release a=l10n-bump DONTBUILD
L10n Bumper Bot <release+l10nbumper@mozilla.com> - Sun, 23 Jun 2019 14:00:22 +0000 - rev 533992
Push 11486 by ffxbld at Sun, 23 Jun 2019 14:00:30 +0000
no bug - Bumping Firefox l10n changesets r=release a=l10n-bump DONTBUILD eu -> 94a6d9f7f84a fi -> affff025e471 id -> 806892778c67 kk -> 1a31248baa85 ro -> 56456c8de90b
c00fefc813a325ead9f1c01afdbc4ae350e2820b: no bug - Bumping Fennec l10n changesets r=release a=l10n-bump DONTBUILD
L10n Bumper Bot <release+l10nbumper@mozilla.com> - Sun, 23 Jun 2019 14:00:15 +0000 - rev 533991
Push 11486 by ffxbld at Sun, 23 Jun 2019 14:00:30 +0000
no bug - Bumping Fennec l10n changesets r=release a=l10n-bump DONTBUILD eu -> 94a6d9f7f84a fi -> affff025e471 id -> 806892778c67 kk -> 1a31248baa85 ro -> 56456c8de90b
c7e10201d989b0d91132fb922056c98a7a1729dc: no bug - Bumping Firefox l10n changesets r=release a=l10n-bump DONTBUILD
L10n Bumper Bot <release+l10nbumper@mozilla.com> - Sun, 23 Jun 2019 13:00:23 +0000 - rev 533990
Push 11485 by ffxbld at Sun, 23 Jun 2019 13:00:31 +0000
no bug - Bumping Firefox l10n changesets r=release a=l10n-bump DONTBUILD be -> b0f94e605b2e bn -> 4315a3044d3e cs -> c090ca90f1e4 cy -> 3e37f64ca582 da -> 5df154721030 el -> 99a893864601 eo -> 8760bcc7018d es-AR -> d4896ee336fa es-CL -> 70b4714e4f38 es-ES -> 10d3b5d830f2 et -> d46b29f8beb5 eu -> 1a84793dbdd8 fi -> 68d10deda080 fr -> ca9274753983 gu-IN -> 73b33714c771 hy-AM -> d8af3e1a88f6 ia -> f1ae2cc42b43 id -> bbe6c60e12e2 is -> 9ef4e7f3dc3f it -> d99ef9eee17d kk -> 6e75156a0abf lt -> 4dab8fb90181 mr -> 796ed1fe283d nb-NO -> 821125543642 nl -> 3f0d224c472f nn-NO -> 8b2c108ccfee pl -> 5aef53374353 ro -> 0e3b4cfd0373 ru -> 8f602d812ca0 sl -> a1d0fe8d3f33 sq -> e005e5e43361 sv-SE -> 0cbf4154accc te -> 955f2e5074de th -> a55dd8b2747d tr -> 62555206dcfc uk -> 3b3cd40dfe15 ur -> 8ef788d9f59f vi -> 15114d2d5bc7
60c41ec534fae84b9eb1df13f5a242e68b20fb64: no bug - Bumping Fennec l10n changesets r=release a=l10n-bump DONTBUILD
L10n Bumper Bot <release+l10nbumper@mozilla.com> - Sun, 23 Jun 2019 13:00:15 +0000 - rev 533989
Push 11485 by ffxbld at Sun, 23 Jun 2019 13:00:31 +0000
no bug - Bumping Fennec l10n changesets r=release a=l10n-bump DONTBUILD be -> b0f94e605b2e bn -> 4315a3044d3e cs -> c090ca90f1e4 cy -> 3e37f64ca582 da -> 5df154721030 el -> 99a893864601 eo -> 8760bcc7018d es-AR -> d4896ee336fa es-CL -> 70b4714e4f38 es-ES -> 10d3b5d830f2 et -> d46b29f8beb5 eu -> 1a84793dbdd8 fi -> 68d10deda080 fr -> ca9274753983 gu-IN -> 73b33714c771 hy-AM -> d8af3e1a88f6 id -> bbe6c60e12e2 is -> 9ef4e7f3dc3f it -> d99ef9eee17d kk -> 6e75156a0abf lt -> 4dab8fb90181 mr -> 796ed1fe283d nb-NO -> 821125543642 nl -> 3f0d224c472f nn-NO -> 8b2c108ccfee pl -> 5aef53374353 ro -> 0e3b4cfd0373 ru -> 8f602d812ca0 sl -> a1d0fe8d3f33 sq -> e005e5e43361 sv-SE -> 0cbf4154accc te -> 955f2e5074de th -> a55dd8b2747d tr -> 62555206dcfc uk -> 3b3cd40dfe15 ur -> 8ef788d9f59f vi -> 15114d2d5bc7
b632ea1ae36e49a6ab60ed2b34ee2e967dcb26d9: Bug 1547217 - Reshuffle how verifymar is linked. r=chmanchester, a=jcristau
Mike Hommey <mh+mozilla@glandium.org> - Wed, 19 Jun 2019 23:26:40 +0000 - rev 533988
Push 11484 by jcristau@mozilla.com at Fri, 21 Jun 2019 06:08:09 +0000
Bug 1547217 - Reshuffle how verifymar is linked. r=chmanchester, a=jcristau The conditions under which verifymar is built were not aligned with what kind of setups are actually doing something. For instance --disable-signmar --enable-verify-mar was building the verifymar library but not doing anything with it. OTOH, building with --enable-signmar --disable-verify-mar did build it but its code was eliminated at link time because it's unused. Finally, the conditions between modules/libmar/verify/moz.build and toolkit/mozapps/update/updater/updater-common.build weren't aligned and broke some non-Linux tier-3 platforms. We remedy the latter by moving the flags and libraries verifymar needs to verifymar, so that things that link verifymar inherit them. And while in the vicinity, replace a use of NSPR_LIBS with the pseudo-library `nspr` which has the same effect. Differential Revision: https://phabricator.services.mozilla.com/D34620
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 tip