a341e170f306d01a9ade7eba3158edfe1c50995c: Bug 1368837 - MockMediaResource::GetCachedDataEnd should return the offset if out of range - r=cpearce
Gerald Squelart <gsquelart@mozilla.com> - Mon, 29 May 2017 15:13:15 +1200 - rev 409835
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1368837 - MockMediaResource::GetCachedDataEnd should return the offset if out of range - r=cpearce If the requested cached-data offset is out of range, we should just return the same offset, as it signals that the actual cached range is 0 bytes, without having to deal with -1. MozReview-Commit-ID: D0rXO0S0mss
d7836ae27b65d4e511d3bf047380e1fb83124002: Bug 1368837 - Implement SourceBufferResource::GetCachedDataEnd - r=cpearce
Gerald Squelart <gsquelart@mozilla.com> - Mon, 29 May 2017 14:51:08 +1200 - rev 409834
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1368837 - Implement SourceBufferResource::GetCachedDataEnd - r=cpearce MediaResourceIndex caching requires GetCachedDataEnd and ReadFromCache. Implementing SourceBufferResource::GetCachedDataEnd is trivial, as it's just a buffer from 0 to GetLength(), so if the requested cached-data offset is inside the buffer, we can just return the total length as known cached data. MozReview-Commit-ID: 1DO0PzDnjQp
e38d5530bf2b18ee63a7b3a1f7633376a0ce0969: Bug 1368837 - BufferMediaResource::GetCachedDataEnd should return aOffset when out of cache - r=cpearce
Gerald Squelart <gsquelart@mozilla.com> - Thu, 01 Jun 2017 11:30:14 +1200 - rev 409833
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1368837 - BufferMediaResource::GetCachedDataEnd should return aOffset when out of cache - r=cpearce MozReview-Commit-ID: 6EEXSUxShLp
7a404b72b9b8f89046938755e17c17de333dfdf5: Bug 1368837 - Document that MediaResource::GetCachedDataEnd should return aOffset when out of cache - r=cpearce
Gerald Squelart <gsquelart@mozilla.com> - Thu, 01 Jun 2017 11:29:49 +1200 - rev 409832
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1368837 - Document that MediaResource::GetCachedDataEnd should return aOffset when out of cache - r=cpearce MozReview-Commit-ID: JKeuEAjIRxr
d2e141768c617d8e45c89d1f55e1f5659fefc5e3: Bug 1353029 - Pass PdfJs.enabled into child on change r=bdahl
Doug Thayer <dothayer@mozilla.com> - Tue, 30 May 2017 16:34:53 -0700 - rev 409831
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1353029 - Pass PdfJs.enabled into child on change r=bdahl isDefaultHandler in PdfJs.jsm appears to only be called on startup and when the settings for pdfs (either the pref or the setting in about:preferences) are changed. During startup, it's only the parent process which makes this call, which it uses to conditionally load a script in the content process. On change, the parent process controls notifying the content process, so it can simply pass along the enabled boolean. This change simply shifts to pass this boolean along to the child, and adds some guards to assert that we're only checking the actual values in the parent process. MozReview-Commit-ID: 9JSEJqHR2Ni
bc5283bd5f85f9de1c17a2d86c1a0a7eec48dce1: Bug 1368932 - Add a testcase for a replace-malloc library that doesn't implement all functions. r=njn
Mike Hommey <mh+mozilla@glandium.org> - Wed, 31 May 2017 15:04:32 +0900 - rev 409830
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1368932 - Add a testcase for a replace-malloc library that doesn't implement all functions. r=njn
4bd3eb1b5f3761565871f226e80c4b158defdf48: Bug 1368932 - Handle missing replace_posix_memalign at the replace-malloc level. r=njn
Mike Hommey <mh+mozilla@glandium.org> - Wed, 31 May 2017 13:47:17 +0900 - rev 409829
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1368932 - Handle missing replace_posix_memalign at the replace-malloc level. r=njn Replace-malloc libraries, such as DMD, don't really need to care about the details of implementing all the variants of aligned memory allocation functions. Currently, by defining MOZ_REPLACE_ONLY_MEMALIGN before including replace_malloc.h, they get predefined functions. Instead of making that an opt-in at build time, we make the replace-malloc initialization just fill the replace-malloc malloc_table_t with implementations that rely on the replace_memalign the library provides.
4753d3677cbe1780928b7b9844700539604c3218: Bug 1368932 - Move the replace_malloc_init_funcs function around. r=njn
Mike Hommey <mh+mozilla@glandium.org> - Wed, 31 May 2017 13:47:11 +0900 - rev 409828
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1368932 - Move the replace_malloc_init_funcs function around. r=njn
13a1349fb675560c774b9c8157f0e86c37e620e8: Bug 1368932 - Fill the replace-malloc malloc_table_t with the real allocator as a fallback. r=njn
Mike Hommey <mh+mozilla@glandium.org> - Tue, 30 May 2017 15:57:28 +0900 - rev 409827
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1368932 - Fill the replace-malloc malloc_table_t with the real allocator as a fallback. r=njn Until now, the malloc implementation functions would call the replace-malloc functions if they exist, and fallback to the real allocator in no such function exists. Instead of doing this, we now fill the empty slots in the malloc_table_t with the real allocator functions.
ff2a02c2733bcb2280baf75911861321bb53d810: Bug 1368932 - Use a malloc_table_t for most replace-malloc function pointers, on all platforms. r=njn
Mike Hommey <mh+mozilla@glandium.org> - Tue, 30 May 2017 15:57:28 +0900 - rev 409826
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1368932 - Use a malloc_table_t for most replace-malloc function pointers, on all platforms. r=njn We make replace_malloc_init_funcs called on all platforms and fill out a malloc_table_t for the replace-malloc functions with what comes from dlsym/GetProcAddress on Android/Windows, and from the dynamically linked weak symbols replace_* on other platforms. replace_malloc.h contains definitions of *_impl_t types for each of the functions in the malloc_table_t, which is redundant with the replace_*_impl_t types we were creating, so we remove those typedefs, except for the two functions (init and get_bridge) that don't have such a typedef. Those functions don't appear in malloc_table_t.
3f71138313da560bddc42152421cb529f4d54e0f: Bug 1368932 - Refactor such that there is only one definition of replace_malloc_init_funcs. r=njn
Mike Hommey <mh+mozilla@glandium.org> - Tue, 30 May 2017 15:57:28 +0900 - rev 409825
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1368932 - Refactor such that there is only one definition of replace_malloc_init_funcs. r=njn We want, in a subsequent patch, to have replace_malloc_init_funcs be called on all platforms (including those relying on the replace-malloc library being loaded already) and perform more initialization. To prepare for that, we move the non-platform-specific pieces out.
3d78fdcff608b2486ea7b75cb9b5fe31b75cc2ed: Bug 1368932 - Generate all the _impl functions with macros in replace-malloc. r=njn
Mike Hommey <mh+mozilla@glandium.org> - Thu, 25 May 2017 16:47:57 +0900 - rev 409824
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1368932 - Generate all the _impl functions with macros in replace-malloc. r=njn All the _impl functions in replace-malloc.c are largely identical. This replaces all of them with macro expansions.
899d3cbc450c37b27b7f3def83cc6836a61df09c: Bug 1368932 - Add argument names to malloc implementation declarations in replace-malloc. r=njn
Mike Hommey <mh+mozilla@glandium.org> - Thu, 25 May 2017 16:04:46 +0900 - rev 409823
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1368932 - Add argument names to malloc implementation declarations in replace-malloc. r=njn This transforms the declarations from e.g.: void *realloc(void *, size_t); into: void *realloc(void *arg1, size_t arg2);
2265602a89551359f9a31fee81887bd9a6360d53: Bug 1368932 - Allow MOZ_PASTE_PREFIX_AND_ARG_COUNT to work with 0 arguments. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Thu, 25 May 2017 15:47:21 +0900 - rev 409822
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1368932 - Allow MOZ_PASTE_PREFIX_AND_ARG_COUNT to work with 0 arguments. r=froydnj At the same time, remove the MOZ_STATIC_ASSERT_VALID_ARG_COUNT, which doesn't actually work for more than 50 arguments(*), and which is now not useful to detect 0 arguments. (*) the build fails, but not directly thanks to the static_assert it expands to.
80496d55346d35f5d14d656acfafff60e0c1870e: Bug 1368932 - Don't rely on the default MALLOC_DECL_VOID for malloc function declarations in replace-malloc. r=njn
Mike Hommey <mh+mozilla@glandium.org> - Thu, 25 May 2017 15:58:56 +0900 - rev 409821
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1368932 - Don't rely on the default MALLOC_DECL_VOID for malloc function declarations in replace-malloc. r=njn In practice, this induces no change in what the expanded code looks like.
aa1bdb69c9e8bad0e1023ff9a0620ee4af65fbec: Bug 1368932 - Factor out function declarations for malloc implementation. r=njn
Mike Hommey <mh+mozilla@glandium.org> - Thu, 25 May 2017 15:54:05 +0900 - rev 409820
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1368932 - Factor out function declarations for malloc implementation. r=njn
a92caa51ce41bab31559d322c95bd7a38104782e: Bug 1368932 - Remove void argument from declarations in malloc_decls.h. r=njn
Mike Hommey <mh+mozilla@glandium.org> - Thu, 25 May 2017 13:56:40 +0900 - rev 409819
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1368932 - Remove void argument from declarations in malloc_decls.h. r=njn This makes no significant difference in practice in the macro expansions, but will help down the line.
7bdd66505228718a7c68723e1364c1aa98956bf1: No bug - Revendor rust dependencies
Servo VCS Sync <servo-vcs-sync@mozilla.com> - Thu, 01 Jun 2017 06:58:58 +0000 - rev 409818
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
No bug - Revendor rust dependencies
7d08d1135232d16077d1df8580ef67a11cc601d3: servo: Merge #17120 - fix double borrowing of image request (from gterzian:fix_double_borrowing_of_image_request); r=jdm
Gregory Terzian <gterzian@users.noreply.github.com> - Wed, 31 May 2017 21:47:33 -0700 - rev 409817
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
servo: Merge #17120 - fix double borrowing of image request (from gterzian:fix_double_borrowing_of_image_request); r=jdm <!-- Please describe your changes on the following line: --> @jdm I couldn't reproduce the crashes, but looking at the code, I can tell that if we hit the cache inside `fetch_image`, we go straight to `process_image_response`, so we're still in the same scope as that where the borrowing occurs in `prepare_image_request`. When there is no cache hit, `process_image_response` is executed as part of a task... This should fix the issue, while retaining the original logic. All tests in `the-img-element` are passing... --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #17109 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 6a638876fdf1f7c87d9c17d302864d38b67510cb
941c6923e4071fd91d079bdc2b827cb5162fd982: servo: Merge #17118 - Remove unicode-bidi/with_serde feature from style deps (from upsuper:unicode-bidi-serde); r=heycam
Xidorn Quan <me@upsuper.org> - Wed, 31 May 2017 19:28:12 -0700 - rev 409816
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
servo: Merge #17118 - Remove unicode-bidi/with_serde feature from style deps (from upsuper:unicode-bidi-serde); r=heycam It seems removing this feature from here would unbust stylo build on Gecko side, and style crate doesn't need it anyway, and for Servo, other crates would bring this feature back, so it shouldn't break Servo either. Source-Repo: https://github.com/servo/servo Source-Revision: af6a14070779a4ba166c8a3a8d6488437a6604b3
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip