a2ee07a4cfaa9cde3b86f200cc912e3343203dd0: Bug 1470400 - Document how archived pings are cleaned up. r=Dexter
Jan-Erik Rediger <jrediger@mozilla.com> - Mon, 25 Jun 2018 15:55:29 +0000 - rev 478714
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1470400 - Document how archived pings are cleaned up. r=Dexter Depends on D1805 Differential Revision: https://phabricator.services.mozilla.com/D1806
54c45d3d2ffa6cd40ed96532508bab9ed22df2ca: Bug 1467125 - [Wayland] Get events from Wayland display faster on compositor thread, r=jhorak
Martin Stransky <stransky@redhat.com> - Wed, 06 Jun 2018 15:25:15 +0200 - rev 478713
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1467125 - [Wayland] Get events from Wayland display faster on compositor thread, r=jhorak MozReview-Commit-ID: AmarsYA2INc
325f3e1ba486da512d1f8397fa2513f572e91d15: Bug 1470244 - Rename all panel documents to index.{xul|html}. r=jdescottes
Alexandre Poirot <poirot.alex@gmail.com> - Thu, 21 Jun 2018 11:08:25 -0700 - rev 478712
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1470244 - Rename all panel documents to index.{xul|html}. r=jdescottes MozReview-Commit-ID: 5C3ehYKBt3m
2f413d5f9635112d0103dc76ffce0fa7bcd4692f: Bug 1471115 - Remove unused methods in nsIHTMLEditor. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Tue, 26 Jun 2018 04:29:36 +0000 - rev 478711
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1471115 - Remove unused methods in nsIHTMLEditor. r=masayuki insertHTMLWithContext, getIndentState, setBodyAttribute and getSelectionContainer are unused from script (inc. c-c and bluegriffon). Differential Revision: https://phabricator.services.mozilla.com/D1822
ca98b6f47b4e33673291a4dc2a4ebca28ce6db00: Bug 1469879 - Add check for closed socket on Multicast IPC parent funcs; r=baku
Kyle Machulis <kyle@nonpolynomial.com> - Mon, 25 Jun 2018 16:59:08 -0700 - rev 478710
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1469879 - Add check for closed socket on Multicast IPC parent funcs; r=baku MozReview-Commit-ID: CaNYPtgFz87
83d286f5134fd374fc4526093afd1be183bd868f: Backed out 5 changesets (bug 1340498) for build bustages on SelectionChangeListener.h on a CLOSED TREE
arthur.iakab <aiakab@mozilla.com> - Tue, 26 Jun 2018 07:59:01 +0300 - rev 478709
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Backed out 5 changesets (bug 1340498) for build bustages on SelectionChangeListener.h on a CLOSED TREE Backed out changeset c89b86622d38 (bug 1340498) Backed out changeset b270d4a01986 (bug 1340498) Backed out changeset 8ed32495b46f (bug 1340498) Backed out changeset df9a67c58183 (bug 1340498) Backed out changeset a5977e0708ea (bug 1340498)
c89b86622d3885cb731dcc52274a35a7d626159b: Bug 1340498 - Fix unified sources build errors r=mrbkap
Doug Thayer <dothayer@mozilla.com> - Fri, 13 Apr 2018 11:04:47 -0700 - rev 478708
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1340498 - Fix unified sources build errors r=mrbkap Adding the Places* files into unified sources pushed the unified sources into a situation that exposed a strangely large number of errors. This seems to be the minimum set of changes I could make to resolve all of the issues. MozReview-Commit-ID: C2H9ce8FmE4
b270d4a0198604fb748e51773eb35f5cbf5488b8: Bug 1340498 - Update onVisits tests to use 'page-visited' r=mak
Doug Thayer <dothayer@mozilla.com> - Wed, 14 Feb 2018 09:17:41 -0800 - rev 478707
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1340498 - Update onVisits tests to use 'page-visited' r=mak MozReview-Commit-ID: FxC3gcUF9hl
8ed32495b46f58741c6c154de3bc5a1b5a5c5a31: Bug 1340498 - Update onVisits uses to 'page-visited' r=mak
Doug Thayer <dothayer@mozilla.com> - Wed, 14 Feb 2018 09:11:49 -0800 - rev 478706
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1340498 - Update onVisits uses to 'page-visited' r=mak Consuming the new 'page-visited' notification was fairly trivial, since it was already brought over to onVisits. There's not much to say about this other than that I'm a little bit uncertain about all the hoops we have to jump through to get a JSContext and GlobalObject from History.cpp (which is discussed in the earlier commit in the series). MozReview-Commit-ID: LHaBWSylyLI
df9a67c58183a189b4175dbe063bed7407f12b37: Bug 1340498 - Implement new Places Observers interface r=mrbkap
Doug Thayer <dothayer@mozilla.com> - Wed, 14 Feb 2018 09:06:15 -0800 - rev 478705
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1340498 - Implement new Places Observers interface r=mrbkap See the design doc[1] for further info. We would like to redesign the places observer system to be more performant and more friendly to consume. WebIDL was recommended as it simplifies creating simple dictionary payloads while allowing dynamic typing with `any`. There were some difficulties with WebIDL though, most of which revolved around allowing consumers to be weakly referenced, from both C++ and JS. The simplest solution I could come up with was to create a simple native interface for the C++ case, and a WebIDL wrapper for a JS callback in the JS case. Suggestions for simpler alternatives are very welcome though. [1] https://docs.google.com/document/d/1G45vfd6RXFXwNz7i4FV40lDCU0ao-JX_bZdgJV4tLjk/edit?usp=sharing MozReview-Commit-ID: ACnAEfa5WxO
a5977e0708ea2bd07e9029b3b80b3035c7243534: Bug 1340498 - Add new globals to lint config r=standard8
Doug Thayer <dothayer@mozilla.com> - Mon, 29 Jan 2018 11:07:28 -0800 - rev 478704
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1340498 - Add new globals to lint config r=standard8 MozReview-Commit-ID: 360gup8cWvi
463ef9c8540fa4444250ab3abd097ec0220e9e12: Bug 1418806 - Try to allocate possible size for AnimationValueMap before composing. r=birtles
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Tue, 26 Jun 2018 11:08:24 +0900 - rev 478703
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1418806 - Try to allocate possible size for AnimationValueMap before composing. r=birtles The EffectSet count does not exactly represent the count what we really need for AnimationValueMap, but in most cases it matches. For example; 1) The element has two different keyframes animations @keyframes anim1 { to { opacity: 0; } } @keyframes anim2 { to { transform: rotate(360deg); } } In this case the number matches. 2) The element has two animations but both keyframes have the same CSS property @keyframes anim1 { to { opacity: 0; } } @keyframes anim2 { to { opacity: 0.1; } } In this case the number doesn't match, moreover it results more memory than we ever needed, but this case is presumably less common. 3) The element has an animation having keyframes for two different CSS properties. @keyframes anim { from { opacity: 0; transform: rotate(360deg); } } In this kind of cases, the number doesn't match. But even so, this patch reduces the opportunities that the AnimationValueMap tries to allocate a new memory (i.e. less opportunities on expanding the map). Note that when the hash map is expanded, we do allocate a new RawTable with the new size then replace the old one with the new one [1], so I believe this change will reduce the crash rate to some extent. [1] https://hg.mozilla.org/mozilla-central/file/15c95df467be/servo/components/hashglobe/src/hash_map.rs#l734 MozReview-Commit-ID: 6tcF9aqXh7a
ca338b516f46818129161ff4f51559c4783a0145: Bug 1418806 - Introduce a constant variable to represents the number of all animatable longhands. r=xidorn
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Tue, 26 Jun 2018 08:51:13 +0900 - rev 478702
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1418806 - Introduce a constant variable to represents the number of all animatable longhands. r=xidorn We will use this number to cap the pre-allocation AnimationValueMap in the next patch. MozReview-Commit-ID: Iqq9plbD8Vl
f15f24bf1131f03941efa265996f84ce8b9c61a9: Bug 900750 - part 6: Rename |name| in test_keycodes.xul to |currentTestName| r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 04 Jun 2018 20:41:43 +0900 - rev 478701
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 900750 - part 6: Rename |name| in test_keycodes.xul to |currentTestName| r=smaug |name| is too generic but the scope is too wide in test_keycodes.xul. So, let's rename it to |currentTestName|. MozReview-Commit-ID: JvEDhRhKYCU
44cb540ef2fc4589c2941ab13dc6ea6b6da59474: Bug 900750 - part 5: Make NativeKey set KeyboardEvent.key value of AltRight key to "AltGraph" when active keyboard layout has AltGr key r=m_kato,smaug
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 31 May 2018 18:36:33 +0900 - rev 478700
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 900750 - part 5: Make NativeKey set KeyboardEvent.key value of AltRight key to "AltGraph" when active keyboard layout has AltGr key r=m_kato,smaug When AltGr key is pressed, following messages come: 1. WM_KEYDOWN for ControlLeft 2. WM_KEYDOWN for AltLeft 3. WM_SYSKEYUP for ControlLeft 4. WM_KEYUP for AltLeft In these key sequence, KeyboardEvent.key value of keydown event at #2 and keyup event at #4 should be "AltGraph". This patch fixes the key value and adding new test into test_keycodes.xul to check the behavior with SynthesizeNativeKey(). MozReview-Commit-ID: JZ6WednB8la
311827011b111f087b862c61c14d47191a58dedc: Bug 900750 - part 4: Make NativeKey replaces MODIFIER_CONTROL and MODIFIER_ALT of mModKeyState with MODIFIER_ALTGRAPH if user emulates AltGr key press with pressing both Ctrl and Alt keys and current keydown produces character(s) r=m_kato,smaug
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 04 Jun 2018 14:45:28 +0900 - rev 478699
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 900750 - part 4: Make NativeKey replaces MODIFIER_CONTROL and MODIFIER_ALT of mModKeyState with MODIFIER_ALTGRAPH if user emulates AltGr key press with pressing both Ctrl and Alt keys and current keydown produces character(s) r=m_kato,smaug Users can emulate AltGr key with pressing both Ctrl key and Alt key on Windows since AltGr is represented as so in Windows and physical keyboard may not have AltRight key. If user emulates AltGr key, we should set MODIFIER_ALTGRAPH to a set of keyboard events for printable keys only when the key press produces character(s) or a dead key. For example: 1. ControlLeft keydown event should make ctrlKey true. 2. AltLeft keydown event should make altKey true (not AltGraph state). 3. ctrlKey and altKey of printable keydown, keypress and keyup events should be set to false, but getModifierState("AltGraph") should return true. 4. AltLeft keyup event should make altKey false. 5. ControlLeft keyup event should make ctrlKey false. (If AltLeft key is pressed first, altKey of AltLeft keydown is true and both altKey and ctrlKey of the following ControlLeft keydown are true as usual.) MozReview-Commit-ID: 8Km8GXPDQw1
2e6a8268778e2c891dd9755e2423864ea58bf20a: Bug 900750 - part 3: Remove unnecessary ModifierKeyState argument from some methods of NativeKey and KeyboardLayout r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 01 Jun 2018 15:22:41 +0900 - rev 478698
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 900750 - part 3: Remove unnecessary ModifierKeyState argument from some methods of NativeKey and KeyboardLayout r=m_kato KeyboardLayout::InitNativeKey() takes |const ModifierKeyState&| as its argument with NativeKey reference and it calls some internal methods with the given ModifierKeyState without any changes. Additionally, its caller is only NativeKey::InitWithKeyChar() and its called with given NativeKey instance's mModKeyState. So, removing the redundant arguments from some methods makes them clearer what they compute with. So, this patch does not change any behavior. MozReview-Commit-ID: 3w9Ee7PMU05
c2e17337f8b84e8c921007347698d49fb4290bf6: Bug 900750 - part 2: Make ModifierKeyState and VirtualKey treat AltGraph as new modifier and won't set Control and Alt state while AltGraph is active r=m_kato,smaug
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 30 May 2018 17:27:31 +0900 - rev 478697
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 900750 - part 2: Make ModifierKeyState and VirtualKey treat AltGraph as new modifier and won't set Control and Alt state while AltGraph is active r=m_kato,smaug By the proposal from Google, <https://github.com/w3c/uievents/issues/147>, Chromium treat AltRight key as "AltGraph" modifier if the keyboard layout has AltGr key. When AltRight key is pressed with a keyboard layout which has AltGr key, modifiers should as following: 1. "keydown" for ControlLeft: ctrlKey: true, altKey: false, getModifierState("AltGraph"): false 2. "keydown" for AltRight: ctrlKey: false, altKey: false, getModifierState("AltGraph"): true 3. Some "keydown", "keypress" and "keyup" events: ctrlKey: false, altKey: false, getModifierState("AltGraph"): true 4. "keyup" for ControlLeft: ctrlKey: false, altKey: false, getModifierState("AltGraph"): true 5. "keyup" for AltRight: ctrlKey: false, altKey: false, getModifierState("AltGraph"): false So, only when the preceding "keydown" event for ControlLeft, ctrlKey should be set to true as usual. However, after AltRight key is pressed actually, we should treat "AltGraph" modifier is true and both ctrlKey and altKey should be set to false for web apps can handle text input normally. So, MODIFIER_ALTGRAPH and MODIFIER_CONTROL/MODIFIER_ALT should not be set at the same time. This patch makes ModifierKeyState have only MODIFIER_ALTGRAPH or MODIFIER_CONTROL/MODIFIER_ALT. Additionally, this patch makes VirtualKey::ShiftState treat "AltGraph" as a modifier. So, now, VirtualKey needs to convert ShiftState to index value when it accesses its mShiftStates array. Therefore, this patch adds VirtualKey::ToIndex() and make each VirtualKey method use it before accessing mShiftStates. Note that this patch also fixes bug of WinUtils::SetupKeyModifiersSequence(). The constructor of KeyPair takes 2 keycode values, but the second virtual keycode can have scancode to distinguish if the key is left or right. However, WinUtils::SetupKeyModifiersSequence() never sets scancode to KeyPair. Therefore, it fails to dispatch AltRight key event. MozReview-Commit-ID: 7ealxJH9KlZ
3f2ed470f406406b888f816b5f6322b5b6687457: Bug 900750 - part 1: Make KeyboardLayout store the information if current keyboard layout has AltGr key r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 29 May 2018 20:36:38 +0900 - rev 478696
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 900750 - part 1: Make KeyboardLayout store the information if current keyboard layout has AltGr key r=m_kato For setting AltRight key's key value to "AltGraph" if it should work as so, we need to know if current keyboard layout has AltGr key. Unfortunately, Windows doesn't provide such information but we retrieve all input characters from each key when a keyboard layout is loaded. So, when we load a keyboard layout, we can mark if current keyboard layout has AltGr key with checking at least one key inputs different character(s) when AltGr key is pressed. MozReview-Commit-ID: 8GI3phSVTUS
61c842a25677cee0c2805a85a9e961179890c611: Bug 1471103 - Add a few useful packages to the base Debian docker images. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Tue, 26 Jun 2018 10:59:34 +0900 - rev 478695
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1471103 - Add a few useful packages to the base Debian docker images. r=froydnj
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip