a20bd8c1a22de3e2d02c8f9ad93fb3a2062ccb19: Bug 1381083: Test. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 27 Jul 2017 00:57:02 +0200 - rev 420350
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Bug 1381083: Test. r=heycam MozReview-Commit-ID: E99v62sXKtX
b8755e706ea7ca93ba444ecfc3eb0fdf60e17131: Bug 1381083: Don't hold the style context if we had a frame and re-resolved the style. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 27 Jul 2017 00:45:29 +0200 - rev 420349
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Bug 1381083: Don't hold the style context if we had a frame and re-resolved the style. r=heycam Otherwise we risk losing track of the frame if we hit the cache. MozReview-Commit-ID: ByHGhcBwIfX
dc839a86967dafca35021b3744f6dfb39264179f: Bug 1381083: Preliminary alignment and whitespace fixup. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 27 Jul 2017 00:28:52 +0200 - rev 420348
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Bug 1381083: Preliminary alignment and whitespace fixup. r=heycam MozReview-Commit-ID: 9V7pqVMOAqo
258d81d739533da1d4753741119bfd18c2176483: Bug 1384027 - part3: Don't send blur notification to IME from IMEStateManager::OnChangeFocusInternal() if no window becomes active and IME wants to keep composition during deactive r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 26 Jul 2017 00:57:29 +0900 - rev 420347
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Bug 1384027 - part3: Don't send blur notification to IME from IMEStateManager::OnChangeFocusInternal() if no window becomes active and IME wants to keep composition during deactive r=m_kato Currently, IMEStateManager::OnChangeFocusInternal() sends blur notification to IME when a remote process has IME focus and focus is moving from the process. However, if IME wants to keep composition even during deactive and nobody will gets focus (i.e., all windows becomes deactive), IMEStateManager shouldn't send the blur notification because it causes committing composition. Therefore, it should send blur notification only when focus is moving to a PresContext (that means that not all windows becomes deactive) or IME doesn't want to keep composition during deactive. Then, even if another window becomes active next time, IMEStateManager can send "stop IME state management" message to the composing remote process and the remote process can commit composition normally. Additionally, this patch ensures to send blur notification when IME focused TabParent or widget is being destroyed. This fixes new memory leak bug of this patch (sFocusedIMETabParent keeps grabbing the instance until shutting down in some mochitests). MozReview-Commit-ID: KYiFGo970a8
51919d68802ec622a8c24a5e839e046f57f66405: Bug 1384027 - part2: Move PuppetWidget::NotifyIMEInternal() implementation to PuppetWidget::NotifyIME() which is a method of TextEventDispatcherListener, not nsIWidget r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 26 Jul 2017 00:09:41 +0900 - rev 420346
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Bug 1384027 - part2: Move PuppetWidget::NotifyIMEInternal() implementation to PuppetWidget::NotifyIME() which is a method of TextEventDispatcherListener, not nsIWidget r=m_kato nsIWidget::NotifyIME() should call only TextEventDispatcher::NotifyIME() if it's necessary. Then, TextEventDispatcher::NotifyIME() calls TextEventDispatcherListener::NotifyIME() if it's necessary. E.g., requests to IME are necessary only for TextInputProcessor or native IME handler because the composition is only owned by one of them. However, notifications are necessary for both of them since focused editor contents and its focus state are shared. So, it doesn't need to call nsBaseWidget::NotifyIMEInternal() if all NotifyIMEInternal() implementations are moved to proper TextEventDispatcherListener::NotifyIME(). Currently, nsBaseWidget::NotifyIMEInternal() is implemented only by PuppetWidget. It sends notifications and requests to the parent process for native IME. Therefore, we can move NotifyIMEInternal() implementation to TextEventDispatcherListener::NotifyIME() which is implemented by PuppetWidget. This patch moves PuppetWidget::NotifyIMEInternal() implementation to PuppetWidget::NotifyIME() of TextEventDispatcherListener class, not of nsIWidget and removes NotifyIMEInternal() completely. With this change, handling order is changed. Old behavior is, TextEventDispatcher::NotifyIME() calls TextEventDispatcherListener::NotifyIME() before handling NOTIFY_IME_OF_FOCUS and then, nsBaseWidget::NotifyIME() sends the notification to the parent process. However, new behavior is, the notification is sent before TextEventDispatcher::NotifyIME() handles NOTIFY_IME_OF_FOCUS. Therefore, with new handling order, TextEventDispatcher can have IME notification requests after setting focus correctly. Additionally, TextEventDispatcher for PuppetWidget updates the notification requests at every event dispatch via TextEventDispatcher::BeginInputTransactionInternal() by the previous patch. So, with those patches, IMEContentObserver can refer actual IME notification requests correctly even after we'll make focus notification to async message. MozReview-Commit-ID: JwdQ68BjTXL
bd4ead9b69d42eb712e30df07c32d2b8c289d543: Bug 1384027 - part1: PuppetWidget should have TextEventDispatcher like nsIWidget instance in the parent process r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 25 Jul 2017 23:27:31 +0900 - rev 420345
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Bug 1384027 - part1: PuppetWidget should have TextEventDispatcher like nsIWidget instance in the parent process r=m_kato In the parent process, every nsIWidget instance like nsWindow has TextEventDispatcher instance after dispatching a keyboard event or a composition event. Then, TextEventDispatcher manages whether there is composition and handles NotifyIME. However, PuppetWidget doesn't have it unless it synthesizes keyboard events or composition events for tests. This causes PuppetWidget implementing nsIWidget::NotifyIME() with nsBaseWidget::NotifyIMEInternal() which is a virtual method only implemented by PuppetWidget. For consistent implementation around here, we should move NotifyIMEInternal() implementation to TextEventDispatcherListener::NotifyIME() which is called by TextEventDispatcher::NotifyIME(). Then, PuppetWidget can handle NotifyIME() easier. This patch creates TextEventDispatcher::BeginInputTransactionFor() which takes pointer to a dispatching event and pointer to PuppetWidget. It emulates each corresponding event dispatcher method for managing composing state and begins input transaction for the dispatching event. Unfortunately, this implementation is ugly due to duplicated code. However, this is enough for now. When we need to make TextEventDispatcher manage more states, we should add methods which are shared by both BeginInputTransactionFor() and event dispatcher method. MozReview-Commit-ID: GeP028luZjR
c8568609e10ca0de349966554906ed2670a150ef: Bug 1383041 - Update bindings for API change in WR cset 9f66b56. r=mrobinson
Kartikaya Gupta <kgupta@mozilla.com> - Fri, 28 Jul 2017 08:18:54 -0400 - rev 420344
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Bug 1383041 - Update bindings for API change in WR cset 9f66b56. r=mrobinson MozReview-Commit-ID: BWXPn0b7g6t
64e6e4ef477695afedcf9b3d443cfd8819f21776: Bug 1383041 - Update bindings for API change in WR cset 9868ef4. r=jrmuizel
Kartikaya Gupta <kgupta@mozilla.com> - Fri, 28 Jul 2017 08:18:32 -0400 - rev 420343
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Bug 1383041 - Update bindings for API change in WR cset 9868ef4. r=jrmuizel MozReview-Commit-ID: 3Jv1HwdfkPr
caba97838c0647c6fb75ab729c0dea41bc1019a1: Bug 1383041 - Update bindings for IdNamespace changes in WR cset 6a2662c. r=kvark
Kartikaya Gupta <kgupta@mozilla.com> - Fri, 28 Jul 2017 08:18:30 -0400 - rev 420342
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Bug 1383041 - Update bindings for IdNamespace changes in WR cset 6a2662c. r=kvark MozReview-Commit-ID: 32dsMgqoOvf
f413861fc69a9c82ba3f4765721baf4e4558d1da: Bug 1383041 - Update WR to cset 0748e02d1be5f889fc17de2eb81c0c363ee3aa80. r=jrmuizel
Kartikaya Gupta <kgupta@mozilla.com> - Fri, 28 Jul 2017 08:18:28 -0400 - rev 420341
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Bug 1383041 - Update WR to cset 0748e02d1be5f889fc17de2eb81c0c363ee3aa80. r=jrmuizel MozReview-Commit-ID: BO0bDTnS1y2
b6a15a11a52958b32e84e885b257c4ec33ea9f92: Bug 1385070 - Remove the WebRenderOMTAEnabled pref. r=ethlin
Kartikaya Gupta <kgupta@mozilla.com> - Thu, 27 Jul 2017 16:11:17 -0400 - rev 420340
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Bug 1385070 - Remove the WebRenderOMTAEnabled pref. r=ethlin MozReview-Commit-ID: CWdrpzorNxq
a4d0803e76901864339252806a8d6960f681af97: Bug 1384962 - Don't set process count for user on Preferences page load, r=jaws
Timothy Guan-tin Chien <timdream@gmail.com> - Thu, 27 Jul 2017 23:41:31 +0800 - rev 420339
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Bug 1384962 - Don't set process count for user on Preferences page load, r=jaws This is a follow-up to incomplete fix in bug 1382649. In that bug, I attempted to set the process count value to the e10s rollout value, when the user unchecks "Use default performance settings". The same function updatePerformanceSettingsBox() is actually run during page load, resulting the user set value being changed to e10s rollout value if the user decided to use the default process count. Tests are written for both patches. MozReview-Commit-ID: 4CLLcEKbS58
a0a41228220bd600b4299758a394bcffebadc0e3: Bug 1379900 - Doing elements filtering in JS to simplify XPath query in FormData::collect. r=mikedeboer
Beekill95 <nnn_bikiu0707@yahoo.com> - Sun, 23 Jul 2017 14:41:52 +0700 - rev 420338
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Bug 1379900 - Doing elements filtering in JS to simplify XPath query in FormData::collect. r=mikedeboer MozReview-Commit-ID: 7VjSkV8dlq1
9b266be297891f2ee6425070e2ac336722c5b865: Bug 1382529 - [Form Autofill] Exception occurs when saving a telephone number like "1234567". r=steveck
Luke Chang <lchang@mozilla.com> - Thu, 20 Jul 2017 13:30:53 +0800 - rev 420337
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Bug 1382529 - [Form Autofill] Exception occurs when saving a telephone number like "1234567". r=steveck MozReview-Commit-ID: mJ3KJemnme
d42bfe2b2e63992b5a201e15f6cb3de8cc11a112: Bug 1384294 - replace GetMainThreadEventTarget with GetNeckoTarget in HttpChannelChild. r=mayhemer
Shih-Chiang Chien <schien@mozilla.com> - Wed, 26 Jul 2017 15:55:18 +0800 - rev 420336
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Bug 1384294 - replace GetMainThreadEventTarget with GetNeckoTarget in HttpChannelChild. r=mayhemer GetMainThreadEventTarget doesn't label runnable with correct doc group or tab group. In HttpChannelChild we should replace it with |GetNeckoTarget| in general. By making mIsTrackingResource atomic, HttpChannelChild::ProcessNotifyTrackingResource can be further changed to do direct function call without dispatching additional runnable on main thread. MozReview-Commit-ID: LVvoiljHElX
fda73b7884dfaabd74069cd31150fa286a3bb333: Bug 1384812 - Add hbox for the defaultEngine menulist because we would like to make the menulist width just align its content width. r=jaws
Evan Tseng <evan@tseng.io> - Thu, 27 Jul 2017 17:51:58 +0800 - rev 420335
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Bug 1384812 - Add hbox for the defaultEngine menulist because we would like to make the menulist width just align its content width. r=jaws MozReview-Commit-ID: DI4d2zloSCb
4283d0e4b1d6a20fcdd523203b21d918752eaae1: Bug 1384812 - Remove the flex=1 attribute from submitHealthReportBox and automaticallySubmitCrashesBox checkboxes because they have learn-more links in the same line which should appear next to the checkbox instead of at the end of the line. r=jaws
Evan Tseng <evan@tseng.io> - Thu, 27 Jul 2017 12:14:22 +0800 - rev 420334
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Bug 1384812 - Remove the flex=1 attribute from submitHealthReportBox and automaticallySubmitCrashesBox checkboxes because they have learn-more links in the same line which should appear next to the checkbox instead of at the end of the line. r=jaws MozReview-Commit-ID: FK0H5u20uQH
12dd4194902de6381faed2a69fabe82f914d45fd: Bug 1382510 - update Private Browsing overlay and notification description;r=Ehsan,flod,mossop
gasolin <gasolin@gmail.com> - Fri, 21 Jul 2017 11:27:47 +0800 - rev 420333
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Bug 1382510 - update Private Browsing overlay and notification description;r=Ehsan,flod,mossop MozReview-Commit-ID: KHyrFHHPVpo
e8d5f44ef5eb7244401e7209f18c9f5370c59466: Bug 1381366 - The onboarding tour notifications and tour dialog close buttons should have a tooltip, r=mossop
Fischer.json <fischer.json@gmail.com> - Thu, 27 Jul 2017 13:52:17 +0800 - rev 420332
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Bug 1381366 - The onboarding tour notifications and tour dialog close buttons should have a tooltip, r=mossop MozReview-Commit-ID: 9sEMs6gUsNu
eeeeccf397ef54c90be732c3aa72a68d66bd455a: Bug 1366384 - Add Advisory test on Safe Browsing warning page r=francois
Thomas Nguyen <tnguyen@mozilla.com> - Thu, 27 Jul 2017 15:11:00 +0800 - rev 420331
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Bug 1366384 - Add Advisory test on Safe Browsing warning page r=francois MozReview-Commit-ID: C0c7GRj1qJo
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip