c3f480fa9744: Bug 1397975 - Show opt-in dialog for is_default with non built-in engines. r=aswan, a=sledru, l10n=flod DEVEDITION_57_0b3_RELEASE FENNEC_57_0b3_BUILD1 FENNEC_57_0b3_RELEASE FIREFOX_57_0b3_BUILD1 FIREFOX_57_0b3_RELEASE
Michael Kaply <mozilla@kaply.com> - Thu, 07 Sep 2017 19:38:55 -0500 - rev 431854
Push 7823 by ryanvm@gmail.com at 2017-09-25 15:03 +0000
Bug 1397975 - Show opt-in dialog for is_default with non built-in engines. r=aswan, a=sledru, l10n=flod MozReview-Commit-ID: 67SvzDcM7kK
29da5f3b170d: Bug 1402472 - Crashtest. a=sledru
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 23 Sep 2017 03:42:57 +0200 - rev 431853
Push 7822 by ryanvm@gmail.com at 2017-09-25 14:41 +0000
Bug 1402472 - Crashtest. a=sledru MozReview-Commit-ID: 3adJy9IKzK0 Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
1512bd018892: Bug 1402472 - servo: style: Make sure to not run any style invalidation in an unstyled children only traversal. r=bholley, a=sledru
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 22 Sep 2017 21:16:43 -0500 - rev 431852
Push 7822 by ryanvm@gmail.com at 2017-09-25 14:41 +0000
Bug 1402472 - servo: style: Make sure to not run any style invalidation in an unstyled children only traversal. r=bholley, a=sledru MozReview-Commit-ID: IFPA7LJpvsZ Source-Repo: https://github.com/servo/servo Source-Revision: 5a6b90b14ff709eab41493a05c8235c522d35250
6fe64a79307f: Bug 1402529 - Fix broken story dismissing, unintended telemetry and bug fixes to Activity Stream. r=dmose, a=sledru
Ed Lee <edilee@mozilla.com> - Fri, 22 Sep 2017 16:13:36 -0700 - rev 431851
Push 7822 by ryanvm@gmail.com at 2017-09-25 14:41 +0000
Bug 1402529 - Fix broken story dismissing, unintended telemetry and bug fixes to Activity Stream. r=dmose, a=sledru MozReview-Commit-ID: F0mYjCJcg0u
71572cf68a07: Bug 1402481 - Reverse incorrect sign of margin calculation. r=mcomella, a=sledru
Chenxia Liu <liuche@mozilla.com> - Fri, 22 Sep 2017 09:12:38 -0700 - rev 431850
Push 7822 by ryanvm@gmail.com at 2017-09-25 14:41 +0000
Bug 1402481 - Reverse incorrect sign of margin calculation. r=mcomella, a=sledru MozReview-Commit-ID: ICS81o8pLOE
627ccc1a0611: Bug 1402145 - Use adapter child position rather than view position. r=mcomella, a=sledru
Chenxia Liu <liuche@mozilla.com> - Fri, 22 Sep 2017 09:09:23 -0700 - rev 431849
Push 7822 by ryanvm@gmail.com at 2017-09-25 14:41 +0000
Bug 1402145 - Use adapter child position rather than view position. r=mcomella, a=sledru MozReview-Commit-ID: ESi8MMYC1lp
5f814a1ccc2d: Bug 1402005 - Add telemetry for Learn More clicks. r=liuche, a=sledru
Michael Comella <michael.l.comella@gmail.com> - Fri, 22 Sep 2017 17:32:03 -0700 - rev 431848
Push 7822 by ryanvm@gmail.com at 2017-09-25 14:41 +0000
Bug 1402005 - Add telemetry for Learn More clicks. r=liuche, a=sledru MozReview-Commit-ID: GA4UBZ4fpK6
6e6c8c1988a9: Bug 1402005 - Add a learn more link to Top Sites. r=liuche, a=sledru
Michael Comella <michael.l.comella@gmail.com> - Fri, 22 Sep 2017 17:04:53 -0700 - rev 431847
Push 7822 by ryanvm@gmail.com at 2017-09-25 14:41 +0000
Bug 1402005 - Add a learn more link to Top Sites. r=liuche, a=sledru Explanation of our motivations are added in code comments. In testing locally, the link I was sent to was: - https://support.mozilla.org/1/mobile/58.0a1/Android/en-US/activity-stream Existing code does not use a referrer so I didn't add one: http://searchfox.org/mozilla-central/rev/56ad02e34d0d36ca4d5ccaa885d26aff270b8ff7/mobile/android/base/java/org/mozilla/gecko/preferences/LinkPreference.java#44 MozReview-Commit-ID: GTY1ku07uWy
2ac580ab9211: Bug 1401706 - Crashtest. a=sledru
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 23 Sep 2017 04:10:22 +0200 - rev 431846
Push 7822 by ryanvm@gmail.com at 2017-09-25 14:41 +0000
Bug 1401706 - Crashtest. a=sledru MozReview-Commit-ID: Jf0n4f4kMhl
73daa36f9532: Bug 1401706 - Remove redundant UpdateValueDisplay call. r=Ehsan, a=sledru
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 22 Sep 2017 14:48:02 +0200 - rev 431845
Push 7822 by ryanvm@gmail.com at 2017-09-25 14:41 +0000
Bug 1401706 - Remove redundant UpdateValueDisplay call. r=Ehsan, a=sledru This was just moved from the old code, but we always call that function in CreateAnonymousContent, so no need to. MozReview-Commit-ID: 1zqmQM2KdpW Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
a896c16082f4: Bug 1401706 - Remove redundant boolean members from nsTextControlFrame. r=Ehsan, a=sledru
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 22 Sep 2017 07:33:41 +0200 - rev 431844
Push 7822 by ryanvm@gmail.com at 2017-09-25 14:41 +0000
Bug 1401706 - Remove redundant boolean members from nsTextControlFrame. r=Ehsan, a=sledru MozReview-Commit-ID: Ka81vlPMa88 Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
f1e83779aee9: Bug 1401706 - Remove unused macro. r=Ehsan, a=sledru
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 22 Sep 2017 07:33:30 +0200 - rev 431843
Push 7822 by ryanvm@gmail.com at 2017-09-25 14:41 +0000
Bug 1401706 - Remove unused macro. r=Ehsan, a=sledru MozReview-Commit-ID: EsvdnJkapgP Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
4d33cf91c8bd: Bug 1401706 - Move ownership of editor anon content to nsTextControlFrame. r=Ehsan, a=sledru
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 22 Sep 2017 02:18:30 +0200 - rev 431842
Push 7822 by ryanvm@gmail.com at 2017-09-25 14:41 +0000
Bug 1401706 - Move ownership of editor anon content to nsTextControlFrame. r=Ehsan, a=sledru MozReview-Commit-ID: 4QpbarX5dvf Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
fd78928b00d8: Bug 1401179 - Add snackbar for bookmark add/remove actions on newtab. r=mcomella, a=sledru
Chenxia Liu <liuche@mozilla.com> - Fri, 22 Sep 2017 18:08:07 -0700 - rev 431841
Push 7821 by ryanvm@gmail.com at 2017-09-25 14:09 +0000
Bug 1401179 - Add snackbar for bookmark add/remove actions on newtab. r=mcomella, a=sledru MozReview-Commit-ID: 7DzoyDSWmVq
3fa652b178a2: Bug 1402684 - Clear the servo data early, but the flags later, in UnbindFromTree. r=bholley, a=sledru
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 24 Sep 2017 19:16:10 +0200 - rev 431840
Push 7821 by ryanvm@gmail.com at 2017-09-25 14:09 +0000
Bug 1402684 - Clear the servo data early, but the flags later, in UnbindFromTree. r=bholley, a=sledru MozReview-Commit-ID: 5rRGKq39smW
99992ed2b3f3: Bug 1400936 - Crashtests. r=bholley, a=sledru
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 23 Sep 2017 00:12:33 +0200 - rev 431839
Push 7821 by ryanvm@gmail.com at 2017-09-25 14:09 +0000
Bug 1400936 - Crashtests. r=bholley, a=sledru MozReview-Commit-ID: 6Q07StWSog Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
ca0193447310: Bug 1400936 - Clear servo data after children data is cleared, and allow setting the root as the document if the tree is mid-unbind. r=bholley, a=sledru
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 23 Sep 2017 00:05:47 +0200 - rev 431838
Push 7821 by ryanvm@gmail.com at 2017-09-25 14:09 +0000
Bug 1400936 - Clear servo data after children data is cleared, and allow setting the root as the document if the tree is mid-unbind. r=bholley, a=sledru This is the actual fix, and makes sure that the state is consistent even if we notify of state changes on a parent during unbind. We potentially do a bit more work than needed given we set the document as the root in that case instead of the parent which could potentially be the root itself, but that's not a huge deal I think, given these cases are rare. If this happens to be a perf problem, we may want to just drop the root during UnbindFromTree if aNullParent == true and the root is a descendant of `this`. MozReview-Commit-ID: A9d2igM0hMr Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
6b96a0fab002: Bug 1400936 - Only tear down the servo data in SetXBLInsertionParent if the parent actually changed. r=bholley, a=sledru
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 23 Sep 2017 00:02:59 +0200 - rev 431837
Push 7821 by ryanvm@gmail.com at 2017-09-25 14:09 +0000
Bug 1400936 - Only tear down the servo data in SetXBLInsertionParent if the parent actually changed. r=bholley, a=sledru This is the reason similar assertion failures can't be reproduced with elements and stuff like fieldset and form validity changes. nsBindingManager::ContentRemoved calls SetXBLInsertionParent, which clears all the Servo data from the subtree eagerly, which is a waste when the actual binding parent is the same (null). MozReview-Commit-ID: A5wLKfD4OTL Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
2d4c045f3066: Bug 1400936 - Remove dumb null check. r=bholley, a=sledru
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 23 Sep 2017 00:02:30 +0200 - rev 431836
Push 7821 by ryanvm@gmail.com at 2017-09-25 14:09 +0000
Bug 1400936 - Remove dumb null check. r=bholley, a=sledru MozReview-Commit-ID: CLs2UcA8DF9 Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
c7907ac20968: Bug 1400825 - Collapse top sites if there are no sites. r=liuche, a=sledru
Michael Comella <michael.l.comella@gmail.com> - Fri, 22 Sep 2017 13:56:13 -0700 - rev 431835
Push 7821 by ryanvm@gmail.com at 2017-09-25 14:09 +0000
Bug 1400825 - Collapse top sites if there are no sites. r=liuche, a=sledru MozReview-Commit-ID: D0eNQBp6IZB
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip