9f34d0075a7300366203a37ac0155aa2198fdf7a: Bug 1512274 - Enable Checkstyle for GeckoView. r=geckoview-reviewers,nalexander,snorp
Agi Sferro <agi@mozilla.com> - Fri, 15 Mar 2019 18:10:27 +0000 - rev 522094
Push 10871 by cbrindusan@mozilla.com at Mon, 18 Mar 2019 15:49:32 +0000
Bug 1512274 - Enable Checkstyle for GeckoView. r=geckoview-reviewers,nalexander,snorp Depends on D23691 Differential Revision: https://phabricator.services.mozilla.com/D23692
6ca9fc4956d03fea17ac48547b7d412aaf31e804: Bug 1512274 - [geckoview] Remove unused imports. r=geckoview-reviewers,snorp
Agi Sferro <agi@mozilla.com> - Fri, 15 Mar 2019 18:10:05 +0000 - rev 522093
Push 10871 by cbrindusan@mozilla.com at Mon, 18 Mar 2019 15:49:32 +0000
Bug 1512274 - [geckoview] Remove unused imports. r=geckoview-reviewers,snorp Depends on D23690 Differential Revision: https://phabricator.services.mozilla.com/D23691
9a9d3c9c124a32d039969ef8c0c0624f3a80705f: Bug 1512274 - [geckoview] Avoid star imports. r=geckoview-reviewers,snorp
Agi Sferro <agi@mozilla.com> - Fri, 15 Mar 2019 18:09:52 +0000 - rev 522092
Push 10871 by cbrindusan@mozilla.com at Mon, 18 Mar 2019 15:49:32 +0000
Bug 1512274 - [geckoview] Avoid star imports. r=geckoview-reviewers,snorp Depends on D23689 Differential Revision: https://phabricator.services.mozilla.com/D23690
670e07131f14753061bf8e85f49d5de461f1fdc0: Bug 1512274 - [geckoview] Fix indentation. r=geckoview-reviewers,snorp
Agi Sferro <agi@mozilla.com> - Fri, 15 Mar 2019 18:09:14 +0000 - rev 522091
Push 10871 by cbrindusan@mozilla.com at Mon, 18 Mar 2019 15:49:32 +0000
Bug 1512274 - [geckoview] Fix indentation. r=geckoview-reviewers,snorp Depends on D23688 Differential Revision: https://phabricator.services.mozilla.com/D23689
161731389a46e2a1ff82736dea560118e6bc8f6f: Bug 1512274 - [geckoview] LeftCurly checkstyle fixes r=geckoview-reviewers,snorp
Agi Sferro <agi@mozilla.com> - Fri, 15 Mar 2019 18:08:51 +0000 - rev 522090
Push 10871 by cbrindusan@mozilla.com at Mon, 18 Mar 2019 15:49:32 +0000
Bug 1512274 - [geckoview] LeftCurly checkstyle fixes r=geckoview-reviewers,snorp Depends on D23687 Differential Revision: https://phabricator.services.mozilla.com/D23688
c34445b1db88d8ec628dbbcbd4b2b62b17f67fe9: Bug 1512274 - [geckoview] Make all private member variable be mCamelCase. r=geckoview-reviewers,snorp
Agi Sferro <agi@mozilla.com> - Fri, 15 Mar 2019 18:08:49 +0000 - rev 522089
Push 10871 by cbrindusan@mozilla.com at Mon, 18 Mar 2019 15:49:32 +0000
Bug 1512274 - [geckoview] Make all private member variable be mCamelCase. r=geckoview-reviewers,snorp Depends on D23686 Differential Revision: https://phabricator.services.mozilla.com/D23687
60897ab005748ea3b73825e6502518b6ab3684d7: Bug 1512274 - [geckoview] Make all local variables be lowerCamelCase. r=geckoview-reviewers,snorp
Agi Sferro <agi@mozilla.com> - Fri, 15 Mar 2019 18:08:42 +0000 - rev 522088
Push 10871 by cbrindusan@mozilla.com at Mon, 18 Mar 2019 15:49:32 +0000
Bug 1512274 - [geckoview] Make all local variables be lowerCamelCase. r=geckoview-reviewers,snorp Depends on D23685 Differential Revision: https://phabricator.services.mozilla.com/D23686
5d02f27fe1747a473a400e8473dc3acf0a365ea1: Bug 1512274 - [geckoview] Make all constants actually final. r=geckoview-reviewers,snorp
Agi Sferro <agi@mozilla.com> - Fri, 15 Mar 2019 18:08:40 +0000 - rev 522087
Push 10871 by cbrindusan@mozilla.com at Mon, 18 Mar 2019 15:49:32 +0000
Bug 1512274 - [geckoview] Make all constants actually final. r=geckoview-reviewers,snorp Depends on D23684 Differential Revision: https://phabricator.services.mozilla.com/D23685
380cdbe5557c86bed91f985824cee75321ee282c: Bug 1512274 - [geckoview] Make all argument names be lowerCamelCase. r=geckoview-reviewers,snorp
Agi Sferro <agi@mozilla.com> - Fri, 15 Mar 2019 18:08:38 +0000 - rev 522086
Push 10871 by cbrindusan@mozilla.com at Mon, 18 Mar 2019 15:49:32 +0000
Bug 1512274 - [geckoview] Make all argument names be lowerCamelCase. r=geckoview-reviewers,snorp Depends on D23683 Differential Revision: https://phabricator.services.mozilla.com/D23684
58642fa9c95b0aad2f6adae8b8005f17e41541fc: Bug 1512274 - [geckoview] Add final to all methods in GeckoView. r=geckoview-reviewers,snorp
Agi Sferro <agi@mozilla.com> - Fri, 15 Mar 2019 18:08:36 +0000 - rev 522085
Push 10871 by cbrindusan@mozilla.com at Mon, 18 Mar 2019 15:49:32 +0000
Bug 1512274 - [geckoview] Add final to all methods in GeckoView. r=geckoview-reviewers,snorp Depends on D23682 Differential Revision: https://phabricator.services.mozilla.com/D23683
3812d67603799766ab89a8ee5d4fdfd1c376d0ce: Bug 1512274 - [geckoview] Don't change value of method arguments. r=geckoview-reviewers,snorp
Agi Sferro <agi@mozilla.com> - Fri, 15 Mar 2019 18:08:34 +0000 - rev 522084
Push 10871 by cbrindusan@mozilla.com at Mon, 18 Mar 2019 15:49:32 +0000
Bug 1512274 - [geckoview] Don't change value of method arguments. r=geckoview-reviewers,snorp Differential Revision: https://phabricator.services.mozilla.com/D23682
b063e2b487b6691582a935b3a407abcd5bc26782: Bug 1532997 - Properly await the default engines restoration process to finish, before refreshing the list in about:preferences. r=florian
Mike de Boer <mdeboer@mozilla.com> - Fri, 15 Mar 2019 11:41:08 +0000 - rev 522083
Push 10871 by cbrindusan@mozilla.com at Mon, 18 Mar 2019 15:49:32 +0000
Bug 1532997 - Properly await the default engines restoration process to finish, before refreshing the list in about:preferences. r=florian Differential Revision: https://phabricator.services.mozilla.com/D23646
0b05d8817659edbbccb23a92be96105c2a0805c9: Bug 1532748 - Properly signal error in getPossibleBreakpoints error case. r=jorendorff
Logan Smyth <loganfsmyth@gmail.com> - Fri, 15 Mar 2019 17:10:17 +0000 - rev 522082
Push 10871 by cbrindusan@mozilla.com at Mon, 18 Mar 2019 15:49:32 +0000
Bug 1532748 - Properly signal error in getPossibleBreakpoints error case. r=jorendorff Differential Revision: https://phabricator.services.mozilla.com/D23702
f6a8502a80bfdab610ea7343c6e7d21fb7e17da0: Bug 1533362 - Record contentBlockingEvent for background tabs. r=Ehsan
Johann Hofmann <jhofmann@mozilla.com> - Fri, 15 Mar 2019 17:37:26 +0000 - rev 522081
Push 10871 by cbrindusan@mozilla.com at Mon, 18 Mar 2019 15:49:32 +0000
Bug 1533362 - Record contentBlockingEvent for background tabs. r=Ehsan When switching tabs we use the securityUI.contentBlockingEvent property to update the shield state. That property is set in https://searchfox.org/mozilla-central/rev/aae527894a97ee3bbe0c2cfce9c67c59e8b8fcb9/browser/base/content/browser.js#5025. Unfortunately, that event is only received by the current browser because is is registered with gBrowser.addProgressListener instead of gBrowser.addTabsProgressListener. Thus, the background tab is not storing its content blocking event. To fix this, we also listen for content blocking events with addTabsProgressListener, but exclude the currently selected tab there. Differential Revision: https://phabricator.services.mozilla.com/D23485
8937817294094795018b3bb908fb78b4fa9416aa: Bug 1534737: use new tooltool packages with updates to adb r=gbrown
Andrew Erickson <aerickson@mozilla.com> - Fri, 15 Mar 2019 17:10:15 +0000 - rev 522080
Push 10871 by cbrindusan@mozilla.com at Mon, 18 Mar 2019 15:49:32 +0000
Bug 1534737: use new tooltool packages with updates to adb r=gbrown Differential Revision: https://phabricator.services.mozilla.com/D23534
3204779395ce6e90bfb39558484641a2d63d2fa7: Bug 1506510 - add/fix keyboard focus styling for notification and blocked permission icon buttons. r=dao
Yura Zenevich <yura.zenevich@gmail.com> - Fri, 15 Mar 2019 16:01:43 +0000 - rev 522079
Push 10871 by cbrindusan@mozilla.com at Mon, 18 Mar 2019 15:49:32 +0000
Bug 1506510 - add/fix keyboard focus styling for notification and blocked permission icon buttons. r=dao Differential Revision: https://phabricator.services.mozilla.com/D23557
19ec728351acee967f424397f9f3e1b11e11c0f3: Bug 1506510 - add keyboard focus styling for toolbar/urlbar buttons. r=dao
Yura Zenevich <yura.zenevich@gmail.com> - Fri, 15 Mar 2019 04:35:09 +0000 - rev 522078
Push 10871 by cbrindusan@mozilla.com at Mon, 18 Mar 2019 15:49:32 +0000
Bug 1506510 - add keyboard focus styling for toolbar/urlbar buttons. r=dao Differential Revision: https://phabricator.services.mozilla.com/D19958
1391a8e0183535b6f56586c844d2bbcc543e8237: Bug 1535649 - [marionette] Fix check for Fennec if app argument doesn't exist. r=ato
Henrik Skupin <mail@hskupin.info> - Fri, 15 Mar 2019 16:12:47 +0000 - rev 522077
Push 10871 by cbrindusan@mozilla.com at Mon, 18 Mar 2019 15:49:32 +0000
Bug 1535649 - [marionette] Fix check for Fennec if app argument doesn't exist. r=ato It's just "fennec" we have to compare with. So no need for an included check. Differential Revision: https://phabricator.services.mozilla.com/D23693
4b6ece1be5c2d4a095c42cf76bdc42120f0da872: Bug 1535651. Whitelist std::__pair_base as memmovable for static analysis purposes. r=emilio
Boris Zbarsky <bzbarsky@mit.edu> - Fri, 15 Mar 2019 16:17:52 +0000 - rev 522076
Push 10871 by cbrindusan@mozilla.com at Mon, 18 Mar 2019 15:49:32 +0000
Bug 1535651. Whitelist std::__pair_base as memmovable for static analysis purposes. r=emilio In at least some libstdc++ versions, std::pair (which we want to be memmovable) inherits from __pair_base. We have a similar setup already for __atomic_base. Differential Revision: https://phabricator.services.mozilla.com/D23698
e05c19c17c88d69bbad0646b3839564a082179a3: Bug 1534661 - Fix the QuantumBar results view to have an accessible role of ROLE_COMBOBOX_LIST. r=dao
Mark Banner <standard8@mozilla.com> - Fri, 15 Mar 2019 16:43:11 +0000 - rev 522075
Push 10871 by cbrindusan@mozilla.com at Mon, 18 Mar 2019 15:49:32 +0000
Bug 1534661 - Fix the QuantumBar results view to have an accessible role of ROLE_COMBOBOX_LIST. r=dao Differential Revision: https://phabricator.services.mozilla.com/D23155
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 tip