9d8b5d05ff0e6c25cd6911b9d44ea0c8499cd4f8: Bug 1392067 - Disconnect open extension ports when the message manager goes away r=zombie
Rob Wu <rob@robwu.nl> - Fri, 06 Apr 2018 19:52:16 +0100 - rev 469073
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1392067 - Disconnect open extension ports when the message manager goes away r=zombie - Previously, if a port is disconnected by the other end, then memory would be leaked to `ProxyMessenger.ports` in ExtensionParent.jsm. To fix this, the port descriptor is now saved separately, keyed by port ID instead of message manager. - Previously, when a message manager was disconnected (e.g. window closed/tab crashed), the port is disconnected only if the port was created from that page. This patch adds bookkeeping to keep track of the message managers at both the sender and receiver's side, so that the port is always disconnected when the other side goes away. - The new test browser_ext_port_disconnect_on_crash.js checks whether the ports are disconnected as expected. Previously, the subtest connect_from_tab_to_bg_and_crash_tab failed because of the previous point. - Although not as deterministic as the crash test, the new browser_ext_port_disconnect_on_window_close.js reproduces the original test failure and serves as a regression test for the bug. - Previously, the data structure in ProxyMessenger.ports contained the original `sender` and `recipient`. For the purpose of sending port disconnection messages, these are not necessary and therefore they have been removed. - Fix incorrect JSDoc (type of portId is number, not string) MozReview-Commit-ID: BoaKRVAUKuq
1374936db0183b95619f8e312c377f5a784e59bd: Bug 1323557 - preserve vendored crates when re-vendoring; r=ted.mielczarek
Myk Melez <myk@mykzilla.org> - Fri, 20 Apr 2018 11:53:10 -0700 - rev 469072
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1323557 - preserve vendored crates when re-vendoring; r=ted.mielczarek `mach vendor rust` currently removes third_party/rust before `cargo update`, which prevents modifying vendored crates for local testing and try pushes. It's also unnecessary. So this patch removes the code that removes the dir. MozReview-Commit-ID: IE0FZ3of8Py
d83f412c924cf989b94928b5eed23732e8015b82: Bug 1450975 - Load themes without an accentcolor. r=jaws
Tim Nguyen <ntim.bugs@gmail.com> - Mon, 16 Apr 2018 10:24:48 +0200 - rev 469071
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1450975 - Load themes without an accentcolor. r=jaws MozReview-Commit-ID: 2EGsaajHZfM
c4b87fb85648eb1309d3135489371a0a713b366f: Bug 1456115 - Increase stack sizes when using audioipc. r=jya
Paul Adenot <paul@paul.cx> - Wed, 25 Apr 2018 12:28:14 +0200 - rev 469070
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1456115 - Increase stack sizes when using audioipc. r=jya This patch set calls a bit deeper in the audio callback thread (down into opus, in particular). MozReview-Commit-ID: 6LWACS6V0Yz
956b62a9c5a437c2bfdfac6605332283f9c14086: Bug 1456115 - Make last_sample_rate_ in `neteq_impl.cc` atomic. r=dminor
Paul Adenot <paul@paul.cx> - Mon, 23 Apr 2018 11:55:19 +0200 - rev 469069
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1456115 - Make last_sample_rate_ in `neteq_impl.cc` atomic. r=dminor This allows removing locking, and allows other threads to progress without taking the lock, hence lowering the probability that the lock will be taken for a long time when we need to pull NeqEQ. MozReview-Commit-ID: HMO67A0hher
4a1df66695dd96b715503b2a27359471de6c57e4: Bug 1456115 - Re-serialize inbound NotifyPull. r=jya
Paul Adenot <paul@paul.cx> - Thu, 12 Apr 2018 14:23:03 +0200 - rev 469068
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1456115 - Re-serialize inbound NotifyPull. r=jya We made NotifyPull parallel to try to lower the load, and we initially measured an improvement. However, we did the measurements with a profiler that did an aggregation of the results. Our results had an high variance, so the mean load was in fact not meaningful. More careful measurement performed without doing any aggregation show that, under load, relying on the fact that the scheduler schedules the tasks on time is too risky, and that the code is fast enough to not have to parallelize. MozReview-Commit-ID: CMhSn8Sc0OO
290879198eb4a7d2b7ecfd5ba07b38ea31710529: Bug 1456115 - Remove locking in AcmReceiver::GetAudio. r=dminor
Paul Adenot <paul@paul.cx> - Thu, 12 Apr 2018 14:36:02 +0200 - rev 469067
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1456115 - Remove locking in AcmReceiver::GetAudio. r=dminor This also causes a lot of dropouts. We don't need to lock here. NetEQ is thread safe, and its created in the ctor. The rest of the members are made atomic or is simply never accessed in multiple threads. MozReview-Commit-ID: 2fRw5ZgxdpQ
91e41f6d1baf9234ae8664d7573e5c12d6bade83: Bug 1456115 - Stop locking when getting the sampling rate from the channel in acm_receiver.cc. r=dminor
Paul Adenot <paul@paul.cx> - Mon, 09 Apr 2018 13:52:08 +0200 - rev 469066
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1456115 - Stop locking when getting the sampling rate from the channel in acm_receiver.cc. r=dminor This accounts for half of our audio dropouts, there is very high contention on this piece of data. MozReview-Commit-ID: 2HSfqZHT2MK
8c7afd58f201b43eaaae4ebb9f156e21269385dc: Bug 1456617 - Remove empty rulesets from aboutMemory.css. r=Gijs
Jared Wein <jwein@mozilla.com> - Tue, 24 Apr 2018 13:10:18 -0700 - rev 469065
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1456617 - Remove empty rulesets from aboutMemory.css. r=Gijs MozReview-Commit-ID: 7jQFTt0cAFu
bb0bb35465d9161f35e06f677df2956afea254a4: Bug 1455990 - Update the no-results-message selector since it changed from a className to an ID. r=sfoster
Jared Wein <jwein@mozilla.com> - Tue, 24 Apr 2018 13:33:57 -0700 - rev 469064
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1455990 - Update the no-results-message selector since it changed from a className to an ID. r=sfoster MozReview-Commit-ID: 8w0dCpBjisH
be0a9b78c2242fcc4eb2545d7fe5b58fecd250e7: Bug 1451307 - Part 3 - Add a test for showing the TP UI for iframes and unloaded documents. r=francois
Johann Hofmann <jhofmann@mozilla.com> - Thu, 19 Apr 2018 22:37:49 +0200 - rev 469063
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1451307 - Part 3 - Add a test for showing the TP UI for iframes and unloaded documents. r=francois MozReview-Commit-ID: FrcwyIbBTFL
13e58d5887d8b8dae297577abe1d15edf254cd44: Bug 1451307 - Part 2 - Move trackingUI tests out of b/b/c/test/general into their own subdirectory. r=Gijs
Johann Hofmann <jhofmann@mozilla.com> - Thu, 19 Apr 2018 17:22:11 +0200 - rev 469062
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1451307 - Part 2 - Move trackingUI tests out of b/b/c/test/general into their own subdirectory. r=Gijs MozReview-Commit-ID: 5e2Hwt9jcX5
7f89d94d45bad5bb387568d935e8dff69312fd7b: Bug 1451307 - Part 1 - Consider iframes when comparing loading URIs in nsChannelClassifier::SetBlockedContent. r=francois,mayhemer
Johann Hofmann <jhofmann@mozilla.com> - Thu, 19 Apr 2018 17:21:58 +0200 - rev 469061
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1451307 - Part 1 - Consider iframes when comparing loading URIs in nsChannelClassifier::SetBlockedContent. r=francois,mayhemer MozReview-Commit-ID: 17edGCCTEmo
bc6609dd306dc303009b0bf254ecf9e70360e348: Bug 1456682 - Remove nsIDOMXULTreeElement;r=bz
Brian Grinstead <bgrinstead@mozilla.com> - Wed, 25 Apr 2018 06:58:56 -0700 - rev 469060
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1456682 - Remove nsIDOMXULTreeElement;r=bz MozReview-Commit-ID: 2QstcmlXh9S
842b7bc6ad24c5e0df37949636b797560cb07a70: Bug 1456630 - Stop checking for Vista or earlier in GMPUtils, since those verisons of Windows aren't supported anymore. r=cpearce
Mike Conley <mconley@mozilla.com> - Tue, 24 Apr 2018 17:00:53 -0400 - rev 469059
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1456630 - Stop checking for Vista or earlier in GMPUtils, since those verisons of Windows aren't supported anymore. r=cpearce This should help us avoid doing some main-thread IO during start-up, since we won't need to init an nsSystemInfo object (which touches disk). MozReview-Commit-ID: IvzHSdzRHGL
c8c27bdc5f543b688f23104afab52bfcded76ec7: Bug 1441707 - Add automation URLs for ProgressListenerTest; r=gbrown
Jim Chen <nchen@mozilla.com> - Tue, 24 Apr 2018 01:04:29 -0400 - rev 469058
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1441707 - Add automation URLs for ProgressListenerTest; r=gbrown Add URLs to use when running ProgressListenerTest in automation. MozReview-Commit-ID: GzRsMuTl0uA
204bb43af94351678a0a639bbc0bc7476e91d3aa: Bug 356831 - Proxy autodiscovery doesn't check DHCP (option 252) r=bagder,valentin
Polly Shaw <polly.shaw@gmail.com> - Sun, 22 Apr 2018 18:13:11 +0100 - rev 469057
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 356831 - Proxy autodiscovery doesn't check DHCP (option 252) r=bagder,valentin This patch addresses an issue with Firefox's proxy detection on networks which do not have their a proxy auto-configuration (PAC) file hosted at http://wpad/wpad.dat, and instead make use of DHCP option 252 for broadcasting the address of the PAC file. See https://findproxyforurl.com/wpad-introduction/ for an introduction to the protocol. Prior to this patch, proxy auto-detect missed out the DHCP query stage, and just looked for a PAC file at http://wpad/wpad.dat This patch only addresses the issue for Firefox on Windows, although it defines a DHCP client interface which could be implemented on other platforms. The high-level components of this patch are: * nsIDHCPClient.idl - this is an interface which has been defined for querying the DHCP server. * nsPACMan.cpp - where previously when the PAC URL was simply set to a constant of http://wpad/wpad.dat, it now dispatches an asynchronous command to the proxy thread. The class ExecutePACThreadAction has been augmented to include an instruction to 'ConfigureWPAD' (Configure Web-proxy auto-detect), and a new class, 'ConfigureWPADComplete' has been created to relay the result (the URL of the PAC file) back to the nsPACMan object. * nsProtocolProxyService.cpp Minor changes to reflect the fact that the PAC URL not being set does not always mean there is no PAC to be used; instead it could be in the process of being detected. * TestPACMan.cpp This is a new file, and tests only the DHCP auto-detect functionality. Some tests use multiple threads, as they test the non-blocking proxy detection. * DHCPUtils.cpp A class containing the main logic for querying DHCP. * WindowsNetworkFunctionsWrapper.cpp A very thin wrapper around the Windows API calls needed by DHCPUtils. This class was introduced so it could be mocked out in tests. * nsWindowsDHCPClient.cpp * An implementation of the interface defined in nsIDHCPClient.idl. Fairly thin: most logic is implemented in DHCPUtils. * TestDHCPUtils.cpp Tests for DHCPUtils and nsWindowsDHCPClient MozReview-Commit-ID: HinC1UevOon
e9b1d02e24f0f461032e80005d32aa00ec87d775: Bug 1449608 - Avoid calling ComputeScrollMetadata repeatedly for same scroll frame and clip. r=mstange
Jamie Nicol <jnicol@mozilla.com> - Thu, 19 Apr 2018 14:48:04 +0100 - rev 469056
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1449608 - Avoid calling ComputeScrollMetadata repeatedly for same scroll frame and clip. r=mstange Currently in ContainerState::SetupScrollingMetadata we call ComputeScrollMetadata for every layer and for each ASR in the layer's clip chain. If there are many sibling layers with the same clip then this is largely wasted work. This change makes us cache the most recently calculated result, and only recalculate if the ASR or clip is different. There was a small portion of ComputeScrollMetadata that must actually be executed for every layer and ASR in its clip chain. This has been moved to a separate function, ClipLayerToDisplayPort, that is still called every time. MozReview-Commit-ID: 7Zzblmimtc5
df424e9d891040d48498770a5f33a9a6dea85b8f: Bug 1435370 - Replace shape editor icon. r=pbro
Razvan Caliman <rcaliman@mozilla.com> - Wed, 25 Apr 2018 12:46:58 +0200 - rev 469055
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1435370 - Replace shape editor icon. r=pbro MozReview-Commit-ID: B3XQrtwacF9
fdce8946a71961ba725a1e3c78ef0faab8bf4857: Bug 1451842 - [mix] Search engine setup for Firefox Mobile for Mixtepec Mixtec, r=flod
Delphine Lebédel <dlebedel@mozilla.com> - Tue, 24 Apr 2018 13:01:00 -0700 - rev 469054
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1451842 - [mix] Search engine setup for Firefox Mobile for Mixtepec Mixtec, r=flod MozReview-Commit-ID: qjXgogzhkm
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip