99b3207cda021ab6c393dac4533321284772afbd: Backed out changeset b57ec6985cd1 (bug 1531632) for Geckoview failures. CLOSED TREE
Dorel Luca <dluca@mozilla.com> - Thu, 07 Mar 2019 02:29:50 +0200 - rev 520677
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Backed out changeset b57ec6985cd1 (bug 1531632) for Geckoview failures. CLOSED TREE
248ccbf196f4bf728bef039871a899cca81f9d7f: Bug 1524435 - Stop using JSRope::new_<NoGC> when allocating test ropes r=jonco
Steve Fink <sfink@mozilla.com> - Thu, 07 Mar 2019 00:27:57 +0000 - rev 520676
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1524435 - Stop using JSRope::new_<NoGC> when allocating test ropes r=jonco Differential Revision: https://phabricator.services.mozilla.com/D22033
ad613d1154eb910dbceeac5dff7585a1ce8d0c52: Bug 1530029 - Turn on the signon.showAutoCompleteFooter pref. r=MattN
prathiksha <prathikshaprasadsuman@gmail.com> - Thu, 07 Mar 2019 00:06:46 +0000 - rev 520675
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1530029 - Turn on the signon.showAutoCompleteFooter pref. r=MattN Differential Revision: https://phabricator.services.mozilla.com/D22425
21d6040d2bd8c083b22965c39bda6702159e0238: Bug 1530029 - Pressing enter on the autocomplete footer should open the password manager dialog. r=MattN
prathiksha <prathikshaprasadsuman@gmail.com> - Thu, 07 Mar 2019 00:06:42 +0000 - rev 520674
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1530029 - Pressing enter on the autocomplete footer should open the password manager dialog. r=MattN Differential Revision: https://phabricator.services.mozilla.com/D21603
f9b3bcda4ab978e63b2aaf38b14db674fb794b5b: Bug 1531313: reenable dom/base/test/test_progress_events_for_gzip_data.html for android r=gbrown,jkt
Andrew Erickson <aerickson@mozilla.com> - Wed, 06 Mar 2019 20:57:04 +0000 - rev 520673
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1531313: reenable dom/base/test/test_progress_events_for_gzip_data.html for android r=gbrown,jkt Differential Revision: https://phabricator.services.mozilla.com/D21590
e0d3d93f0275d11a50ffeb286f1d7224401f5a12: Bug 1524610: Add a document for Reference Browser. r=jdescottes,agi,snorp
Daisuke Akatsuka <dakatsuka@mozilla.com> - Wed, 06 Mar 2019 23:57:16 +0000 - rev 520672
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1524610: Add a document for Reference Browser. r=jdescottes,agi,snorp Depends on D19106 Differential Revision: https://phabricator.services.mozilla.com/D19465
f7677d79738b9117c8cc8ad2e9a4efce7f7dd935: Bug 1524610: Add a document for building GeckoView Example. r=jdescottes,m_kato
Daisuke Akatsuka <dakatsuka@mozilla.com> - Fri, 22 Feb 2019 04:00:29 +0000 - rev 520671
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1524610: Add a document for building GeckoView Example. r=jdescottes,m_kato Differential Revision: https://phabricator.services.mozilla.com/D19106
4f6e4cbf401f4e32bfa4431b6ee2e003f8faa832: Backed out 6 changesets (bug 1353956) for Linux Build bustage
Dorel Luca <dluca@mozilla.com> - Thu, 07 Mar 2019 01:49:03 +0200 - rev 520670
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Backed out 6 changesets (bug 1353956) for Linux Build bustage Backed out changeset 71dafccc22ae (bug 1353956) Backed out changeset f1f29fe519cf (bug 1353956) Backed out changeset 4978556a66f6 (bug 1353956) Backed out changeset bc0b91abce9b (bug 1353956) Backed out changeset 6b8412db5a05 (bug 1353956) Backed out changeset 3d326cfcd002 (bug 1353956)
edb56e9a487b9f3eb96688d39ddd6bc662947a23: Bug 1532570 - nsDOMCSSDeclaration::SetProperty should check for the "important" string in a case-insensitive way. r=emilio
hrdktg <hrdktg@gmail.com> - Wed, 06 Mar 2019 23:36:23 +0000 - rev 520669
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1532570 - nsDOMCSSDeclaration::SetProperty should check for the "important" string in a case-insensitive way. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D22423
35b20b5040638d1c4a055c360a3913606975f5f1: Bug 1533142 - followup: Fix Windows MinGW bustage. r=me
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 07 Mar 2019 00:32:58 +0100 - rev 520668
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1533142 - followup: Fix Windows MinGW bustage. r=me
49d30719700f4cee5d837e35464ebc274b8eeaf5: Bug 1533088: Initialize member-var FlexItem::mAlignSelfFlags to zero, in the legacy-box and 'visibility:collapse' FlexItem scenarios. r=heycam
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 06 Mar 2019 23:11:19 +0000 - rev 520667
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1533088: Initialize member-var FlexItem::mAlignSelfFlags to zero, in the legacy-box and 'visibility:collapse' FlexItem scenarios. r=heycam Differential Revision: https://phabricator.services.mozilla.com/D22350
005cf12d04d0bf5ad0f2f7ac917f90e1b440e0b8: No bug - fix a typo.
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 07 Mar 2019 00:14:43 +0100 - rev 520666
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
No bug - fix a typo. DONTBUILD
37fc9c97e0d2493db260631ad2c4a548fac71ec1: Bug 1532135 - followup: Add a comment as requested on Phabricator.
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 07 Mar 2019 00:14:06 +0100 - rev 520665
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1532135 - followup: Add a comment as requested on Phabricator.
71dafccc22ae493b656d9130cec82ba37d4babf7: Bug 1353956 - P6. Load the old prefixset(.pset) when there is no .vlpset. r=gcp
dlee <dlee@mozilla.com> - Wed, 06 Mar 2019 09:41:34 +0000 - rev 520664
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1353956 - P6. Load the old prefixset(.pset) when there is no .vlpset. r=gcp To avoid forcing a redownload of SafeBrowsing v4 list. Differential Revision: https://phabricator.services.mozilla.com/D21876
f1f29fe519cf169d43eeacfe710d0b84e9da55db: Bug 1353956 - P5. Remove old v4 prefix files after new files are stored. r=gcp
dlee <dlee@mozilla.com> - Tue, 05 Mar 2019 18:32:23 +0000 - rev 520663
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1353956 - P5. Remove old v4 prefix files after new files are stored. r=gcp This patch is to cleanup old SafeBrowsing v4 prefix files. Differential Revision: https://phabricator.services.mozilla.com/D21464
4978556a66f66cd6d214f98aa656ea1e223ead63: Bug 1353956 - P4. Add header and CRC32 checksum to SafeBrowsing V4 prefix files. r=gcp
dlee <dlee@mozilla.com> - Wed, 06 Mar 2019 22:57:12 +0000 - rev 520662
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1353956 - P4. Add header and CRC32 checksum to SafeBrowsing V4 prefix files. r=gcp After this patch, we may have the following files in SafeBrowsing directory: - (v2) .sbstore : Store V2 chunkdata, for update, MD5 integrity check while load - (v2) .pset : Store V2 prefixset, for lookup, load upon startup, no integrity check - (v4) .metadata : Store V4 state, for update, no integrity check - (v4) .vlpset : Store V4 prefixset, for lookup, load upon startup, CRC32 integrity check - (v4) .pset : V4 prefix set before this patch, should be removed The magic string is also added to ".vlpset" header so we can add a telemetry to see if sanity check is good enough for prefix set integrity check (The telemetry is not yet added). If yes, we can remove the CRC32 in the future for even better performance. Differential Revision: https://phabricator.services.mozilla.com/D21463
bc0b91abce9bcb43ef501dfa7bca03ea678f9783: Bug 1353956 - P3. Separate file processing and prefix data processing for SafeBrowsing prefix set. r=gcp
Dimi Lee <dlee@mozilla.com> - Mon, 04 Mar 2019 21:22:46 +0000 - rev 520661
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1353956 - P3. Separate file processing and prefix data processing for SafeBrowsing prefix set. r=gcp SafeBrowsing prefix files LOAD/SAVE operations are handled in xxxPrefixSet.cpp. It would be more clear if xxxPrefixSet.cpp only processes prefix data, while LookupCacheV2/LookupCacheV4 which use prefix set process file. This patch doesn't change any behavior, testcases need to update because the LookupCache & xxxPrefixSet APIs are changed. Differential Revision: https://phabricator.services.mozilla.com/D21462
6b8412db5a05f12bf44b5abc1bf553ed356da41f: Bug 1353956 - P2. Do not use SHA-256 while loading the V4 prefix files. r=gcp
dlee <dlee@mozilla.com> - Thu, 28 Feb 2019 08:18:46 +0000 - rev 520660
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1353956 - P2. Do not use SHA-256 while loading the V4 prefix files. r=gcp SHA256 is an expensive operation, we should avoid using them if possible. SafeBrowsing prefix files are loaded during startup and verify integrity with SHA256 which may affect the performance especially on the low-end device. This patch simply removes the SHA256 integrity check. CRC32 version integrity check will be introduced in the other patch. This patch also changes the behavior of recording "Telemetry::URLCLASSIFIER_VLPS_LOAD_CORRUPT" a little bit. It used to records only once per session(during startup, the first time we load prefix set), now it records per update. Differential Revision: https://phabricator.services.mozilla.com/D21461
3d326cfcd002b1c9598151ae5d39bbc9051524f3: Bug 1353956 - P1. Rename checksum used in SafeBrowsing V4 to SHA256. r=gcp
Dimi Lee <dlee@mozilla.com> - Thu, 28 Feb 2019 08:12:36 +0000 - rev 520659
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1353956 - P1. Rename checksum used in SafeBrowsing V4 to SHA256. r=gcp SafeBrowsing V4 protocol use SHA-256 as the checksum to check integrity of update data and also the integrity of prefix files. SafeBrowsing V2 HashStore use MD5 as the checksum to check integrity of .sbstore Since we are going to use CRC32 as the integrity check of V4 prefix files, I think rename V4 "checksum" to SHA256 can improve readability. Differential Revision: https://phabricator.services.mozilla.com/D21460
e647490b3655a5518a296ab09d164085ac21eacd: Bug 1525395 - Part 2: Rewrite a Scratchpad test to eliminate some race conditions. r=jimb
Jason Orendorff <jorendorff@mozilla.com> - Wed, 06 Mar 2019 23:04:01 +0000 - rev 520658
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1525395 - Part 2: Rewrite a Scratchpad test to eliminate some race conditions. r=jimb I don't understand how the test ever worked. I think the idea was that each operation would result in changes to the prefs, because those prefs are the source of truth for the recent-files list. However, I don't understand why some tests would not trigger multiple observer callbacks, which should have been a huge mess. The new code doesn't observe the prefs at all. Where possible, it waits for an appropriate promise; in other places it uses `setTimeout()` to wait for the next tick, relying on the Scratchpad implementation to be done reacting by then. Since the original code was event-driven, most tests were split across two functions. Each test function had the bottom half of one test and the top half of the next test. The new code uses async/await and can therefore at least group related functionality into single cohesive test functions. But those test functions aren't as independent as they look -- most of them still depend on previous tests to set up the expected starting state. Differential Revision: https://phabricator.services.mozilla.com/D20759
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 tip