98b3c3a9c2732dd58a6e74c6d19deb53060dd5bf: Bug 1249288 - review: Correct concurrency issues with searchEngineManager. r=sebastian a=ritu
Michael Comella <michael.l.comella@gmail.com> - Thu, 24 Mar 2016 11:18:58 -0700 - rev 323983
Push 5913 by jlund@mozilla.com at Mon, 25 Apr 2016 16:57:49 +0000
Bug 1249288 - review: Correct concurrency issues with searchEngineManager. r=sebastian a=ritu Additionally, added WeakReferences to the SEM in its callbacks so we can GC ASAP if the Activity (and thus the SEM) gets GC'd. This is important since we hold a reference to Context which can be a rather large object. Furthermore, I added some related thread annotations where I felt they were useful. MozReview-Commit-ID: KaWlw14uOoN
a5801fb8ba648ee9a98a75479c7743d408cc43b9: Bug 1249288 - Update telemetry docs to include defaultSearch. r=gfritzsche,rnewman a=ritu
Michael Comella <michael.l.comella@gmail.com> - Thu, 10 Mar 2016 16:23:13 -0800 - rev 323982
Push 5913 by jlund@mozilla.com at Mon, 25 Apr 2016 16:57:49 +0000
Bug 1249288 - Update telemetry docs to include defaultSearch. r=gfritzsche,rnewman a=ritu MozReview-Commit-ID: 4pihITjabns
c046a7887ffa94a050cd44455ab06a7f37e84519: Bug 1249288 - Don't call SearchEngineManager change callback if it's null. r=margaret a=ritu
Michael Comella <michael.l.comella@gmail.com> - Tue, 23 Feb 2016 18:11:57 -0800 - rev 323981
Push 5913 by jlund@mozilla.com at Mon, 25 Apr 2016 16:57:49 +0000
Bug 1249288 - Don't call SearchEngineManager change callback if it's null. r=margaret a=ritu The callback may be null if setChangeCallback is never called and would cause a crash. MozReview-Commit-ID: BNd16Db1A8Q
130280323942f6d099e145bb2fcd8818f3ac920f: Bug 1249288 - Add default search engine to core ping. r=rnewman a=ritu
Michael Comella <michael.l.comella@gmail.com> - Thu, 10 Mar 2016 16:00:15 -0800 - rev 323980
Push 5913 by jlund@mozilla.com at Mon, 25 Apr 2016 16:57:49 +0000
Bug 1249288 - Add default search engine to core ping. r=rnewman a=ritu The default search engine attribute may be null in the core ping if we haven't been able to retrieve the value yet. It's unclear when this might be, but the possibility is in the javadoc of `SearchEngineManager.getEngine`. MozReview-Commit-ID: IrJB6GyjyTO
616c474808cc2cfe6697967ba4b9e5cefb13fcef: Bug 1249288 - Move om.search.providers.SearchEngine\* to omg.search. r=nalexander a=ritu
Michael Comella <michael.l.comella@gmail.com> - Tue, 23 Feb 2016 17:27:24 -0800 - rev 323979
Push 5913 by jlund@mozilla.com at Mon, 25 Apr 2016 16:57:49 +0000
Bug 1249288 - Move om.search.providers.SearchEngine\* to omg.search. r=nalexander a=ritu We want to reuse this code for the main Activity. MozReview-Commit-ID: BZxIrgmJI2r
1a229bf7891d7b453eb6e5269c11ace513e400a4: Bug 1256547: When the DWM is disabled don't force presentation. r=milan a=rkothari
Bas Schouten <bschouten@mozilla.com> - Mon, 11 Apr 2016 13:08:00 +0200 - rev 323978
Push 5913 by jlund@mozilla.com at Mon, 25 Apr 2016 16:57:49 +0000
Bug 1256547: When the DWM is disabled don't force presentation. r=milan a=rkothari
3e665a8f5cc0b2a4ae356b4fcf981d41d7ae4be8: Bug 1260415 - Use revision as tag r=coop a=release DONTBUILD
Rail Aliiev <rail@mozilla.com> - Fri, 15 Apr 2016 23:14:48 -0400 - rev 323977
Push 5913 by jlund@mozilla.com at Mon, 25 Apr 2016 16:57:49 +0000
Bug 1260415 - Use revision as tag r=coop a=release DONTBUILD MozReview-Commit-ID: 3cZe5ieNndK
72bdf0a085a53a9ff83511bee4dcc353731866a7: Bug 1264786 - Update Google search plugin; r=mconnor, a=lizzard
Michael Kaply <mozilla@kaply.com> - Mon, 18 Apr 2016 09:22:40 -0500 - rev 323976
Push 5913 by jlund@mozilla.com at Mon, 25 Apr 2016 16:57:49 +0000
Bug 1264786 - Update Google search plugin; r=mconnor, a=lizzard
ae136454b6b76b79a5bf9498fe262c75bd03c763: Bug 1258313 - Allow snapping of 'pseudo' 3d transforms. r=jrmuizel, a=ritu
Matt Woodrow <mwoodrow@mozilla.com> - Wed, 06 Apr 2016 15:29:32 +1200 - rev 323975
Push 5913 by jlund@mozilla.com at Mon, 25 Apr 2016 16:57:49 +0000
Bug 1258313 - Allow snapping of 'pseudo' 3d transforms. r=jrmuizel, a=ritu
c0d6effecccbae1a3105e231428947d5c0d23ded: Bug 1264227: lighten the box shadow inside the navbar on Linux to match the active tab highlight color. r=Gijs, a=lizzard
Mike de Boer <mdeboer@mozilla.com> - Thu, 14 Apr 2016 12:22:13 +0200 - rev 323974
Push 5913 by jlund@mozilla.com at Mon, 25 Apr 2016 16:57:49 +0000
Bug 1264227: lighten the box shadow inside the navbar on Linux to match the active tab highlight color. r=Gijs, a=lizzard
d6d1d04e3dbdecaefc54b3623f28226133aef722: Bug 1229967 - Handle onKeyDown() for the menu key in GeckoMenu. r=sebastian, a=lizzard
Jan Henning <jh+bugzilla@buttercookie.de> - Mon, 11 Apr 2016 12:42:21 +0200 - rev 323973
Push 5913 by jlund@mozilla.com at Mon, 25 Apr 2016 16:57:49 +0000
Bug 1229967 - Handle onKeyDown() for the menu key in GeckoMenu. r=sebastian, a=lizzard This restores the functionality to close the menu by pressing the hardware menu key. MozReview-Commit-ID: EKCeALPvFoB
133c7279577b12d9814cbebdd09d529f7c75a0f6: Bug 1265332 - Publish l10n XPI files to candidates and releases r=mtabara a=release DONTBUILD
Rail Aliiev <rail@mozilla.com> - Mon, 18 Apr 2016 07:05:51 -0400 - rev 323972
Push 5913 by jlund@mozilla.com at Mon, 25 Apr 2016 16:57:49 +0000
Bug 1265332 - Publish l10n XPI files to candidates and releases r=mtabara a=release DONTBUILD MozReview-Commit-ID: JgjZJyd6eQi
02b8dc35ec80a95dd4f1cdd5a4075718aed233f2: Bug 1255657 - Write client ID file before Gecko starts to prevent race. r=rnewman, a=ritu
Michael Comella <michael.l.comella@gmail.com> - Wed, 06 Apr 2016 15:07:01 -0700 - rev 323971
Push 5913 by jlund@mozilla.com at Mon, 25 Apr 2016 16:57:49 +0000
Bug 1255657 - Write client ID file before Gecko starts to prevent race. r=rnewman, a=ritu As best as I can tell, this code runs before Gecko is initialized. via bug 1255657 comment 8: To confirm this, GeckoProfile is created before the GeckoThread is finished launching but it seems almost coincidental: GeckoApp.onCreate GeckoThread.launch GeckoThread.start ... GeckoThread.run GeckoThread.getGeckoArgs (notably before GeckoLader.nativeRun) GeckoThread.addCustomProfileArg (if GAP.getGeckoInterface != null, which is set earlier in GeckoApp.onCreate) EITHER GeckoProfile.getDir() (if in guest mode) GeckoProfile.forceCreate GeckoProfile.forceCreate (if not in guest mode) forceCreate opens the times.json file. That being said, if this code path changes, forceCreate is also called when the GeckoView is initialized (which occurs after the GeckoThread.launch call, but is likely to happen before Gecko finishes launching). --- If we wanted GeckoProfile initialization timing to be seem less coincidental, we should consider initializing the profile non-lazily: bug 1262625. MozReview-Commit-ID: LGluC021CTg
d6f797000c07b0d328b8843524de953e678c7379: Bug 1263630 - Remove everything except Flash from the click-to-activate whitelist. r=jimm, a=ritu
Benjamin Smedberg <benjamin@smedbergs.us> - Mon, 11 Apr 2016 11:30:08 -0400 - rev 323970
Push 5913 by jlund@mozilla.com at Mon, 25 Apr 2016 16:57:49 +0000
Bug 1263630 - Remove everything except Flash from the click-to-activate whitelist. r=jimm, a=ritu MozReview-Commit-ID: IwCfIHVANqX
2661a458de7e23248168b57b3ffe246dfaee3805: Bug 1250085 - watch for tab navigations so we know to re-fetch the list of tabs to sync. r=rnewman, a=ritu
Mark Hammond <mhammond@skippinet.com.au> - Tue, 08 Mar 2016 17:47:26 +1100 - rev 323969
Push 5913 by jlund@mozilla.com at Mon, 25 Apr 2016 16:57:49 +0000
Bug 1250085 - watch for tab navigations so we know to re-fetch the list of tabs to sync. r=rnewman, a=ritu
b951ec88e61edd7c8e883233987ab1a81d456824: No bug, Automated blocklist update from host bld-linux64-spot-1050 - a=blocklist-update
ffxbld - Sat, 16 Apr 2016 05:03:21 -0700 - rev 323968
Push 5913 by jlund@mozilla.com at Mon, 25 Apr 2016 16:57:49 +0000
No bug, Automated blocklist update from host bld-linux64-spot-1050 - a=blocklist-update
8ee9a97d915b5d1e1d7bc42fc078e22df85460df: No bug, Automated HPKP preload list update from host bld-linux64-spot-1050 - a=hpkp-update
ffxbld - Sat, 16 Apr 2016 05:03:19 -0700 - rev 323967
Push 5913 by jlund@mozilla.com at Mon, 25 Apr 2016 16:57:49 +0000
No bug, Automated HPKP preload list update from host bld-linux64-spot-1050 - a=hpkp-update
50d894b6fd0a870ee4f4b74dec6d9bf7f88a6371: No bug, Automated HSTS preload list update from host bld-linux64-spot-1050 - a=hsts-update
ffxbld - Sat, 16 Apr 2016 05:03:17 -0700 - rev 323966
Push 5913 by jlund@mozilla.com at Mon, 25 Apr 2016 16:57:49 +0000
No bug, Automated HSTS preload list update from host bld-linux64-spot-1050 - a=hsts-update
aca518830db248be63b2e879d12bfb899fc39ec1: Bug 1103588 - Report String#contains() deprecation warning in Beta and Release channels. r=till a=ritu
Chris Peterson <cpeterson@mozilla.com> - Wed, 13 Apr 2016 11:48:07 -0700 - rev 323965
Push 5913 by jlund@mozilla.com at Mon, 25 Apr 2016 16:57:49 +0000
Bug 1103588 - Report String#contains() deprecation warning in Beta and Release channels. r=till a=ritu
ce4b3f7285ab1ec78032fd0529bfe47ea8189a92: Bug 1256745 - Cancel the DidPaint timer in SetShell(nullptr). r=mattwoodrow a=ritu
L. David Baron <dbaron@dbaron.org> - Wed, 16 Mar 2016 13:47:41 -0700 - rev 323964
Push 5913 by jlund@mozilla.com at Mon, 25 Apr 2016 16:57:49 +0000
Bug 1256745 - Cancel the DidPaint timer in SetShell(nullptr). r=mattwoodrow a=ritu MozReview-Commit-ID: KwtJD4AywX1
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip