js/src/vm/ArrayBufferObject.cpp
973c3800d5d6c10e06ce653add01316f9b0ee25e
created 2019-02-20 13:51 -0800
pushed 2019-03-11 13:01 +0000
Jeff Walden Jeff Walden - Bug 1529298 - Remove ArrayBufferObject::change{,View}Contents as unused. r=sfink
694fe0c4379319644cd9f64781fcb71a75558ed5
created 2019-02-20 13:33 -0800
pushed 2019-03-11 13:01 +0000
Jeff Walden Jeff Walden - Bug 1529298 - Remove setOwnsData and the OWNS_DATA flag. r=sfink
650bd5a18809655323834c7b56d84ad6c512d752
created 2019-02-20 13:33 -0800
pushed 2019-03-11 13:01 +0000
Jeff Walden Jeff Walden - Bug 1529298 - Now that |ownsData()| is always true, inline that true value into all callers. r=sfink
ef4c27821811d19a0dc64e4d9b4d2e7841bb1370
created 2019-02-20 13:33 -0800
pushed 2019-03-11 13:01 +0000
Jeff Walden Jeff Walden - Bug 1529298 - Remove the useless OwnsState argument from ArrayBufferObject::setDataPointer. r=sfink
a06864bc83520a544a3412f81b5d3ef0e930138b
created 2019-02-20 13:33 -0800
pushed 2019-03-11 13:01 +0000
Jeff Walden Jeff Walden - Bug 1529298 - Remove the useless OwnsState argument from ArrayBufferObject::initialize. r=sfink
f4101f4427821666a773c683fc893e977c81946b
created 2019-02-20 13:33 -0800
pushed 2019-03-11 13:01 +0000
Jeff Walden Jeff Walden - Bug 1529298 - Inline the contents of a fresh |if (true) { ... }| in ArrayBufferObject::createForContent. r=sfink
870a5571096968b606babc8eb1f7c495c18ddf1c
created 2019-02-20 13:33 -0800
pushed 2019-03-11 13:01 +0000
Jeff Walden Jeff Walden - Bug 1529298 - Remove the useless OwnsState argument from ArrayBufferObject::createForContent. r=sfink
713088adfe5f3c60bdb08254b2768c70731db317
created 2019-02-20 13:33 -0800
pushed 2019-03-11 13:01 +0000
Jeff Walden Jeff Walden - Bug 1529298 - Remove the useless OwnsState argument from ArrayBufferObject::setNewData. r=sfink
a7a39ff0615820e92079562b305e996865e7b56f
created 2019-02-20 13:33 -0800
pushed 2019-03-11 13:01 +0000
Jeff Walden Jeff Walden - Bug 1529298 - Remove the useless OwnsState argument from ArrayBufferObject::changeContents. r=sfink
5cb592de5e03d0df8254bbd779d84760b0d16eef
created 2019-02-20 13:33 -0800
pushed 2019-03-11 13:01 +0000
Jeff Walden Jeff Walden - Bug 1529298 - Remove ArrayBufferObject::stealContents now that it's unused. r=sfink
63536a044a29b3f723e3ee829f260dafc41feb54
created 2019-02-20 13:33 -0800
pushed 2019-03-11 13:01 +0000
Jeff Walden Jeff Walden - Bug 1529298 - Implement an ArrayBufferObject::extractStructuredCloneContents for structured-cloning an ArrayBuffer. r=sfink
a9638eeea75714425a28e5bcd9edb9ae55dd13b9
created 2019-02-20 13:33 -0800
pushed 2019-03-11 13:01 +0000
Jeff Walden Jeff Walden - Bug 1529298 - Make ArrayBufferObject::wasmGrowToSizeInPlace do its work *not* using ArrayBufferObject::stealContents, rather using the exact operations desired, far more simply. r=sfink
715e9b139ebbd407ac64b5ee8737d0f042f74b4c
created 2019-02-20 13:33 -0800
pushed 2019-03-11 13:01 +0000
Jeff Walden Jeff Walden - Bug 1529298 - Implement an ArrayBufferObject::stealMallocedContents for use in JS_StealArrayBufferContents, rather than reusing the hoary ArrayBufferObject::stealContents with finicky caller-side should-this-steal logic. r=sfink
f487c864d2abb77498667161baf187b3ecb7f995
created 2019-02-20 13:33 -0800
pushed 2019-03-11 13:01 +0000
Jeff Walden Jeff Walden - Bug 1529298 - Make NoteViewBufferWasDetached a lambda instead of a global function. r=sfink
d8a4ce77f2f10639b3a5783b5961319d35342711
created 2019-02-18 23:13 -0800
pushed 2019-03-11 13:01 +0000
Jeff Walden Jeff Walden - Bug 1529298 - Remove most uses of DoesntOwnData for NO_DATA and USER_OWNED and make current users that depend on |ownsData()| not do so. r=sfink
ac3ad3942d6791b7df823d87b23f68efdfa7317a
created 2019-02-18 23:06 -0800
pushed 2019-03-11 13:01 +0000
Jeff Walden Jeff Walden - Bug 1529298 - Remove |ArrayBufferObject::hasStealableContents()| and replace it with its contents, appropriately simplified for each calling location. r=sfink
5b7a07b449ba9d2a0737a3d193d8fec3984ab9ca
created 2019-02-18 23:06 -0800
pushed 2019-03-11 13:01 +0000
Jeff Walden Jeff Walden - Bug 1529298 - Initialize all ArrayBuffers that store their data inline using a single function. r=sfink
3556d94cbc81358a0dbe561079b71f924c235d3f
created 2019-02-18 22:53 -0800
pushed 2019-03-11 13:01 +0000
Jeff Walden Jeff Walden - Bug 1529298 - Add BufferKind::NO_DATA for ArrayBuffers that have no data (whether because byteLength is zero or because the ArrayBuffer is detached), for which the value of |ownsData()| is irrelevant. r=sfink
dcdddf46e820597ddcc985590782fd393cf4291b
created 2019-02-18 22:52 -0800
pushed 2019-03-11 13:01 +0000
Jeff Walden Jeff Walden - Bug 1529298 - Add BufferContents::createFoo functions for every kind so that the templaty, harder-to-search-for create function can be removed. r=sfink
b2c09226e55b6d3b19160b585bc177d8df528264
created 2019-02-18 22:52 -0800
pushed 2019-03-11 13:01 +0000
Jeff Walden Jeff Walden - Bug 1529298 - Simplify ArrayBufferObject::createForContents some now that it's only ever passed non-null contents. r=sfink
4771a589408dc33f8751eb8b4c9fc2b087967ae9
created 2019-02-18 22:52 -0800
pushed 2019-03-11 13:01 +0000
Jeff Walden Jeff Walden - Bug 1529298 - Only pass BufferContents containing a non-null pointer to |ArrayBufferObject::createForContents|. r=sfink
51d373ab477b31f1306de895e235e9a879a5c099
created 2019-02-18 22:52 -0800
pushed 2019-03-11 13:01 +0000
Jeff Walden Jeff Walden - Bug 1529298 - Make AllocateArrayBufferContents return uint8_t*, and make its callers consistently not redundantly report OOMs. r=sfink
92fc3d9b6699885b0af2feb47b9577640d6d2898
created 2019-02-18 22:52 -0800
pushed 2019-03-11 13:01 +0000
Jeff Walden Jeff Walden - Bug 1529298 - Remove trailing arguments to ArrayBufferObject::createForContents that are identical for every caller. r=sfink
765bc7a86f726c7fd3633ca29026cc10f4950864
created 2019-02-18 22:52 -0800
pushed 2019-03-11 13:01 +0000
Jeff Walden Jeff Walden - Bug 1529298 - Rename the two ArrayBufferObject::create overloads to ArrayBufferObject::create{Zeroed,WithContents}, and inline a simplified form of the more-complex ArrayBufferObject::create into the new createZeroed function. r=sfink
5a304d4b53c05587d9da2fdb4db5276380c6ff5b
created 2019-02-18 22:52 -0800
pushed 2019-03-11 13:01 +0000
Jeff Walden Jeff Walden - Bug 1529298 - Remove ArrayBufferObject::hasData and perform its operation in its sole caller in a more straightforward manner. r=sfink
76600605e1e3ce8a54e7ab8c1d98851cad365959
created 2019-02-18 22:52 -0800
pushed 2019-03-11 13:01 +0000
Jeff Walden Jeff Walden - Bug 1529298 - Remove JS_ExternalizeArrayBufferContents because it has no users except in tests, implements complicated ownership semantics, and is definite implementation complexity. r=sfink
9e5e10661a782ba3bd5836eef5505b3f10e09967
created 2019-02-18 22:52 -0800
pushed 2019-03-11 13:01 +0000
Jeff Walden Jeff Walden - Bug 1529298 - Move most of JS_ExternalizeArrayBufferContents into a static member function on ArrayBufferObject so that internals-observing code isn't smeared across two functions. r=sfink
c0aee08543ad5825d3a08aedf60ea8b1f524625f
created 2019-02-18 22:52 -0800
pushed 2019-03-11 13:01 +0000
Jeff Walden Jeff Walden - Bug 1529298 - Split PLAIN into INLINE_DATA/MALLOCED for ArrayBuffer kinds. r=sfink
efd2d5e7ec57c3f347b74ace7ea4605b84bfeac5
created 2019-02-18 22:48 -0800
pushed 2019-03-11 13:01 +0000
Jeff Walden Jeff Walden - Bug 1529298 - Rename JS_NewArrayBufferWithExternalContents to JS_NewArrayBufferWithUserOwnedContents to better accord with the USER_OWNED ArrayBufferKind name, and to avoid namespace overload with the semantically distinct JS_NewExternalArrayBuffer and JS_ExternalizeArrayBufferContents functions. r=sfink
eed1098d0d6c9e3af5b02154295e452c6c21bb48
created 2019-02-22 05:43 +0200
pushed 2019-03-11 13:01 +0000
Csoregi Natalia Csoregi Natalia - Backed out 16 changesets (bug 1529298, bug 1529294) for spidermonkey bustages on testAtomicOperations.cpp. CLOSED TREE
d80b681a68e6a273d1663d5048c3dfcd7b4debd1
created 2019-02-18 23:06 -0800
pushed 2019-03-11 13:01 +0000
Jeff Walden Jeff Walden - Bug 1529298 - Initialize all ArrayBuffers that store their data inline using a single function. r=sfink
086849ef0dd549f9562bc56e79abb62047a99d15
created 2019-02-18 22:53 -0800
pushed 2019-03-11 13:01 +0000
Jeff Walden Jeff Walden - Bug 1529298 - Add BufferKind::NO_DATA for ArrayBuffers that have no data (whether because byteLength is zero or because the ArrayBuffer is detached), for which the value of |ownsData()| is irrelevant. r=sfink
6cc3cd982953405eaa669248b103c5cc6b987d57
created 2019-02-18 22:52 -0800
pushed 2019-03-11 13:01 +0000
Jeff Walden Jeff Walden - Bug 1529298 - Add BufferContents::createFoo functions for every kind so that the templaty, harder-to-search-for create function can be removed. r=sfink
deaa41ca96da55cb27d03ea2c60895a25474488a
created 2019-02-18 22:52 -0800
pushed 2019-03-11 13:01 +0000
Jeff Walden Jeff Walden - Bug 1529298 - Simplify ArrayBufferObject::createForContents some now that it's only ever passed non-null contents. r=sfink
e7fad41d68e05c402c314b596465d16670f7eb89
created 2019-02-18 22:52 -0800
pushed 2019-03-11 13:01 +0000
Jeff Walden Jeff Walden - Bug 1529298 - Only pass BufferContents containing a non-null pointer to |ArrayBufferObject::createForContents|. r=sfink
b3e668a95d3211f479b03b0ca7b2c5fa6a8fa39e
created 2019-02-18 22:52 -0800
pushed 2019-03-11 13:01 +0000
Jeff Walden Jeff Walden - Bug 1529298 - Make AllocateArrayBufferContents return uint8_t*, and make its callers consistently not redundantly report OOMs. r=sfink
c9f62f10eeb5db27027ebb2c6ad54db1d23a9db6
created 2019-02-18 22:52 -0800
pushed 2019-03-11 13:01 +0000
Jeff Walden Jeff Walden - Bug 1529298 - Remove trailing arguments to ArrayBufferObject::createForContents that are identical for every caller. r=sfink
1477b8eb544268bdd7deacd909077bfbebc59f0e
created 2019-02-18 22:52 -0800
pushed 2019-03-11 13:01 +0000
Jeff Walden Jeff Walden - Bug 1529298 - Rename the two ArrayBufferObject::create overloads to ArrayBufferObject::create{Zeroed,WithContents}, and inline a simplified form of the more-complex ArrayBufferObject::create into the new createZeroed function. r=sfink
5be8cb19ad3d9f581bacf4a6acf9a7dba43dd5da
created 2019-02-18 22:52 -0800
pushed 2019-03-11 13:01 +0000
Jeff Walden Jeff Walden - Bug 1529298 - Remove ArrayBufferObject::hasData and perform its operation in its sole caller in a more straightforward manner. r=sfink
432b2e88c651908122e95cc5bdca63aed1758217
created 2019-02-18 22:52 -0800
pushed 2019-03-11 13:01 +0000
Jeff Walden Jeff Walden - Bug 1529298 - Remove JS_ExternalizeArrayBufferContents because it has no users except in tests, implements complicated ownership semantics, and is definite implementation complexity. r=sfink
3512de18097c797cdbeec56b56efdf3e36eb3399
created 2019-02-18 22:52 -0800
pushed 2019-03-11 13:01 +0000
Jeff Walden Jeff Walden - Bug 1529298 - Move most of JS_ExternalizeArrayBufferContents into a static member function on ArrayBufferObject so that internals-observing code isn't smeared across two functions. r=sfink
9294b0d54597d7ef4ec4615739306f9bb9f3d1e5
created 2019-02-18 22:52 -0800
pushed 2019-03-11 13:01 +0000
Jeff Walden Jeff Walden - Bug 1529298 - Split PLAIN into INLINE_DATA/MALLOCED for ArrayBuffer kinds. r=sfink
c5a391fd808f66366fb776e2df7e5d204d87c3ab
created 2019-02-18 22:48 -0800
pushed 2019-03-11 13:01 +0000
Jeff Walden Jeff Walden - Bug 1529298 - Rename JS_NewArrayBufferWithExternalContents to JS_NewArrayBufferWithUserOwnedContents to better accord with the USER_OWNED ArrayBufferKind name, and to avoid namespace overload with the semantically distinct JS_NewExternalArrayBuffer and JS_ExternalizeArrayBufferContents functions. r=sfink
2849a2838ea50d685b386bd962b8b41ef5f84899
created 2019-02-18 22:47 -0800
pushed 2019-03-11 13:01 +0000
Jeff Walden Jeff Walden - Bug 1529298 - Split PLAIN into PLAIN_DATA and USER_OWNED ArrayBuffer data types to clearly segregate the two, rather than categorizing them both as the same thing. r=sfink
6e25dc78ef1e6b949e6a3839a9a28f43a14ae635
created 2019-02-18 22:45 -0800
pushed 2019-03-11 13:01 +0000
Jeff Walden Jeff Walden - Bug 1529298 - Add a BufferContents::createFailed() to use in situations where a failure occurs, rather than overloading createPlain(nullptr). r=sfink
f24c3019443fbfcc4f7d2ee5a67f1d364889840a
created 2019-02-18 22:45 -0800
pushed 2019-03-11 13:01 +0000
Jeff Walden Jeff Walden - Bug 1529298 - Change the comment by ArrayBufferFlags's FOR_ASMJS to indicate that buffers prepared for asm.js must be PLAIN, MAPPED, or EXTERNAL. r=sfink
6a9063e764426f1adb8852595121162a0708e4cb
created 2019-02-18 22:45 -0800
pushed 2019-03-11 13:01 +0000
Jeff Walden Jeff Walden - Bug 1529298 - Add an extra bit to ArrayBufferObject::BufferKind's KIND_MASK to permit adding additional buffer kinds beyond the current four. r=sfink
983e5c1a6ba7eda53a9075bc657cf82ba6c06028
created 2019-02-15 19:53 -0800
pushed 2019-03-11 13:01 +0000
Jeff Walden Jeff Walden - Bug 1527174 - Remove ArrayBufferObject::trace as unnecessary now that buffers for inline typed objects no longer exist. r=sfink
f21f35c4c4ec7e7b0ec6b82570f1b1e1f28c1414
created 2019-02-15 19:53 -0800
pushed 2019-03-11 13:01 +0000
Jeff Walden Jeff Walden - Bug 1527174 - Remove ArrayBufferObject::ArrayBufferFlags's FOR_INLINE_TYPED_OBJECT initializer, as this flag is never set when typed object buffers can't be reified. r=sfink
17d8de567ea416b9a995fcec56897b1bc138b9c6
created 2019-02-19 11:22 +0000
pushed 2019-03-11 13:01 +0000
Jan de Mooij Jan de Mooij - Bug 1521906 part 2 - Replace remaining CheckedUnwrap calls in js/src. r=luke
e7dc5234c6567ed6ff2c7db0c83314e3812f58c1
created 2019-02-10 17:37 +0000
pushed 2019-03-11 13:01 +0000
Jan de Mooij Jan de Mooij - Bug 1521906 part 1 - Use obj->maybeUnwrapAs<T>() or obj->maybeUnwrapIf<T>() instead of CheckedUnwrap where possible. r=luke
13840080fc24aef5ca298b38f2e0b714dc75d05f
created 2019-01-21 13:09 +0000
pushed 2019-01-24 17:31 +0000
Jon Coppeard Jon Coppeard - Bug 1512749 - Convert JS::gcreason::Reason to enum class JS:GCReason r=jonco r=mccr8
5f4630838d46dd81dadb13220a4af0da9e23a619
created 2019-01-18 10:16 +0100
pushed 2019-01-21 13:03 +0000
Ehsan Akhgari Ehsan Akhgari - Bug 1521000 - Part 2: Adjust our clang-format rules to include spaces after the hash for nested preprocessor directives r=sylvestre
1ce15a2a79e08b2b8803d42b06476d5b101111d0
created 2019-01-14 20:19 +0000
pushed 2019-01-21 13:03 +0000
Jason Orendorff Jason Orendorff - Bug 1317416 - GetPrototypeFromConstructor needs to retrieve the fallback prototype from the constructor's realm. r=jandem
81ddd47b2cae63f03d4e70853f5bd5262ff1afc4
created 2019-01-04 16:49 +0100
pushed 2019-01-21 13:03 +0000
Lars T Hansen Lars T Hansen - Bug 1517412 - Adapt wasm buffer management parameters for android-on-arm64. r=luke
0ff9408e595655e51076d4582d88c566da65e990
created 2019-01-03 02:52 -0800
pushed 2019-01-21 13:03 +0000
André Bargull André Bargull - Bug 1517259 - Part 9: Replace unreachable code in ArrayBufferView tracking with assertions. r=jandem
77a8b17163210f7d4bba7e800c2fcb55b0690a24
created 2019-01-03 15:37 -0600
pushed 2019-01-21 13:03 +0000
Jeff Walden Jeff Walden - Bug 1517624 - Move JSPropertySpec and JSFunctionSpec definitions into a new js/public/PropertySpec.h header. r=arai
e32d3be39b84c40e5bf8dee55d3a3ae8c6773916
created 2019-01-04 16:33 -0600
pushed 2019-01-21 13:03 +0000
Jeff Walden Jeff Walden - Back out f8a29b8bb211, d1267711aef0, df1b7a886a9d, 0f6a3dd2c2f7, e6628922b7be, 0a374ac233cd, cf00fd0f080c, 6fc24c4e7798, ab2e4a2e5dd2, 2d17e4ef5e71, 4a8940073f8c, ea3ab4b83152, c7577c232591, e58454c68f0f, and 0e39815d1bce for breaking a single Android J10 and nothing else. (That J10 task must not like deck chairs...) r=bustage
cf00fd0f080c31a4d475585e7583180a62007596
created 2019-01-03 15:37 -0600
pushed 2019-01-21 13:03 +0000
Jeff Walden Jeff Walden - Bug 1517624 - Move JSPropertySpec and JSFunctionSpec definitions into a new js/public/PropertySpec.h header. r=arai
e99c9b3af3854a24c015069659643ac08656d70f
created 2018-12-20 20:51 -0600
pushed 2019-01-21 13:03 +0000
Luke Wagner Luke Wagner - Bug 1507939 - Baldr: add javascript.options.wasm_verbose (r=lth)
less more (0) -300 -100 -60 tip