9204ba25e6ba4b98f3acdc615231449e64efdb71: Bug 1641096 [wpt PR 23784] - Perform monospace-related adjustment using true parent style, a=testonly
Anders Hartvoll Ruud <andruud@chromium.org> - Sat, 30 May 2020 09:50:59 +0000 - rev 597311
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1641096 [wpt PR 23784] - Perform monospace-related adjustment using true parent style, a=testonly Automatic update from web-platform-tests Perform monospace-related adjustment using true parent style There is currently some code in FontBuilder that tweaks the specified font size if the current generic font family changes to or from monospace. This code assumes that the FontDescription stored on the ComputedStyle pre-CreateFont is the inherited FontDescription, but this is no longer (always) true. This means that declarations like font-size:1em can be applied (and subjected to CreateFont) twice, which means that the second call to CheckForGenericFamilyChange won't detect a change in the monospace-ness, hence the specified size will fail to adjust. This CL fixes this by propagating the actual parent style to CheckForGenericFamilyChange. Bug: 1086082, 1086680 Change-Id: Ia61a2327890f27497e4ea5f41dec00a5e0a450d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216511 Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#772032} -- wpt-commits: 14401ce76c8bf36057a6992c0c9ac64f1457a87c wpt-pr: 23784
924f71218235f1f4e37444cf8c86738d19e0c8c3: Bug 1641087 [wpt PR 23782] - [css-grid] Test that inheriting rows and columns doesn't inherit areas, a=testonly
Oriol Brufau <obrufau@igalia.com> - Sat, 30 May 2020 09:50:53 +0000 - rev 597310
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1641087 [wpt PR 23782] - [css-grid] Test that inheriting rows and columns doesn't inherit areas, a=testonly Automatic update from web-platform-tests [css-grid] Test that inheriting rows and columns doesn't inherit areas It used to be the case that setting 'grid-template-columns: inherit' and 'grid-template-rows: inherit' would also inherit 'grid-template-areas'. This got fixed as a side-effect of r747669, adding a test now. Bug: 966090, 1085853 TEST=external/wpt/css/css-grid/placement/grid-placement-using-named-grid-lines-009.html Change-Id: I27865cd8e0533f2ba4380c94c0a51e2ef0decea4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215858 Reviewed-by: Javier Fernandez <jfernandez@igalia.com> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#772012} -- wpt-commits: 3ddd3b70413ffb22e4589aac41971434c2579b92 wpt-pr: 23782
c84f430705686b7a73696ea93de6999d2a50dc66: Bug 1640732 [wpt PR 23760] - ZIndex: Report computed z-index as specified, ignoring stacking context., a=testonly
Vladimir Levin <vmpstr@chromium.org> - Sat, 30 May 2020 09:50:48 +0000 - rev 597309
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1640732 [wpt PR 23760] - ZIndex: Report computed z-index as specified, ignoring stacking context., a=testonly Automatic update from web-platform-tests ZIndex: Report computed z-index as specified, ignoring stacking context. This patch changes the behavior of computed style z-index to comply with spec: it reports the value as specified instead of changing it to auto if the style does not induce a stacking context. Note that since z-index only applies on positioned elements, and grid and flex children, this patch introduces an EffectiveZIndex() which is set to 0 if the z-index does not apply. This is so that code relying on z-index will behave as it did before. However, ZIndex() now reflects the value that was specified. R=futhark@chromium.org, pdr@chromium.org Fixed: 1023232, 375982 Change-Id: Ib11467a9818b746c72bebbb167223f1bb41a5f9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212391 Auto-Submit: vmpstr <vmpstr@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#771989} -- wpt-commits: 3c20a28087856bd19ef7e06e1244c536e4ff83c7 wpt-pr: 23760
16b0a8b4475789462bf2837963378c0226aeb3ec: Bug 1641035 [wpt PR 23779] - [css-grid] Fix 'grid-template-areas: inherit', a=testonly
Oriol Brufau <obrufau@igalia.com> - Sat, 30 May 2020 09:50:42 +0000 - rev 597308
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1641035 [wpt PR 23779] - [css-grid] Fix 'grid-template-areas: inherit', a=testonly Automatic update from web-platform-tests [css-grid] Fix 'grid-template-areas: inherit' GridTemplateAreas::ApplyInherit wasn't setting ImplicitNamedGridRowLines nor ImplicitNamedGridColumnLines inherited from the parent, so grid items referencing these lines were placed into the implicid grid. The patch also makes sure to set them in GridTemplateAreas::ApplyInitial and GridTemplateAreas::ApplyValue for a 'none' keyword. It seems these weren't causing noticeable problems, though. BUG=1085853 TEST=external/wpt/css/css-grid/placement/grid-placement-using-named-grid-lines-008.html Change-Id: If92e771d51450dea3f7fa12deaec6ce9dd7639d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214960 Reviewed-by: Javier Fernandez <jfernandez@igalia.com> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#771984} -- wpt-commits: c81ab1e2472ed9930826294d9f4a48bcf8398e30 wpt-pr: 23779
9a874dd81dc3bee244db7c91b58bb124e4a2b3f7: Bug 1641062 [wpt PR 23780] - [ScrollTimeline] Force compositing scrollers to run tests on compositor correctly, a=testonly
Yi Gu <yigu@chromium.org> - Sat, 30 May 2020 09:50:30 +0000 - rev 597307
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1641062 [wpt PR 23780] - [ScrollTimeline] Force compositing scrollers to run tests on compositor correctly, a=testonly Automatic update from web-platform-tests [ScrollTimeline] Force compositing scrollers to run tests on compositor correctly This is similar to crrev.com/c/2211048. cc::ScrollTimeline is considered as inactive if the scroller is not composited (not in cc::ScrollTree). Bug: None Change-Id: Id933a41ba40f8a736692653a934f963d52c011be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216711 Reviewed-by: Xida Chen <xidachen@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#771955} -- wpt-commits: 4d305fd635fa6fc95528a60d77ccd3d87c4c7855 wpt-pr: 23780
d9a26b58a5165bd1f5ed1921c4583354ecaf873d: Bug 1633824 [wpt PR 23303] - bluetooth: implement writeValueWith[out]Response(), a=testonly
David Lechner <david@pybricks.com> - Sat, 30 May 2020 09:50:25 +0000 - rev 597306
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1633824 [wpt PR 23303] - bluetooth: implement writeValueWith[out]Response(), a=testonly Automatic update from web-platform-tests bluetooth: implement writeValueWith[out]Response() This implements the Web Bluetooth BluetoothRemoteGATTCharacteristic writeValueWithResponse() and writeValueWithoutResponse() methods. https://webbluetoothcg.github.io/web-bluetooth/#writecharacteristicvalue The writeValue() method is now deprecated and should continue to work exactly as it did before. New web_tests are just a copy of existing tests for writeValue(). New non-generated tests have been converted to async/await. The tests for writeValueWithoutResponse() have calls to setNextWriteResponse() removed since they do not receive a response. The getLastWrittenValue() method is modified to also return the write type of the last written value. This is used to confirm that the correct write type is requested. Bug: 672648 Change-Id: I0d8032fded0028eaa78a55afe3336f253c85c590 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159770 Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Reviewed-by: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#771935} -- wpt-commits: c6aa9c9a8ec3a3dd5fdd6933f612772677aaa22b wpt-pr: 23303
2746d529a7cc21bd5a1f1d53003dc6f2631e30e0: Bug 1640930 [wpt PR 23775] - CacheStorage: Persist explicit response mime type., a=testonly
Ben Kelly <wanderview@chromium.org> - Sat, 30 May 2020 09:50:19 +0000 - rev 597305
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1640930 [wpt PR 23775] - CacheStorage: Persist explicit response mime type., a=testonly Automatic update from web-platform-tests CacheStorage: Persist explicit response mime type. This CL fixes a small interop issue where chromium would always recompute the mime type for a response after reading it from cache_storage. This was incorrect because the mime type should be fixed at original response construction time even if its headers are later mutated. This CL also causes service workers to use the mime type originally computed for the Response instead of re-extracting the value from the content-type header. Bug: 938939 Change-Id: I941c1b1e3863e41da49128ce814ac0f1762dae70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211949 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#771921} -- wpt-commits: baaeb9f35537fdbac74bec334aedacdf74c9f08f wpt-pr: 23775
7ce73f5b515c5e8be5daa763ad60bf92e64a0f63: Bug 1640966 [wpt PR 23776] - [canvas] Fix intrinsic size invalidation for canvas elements., a=testonly
Ian Kilpatrick <ikilpatrick@chromium.org> - Sat, 30 May 2020 09:50:13 +0000 - rev 597304
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1640966 [wpt PR 23776] - [canvas] Fix intrinsic size invalidation for canvas elements., a=testonly Automatic update from web-platform-tests [canvas] Fix intrinsic size invalidation for canvas elements. Previously we cached at the preferred sizes level, this meant that whenever we called LayoutReplaced::PreferredLogicalWidths the (previous) PreferredLogicalWidthsDirty bit got cleared. However we now cache at the IntrinsicLogicalWidths level. The difference is that LayoutReplaced elements don't clear their IntrinsicLgoicalWidthsDirty bit. This meant that the innocent looking: if (!IntrinsicLogicalWidthsDirty()) SetIntrinsicLogicalWidthsDirty(); Was incorrect, as we were never invalidating the container chain. This caused the observed incorrect rendering in the bug. This patch changes this function to always invalidate the container chain for intrinsic sizes, and layout invalidations. Bug: 1086299 Change-Id: I8145a6276d4ec89c0c7acf91c1bf67714c127440 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216373 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#771912} -- wpt-commits: c21265d712f57e725d3d9a679d4d0283e4e98ccc wpt-pr: 23776
0cc9ccac66c6883628e132aab1ac5e3e0041749a: Bug 1640889 [wpt PR 23767] - [@property] Avoid crash with non-matching 'media' attribute, a=testonly
Anders Hartvoll Ruud <andruud@chromium.org> - Sat, 30 May 2020 09:50:07 +0000 - rev 597303
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1640889 [wpt PR 23767] - [@property] Avoid crash with non-matching 'media' attribute, a=testonly Automatic update from web-platform-tests [@property] Avoid crash with non-matching 'media' attribute The RuleSet of an ActiveStyleSheet can be nullptr for non-matching media (see StyleEngine::RuleSetForSheet), hence we can't DCHECK that it exists. Bug: 1085994 Change-Id: Iac7f746045f46ad7752b30cccce8b6f403cf19b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214537 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#771897} -- wpt-commits: d004c9c8e0265fc20535110d31be7042b7fbc509 wpt-pr: 23767
0f16ea25eded5cb8ca91f1795ccb1b3243441a8a: Bug 1637281 [wpt PR 23533] - Enabled Web Animation APIs for scroll animations, a=testonly
Olga Gerchikov <gerchiko@microsoft.com> - Sat, 30 May 2020 09:50:02 +0000 - rev 597302
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1637281 [wpt PR 23533] - Enabled Web Animation APIs for scroll animations, a=testonly Automatic update from web-platform-tests Enabled Web Animation APIs for scroll animations - Enabled pause(), reverse() and updatePlaybackRate() APIs for scroll animations. - Provided temporary fix for play animation procedure to accommodate reverse() and replaying finished animation cases. The fix reflects pending https://github.com/w3c/csswg-drafts/pull/5059. - Ported wpt/web-animations/timing-model/animations tests that exercise the APIs. - Implemented scroll animation specific tests. Bug: 916117 Change-Id: I689e7a6d1f220ee12e7f7a6f90e54340eaa33aee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2194586 Reviewed-by: Kevin Ellis <kevers@chromium.org> Commit-Queue: Olga Gerchikov <gerchiko@microsoft.com> Cr-Commit-Position: refs/heads/master@{#771881} -- wpt-commits: 1afcb0f78cd1f6ec37d64f9bce4220102a6dc0a2 wpt-pr: 23533
919781699601aa31022bd862f25afb11e121ec37: Bug 1640014 [wpt PR 23735] - Update wpt metadata, a=testonly
moz-wptsync-bot <wptsync@mozilla.com> - Thu, 28 May 2020 10:12:12 +0000 - rev 597301
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1640014 [wpt PR 23735] - Update wpt metadata, a=testonly wpt-pr: 23735 wpt-type: metadata
edccacea76fc0bdb3eb5cb25cd53d18710dd3504: Bug 1640014 [wpt PR 23735] - [AspectRatio] Correctly handle a stretched item in a fixed height flexbox, a=testonly
Christian Biesinger <cbiesinger@chromium.org> - Sat, 30 May 2020 09:49:45 +0000 - rev 597300
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1640014 [wpt PR 23735] - [AspectRatio] Correctly handle a stretched item in a fixed height flexbox, a=testonly Automatic update from web-platform-tests [AspectRatio] Correctly handle a stretched item in a fixed height flexbox With a fixed-height single-line flex container, a stretched item should be considered to have a definite height and thus should have its aspect-ratio calculated from that: https://drafts.csswg.org/css-flexbox/#definite-sizes item 1 This patch limits this behavior to the CSS aspect-ratio property for now (as opposed to supporting it for everything with an aspect ratio, like images), to limit the behavior differences from pre-FlexNG Blink. Bug: 1083020 Change-Id: I2abe33d49a8727857a28e47ba6344ad3da860cad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212984 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#771863} -- wpt-commits: 0d155d5c685a2c22f2e3ec5f976f31c1f2180c20 wpt-pr: 23735
8c217d1362d880316690ae4f676ecb78b8f80206: Bug 1640923 - Add Iterator constructor on global object r=jorendorff
Adam Vandolder <avandolder@mozilla.com> - Fri, 29 May 2020 20:08:08 +0000 - rev 597299
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1640923 - Add Iterator constructor on global object r=jorendorff Differential Revision: https://phabricator.services.mozilla.com/D76907
3de491b80e70d7f880caed68853d74d4d9d144d3: Bug 1638275 - Allow searchbar one-offs hidden attribute to override display:flex. r=dao
Harry Twyford <htwyford@mozilla.com> - Wed, 27 May 2020 15:39:22 +0000 - rev 597298
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1638275 - Allow searchbar one-offs hidden attribute to override display:flex. r=dao Differential Revision: https://phabricator.services.mozilla.com/D77086
705f2d35af32cb12bdc2e2ea1a32751d460c7887: Bug 1637235 - Implement the audio drift correction. r=padenot
Alex Chronopoulos <achronop@gmail.com> - Mon, 01 Jun 2020 12:27:04 +0000 - rev 597297
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1637235 - Implement the audio drift correction. r=padenot Implement the drift correction logic that counts the frames between a source and a target (the master clock) and adjust the source buffer in order to compensate for the drift between source and target. Differential Revision: https://phabricator.services.mozilla.com/D74884
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -15 +15 +100 +300 +1000 +3000 +10000 +30000 tip