91d7e3da08e32348b2a2515c0e46a9fecacbddfd: servo: Merge #17709 - always call new_pipeline() before add_pending_changes() (from paulrouget:new_pipeline_before_add_pending_changes); r=cbrewster
Paul Rouget <me@paulrouget.com> - Thu, 13 Jul 2017 10:50:07 -0700 - rev 417541
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
servo: Merge #17709 - always call new_pipeline() before add_pending_changes() (from paulrouget:new_pipeline_before_add_pending_changes); r=cbrewster There are some changes we want to make in `add_pending_changes` which require pipelines to be registered in self.pipelines. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: a287271486e85a0e20d9465ebe25522ad5900a2c
6821f71e10c1909c5f00d6e3ec178184320477a2: servo: Merge #17690 - layout: Stop in-order traversal on children of InlineFlow (from stshine:no-inorder); r=emilio
Pu Xingyu <pu.stshine@gmail.com> - Thu, 13 Jul 2017 09:53:39 -0700 - rev 417540
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
servo: Merge #17690 - layout: Stop in-order traversal on children of InlineFlow (from stshine:no-inorder); r=emilio No need to do in-order traversal for children of InlineFlow, since they are either inline-block or absolutely positioned elements, which are guaranteed to be block formatting context. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because cleanup <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 95bad3f33a9f0af9511011d4a83a9c95322784d5
c7f9f51b01bb49634982b3653431dedc30c14564: servo: Merge #17703 - Reduce amount of Mako-generated code in style (from servo:code-size); r=emilio
Simon Sapin <simon.sapin@exyr.org> - Thu, 13 Jul 2017 08:51:55 -0700 - rev 417539
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
servo: Merge #17703 - Reduce amount of Mako-generated code in style (from servo:code-size); r=emilio In multiple places, instead of generated similar code for each CSS property, have a single code path that uses an enum such as `LonghandId`. Fix https://bugzilla.mozilla.org/show_bug.cgi?id=1377262 Machine code size is measured with [bloaty](https://github.com/google/bloaty), looking at the total "VM size" in order to exclude debug info (which is stripped in binaries shipped to users). ``` mach build-geckolib --release bloaty target/geckolib/release/libgeckoservo.a ``` Initial size was 9.56Mi. Successive commits in this PR bring it to 9.55Mi, 9.51Mi, 9.44Mi, 9.31Mi, 8.89Mi, 8.89Mi, and 7.54Mi. Total savings: 2.02 MiB. In an optimized Firefox build with `mach build && mach package`, the size of `obj-x86_64-pc-linux-gnu/dist/firefox/libxul.so` goes from 109.11 MiB to 107.49 MiB, saving 1.62 MiB. I don’t really know how to explain the difference. Does `libgeckoservo.a` contain code that ends up not being used in `libxul.so`? Source-Repo: https://github.com/servo/servo Source-Revision: 68ae7ceff6e95f1008c6f32f240c1601e5d440d1
8d54766fc7c4e0b9f557bafb33531db45d3c6404: servo: Merge #17685 - remove no-op InitializeCompositing message (from paulrouget:rm_InitializeCompositing); r=jdm
Paul Rouget <me@paulrouget.com> - Thu, 13 Jul 2017 07:46:32 -0700 - rev 417538
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
servo: Merge #17685 - remove no-op InitializeCompositing message (from paulrouget:rm_InitializeCompositing); r=jdm I think this is no-op. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 43e2720f86ddb710843724969a6b3e1892a01829
4c8ee44afffba102542012452d18e746cdca2e56: Bug 1304042 - Fail the build if running dsymutil fails. r=mshal
Chris Manchester <cmanchester@mozilla.com> - Thu, 13 Jul 2017 11:57:50 -0700 - rev 417537
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Bug 1304042 - Fail the build if running dsymutil fails. r=mshal MozReview-Commit-ID: 9ROIRpuoVGR
a419686f707e7a248a3b477556fef8b8ae7d6bae: Bug 1352602 - Part 2: Use build system SDK versions in Gradle configurations. r=maliu
Nick Alexander <nalexander@mozilla.com> - Wed, 21 Jun 2017 10:52:30 -0700 - rev 417536
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Bug 1352602 - Part 2: Use build system SDK versions in Gradle configurations. r=maliu This patch does two things: - add a Gradle-only ANDROID_COMPILE_SDK_VERSION substitution; - uses it while uniformizing all of the Gradle Android SDK version configurations. The approach is fairly standard (and we were using it already); see, for example https://medium.com/@ali.muzaffar/gradle-configure-variables-for-all-android-project-modules-in-one-place-5a6e56cd384e This will make bumping the Gradle configuration versions forward easier. MozReview-Commit-ID: 1j5siCvR5qt
d14a94ba9fc7dd64d27d4c1caf44ffcace625b9a: Bug 1352602 - Part 1: Don't AC_DEFINE ANDROID_TARGET_SDK, MOZ_ANDROID_{MIN,MAX}_SDK_VERSION. r=chmanchester
Nick Alexander <nalexander@mozilla.com> - Wed, 21 Jun 2017 11:16:08 -0700 - rev 417535
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Bug 1352602 - Part 1: Don't AC_DEFINE ANDROID_TARGET_SDK, MOZ_ANDROID_{MIN,MAX}_SDK_VERSION. r=chmanchester This is just a small piece in the larger project of minimizing the set of global AC_DEFINEs. None of these are relevant to C/C++ code; they're mobile/android specific, so we should get them out of mozilla-config.h. In addition, this replaces hard-coded values with values from the build system throughout mobile/android. MozReview-Commit-ID: 9IJlsm38LFK
1a2bc58d4298f8e0bae68a79a4a18dd04b3665ef: Bug 1380142: Add a pref to enable the D3D11 debug layer and to break on errors. r=milan
Bas Schouten <bschouten@mozilla.com> - Tue, 11 Jul 2017 22:53:04 +0200 - rev 417534
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Bug 1380142: Add a pref to enable the D3D11 debug layer and to break on errors. r=milan MozReview-Commit-ID: 2FrQGXdgJrD
400584289c8fa44060d6443a3288ef57cf73ff4e: Backed out changeset 2bec8580742b (bug 1370753) for breaking Android L10n nightlies. r=backout a=backout
Sebastian Hengst <archaeopteryx@coole-files.de> - Fri, 14 Jul 2017 15:04:53 +0200 - rev 417533
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Backed out changeset 2bec8580742b (bug 1370753) for breaking Android L10n nightlies. r=backout a=backout MozReview-Commit-ID: JpJRsrL0r9B
992a8358d408ec20a4a1f49c639d88b2609108fb: Bug 1373007 - More manifest fixups. a=me
Ryan VanderMeulen <ryanvm@gmail.com> - Fri, 14 Jul 2017 08:43:19 -0400 - rev 417532
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Bug 1373007 - More manifest fixups. a=me
66e27c932aae1aa201fb4cc97edb23e5dda331a6: Backed out changeset 020581c23b7d (bug 1367613) for gl error during test_conformance__extensions__webgl-debug-shaders.html. r=backout on a CLOSED TREE
Sebastian Hengst <archaeopteryx@coole-files.de> - Fri, 14 Jul 2017 10:11:54 +0200 - rev 417531
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Backed out changeset 020581c23b7d (bug 1367613) for gl error during test_conformance__extensions__webgl-debug-shaders.html. r=backout on a CLOSED TREE
51571f2cd52eb2694fee5868b772cb448bd020ab: Backed out changeset 49ef9e17682e (bug 1377974) for gl error during test_conformance__extensions__webgl-debug-shaders.html. r=backout on a CLOSED TREE
Sebastian Hengst <archaeopteryx@coole-files.de> - Fri, 14 Jul 2017 10:11:11 +0200 - rev 417530
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Backed out changeset 49ef9e17682e (bug 1377974) for gl error during test_conformance__extensions__webgl-debug-shaders.html. r=backout on a CLOSED TREE
2a4effa27df4c80076fac61fca0438af0a841097: Backed out changeset 7ec72cbf67b6 (bug 1380471) for Windows 2012 static bustage. r=backout on a CLOSED TREE
Sebastian Hengst <archaeopteryx@coole-files.de> - Fri, 14 Jul 2017 10:00:52 +0200 - rev 417529
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Backed out changeset 7ec72cbf67b6 (bug 1380471) for Windows 2012 static bustage. r=backout on a CLOSED TREE
85a383b0638256b457b42689c8580200ad52e669: Bug 1374828 - Properly initialize/shutdown telemetry in test_TelemetrySession.js. r=chutten
Alessio Placitelli <alessio.placitelli@gmail.com> - Thu, 13 Jul 2017 09:51:00 +0200 - rev 417528
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Bug 1374828 - Properly initialize/shutdown telemetry in test_TelemetrySession.js. r=chutten This patch adds TelemetryController.testShutdown() calls to the tests that were not calling it, relying on TelemetryController.testReset() to do the full shutdown/restart cycle. Without the shutdown, the telemetry scheduler was generating rougue daily pings at undesired times.
bfd1975229fddbaf6994373e4a8e9180080677d9: Bug 1350958 - Finish labeling ProxyReleaseEvent, r=billm
Andrea Marchesini <amarchesini@mozilla.com> - Fri, 14 Jul 2017 08:49:22 +0200 - rev 417527
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Bug 1350958 - Finish labeling ProxyReleaseEvent, r=billm
e23b4fd5dce3a7ef94e21943ebba42af3db30f85: Bug 1378147. Hold strong refs to elements when calling various functions that can run script. r=mystor
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 13 Jul 2017 23:46:59 -0400 - rev 417526
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Bug 1378147. Hold strong refs to elements when calling various functions that can run script. r=mystor
a3148fb9d930e3a608605c7a26e03bda72096079: Bug 1380415 part 2. Remove XPCOM constraint validation APIs. r=mccr8
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 13 Jul 2017 23:46:28 -0400 - rev 417525
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Bug 1380415 part 2. Remove XPCOM constraint validation APIs. r=mccr8
ada83982640a67735452fa92923e43dd7e5ad6bb: Bug 1380415 part 1. Remove unused bits of nsIDOMHTMLInputElement. r=mccr8
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 13 Jul 2017 23:46:13 -0400 - rev 417524
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Bug 1380415 part 1. Remove unused bits of nsIDOMHTMLInputElement. r=mccr8
62015017951daa6c6daf76a08d862de6e81624b3: Bug 1380413 part 2. Remove nsIDOMHTMLImageElement.width/height. r=mccr8
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 13 Jul 2017 23:46:12 -0400 - rev 417523
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Bug 1380413 part 2. Remove nsIDOMHTMLImageElement.width/height. r=mccr8
666ff5b5a59788e3dabdb5d0901021eb344113b8: Bug 1380413 part 1. Remove unused nsIDOMHTMLImageElement bits. r=mccr8
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 13 Jul 2017 23:45:56 -0400 - rev 417522
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Bug 1380413 part 1. Remove unused nsIDOMHTMLImageElement bits. r=mccr8
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip