891e389f58fb6672b700a9ac9cdb31f54a344b01: Bug 1647455 [wpt PR 24295] - Use the correct layout invalidation root in StyleEngine::InvalidateStyleAndLayoutForFontUpdates, a=testonly
Xiaocheng Hu <xiaochengh@chromium.org> - Tue, 23 Jun 2020 21:52:24 +0000 - rev 601249
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1647455 [wpt PR 24295] - Use the correct layout invalidation root in StyleEngine::InvalidateStyleAndLayoutForFontUpdates, a=testonly Automatic update from web-platform-tests Use the correct layout invalidation root in StyleEngine::InvalidateStyleAndLayoutForFontUpdates The function currently uses the LayoutObject of the documentElement as the layout invalidation root, which is incorrect because there can be objects not in its subtree. For example, a modal dialog. This patch fixes it by using the LayoutView, the root of the layout tree, as the layout invalidation root. Bug: 1092411 Change-Id: Ic2475fe1fc9fd9029699a410b4f03a9f3812e240 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255738 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#781132} -- wpt-commits: 80aec473c19f40c879df56657c9c4ee6ed8959ca wpt-pr: 24295
dedc7a9428e64e711a4adf7e756b3b89e27d702c: Bug 1646210 [wpt PR 24173] - Use same/cross-site terminology for split cache WPT and minor changes, a=testonly
Alex Turner <alexmt@chromium.org> - Tue, 23 Jun 2020 21:52:18 +0000 - rev 601248
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1646210 [wpt PR 24173] - Use same/cross-site terminology for split cache WPT and minor changes, a=testonly Automatic update from web-platform-tests Use same/cross-site terminology for split cache WPT and minor changes Changes the use of same/cross-origin to same/cross-site to reflect the change in the approach. Accordingly, names helper files more appropriately. Also makes the ordering of tests more natural and adds descriptive names to each test. Bug: 1092991 Change-Id: If9bebebea8b0b51db2d4f8c1c3ab1ddf1e2fb233 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248867 Commit-Queue: Alex Turner <alexmt@chromium.org> Reviewed-by: Shivani Sharma <shivanisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#781090} -- wpt-commits: 9e1358f2d09a75340b8e4b572e19f52e864f2790 wpt-pr: 24173
05ed1f5d6d47c1fb458aa84792586d7e97370658: Bug 1647507 [wpt PR 24301] - [FileAPI] Address post-land comments in url-charset.window.js, a=testonly
Marijn Kruisselbrink <mek@chromium.org> - Tue, 23 Jun 2020 21:52:13 +0000 - rev 601247
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1647507 [wpt PR 24301] - [FileAPI] Address post-land comments in url-charset.window.js, a=testonly Automatic update from web-platform-tests [FileAPI] Address post-land comments in url-charset.window.js Bug: 1086845 Change-Id: Ifac1e7050b64f790482b2a06d0ef01814edc83e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258683 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#781061} -- wpt-commits: d3e8b806e1f66a0b08ae123e01a92f7f96ece751 wpt-pr: 24301
bff0fe6131ebb62210814dfb2bb155c367ec5963: Bug 1647465 [wpt PR 24296] - Revert "Don't reset computed 'float' for flex and grid items", a=testonly
Alison Maher <almaher@microsoft.com> - Tue, 23 Jun 2020 21:52:07 +0000 - rev 601246
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1647465 [wpt PR 24296] - Revert "Don't reset computed 'float' for flex and grid items", a=testonly Automatic update from web-platform-tests Revert "Don't reset computed 'float' for flex and grid items" This reverts commit 906abd41e4f6c786a1927f6edd69d6926e20317b. Reason for revert: A DCHECK was getting hit, causing a crash: https://bugs.chromium.org/p/chromium/issues/detail?id=1097595#c4 Original change's description: > Don't reset computed 'float' for flex and grid items > > Floated flex and grid items have their 'float' incorrectly computed to > "none". This change fixes this by adjusting IsFloating() for flex and > grid items inside LayoutBox::UpdateFromStyle() instead of inside > StyleAdjuster::AdjustStyleForDisplay(). > > Beyond this, legend elements are not allowed to be rendered legends > if they are floating. However, if legends are flex items, we > adjust IsFloating() to be false. This causes legends to be > used as rendered legends when they are flex items, even if they > were styled as a float. > > This is fixed by checking ComputedStyle::IsFloating() instead > of LayoutObject::IsFloating() when finding the rendered legend in > order to get its non-adjusted floating value. > > Bug: 875235,350505 > Change-Id: Ia1e7f7c244cc0c443cd58be42854866884b7f7e7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157889 > Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> > Reviewed-by: Morten Stenshorne <mstensho@chromium.org> > Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> > Commit-Queue: Alison Maher <almaher@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#763988} TBR=cbiesinger@chromium.org,ikilpatrick@chromium.org,mstensho@chromium.org,almaher@microsoft.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 875235, 350505, 1097595 Change-Id: I5e5ff8a93d1e1e46908f9b640b9564e70345e9e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256772 Reviewed-by: Alison Maher <almaher@microsoft.com> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#780995} -- wpt-commits: 9f6b1348c4216fb3597f1ebab3f4b06091cd7ab9 wpt-pr: 24296
6f4a456ee3f696af3b7f193bf63f7a7e818c2709: Bug 1647382 [wpt PR 24290] - Fixes Heap-use-after-free in ImageResourceContent::PriorityFromObservers, a=testonly
Yu Han <yuzhehan@chromium.org> - Tue, 23 Jun 2020 21:52:02 +0000 - rev 601245
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1647382 [wpt PR 24290] - Fixes Heap-use-after-free in ImageResourceContent::PriorityFromObservers, a=testonly Automatic update from web-platform-tests Fixes Heap-use-after-free in ImageResourceContent::PriorityFromObservers Prior to this CL, asynchronously applying and removing a CSS property containing image content to an ImageInputType that's rendered as fallback content causes heap use after use exception in ImageResourceContent when it tries to access its ImageResourceObserver. See minimized repro case in bug for details in the use case. This is a regression caused by my fix [1] to bug 948066. With the previous fix [1], the above case triggers a call into LayoutObject [2] from ImageInputType::CreateLayoutObject() which instead of creating a LayoutObject for its fallback content, it creates a LayoutImage instead. This is clearly wrong. I spend some time debugging into the lifecycle of LayoutImage, ImageResourceContent and ImageResourceObserver but didn't track down the cause of the stale ImageResourceObserver. Regardless, the fix is to not use LayoutObject::CreateObject() directly, but to create layout object subclass to render the fallback content. [1] https://crrev.com/c/2212963 [2] https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/renderer/core/layout/layout_object.cc;l=210;drc=0a03e5eb198d0485b8cc023dbc24fd17c16c9629;bpv=0;bpt=1 Bug: 1096002 Change-Id: If059a694c9a60fb6563a446b0250532e6d19f1c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255311 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Mason Freed <masonfreed@chromium.org> Commit-Queue: Yu Han <yuzhehan@chromium.org> Cr-Commit-Position: refs/heads/master@{#780992} -- wpt-commits: 4c2a6361679794417423fe7cbae70f42cc73d468 wpt-pr: 24290
2ab79ee5b19119de0bc6d4edbb7e55f8717f0e68: Bug 1646995 [wpt PR 24255] - Don't navigate to jsurls with pending form submission, a=testonly
Joey Arhar <jarhar@chromium.org> - Tue, 23 Jun 2020 21:51:56 +0000 - rev 601244
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1646995 [wpt PR 24255] - Don't navigate to jsurls with pending form submission, a=testonly Automatic update from web-platform-tests Don't navigate to jsurls with pending form submission In the case where a javascript: url is executed and submits a form inside the execution and also returns a value, the form submission should take precedence over the javascript: url's return value. Although I could have made HasProvisionalNavigation return true instead of adding a separate check for pending form submissions, I'm afraid to do this because I don't know how it will affect the other places that use HasProvisionalNavigation. I already have a bug open to track this, and I will give it a shot after things with form submission settle down more. Bug: 1087431 Change-Id: If2761952b9a03f4193efb822ecf3db4fabc10f40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248485 Reviewed-by: Mason Freed <masonfreed@chromium.org> Reviewed-by: Nate Chapin <japhet@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#780955} -- wpt-commits: 4016b193377912783e86b8579eb271aff15c002f wpt-pr: 24255
2207088ca603baf10af63dcaf64151e9c94e14c3: Bug 1647162 [wpt PR 24266] - Update wpt metadata, a=testonly
moz-wptsync-bot <wptsync@mozilla.com> - Tue, 23 Jun 2020 00:42:40 +0000 - rev 601243
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1647162 [wpt PR 24266] - Update wpt metadata, a=testonly wpt-pr: 24266 wpt-type: metadata
d99445d326a6d194af664afbd62a34fa3d04fd0e: Bug 1647162 [wpt PR 24266] - Support async iterable declarations in idlharness, a=testonly
Mattias Buelens <649348+MattiasBuelens@users.noreply.github.com> - Tue, 23 Jun 2020 21:51:47 +0000 - rev 601242
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1647162 [wpt PR 24266] - Support async iterable declarations in idlharness, a=testonly Automatic update from web-platform-tests Support async iterable declarations in idlharness (#24266) -- wpt-commits: 29b173a925b9b40da9f086f45b27ab195fd809ce wpt-pr: 24266
11b3f9ba8344bcf18fe652e6c70f212888707f47: Bug 1647021 [wpt PR 24261] - Update wpt metadata, a=testonly
moz-wptsync-bot <wptsync@mozilla.com> - Tue, 23 Jun 2020 13:23:29 +0000 - rev 601241
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1647021 [wpt PR 24261] - Update wpt metadata, a=testonly wpt-pr: 24261 wpt-type: metadata
c936a4e62579c886ec241ec626803d48969f0f72: Bug 1647021 [wpt PR 24261] - Origin isolation: test initial about:blank, a=testonly
Domenic Denicola <domenic@chromium.org> - Tue, 23 Jun 2020 21:51:38 +0000 - rev 601240
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1647021 [wpt PR 24261] - Origin isolation: test initial about:blank, a=testonly Automatic update from web-platform-tests Origin isolation: test initial about:blank The initial about:blank inheriting its origin from the parent is a rather special case, and deserves its own tests when origin isolation is involved. Bug: 1042415 Change-Id: I6c7d41e05b601bd1044f1c70f1ee7c75a44ffb14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255519 Commit-Queue: Domenic Denicola <domenic@chromium.org> Reviewed-by: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#780830} -- wpt-commits: e61900f7d9d57595a17f067bc3b14073bf30d366 wpt-pr: 24261
f7b2e921fe00d7c839ee94b3ce5cab45df0aec64: Bug 1647432 [wpt PR 24293] - Update interfaces/webauthn.idl, a=testonly
autofoolip <auto@foolip.org> - Tue, 23 Jun 2020 21:51:32 +0000 - rev 601239
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1647432 [wpt PR 24293] - Update interfaces/webauthn.idl, a=testonly Automatic update from web-platform-tests Update interfaces/webauthn.idl (#24293) Source: https://github.com/tidoust/reffy-reports/blob/313473a/ed/idl/webauthn.idl Build: https://travis-ci.org/tidoust/reffy-reports/builds/700993753 -- wpt-commits: a16dbbde7c098577d8a7f51cc9bf4c80499dd05d wpt-pr: 24293
279ed4f11a293779cafc26b3d034f89c982340f2: Bug 1647016 [wpt PR 24259] - Update wpt metadata, a=testonly
moz-wptsync-bot <wptsync@mozilla.com> - Mon, 22 Jun 2020 23:48:11 +0000 - rev 601238
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1647016 [wpt PR 24259] - Update wpt metadata, a=testonly wpt-pr: 24259 wpt-type: metadata
bf8923493cfc686385de8a84c6cad414b42d8dc1: Bug 1647016 [wpt PR 24259] - Origin isolation: test location.href access, a=testonly
Domenic Denicola <domenic@chromium.org> - Tue, 23 Jun 2020 21:51:22 +0000 - rev 601237
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1647016 [wpt PR 24259] - Origin isolation: test location.href access, a=testonly Automatic update from web-platform-tests Origin isolation: test location.href access location.href access is one of the things that is guarded by the "same-origin domain" check, but it goes down a different code path than generic synchronous property access such as we test with window.document. So, it's worth testing it additionally. Bug: 1042415 Change-Id: I92fc222f895bf25fc1767e7ffddd3d7f7f1f1e86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255102 Reviewed-by: James MacLean <wjmaclean@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#780787} -- wpt-commits: 30dda6576f9858b77e9e3bf96a551ad135bfd2a7 wpt-pr: 24259
e4609ca2c2af0381b57aa08b895f1672b398b0b9: Bug 1647024 [wpt PR 24262] - Update wpt metadata, a=testonly
moz-wptsync-bot <wptsync@mozilla.com> - Mon, 22 Jun 2020 23:32:47 +0000 - rev 601236
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1647024 [wpt PR 24262] - Update wpt metadata, a=testonly wpt-pr: 24262 wpt-type: metadata
853f35a77a30a89e26a5b7a3a2bedf1f2eb69629: Bug 1647024 [wpt PR 24262] - Revert non-URL background images in Forced Colors Mode, a=testonly
Alison Maher <almaher@microsoft.com> - Tue, 23 Jun 2020 21:51:12 +0000 - rev 601235
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1647024 [wpt PR 24262] - Revert non-URL background images in Forced Colors Mode, a=testonly Automatic update from web-platform-tests Revert non-URL background images in Forced Colors Mode As resolved by the CSSWG, non-URL background-images should be reverted in Forced Colors Mode. https://github.com/w3c/csswg-drafts/issues/4916 Bug: 970285 Change-Id: I24c903f96da1921bb3da0388100062091afbb507 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254441 Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#780874} -- wpt-commits: 2e78e6d435f33d7c44e68978fe0b459a801c2ee8 wpt-pr: 24262
394925e5237b9883c2e74fd1419fa7954a7ba17d: Bug 1646999 [wpt PR 24256] - [AspectRatio] Add a test for <picture>, a=testonly
Christian Biesinger <cbiesinger@chromium.org> - Tue, 23 Jun 2020 21:51:06 +0000 - rev 601234
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1646999 [wpt PR 24256] - [AspectRatio] Add a test for <picture>, a=testonly Automatic update from web-platform-tests [AspectRatio] Add a test for <picture> <picture> does not currently let you specify an aspect ratio per source: https://github.com/w3c/csswg-drafts/issues/5212 https://github.com/whatwg/html/issues/4968 So this just tests setting a single aspect-ratio on the <img> element for now. Bug: 1045668 Change-Id: I89f5132322f8131bf346ea663b889e3b1d740e7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254454 Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#780870} -- wpt-commits: 0c5883bd05b5d962ae68998b450510582e6ef6ca wpt-pr: 24256
e34256da98b3c61546d89f25f2f7202517f9ade6: Bug 1646991 [wpt PR 24253] - Fix a wrong paint worklet layout test expectation, a=testonly
Xida Chen <xidachen@chromium.org> - Tue, 23 Jun 2020 21:51:01 +0000 - rev 601233
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1646991 [wpt PR 24253] - Fix a wrong paint worklet layout test expectation, a=testonly Automatic update from web-platform-tests Fix a wrong paint worklet layout test expectation There are actually two problems in this test: 1. The expectation file is wrong, when canvas context.fillRect takes int as size, not '50px'. 2. The test file needs parseInt to convert string to it. This CL fixes the test. Bug: 1096078 Change-Id: I01e6a753d3d9772a39dfacfe8b87f80b6f877b88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254449 Reviewed-by: Kevin Ellis <kevers@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#780773} -- wpt-commits: 2e70a19bfdd6fdb76924f2673f9f7086fe607d29 wpt-pr: 24253
412c316534266f209253a837e96c674fb78ed1fd: Bug 1647083 [wpt PR 24264] - Update mypy to 0.781, a=testonly
pyup-bot <github-bot@pyup.io> - Tue, 23 Jun 2020 21:50:55 +0000 - rev 601232
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1647083 [wpt PR 24264] - Update mypy to 0.781, a=testonly Automatic update from web-platform-tests Update mypy from 0.780 to 0.781 -- wpt-commits: b9bee7acef7e6be2ddefc7491d7fef0c2f9f7aec wpt-pr: 24264
d6f811a145d6e86ed933c82efd68435525a94dd2: Bug 1647247 [wpt PR 24276] - Python 3: port xhr tests [part 5], a=testonly
Ziran Sun <zsun@igalia.com> - Tue, 23 Jun 2020 21:50:50 +0000 - rev 601231
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1647247 [wpt PR 24276] - Python 3: port xhr tests [part 5], a=testonly Automatic update from web-platform-tests Python 3: port xhr tests [part 5] -- wpt-commits: 708893d8180931603d2e6b5e74c45fc2954c4b18 wpt-pr: 24276
97fb6d9db32571e420a13f2bf2292cbbdf2f20f9: Bug 1647223 [wpt PR 24272] - Python 3: port xhr tests [part 2], a=testonly
Ziran Sun <zsun@igalia.com> - Tue, 23 Jun 2020 21:50:44 +0000 - rev 601230
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1647223 [wpt PR 24272] - Python 3: port xhr tests [part 2], a=testonly Automatic update from web-platform-tests Python 3: port xhr tests [part 2] -- wpt-commits: 994da7ee6338dd66d4d0462b05f5962a05f811b5 wpt-pr: 24272
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 tip