875d43d35a71e530b84388ad55d515015c6d3a68: Bug 1530190. Fix unified build bustage in image/Downscaler.cpp. r=aosmond
Timothy Nikkel <tnikkel@gmail.com> - Mon, 22 Apr 2019 17:30:40 -0500 - rev 534555
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1530190. Fix unified build bustage in image/Downscaler.cpp. r=aosmond The unifed tweak I make in the next patch exposes this. Differential Revision: https://phabricator.services.mozilla.com/D28421
bb340bd557d44a059953eb8b5f5e48ab3761a545: Bug 1530190. Change description of DecodePool::mMutex to be more accurate. r=aosmond
Timothy Nikkel <tnikkel@gmail.com> - Mon, 22 Apr 2019 17:30:40 -0500 - rev 534554
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1530190. Change description of DecodePool::mMutex to be more accurate. r=aosmond This mutex only protects the iothread, not the rest of the decodepool. There is a different monitor for that in DecodePoolImpl. Differential Revision: https://phabricator.services.mozilla.com/D28420
71bf2b9ca6ea2cbd97f4a07242e2ad7f20a1a2e5: Bug 1530190. Call SHGetFileInfo off the main thread in nsIconChannel on Windows. r=tnikkel
Andrew Osmond <aosmond@mozilla.com> - Mon, 22 Apr 2019 17:30:40 -0500 - rev 534553
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1530190. Call SHGetFileInfo off the main thread in nsIconChannel on Windows. r=tnikkel There are two reasons for this. One is performance, it can be slow. The second is that is can spin the event loop which can re-enter into things like layout. This patch uses the image decoder thread pool for that. But this is unsuitable (reason in next patch), the next patch changes it to use the img io thread used for network to pass data to imglib off main thread. Differential Revision: https://phabricator.services.mozilla.com/D28419
a5f7f53421ebce84b0dd4cb3535b49906fdf78ef: Merge autoland to mozilla-central. a=merge
shindli <shindli@mozilla.com> - Wed, 22 May 2019 18:23:32 +0300 - rev 534552
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Merge autoland to mozilla-central. a=merge
3c6b640e364f1eb7fc920ed1737de089631882b3: Bug 1552636 - Remove eStyleImageType_URL. r=TYLin
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 22 May 2019 11:34:23 +0000 - rev 534551
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1552636 - Remove eStyleImageType_URL. r=TYLin It was introduced in bug 1352096 to reduce complexity with Stylo (apparently). Right now it doesn't look like it reduces any complexity, and it's a bit annoying with some of the patches that I'm writing at the moment. So unless there's any objection I think it should go away. Differential Revision: https://phabricator.services.mozilla.com/D31708
97a9fa27755b76a1f64fdaa7a2a2ed84fb120af9: Bug 1418472 - Flush line-breaks when encountering a Placeholder for an absolutely-positioned frame. r=emilio
Jonathan Kew <jkew@mozilla.com> - Wed, 22 May 2019 11:33:21 +0000 - rev 534550
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1418472 - Flush line-breaks when encountering a Placeholder for an absolutely-positioned frame. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D32023
03ffbd776c1e8075880041d97c13c7cc31055e04: Bug 1418472 - Add WPT reftests for the abs-pos at line-break issue here. r=emilio
Jonathan Kew <jkew@mozilla.com> - Tue, 21 May 2019 17:02:21 +0000 - rev 534549
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1418472 - Add WPT reftests for the abs-pos at line-break issue here. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D32022
b6e9a64b68d92fcb540c0c90550986d0ada13eab: Backed out changeset 3c2a368a4c8b (bug 1552464) for xpcshell failures on test_rotate_viewport.js on a CLOSED TREE
Oana Pop Rus <opoprus@mozilla.com> - Wed, 22 May 2019 14:57:46 +0300 - rev 534548
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Backed out changeset 3c2a368a4c8b (bug 1552464) for xpcshell failures on test_rotate_viewport.js on a CLOSED TREE
ee7e04b12dd34b89aff8a4e0ba5ae3dc5be7d9f9: Bug 1548542 - Remove notions of Kinto in blocklists unit tests r=keeler,Gijs
Mathieu Leplatre <mathieu@mozilla.com> - Wed, 22 May 2019 11:25:04 +0000 - rev 534547
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1548542 - Remove notions of Kinto in blocklists unit tests r=keeler,Gijs Differential Revision: https://phabricator.services.mozilla.com/D31221
46afaea4fa40e6dbae17245d138e90c973fe20a9: Bug 1553385 - Add context fill to about:preferences permanent private browsing mode info icon for dark mode r=dao
Kestrel <ke5trel@protonmail.com> - Wed, 22 May 2019 08:41:31 +0000 - rev 534546
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1553385 - Add context fill to about:preferences permanent private browsing mode info icon for dark mode r=dao Differential Revision: https://phabricator.services.mozilla.com/D32096
134250706ea6c5988546c73f808815acfc80688e: Bug 1526018 - Initialize PSM clients in their own service r=Gijs,jcj
Mathieu Leplatre <mathieu@mozilla.com> - Tue, 21 May 2019 21:14:11 +0000 - rev 534545
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1526018 - Initialize PSM clients in their own service r=Gijs,jcj Differential Revision: https://phabricator.services.mozilla.com/D31603
3c2a368a4c8bb527fdd37645b015787a3d3e2613: Bug 1552464 - Add telemetry probe to count the number of viewport changes in RDM. r=mtigley,nchevobbe.
Razvan Caliman <rcaliman@mozilla.com> - Tue, 21 May 2019 18:40:23 +0000 - rev 534544
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1552464 - Add telemetry probe to count the number of viewport changes in RDM. r=mtigley,nchevobbe. This patch adds telemetry instrumentation to count the number of times the RDM viewport properties are changed (dimensions and rotation). This count will be correlated with the panel open count and time spent open to refine the baseline for RDM usage and filter out accidental usage. A new Redux middleware, `telemetryMiddleware`, is introduced to the RDM Redux store. This observes actions dispatched to the store. For `RESIZE_VIEWPORT` and `ROTATE_VIEWPORT` actions, it increases a numeric value for the new scalar telemetry probe, `"devtools.responsive.viewport_change_count"`. Other actions may be observed in this middleware for future telemetry instrumentation of RDM. The `RESIZE_VIEWPORT` action is a dispatched with a high frequency when dragging to resize. Therefore, we debounce logging for this action. To ensure the test can reliably test counting this action without adding needless complexity to account for the asynchronicity, the `debounce()` utility is extended with an `immediate` parameter to cause the very first call to be executed immediately before going into the debounce behaviour. Differential Revision: https://phabricator.services.mozilla.com/D31645
e61c315b780db1def991c721606ad947d6848a47: Bug 1553194 - Remove unrelated code comment from shared/css-logic.js r=pbro
Razvan Caliman <rcaliman@mozilla.com> - Wed, 22 May 2019 07:35:02 +0000 - rev 534543
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1553194 - Remove unrelated code comment from shared/css-logic.js r=pbro Depends on D32016 The code comment is perhaps a leftover from a file duplication to extract shared methods to `shared/inspector/css-logic.js` from `server/actors/inspector/css-logic.js`. The comment is confusing because there is no usage of any of the CssLogic terminology within the file. Differential Revision: https://phabricator.services.mozilla.com/D32017
e24c48157bf155e4f92db2e8e33e487fcbfa98db: Bug 1553194 - Remove unnecessary isInherited from CssLogic constructor. r=pbro
Razvan Caliman <rcaliman@mozilla.com> - Wed, 22 May 2019 07:34:03 +0000 - rev 534542
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1553194 - Remove unnecessary isInherited from CssLogic constructor. r=pbro `isInherited` is a callback function that checks if a given CSS property is inherited. It is misleadingly commented as a cache of inherited properties (which perhaps it is on the InspectorUtils implementation, but on the consumer side it is just a function). The actual call is done by InspectorUtils.isPropertyInherited. There is no need to pass the handler to CssLogic or to CssPropertyInfo since InspectorUtils is available in the same context as the definition of the consumers. There is no other use case where a custom handler is passed to check for inherited properties in so it is safe to remove this as an argument and just use InspectorUtils.isPropertyInherited where needed. This cleans up the code slightly. Differential Revision: https://phabricator.services.mozilla.com/D32016
0a9f9f076b93f3d456a3f11a330aae3d42ed6f78: Bug 1553113 - Rename the profiles uploaded by startup main thread IO tests so that treeherder offers to open them in Firefox Profiler, r=mconley.
Florian Quèze <florian@queze.net> - Wed, 22 May 2019 10:03:48 +0000 - rev 534541
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1553113 - Rename the profiles uploaded by startup main thread IO tests so that treeherder offers to open them in Firefox Profiler, r=mconley. Differential Revision: https://phabricator.services.mozilla.com/D31994
bc517e65f14efda9a149410692057c1500dcb0e1: Bug 1549973 - Force tabState flush from C++ listener before tab is closed r=peterv
Alphan Chen <alchen@mozilla.com> - Wed, 22 May 2019 09:06:14 +0000 - rev 534540
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1549973 - Force tabState flush from C++ listener before tab is closed r=peterv Differential Revision: https://phabricator.services.mozilla.com/D30475
81e2959af69065808f368500becaa85f61a9ac1c: Bug 1538270 - Show toast for default file picker when permissions denied.;r=VladBaicu
Brad Arant <brad.arant@softvision.com> - Wed, 22 May 2019 09:10:45 +0000 - rev 534539
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1538270 - Show toast for default file picker when permissions denied.;r=VladBaicu Differential Revision: https://phabricator.services.mozilla.com/D32073
bfb0684033ad22f579ed7bbbc9f0098f72eedb78: Bug 1553413 - Update and harden form data filtering for privacy to account for no data being passed in. r=dao
Mike de Boer <mdeboer@mozilla.com> - Wed, 22 May 2019 09:46:58 +0000 - rev 534538
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1553413 - Update and harden form data filtering for privacy to account for no data being passed in. r=dao Differential Revision: https://phabricator.services.mozilla.com/D32116
41db3c4f9929b832dfdce160ffc57d65280dc15f: Bug 1546255 - When an @import stylesheet is cloned, we should also make sure to restyle. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 22 May 2019 06:01:51 +0000 - rev 534537
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1546255 - When an @import stylesheet is cloned, we should also make sure to restyle. r=heycam We need to notify the whole parent chain (using NOTIFY) rather than just mStyleSets, since mStyleSets is empty for @import-ed sheets. Differential Revision: https://phabricator.services.mozilla.com/D31787
ce950f1fe559c61010ac30386a607fe29bca82b6: Bug 1543684 - When a session is set to resume anyways, skip analyzing previous crashes and always restore immediately. r=dao
Mike de Boer <mdeboer@mozilla.com> - Wed, 22 May 2019 09:08:09 +0000 - rev 534536
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1543684 - When a session is set to resume anyways, skip analyzing previous crashes and always restore immediately. r=dao I also made a few gratuitous code formatting cleanups. I hope you don't mind. We are unable to properly analyze shutdown crashes and deduce the right action to take when that happened. This leads to surprising occurrences of the 'about:sessionrestore' page shown, especially when a full restore is expected anyway. Differential Revision: https://phabricator.services.mozilla.com/D29676
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip