81a9b77172db760892dc00fd5d3c9c6fa0dd891f: Backed out 6 changesets (bug 1518999) for geckoview failures on scrollToVerticalOnZoomedContentAuto.
Cosmin Sabou <csabou@mozilla.com> - Tue, 25 Aug 2020 01:02:36 +0300 - rev 611158
Push 13943 by ffxbld-merge at Mon, 21 Sep 2020 13:41:08 +0000
Backed out 6 changesets (bug 1518999) for geckoview failures on scrollToVerticalOnZoomedContentAuto. Backed out changeset 10bf1552e301 (bug 1518999) Backed out changeset e62cd63e3595 (bug 1518999) Backed out changeset 1bf0b02bb0e0 (bug 1518999) Backed out changeset 2203a9c52afa (bug 1518999) Backed out changeset 10f07ca7a246 (bug 1518999) Backed out changeset b90cf6b54c09 (bug 1518999)
ced8e8e8322c3926439b0b138fe75e44099265a7: Merge autoland to mozilla-central. a=merge
Cosmin Sabou <csabou@mozilla.com> - Tue, 25 Aug 2020 00:49:19 +0300 - rev 611157
Push 13943 by ffxbld-merge at Mon, 21 Sep 2020 13:41:08 +0000
Merge autoland to mozilla-central. a=merge
8a0a081d18f2869213f2e9b5afa21fce33204fe1: Bug 1660877 - Fix leak in nsPrinterListCUPS r=emilio
Erik Nordin <nordzilla@mozilla.com> - Mon, 24 Aug 2020 21:17:53 +0000 - rev 611156
Push 13943 by ffxbld-merge at Mon, 21 Sep 2020 13:41:08 +0000
Bug 1660877 - Fix leak in nsPrinterListCUPS r=emilio Fixes a potential memory leak when retrieving the system default printer name. Differential Revision: https://phabricator.services.mozilla.com/D88063
c8c45320ddaf91733777382ed02334ad77490427: Bug 1660032 - Make the JS Context selector scrollable. r=jdescottes,nchevobbe
Alexandre Poirot <poirot.alex@gmail.com> - Fri, 21 Aug 2020 09:59:34 +0000 - rev 611155
Push 13943 by ffxbld-merge at Mon, 21 Sep 2020 13:41:08 +0000
Bug 1660032 - Make the JS Context selector scrollable. r=jdescottes,nchevobbe I had to put it in toolbox.css as it wasn't working from EvaluationContextSelector.css. I imagine that's because the context DOM element are actually in toolbox document rather than the console one. Also, React must be re-creating all DOM elements anytime there is an update as you can see the list scroll up, everytime there is an update. We should probably have a look at that as well. Differential Revision: https://phabricator.services.mozilla.com/D87620
10d210c411dfd545881deddfd90980cb3911c3d0: Bug 1660026 - Move print preview updating code into print.js r=sfoster,emalysz
Mark Striemer <mstriemer@mozilla.com> - Mon, 24 Aug 2020 19:17:08 +0000 - rev 611154
Push 13943 by ffxbld-merge at Mon, 21 Sep 2020 13:41:08 +0000
Bug 1660026 - Move print preview updating code into print.js r=sfoster,emalysz Differential Revision: https://phabricator.services.mozilla.com/D87366
6e22b4fd2ee0907ccfcf6776094cb24fb518a816: Bug 1660303 - Remove list bullets from text marker navigation. r=Jamie
Eitan Isaacson <eitan@monotonous.org> - Mon, 24 Aug 2020 21:07:14 +0000 - rev 611153
Push 13943 by ffxbld-merge at Mon, 21 Sep 2020 13:41:08 +0000
Bug 1660303 - Remove list bullets from text marker navigation. r=Jamie We need to navigate past bullets when moving markers by character or word, but we need to still include bullets when retrieving the string of a given marker range. Differential Revision: https://phabricator.services.mozilla.com/D87813
486321748d937d60faa08c2813e424f1da7356e2: Bug 1660290 - Robustify text marker reverse iteration. r=Jamie
Eitan Isaacson <eitan@monotonous.org> - Mon, 24 Aug 2020 21:07:10 +0000 - rev 611152
Push 13943 by ffxbld-merge at Mon, 21 Sep 2020 13:41:08 +0000
Bug 1660290 - Robustify text marker reverse iteration. r=Jamie Differential Revision: https://phabricator.services.mozilla.com/D87797
846f88debca60ea217616fdc792a1585aa98f40f: Bug 1660798 - Part 2 - Convert uses of JSAtom* and PropertyName* to ParserAtomId and ParserNameId. r=tcampbell
Kannan Vijayan <kvijayan@mozilla.com> - Mon, 24 Aug 2020 19:50:43 +0000 - rev 611151
Push 13943 by ffxbld-merge at Mon, 21 Sep 2020 13:41:08 +0000
Bug 1660798 - Part 2 - Convert uses of JSAtom* and PropertyName* to ParserAtomId and ParserNameId. r=tcampbell Differential Revision: https://phabricator.services.mozilla.com/D82826
12d099efac67cb345747abd59d4ddf385d8457c4: Bug 1660798 - Part 1 - Adaptor glue to allow for parser to transition to internal atoms representation. r=mgaudet,tcampbell
Kannan Vijayan <kvijayan@mozilla.com> - Mon, 24 Aug 2020 16:51:38 +0000 - rev 611150
Push 13943 by ffxbld-merge at Mon, 21 Sep 2020 13:41:08 +0000
Bug 1660798 - Part 1 - Adaptor glue to allow for parser to transition to internal atoms representation. r=mgaudet,tcampbell Differential Revision: https://phabricator.services.mozilla.com/D84865
72ba4a955fb40f1ea4e47ab4ab27252e55f2f220: Bug 1654962 - Size tab modal print UI to available window size r=Gijs,sfoster,emalysz,pbz
Mark Striemer <mstriemer@mozilla.com> - Mon, 24 Aug 2020 21:00:36 +0000 - rev 611149
Push 13943 by ffxbld-merge at Mon, 21 Sep 2020 13:41:08 +0000
Bug 1654962 - Size tab modal print UI to available window size r=Gijs,sfoster,emalysz,pbz Differential Revision: https://phabricator.services.mozilla.com/D86037
9a0556195f9df083dabb657b953e112c2366f234: Bug 1653937 - Read top site defaults from remote settings. r=mikedeboer
Dão Gottwald <dao@mozilla.com> - Mon, 24 Aug 2020 20:57:53 +0000 - rev 611148
Push 13943 by ffxbld-merge at Mon, 21 Sep 2020 13:41:08 +0000
Bug 1653937 - Read top site defaults from remote settings. r=mikedeboer Differential Revision: https://phabricator.services.mozilla.com/D88041
c369983f2015dd81901fce6867becd4fd632b152: Bug 1660408 - enable rtcp-rsize in default offer;r=bwc
Nico Grunbaum <na-g@nostrum.com> - Mon, 24 Aug 2020 19:53:08 +0000 - rev 611147
Push 13943 by ffxbld-merge at Mon, 21 Sep 2020 13:41:08 +0000
Bug 1660408 - enable rtcp-rsize in default offer;r=bwc This adds rtcp-rsize to the default offer for video, a pref is included in case it needs to be turned off. Differential Revision: https://phabricator.services.mozilla.com/D87835
623e8ceb5c3f24411d0e6dabd6456dafd0bfe1d2: Bug 1660524 - Remove dom.disable_window_open_feature prefs from all.js/firefox.js. r=smaug
Tooru Fujisawa <arai_a@mac.com> - Mon, 24 Aug 2020 18:37:43 +0000 - rev 611146
Push 13943 by ffxbld-merge at Mon, 21 Sep 2020 13:41:08 +0000
Bug 1660524 - Remove dom.disable_window_open_feature prefs from all.js/firefox.js. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D87970
a48154f05b266759429422499787b2d925701c58: Backed out changeset 555de96d4f49 (bug 1653937) as requested by dao.
Mihai Alexandru Michis <malexandru@mozilla.com> - Mon, 24 Aug 2020 23:50:58 +0300 - rev 611145
Push 13943 by ffxbld-merge at Mon, 21 Sep 2020 13:41:08 +0000
Backed out changeset 555de96d4f49 (bug 1653937) as requested by dao. CLOSED TREE
bc10221a926d3561e215d0ba3ca22bf315fda13d: Backed out changeset 773188fb9acf (bug 1660551) for causing bustages.
Mihai Alexandru Michis <malexandru@mozilla.com> - Mon, 24 Aug 2020 23:33:44 +0300 - rev 611144
Push 13943 by ffxbld-merge at Mon, 21 Sep 2020 13:41:08 +0000
Backed out changeset 773188fb9acf (bug 1660551) for causing bustages. CLOSED TREE
abdf912d175b93a20a886dcb92ec7adba0e82ec2: Bug 1660345 - Remove unnecessary process checks from BrowserParent, r=kmag
Anny G <annygakh@mozilla.com> - Mon, 24 Aug 2020 20:24:04 +0000 - rev 611143
Push 13943 by ffxbld-merge at Mon, 21 Sep 2020 13:41:08 +0000
Bug 1660345 - Remove unnecessary process checks from BrowserParent, r=kmag Differential Revision: https://phabricator.services.mozilla.com/D88066
b3d572eae3595cafbb3c57b1caccf6d8a6650f0b: Bug 1659764 - Fix compositor surface overlap with native compositors. r=mattwoodrow
Glenn Watson <git@intuitionlibrary.com> - Mon, 24 Aug 2020 20:22:21 +0000 - rev 611142
Push 13943 by ffxbld-merge at Mon, 21 Sep 2020 13:41:08 +0000
Bug 1659764 - Fix compositor surface overlap with native compositors. r=mattwoodrow This patch fixes a regression introduced when support was added for transforms with native OS compositor surfaces. We need to store both the true device rect and also the pre-transform device rect for the external surface descriptor. The true device rect is used for overlap detection to order compositor surfaces correctly, while the pre-transform rect is sent to the native OS compositor, since the transform is applied at that level. Differential Revision: https://phabricator.services.mozilla.com/D87683
555de96d4f49ef1bb0684c27c458f10958124ec5: Bug 1653937 - Read top site defaults from remote settings. r=mikedeboer
Dão Gottwald <dao@mozilla.com> - Mon, 24 Aug 2020 17:55:40 +0000 - rev 611141
Push 13943 by ffxbld-merge at Mon, 21 Sep 2020 13:41:08 +0000
Bug 1653937 - Read top site defaults from remote settings. r=mikedeboer Differential Revision: https://phabricator.services.mozilla.com/D88041
c4a5371dcac9601e3b28f7e3033e5c6908937d5b: Bug 1657648 - Rewrite muxer and show more local suggestions if there aren't many remote suggestions. r=harry
Drew Willcoxon <adw@mozilla.com> - Mon, 24 Aug 2020 14:44:58 +0000 - rev 611140
Push 13943 by ffxbld-merge at Mon, 21 Sep 2020 13:41:08 +0000
Bug 1657648 - Rewrite muxer and show more local suggestions if there aren't many remote suggestions. r=harry This rewrites the muxer. I'll explain why. The obvious way to fix this bug is to modify UrlbarProviderSearchSuggestions so it adds `maxHistoricalSearchSuggestions` form history results first, followed by as many remote suggestions as there are, followed by any remaining form history results. And in fact that's what this patch does. But the muxer isn't capable of handling that very well, with regard to deuping SERPs and form history. The muxer does a first pass through all results, and it builds a set of form history suggestions. Then, as it's adding URL results in the second pass, it excludes SERPs whose search terms are in the set. The problem is that the set can include search terms from form history results that do not end up in the final list of results. And that's because UrlbarProviderSearchSuggestions now returns many form history results -- as many as `context.maxResults + 1` so that there are enough of them to fill the view when appropriate. This is a problem with the muxer in general. It collects a bunch of state from all results in its first pass, even though not all of those results may end up in the final list. Worst case, we may end up excluding results we should not exclude. The fundamental problem is that the muxer doesn't know which results will end up being included until it starts including results. The key thing about this rewrite is that the muxer builds up state as it goes along filling its buckets. If a result is excluded, then it doesn't contribute to the state used to determine whether subsequent results should be included. There are a couple of exceptions though where it still does build state using all results. (1) It still determines the heuristic this way, but that's OK since there's only one heuristic. (2) It still builds `strippedUrlToTopPrefixAndTitle` this way. I couldn't think of a nice way around that, because AFAICT there's no guarantee that UnifiedComplete will put the higher-ranking URL result before the lower one. If the lower one comes first, we'd end up including it too since `strippedUrlToTopPrefixAndTitle` would not contain the higher-ranking one at that point. There's one drawback of building up the state in this new way. It's the flip side of solving the problem above. If a result depends in some way on a subsequent result, then the state at that first result won't be accurate and the muxer will make a bad decision about that result. There's an example of this in test_search_suggestions.js, near the bottom of the `formHistory` task. In that test, `matchBuckets` is defined so that general results (e.g., history) appear before search suggestions. That means the SERP in history can't be deduped in favor of the form history result that appears later, so both results appear. I think that's better than the alternative of possibly deduping too aggressively. One important thing to note is that this patch isn't restricted to search mode. It will always include more form history results to fill out the final list if some other higher-ranked result group doesn't fill it out sooner. Currently `matchBuckets` is `heuristic,1,extension,5,suggestion,4,general,Infinity,suggestion,Infinity,general,Infinity.` Since `general,Infinity` comes before `suggestion,Infinity`, this means that if there aren't enough general results to fill out the list, then suggestions will fill it out as much as possible. Within suggestions, remote suggestions will fill it out first and then form history, since that's the order that UrlbarProviderSearchSuggestions adds them in after the initial `maxHistoricalSearchSuggestions` form history results. I think that's what we want regardless of search mode. Finally, this patch also breaks up `sort` into more, smaller methods. The patch started out as a much larger version that also redesigned `matchBuckets`. That's the main reason I split it up, but it's nice by itself I think. (I'd like to come back to that `matchBuckets` redesign, which could now build on top of this. The original patch is in D87830.) Differential Revision: https://phabricator.services.mozilla.com/D87838
d809d55636b677aa5c693b90b355d5578e89129d: Bug 1660828 - move `HAVE_AS_X86_64_UNWIND_SECTION_TYPE` to be x86-64 Unix-specific; r=firefox-build-system-reviewers,rstewart
Nathan Froyd <froydnj@mozilla.com> - Mon, 24 Aug 2020 19:31:43 +0000 - rev 611139
Push 13943 by ffxbld-merge at Mon, 21 Sep 2020 13:41:08 +0000
Bug 1660828 - move `HAVE_AS_X86_64_UNWIND_SECTION_TYPE` to be x86-64 Unix-specific; r=firefox-build-system-reviewers,rstewart Somehow we have had it be a general define, but it has not mattered...at least it won't matter until we upgrade to clang 11, at which point the compiler will start to complain at us about the codepaths this define activates. Differential Revision: https://phabricator.services.mozilla.com/D88056
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 tip