7b7026149e56e8af45061fb7769f83b06c3c7dd8: Bug 1440177 - Part 3: Preallocate a small number of PaintedLayerData objects and only resize the mPaintedLayerDataStack once. r=jnicol
Matt Woodrow <mwoodrow@mozilla.com> - Thu, 15 Feb 2018 14:45:35 +1300 - rev 458699
Push 8808 by archaeopteryx@coole-files.de at Fri, 02 Mar 2018 22:13:05 +0000
Bug 1440177 - Part 3: Preallocate a small number of PaintedLayerData objects and only resize the mPaintedLayerDataStack once. r=jnicol MozReview-Commit-ID: 4RvU35pBz3z
ef972081de6964e22c38b6bbd1455d7bcb282723: Bug 1440177 - Part 2: Combine PaintedLayerItemsEntry and PaintedDisplayItemLayerUserData into a single struct. r=jnicol
Matt Woodrow <mwoodrow@mozilla.com> - Tue, 13 Feb 2018 15:56:43 +1300 - rev 458698
Push 8808 by archaeopteryx@coole-files.de at Fri, 02 Mar 2018 22:13:05 +0000
Bug 1440177 - Part 2: Combine PaintedLayerItemsEntry and PaintedDisplayItemLayerUserData into a single struct. r=jnicol These two structs store very similar state (including duplicating the mask layer common clip count), and the former uses an expensive hashtable for lookups. This patch combines the two, and uses a vector of entries instead of the hashtable so we can do the cleanup pass. * * * [mq]: fix MozReview-Commit-ID: KamhbGAIqpD
8d4b4e8e9d048da096f52f5b319290b079a808b3: Bug 1440177 - Part 1: Don't call GetLayerState from BuildContainerLayerFor as it recurses into child display items to find the answer. r=jnicol
Matt Woodrow <mwoodrow@mozilla.com> - Tue, 13 Feb 2018 14:25:55 +1300 - rev 458697
Push 8808 by archaeopteryx@coole-files.de at Fri, 02 Mar 2018 22:13:05 +0000
Bug 1440177 - Part 1: Don't call GetLayerState from BuildContainerLayerFor as it recurses into child display items to find the answer. r=jnicol MozReview-Commit-ID: 3A4OBC5L6Ps
17439bf87b9aae5c6353a89a595fb8b3d5faeb60: Bug 1440040 - Improve MediaEngineWebRTCMicrophoneSource logging. r=padenot
Andreas Pehrson <pehrsons@mozilla.com> - Wed, 28 Feb 2018 22:46:33 +0100 - rev 458696
Push 8808 by archaeopteryx@coole-files.de at Fri, 02 Mar 2018 22:13:05 +0000
Bug 1440040 - Improve MediaEngineWebRTCMicrophoneSource logging. r=padenot MozReview-Commit-ID: 3mB1gZOGfCY
e052863c1979bdb805764528544d3e8a77c23e57: Bug 1440040 - Fix assertion that checks for appending silence in real callback when enabled. r=padenot
Andreas Pehrson <pehrsons@mozilla.com> - Wed, 28 Feb 2018 22:45:40 +0100 - rev 458695
Push 8808 by archaeopteryx@coole-files.de at Fri, 02 Mar 2018 22:13:05 +0000
Bug 1440040 - Fix assertion that checks for appending silence in real callback when enabled. r=padenot MozReview-Commit-ID: IiEQ7fKKz8g
20005cd06f7875950a02714c36327b9529b26f0d: Bug 1440040 - Properly apply microphone capture settings. r=padenot
Andreas Pehrson <pehrsons@mozilla.com> - Wed, 28 Feb 2018 22:41:15 +0100 - rev 458694
Push 8808 by archaeopteryx@coole-files.de at Fri, 02 Mar 2018 22:13:05 +0000
Bug 1440040 - Properly apply microphone capture settings. r=padenot MozReview-Commit-ID: 7TqYvHrltxm
52312a6c6becf6c19d3f733a8c268086bd4a2587: Bug 1440040 - Don't round up to next block unless necessary. r=padenot
Andreas Pehrson <pehrsons@mozilla.com> - Wed, 28 Feb 2018 22:37:02 +0100 - rev 458693
Push 8808 by archaeopteryx@coole-files.de at Fri, 02 Mar 2018 22:13:05 +0000
Bug 1440040 - Don't round up to next block unless necessary. r=padenot With block size 128, rounding `128` to end of next block gives `256`, which is not what we want when running MSG iterations. That could mean over-iterating and buffering unnecessary amounts of silence. MozReview-Commit-ID: vW14l2ygRy
723f97b68476b396cf7336d87e6c7c646c2365b7: Bug 1441018 - Add snippets data, lazy menus and bug fixes to Activity Stream. r=k88hudson
Ed Lee <edilee@mozilla.com> - Thu, 01 Mar 2018 11:21:00 -0800 - rev 458692
Push 8808 by archaeopteryx@coole-files.de at Fri, 02 Mar 2018 22:13:05 +0000
Bug 1441018 - Add snippets data, lazy menus and bug fixes to Activity Stream. r=k88hudson MozReview-Commit-ID: 6CilV8vrqwY
7a1af2d03c5435747257e43e94af48c4349190ed: Bug 1439882 - Removes several redundant #include directives in layout files r=dholbert
Zhang Junzhi <zjz@zjz.name> - Fri, 02 Mar 2018 04:12:39 +0800 - rev 458691
Push 8808 by archaeopteryx@coole-files.de at Fri, 02 Mar 2018 22:13:05 +0000
Bug 1439882 - Removes several redundant #include directives in layout files r=dholbert Some included headers for source code in layout directory are left unused. This patch merely removes these redundant headers. All of these headers are still found in use for other code, so all of them and their related cpp files are kept still. MozReview-Commit-ID: KCleuWyOV8Z
39df0ca8a664608014c4b03d2644ee608514b6fa: Bug 1429904 - Remove ProfileBuffer::Reset(). r=njn
Markus Stange <mstange@themasta.com> - Thu, 15 Feb 2018 21:49:05 -0500 - rev 458690
Push 8808 by archaeopteryx@coole-files.de at Fri, 02 Mar 2018 22:13:05 +0000
Bug 1429904 - Remove ProfileBuffer::Reset(). r=njn MozReview-Commit-ID: AzIyYByoesS
14627f6eefd10400b30e165da220d2f190648a88: Bug 1429904 - Remove unused arguments and return values. r=njn
Markus Stange <mstange@themasta.com> - Sat, 17 Feb 2018 19:21:05 -0500 - rev 458689
Push 8808 by archaeopteryx@coole-files.de at Fri, 02 Mar 2018 22:13:05 +0000
Bug 1429904 - Remove unused arguments and return values. r=njn MozReview-Commit-ID: 9P0TKavkwgA
0d15c7f905365c952ec5c42ef7e0f4315276ec8a: Bug 1429904 - When a JSContext for a thread is about to go away, collect enough information about any JIT entries in the buffer so that the entire buffer can be streamed to JSON. r=njn
Markus Stange <mstange@themasta.com> - Wed, 28 Feb 2018 00:17:16 -0500 - rev 458688
Push 8808 by archaeopteryx@coole-files.de at Fri, 02 Mar 2018 22:13:05 +0000
Bug 1429904 - When a JSContext for a thread is about to go away, collect enough information about any JIT entries in the buffer so that the entire buffer can be streamed to JSON. r=njn This changeset changes behavior. If the profile is streamed before any JSContext has gone away, we now iterate over the entire buffer twice (per thread): First, to collect information about JIT frames, and then again when we build the JSON for the samples. The first traversal stores small pieces of JSON for JIT fromes in individual strings, and the second iteration splices those strings into the thread JSON's frame table. When the JSContext for a thread goes away, we no longer build JSON for samples, and we don't reset the profiler buffer. We now only build the JSON for JIT frames. Once the complete profile is requested and we build samples for it, we iterate over the entire buffer, and look up the cached JIT frame information for JitReturnAddr entries from the correct range. Different parts of the buffer may correspond to the life time of different JSContexts: For each JSContext we will have one range in the JITFrameInfo, and we can look up the correct range based on the buffer position of the JitReturnAddr entry that we're processing. This new way of doing things has multiple advantages: - We no longer reset the buffer, so we no longer lose information about other threads. - All threads from a given process now always have sample data for the same time range. Before this change, the "partial profile" from a thread that lost its JSContext could extend further into the past than the other threads' profiles. - Requesting profiles multiple times now has more consistent results. Before this change, the first requested profile would include the partial profile, but then the partial profile was discarded. And the second requested profile would not contain any data for the time before the JSContext went away. - We now do less work when a thread's JSContext goes away. This should decrease the interruption time. MozReview-Commit-ID: 3KhnPtBijna
3284f277d5323ab2ea5775588b9e37d5558655f1: Bug 1429904 - Add JITFrameInfo. r=njn
Markus Stange <mstange@themasta.com> - Wed, 28 Feb 2018 00:13:51 -0500 - rev 458687
Push 8808 by archaeopteryx@coole-files.de at Fri, 02 Mar 2018 22:13:05 +0000
Bug 1429904 - Add JITFrameInfo. r=njn MozReview-Commit-ID: DashxIKyzYZ
b323ee89d4c7cc81c5d7b7a4d1e3292f074f976d: Bug 1429904 - Put mUniqueStrings into a UniquePtr. r=njn
Markus Stange <mstange@themasta.com> - Sat, 17 Feb 2018 15:50:43 -0500 - rev 458686
Push 8808 by archaeopteryx@coole-files.de at Fri, 02 Mar 2018 22:13:05 +0000
Bug 1429904 - Put mUniqueStrings into a UniquePtr. r=njn In an upcoming patch we'll want to initialize mUniqueStrings by stealing another object's UniqueJSONStrings, but UniqueJSONStrings itself is not move-constructible. But UniquePtr is. Making UniqueJSONStrings itself move-constructible would be a bit tricky because it has a SpliceableChunkedJSONWriter which is not move-constructible; and making SpliceableChunkedJSONWriter move-constructible is hard because there's no obvious "empty but valid" state that we could leave a moved-out-of SpliceableChunkedJSONWriter in; for example, it expects to have a non-null WriteFunc at all times. MozReview-Commit-ID: Q6o61HFTiD
d3a10f0b9df618edbc2758ce2f32aa926b5de906: Bug 1429904 - Give UniqueJSONStrings a copy constructor. r=njn
Markus Stange <mstange@themasta.com> - Sat, 17 Feb 2018 15:39:45 -0500 - rev 458685
Push 8808 by archaeopteryx@coole-files.de at Fri, 02 Mar 2018 22:13:05 +0000
Bug 1429904 - Give UniqueJSONStrings a copy constructor. r=njn MozReview-Commit-ID: tlh6qkYX7A
099e70b23f74d675e95df652d74a1dbaf29339e2: Bug 1429904 - Tell the ProfiledThreadData what the buffer position was when the thread received its JSContext. r=njn
Markus Stange <mstange@themasta.com> - Sat, 17 Feb 2018 15:03:30 -0500 - rev 458684
Push 8808 by archaeopteryx@coole-files.de at Fri, 02 Mar 2018 22:13:05 +0000
Bug 1429904 - Tell the ProfiledThreadData what the buffer position was when the thread received its JSContext. r=njn This also renames FlushSamplesAndMarkers to NotifyAboutToLoseJSContext. MozReview-Commit-ID: FWinMi85yDZ
5438aa8b248a59a16e14c961bb32f33d90c218d7: Bug 1429904 - Use a Variant to split the FrameKey members into two groups. r=njn
Markus Stange <mstange@themasta.com> - Tue, 27 Feb 2018 23:44:02 -0500 - rev 458683
Push 8808 by archaeopteryx@coole-files.de at Fri, 02 Mar 2018 22:13:05 +0000
Bug 1429904 - Use a Variant to split the FrameKey members into two groups. r=njn This makes it clear which combinations of fields are possible. MozReview-Commit-ID: C3PriO7nWsJ
c072bfec3cd0e6edc11c7b17ea0a73f45487d4e5: Bug 1429904 - Add 'using namespace mozilla;' to ProfileBufferEntry.cpp and remove some mozilla:: prefixes. r=njn
Markus Stange <mstange@themasta.com> - Sat, 17 Feb 2018 12:35:57 -0500 - rev 458682
Push 8808 by archaeopteryx@coole-files.de at Fri, 02 Mar 2018 22:13:05 +0000
Bug 1429904 - Add 'using namespace mozilla;' to ProfileBufferEntry.cpp and remove some mozilla:: prefixes. r=njn I think this file was picking up such a declaration from a different file already, through unified builds. MozReview-Commit-ID: 9xTB2QA86U0
0bf304822495a39b50a173fb1f62cc7602bbcab8: Bug 1429904 - Remove a comment about std::string. r=njn
Markus Stange <mstange@themasta.com> - Wed, 28 Feb 2018 00:30:55 -0500 - rev 458681
Push 8808 by archaeopteryx@coole-files.de at Fri, 02 Mar 2018 22:13:05 +0000
Bug 1429904 - Remove a comment about std::string. r=njn nsCString is the idiomatic string class we want to use anyway. There's no need to think about std::string here. MozReview-Commit-ID: 1rjZAyqp13d
b465484b85ab8a071a51d7d4a7129d0437964ac3: Bug 1429904 - Make FrameKey members const. r=njn
Markus Stange <mstange@themasta.com> - Tue, 27 Feb 2018 23:11:34 -0500 - rev 458680
Push 8808 by archaeopteryx@coole-files.de at Fri, 02 Mar 2018 22:13:05 +0000
Bug 1429904 - Make FrameKey members const. r=njn MozReview-Commit-ID: KTYmCJM9tOH
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip