760a16bf0d2b2be3062670590dd64a977acd4685: Merge autoland to mozilla-central. a=merge
Noemi Erli <nerli@mozilla.com> - Fri, 26 Oct 2018 18:47:12 +0300 - rev 499553
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Merge autoland to mozilla-central. a=merge
4ee89e659d382b1052dca58c955dd675c9f2a80f: Bug 1502344 - Update webrender to commit 2537e5f27c2ce7b64a93498c7569a870c190feda. r=kats
WR Updater Bot <graphics-team@mozilla.staktrace.com> - Fri, 26 Oct 2018 13:08:25 +0000 - rev 499552
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1502344 - Update webrender to commit 2537e5f27c2ce7b64a93498c7569a870c190feda. r=kats Differential Revision: https://phabricator.services.mozilla.com/D9908
e02bbef03c88272b754768d0f7a0c2252e5c93e2: Bug 1502156 - Update webrender to commit 20214bf371002786cfd8daabf58c815bf1ee84a3. r=kats
WR Updater Bot <graphics-team@mozilla.staktrace.com> - Fri, 26 Oct 2018 13:05:51 +0000 - rev 499551
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1502156 - Update webrender to commit 20214bf371002786cfd8daabf58c815bf1ee84a3. r=kats Differential Revision: https://phabricator.services.mozilla.com/D9907
f106b1dc2db1c29df92e5f653c4de2b9d96e63d5: bug 1502273 - improve the LOAD_FRESH_CONNECTION description r=dragana
Daniel Stenberg <daniel@haxx.se> - Fri, 26 Oct 2018 12:18:28 +0000 - rev 499550
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
bug 1502273 - improve the LOAD_FRESH_CONNECTION description r=dragana MozReview-Commit-ID: 4y5SkKkK64r Differential Revision: https://phabricator.services.mozilla.com/D9892
1f0ea920012282582551a6eae8c36ef2b62ca9b7: Bug 1437631 - Flexbox highlighter doesn't honor RTL or writing mode r=gl
Michael Ratcliffe <mratcliffe@mozilla.com> - Fri, 26 Oct 2018 12:12:48 +0000 - rev 499549
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1437631 - Flexbox highlighter doesn't honor RTL or writing mode r=gl This patch fixes **all** issues caused by RTL or writing mode. Differential Revision: https://phabricator.services.mozilla.com/D8429
f2ea2c762c5dd5a82534ba4a1cf87891b015a59a: Bug 1502312 PlacesUtils.validatePageInfo isn't setting requiredIf for url/guid properly. r=mak
Mark Banner <standard8@mozilla.com> - Fri, 26 Oct 2018 12:03:12 +0000 - rev 499548
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1502312 PlacesUtils.validatePageInfo isn't setting requiredIf for url/guid properly. r=mak Differential Revision: https://phabricator.services.mozilla.com/D9902
aa01df6dc4db602fff7b15b8179fa936a5141700: Bug 1497182 - Flexbox justify-content incorrectly drawn when using flex-direction: row-reverse r=gl
Michael Ratcliffe <mratcliffe@mozilla.com> - Fri, 26 Oct 2018 12:00:16 +0000 - rev 499547
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1497182 - Flexbox justify-content incorrectly drawn when using flex-direction: row-reverse r=gl Differential Revision: https://phabricator.services.mozilla.com/D7999
5866c7a7e9066aa7451bf056cd82ca0683093bff: Bug 1501624 - Add a method for setting the value from a result and migrate urlbar tests away from setting textValue. r=Standard8
Dão Gottwald <dao@mozilla.com> - Fri, 26 Oct 2018 09:52:23 +0000 - rev 499546
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1501624 - Add a method for setting the value from a result and migrate urlbar tests away from setting textValue. r=Standard8 Differential Revision: https://phabricator.services.mozilla.com/D9764
d0c4e1db970ef48154e77ae540f8bc71b1431ed1: Bug 1499049 - (Part 9) Add tests for tracking changes to CSS declarations from the Rule view; r=pbro
Razvan Caliman <rcaliman@mozilla.com> - Thu, 25 Oct 2018 16:01:21 +0000 - rev 499545
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1499049 - (Part 9) Add tests for tracking changes to CSS declarations from the Rule view; r=pbro Depends on D9659 Adds infrastructure and tests for validating that changes to CSS declarations in the Inspector Rule view are tracked and show up in the Changes panel. Makes use of the `client/inspector/rules/test/head.js` file with helpers to instrument changes in the Rule view then observe results on the Changes panel. This is a first pass on tests. More will follow to validate: - declarations in at-rules; - nested at-rules; - declarations in various sources: inline styles, external stylesheets. Differential Revision: https://phabricator.services.mozilla.com/D9660
629deef4613c09a0f081fc804507355b250aab77: Bug 1499049 - (Part 8) Clear the changes store when about to navigate to a new page; r=pbro
Razvan Caliman <rcaliman@mozilla.com> - Thu, 25 Oct 2018 08:07:40 +0000 - rev 499544
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1499049 - (Part 8) Clear the changes store when about to navigate to a new page; r=pbro Depends on D9257 We need to clear the store of previous changes but we should not remove references and event listeners to the ChangesActor since the DevTools session is still active. MozReview-Commit-ID: Okp2CcSlfw Differential Revision: https://phabricator.services.mozilla.com/D9659
c4f23d37432644acf51200bb418a5029e66b0a68: Bug 1499049 - (Part 7) Fix issues with toggled and renamed CSS declarations r=pbro;
Razvan Caliman <rcaliman@mozilla.com> - Thu, 25 Oct 2018 11:07:29 +0000 - rev 499543
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1499049 - (Part 7) Fix issues with toggled and renamed CSS declarations r=pbro; Depends on D8967 This patch fixes an issue where toggling a new CSS declaration OFF then back ON would make the Changes panel lose track of its existence. This happened because tracked changes don't have context about "disabled" state, only "add" or "remove", like diffs. Additionally, this patch fixes the case where renaming a property would erroneously track two distinct operations (rename + add). To fix this, we prevent the inline editor for the property name from the CSS Rules view to advance and focus the property value, which then immediately blurred triggering a fake second operation to be tracked. Auto-advancing to the property value inline editor still works if adding a new declaration or if the property name ends with a colon, ":", therefore old behaviour is not lost. MozReview-Commit-ID: Faw2DeCJJYk Differential Revision: https://phabricator.services.mozilla.com/D9257
f7565ed1376dc6cc9ffa6b9f054a9a4aeaa2f480: Bug 1499049 - (Part 6) Support !important in changed CSS property values; r=pbro
Razvan Caliman <rcaliman@mozilla.com> - Thu, 25 Oct 2018 11:06:56 +0000 - rev 499542
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1499049 - (Part 6) Support !important in changed CSS property values; r=pbro Depends on D8722 Include the "!importat" priority flag when tracking changes to CSS declarations. Differential Revision: https://phabricator.services.mozilla.com/D8967
0b04c98133b3d22225d8aeb7c4df325ccaa0fea3: Bug 1499049 - (Part 5) Refactor Changes panel to render diff of nested CSS rule structures; r=pbro
Razvan Caliman <rcaliman@mozilla.com> - Thu, 25 Oct 2018 13:42:05 +0000 - rev 499541
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1499049 - (Part 5) Refactor Changes panel to render diff of nested CSS rule structures; r=pbro Depends on D8721 - Externalize reusable CSSDeclaration React component; - Introduce the ability to render rules with unlimited levels of nesting, but cap indentation in the UI at a reasonable level; - Remove accordion behavior from rules, but keep for sources; - Cleanup CSS styles for Changes panel. Differential Revision: https://phabricator.services.mozilla.com/D8722
578d839f3c6c472b43b0fc9b4753549ebdb9ccb3: Bug 1499049 - (Part 4) Remove tracked rules and sources that end up unchanged; r=pbro
Razvan Caliman <rcaliman@mozilla.com> - Thu, 25 Oct 2018 11:05:55 +0000 - rev 499540
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1499049 - (Part 4) Remove tracked rules and sources that end up unchanged; r=pbro Depends on D8720 If all of the changes to a CSS rule cancel each other out, remove the information about the rule from the Redux store. If none of the rules in a source end up changed, remove the information about the source form the Redux store. This ensures the Changes panel only shows actual diffs and not empty signatures of rules which were changed but the sum of their changes means nothing really changed. MozReview-Commit-ID: 4n9yRkFdmN4 Differential Revision: https://phabricator.services.mozilla.com/D8721
90491f2fdf3db959f918b6419f013c2f887f17a7: Bug 1499049 - (Part 3) Add new reducer logic for tracking CSS changes to nested rules; r=pbro
Razvan Caliman <rcaliman@mozilla.com> - Thu, 25 Oct 2018 16:20:00 +0000 - rev 499539
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1499049 - (Part 3) Add new reducer logic for tracking CSS changes to nested rules; r=pbro Depends on D8719 - Add methods to generate unique identifiers for stylesheets and CSS rules changed within those stylesheets. These are used as IDs in the Redux store; - Add logic to generate entries in the store for each one of the rule's ancestors and assign parent/child dependencies. This single-level structure for all rules in a source helps with quickly identifying a rule on subsequent changes independent of its rule tree (it avoids needless tree traversal). The parent/child references help with rendering of the nested rule structure in the Changes panel; - Deep clone Redux store state before aggregating tracked changes (no more mutations of previous state). Differential Revision: https://phabricator.services.mozilla.com/D8720
1d612a71f940facc02938a5666e68f56902e8022: Bug 1499049 - (Part 2) Remove old reducer logic for tracking CSS changes; r=pbro
Razvan Caliman <rcaliman@mozilla.com> - Thu, 25 Oct 2018 13:21:38 +0000 - rev 499538
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1499049 - (Part 2) Remove old reducer logic for tracking CSS changes; r=pbro Depends on D8718 Opting to first completely remove, then add the new logic, otherwise the diff gets very confusing since most of the code changed MozReview-Commit-ID: BbncSBhD5py Differential Revision: https://phabricator.services.mozilla.com/D8719
d476c9f67f34f5e89a6600baedb64711883193dc: Bug 1499049 - (Part 1) Log ancestor rule tree for changes to CSS declarations; r=pbro
Razvan Caliman <rcaliman@mozilla.com> - Wed, 24 Oct 2018 17:43:33 +0000 - rev 499537
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1499049 - (Part 1) Log ancestor rule tree for changes to CSS declarations; r=pbro ⚠️ **To build locally, this change series depends on the [change series](https://phabricator.services.mozilla.com/D4399) which adds the ChangesActor**. 🏋️‍♂️ **To test hands-on, you can download a [custom macOS build](https://queue.taskcluster.net/v1/task/HIiZcwLXTuuSYYjfwEDmmA/runs/0/artifacts/public/build/target.dmg) (updated Wed, Oct 24) which includes both change series.** - Introduce ancestorRules getter to StyleRuleActor to get a flattened rule tree with the ancestors of the current rule; - Introduce CSSRuleTypeName to css-logic helpers to map between CSS rule type and human-readable name; - Log rule index position with each CSS declaration change to help differentiate between changes to rules with identical selectors at the same level of nesting. Differential Revision: https://phabricator.services.mozilla.com/D8718
8d38810fdc7309de2520fb9b36abbb09767a4bee: Bug 1497526 - TransactionTooLargeException when downloading from Data URLs; r=jchen
Petru Lingurar <petru.lingurar@softvision.ro> - Fri, 26 Oct 2018 07:39:01 +0000 - rev 499536
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1497526 - TransactionTooLargeException when downloading from Data URLs; r=jchen The issue stems from putting download's source url as `cookie` in the pending intent for when the download notification is clicked. This cookie functions like a tag, allowing to identify a particular download. The problem is that a download's url can be a Data URL for which Mozilla imposes no size limit. When an Android Intent with that payload is used it counts against Binder's 1MB limit which can result in the TransactionTooLargeException. If we are to truncate download's source url to an arbitrary length of 100 we should still get a unique `cookie` for that download and at the same time avoid cluttering Notification's contentIntent. Differential Revision: https://phabricator.services.mozilla.com/D9666
095cb0042729b07598ca8139eb30284c5a564024: Bug 1500138 - Remove browser.urlbar.matchBehavior and some unused Address Bar behaviors. r=adw
Marco Bonardo <mbonardo@mozilla.com> - Thu, 25 Oct 2018 23:23:36 +0000 - rev 499535
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1500138 - Remove browser.urlbar.matchBehavior and some unused Address Bar behaviors. r=adw Remove browser.urlbar.matchBehavior pref. Remove code for BEGINNING behaviors, and stop referencing MATCH_BOUNDARY_ANYWHERE from our code. Differential Revision: https://phabricator.services.mozilla.com/D9806
eaf542a7bdb119fdb0585e149e4827eed185b456: Bug 1501113 Disable local partials caching to work around races r=aki
Simon Fraser <sfraser@mozilla.com> - Thu, 25 Oct 2018 18:57:22 +0000 - rev 499534
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1501113 Disable local partials caching to work around races r=aki Differential Revision: https://phabricator.services.mozilla.com/D9628
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip