74e72eb8369d8f494be2943cbf010d072d3e266c: Bug 1549075 Don't blow up on builtin addons while rebuilding the extensions database r=kmag a=lizzard CLOSED TREE
Andrew Swan <aswan@mozilla.com> - Sat, 04 May 2019 19:23:37 -0700 - rev 531369
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1549075 Don't blow up on builtin addons while rebuilding the extensions database r=kmag a=lizzard CLOSED TREE Differential Revision: https://phabricator.services.mozilla.com/D29954
023dd959512e2cfa685187616560f91efa91183c: Bug 1549061 - Add intermediate certificate r=kmag a=lizzard CLOSED TREE
Rob Wu <rob@robwu.nl> - Sat, 04 May 2019 21:39:46 +0000 - rev 531368
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1549061 - Add intermediate certificate r=kmag a=lizzard CLOSED TREE This patch relies on a schema bump in a previous commit to be effective for users. Differential Revision: https://phabricator.services.mozilla.com/D29940
9419be649effc5bc67eb3d6fce1db46caa7fae7e: Back out changeset fa013d593d02e29d9062900f89a14fd40a9ba687 (bug 1549010). a=sylvestre
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 04 May 2019 11:57:19 +0200 - rev 531367
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Back out changeset fa013d593d02e29d9062900f89a14fd40a9ba687 (bug 1549010). a=sylvestre CLOSED TREE
24a6a4f933a8289666dbda9b9c5e39c2de89fa4f: Backed out changeset 03166449953f (bug 1539759) on request from past for causing bug 1548990. CLOSED TREE
Cosmin Sabou <csabou@mozilla.com> - Sat, 04 May 2019 11:02:30 +0300 - rev 531366
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Backed out changeset 03166449953f (bug 1539759) on request from past for causing bug 1548990. CLOSED TREE
e9bfe907b847e08e7fe89e12e6d86aa6115c99d9: Bug 1549010: Part 2 - Bump DB schema version to force certificate reverification. r=zombie a=lizzard CLOSED TREE
Kris Maglione <maglione.k@gmail.com> - Fri, 03 May 2019 21:32:17 -0700 - rev 531365
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1549010: Part 2 - Bump DB schema version to force certificate reverification. r=zombie a=lizzard CLOSED TREE Users who are affected by the intermediate add-on signing certificate expiry need their add-on signatures re-verified as soon as possible after updating to a version containging the fix. A database rebuild includes signature reverifications, so a schema version achieves this. Differential Revision: https://phabricator.services.mozilla.com/D29930
fa013d593d02e29d9062900f89a14fd40a9ba687: Bug 1549010 - verify add-on signing certificates at 2019-04-27T02:43:20.000Z r=jcj a=lizzard
Dana Keeler <dkeeler@mozilla.com> - Sat, 04 May 2019 04:15:11 +0000 - rev 531364
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1549010 - verify add-on signing certificates at 2019-04-27T02:43:20.000Z r=jcj a=lizzard Differential Revision: https://phabricator.services.mozilla.com/D29928
eb5b01e0b309d50231f2412721353b1183aff117: Bug 1548903 - Remove unused JS TypeInference methods. r=iain
Ted Campbell <tcampbell@mozilla.com> - Fri, 03 May 2019 18:17:39 +0000 - rev 531363
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1548903 - Remove unused JS TypeInference methods. r=iain Differential Revision: https://phabricator.services.mozilla.com/D29865
24bc67a8d261462be0958e9bd9e4e7101e35ee76: Bug 1539147 - Part 2: Refactor WindowGlobalParent and WindowGlobalChild; r=nika
John Dai <jdai@mozilla.com> - Fri, 03 May 2019 18:12:55 +0000 - rev 531362
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1539147 - Part 2: Refactor WindowGlobalParent and WindowGlobalChild; r=nika Differential Revision: https://phabricator.services.mozilla.com/D29427
349bb2c0cfac61fc2485865fcf1ecc30874c90ce: Bug 1539147 - Part 1: Remove unused function; r=nika
John Dai <jdai@mozilla.com> - Fri, 03 May 2019 18:10:47 +0000 - rev 531361
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1539147 - Part 1: Remove unused function; r=nika Differential Revision: https://phabricator.services.mozilla.com/D29426
4e998aa9c04bf1dbce2087bfcf91ce8292fb7855: Bug 1548555 - For android gtest, push support files to device; r=bc
Geoff Brown <gbrown@mozilla.com> - Fri, 03 May 2019 17:45:21 +0000 - rev 531360
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1548555 - For android gtest, push support files to device; r=bc Differential Revision: https://phabricator.services.mozilla.com/D29837
914bcc5d82716ce7ae91b90202b754ead0db06aa: Bug 1546973 - Add download related policies. r=jaws,flod
Michael Kaply <mozilla@kaply.com> - Fri, 03 May 2019 17:53:32 +0000 - rev 531359
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1546973 - Add download related policies. r=jaws,flod Differential Revision: https://phabricator.services.mozilla.com/D29277
cbf988d7f823f40af06d3124273626c6b63ee1f2: Bug 1533890: Minor cleanups r=mgaudet
Iain Ireland <iireland@mozilla.com> - Wed, 01 May 2019 20:35:16 +0000 - rev 531358
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1533890: Minor cleanups r=mgaudet 1. In bug 1545278, Ted is making our story about guarding on object pointer identity more robust. Since I am adding a new guardSpecificObject call in the ConstStringSplit patch, it seemed reasonable to add guardSpecificFunction now instead of later. 2. It's not directly relevant in the current patch, but in a previous version of the StringSplit patch (before I realized we could delete the whole thing) it turned out that calling isSelfHostedFunctionWithName on an arbitrary function can trigger assertions, because GetSelfHostedFunctionName assumes isExtended, but isSelfHostedBuiltin does not necessarily imply isExtended (in the case of nested anonymous functions). 3. Fixing the format string in a JitSpew message I added in a previous stack. Depends on D29535 Differential Revision: https://phabricator.services.mozilla.com/D29536
5d03ed4eeeb06b1bd28306e47ec0b0327690de25: Bug 1533890: Remove StringSplit call IC r=mgaudet
Iain Ireland <iireland@mozilla.com> - Wed, 01 May 2019 20:32:15 +0000 - rev 531357
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1533890: Remove StringSplit call IC r=mgaudet I started changing StringSplit to attach outside of self-hosted code, to match ConstStringSplit. Upon closer examination, the StringSplit IC doesn't actually add any value, and we're better off deleting it. The generated code calls StringSplitHelper, which ends up doing almost exactly the same thing as the call to intrinsic_StringSplitString it replaces. When we first wrote the patch (bug 1366377), the advantage was that we got to skip a lookup to determine the group of the resulting object. However, a subsequent patch created a single group for every StringSplitString result, which is basically free to look up. I couldn't write a microbenchmark where the StringSplit IC made any difference, so let's just delete it and simplify our codebase. Depends on D29534 Differential Revision: https://phabricator.services.mozilla.com/D29535
2ee2a6c2095d3dd7e56a87f44742cb2f63c950b9: Bug 1533890: Create template objects for native constructors called without "new" r=mgaudet
Iain Ireland <iireland@mozilla.com> - Wed, 01 May 2019 20:13:07 +0000 - rev 531356
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1533890: Create template objects for native constructors called without "new" r=mgaudet Some native functions (for example, the Array constructor) have constructor-like behaviour even when called in a non-constructing context. We still want to create template objects for these cases. This fixes a noticeable regression in Speedometer (particularly in EmberJS-debug). Depends on D29533 Differential Revision: https://phabricator.services.mozilla.com/D29534
274e684c7979b29f1df7a5232248daa05643f714: Bug 1533890: Rewrite ConstStringSplit to work outside of microbenchmarks r=mgaudet
Iain Ireland <iireland@mozilla.com> - Thu, 02 May 2019 06:57:27 +0000 - rev 531355
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1533890: Rewrite ConstStringSplit to work outside of microbenchmarks r=mgaudet While trying to pin down a performance regression, I realized that both the new and the old implementations of ConstStringSplit are broken. Three years ago, as part of some ES6 work, we changed String.prototype.split to call a self-hosted String_split function instead of native str_split. In turn, String_split calls intrinsic_StringSplitString in the case we care about. However, because the call to intrinsic_StringSplitString is in self-hosted code, we would only get value out of this stub if there was only one caller of String_split in the entire program. This patch changes ConstStringSplit to look for the self-hosted String_Split function, which means we can attach a stub to the user script instead of self-hosted code. It also adds support in BaselineInspector for extracting metadata about the string split from the stub, which enables the Ion version of this optimization. Depends on D29532 Differential Revision: https://phabricator.services.mozilla.com/D29533
98c5fbe185df062d9459c003dab7ce0d64da6003: Bug 1533890: Don't push callee unnecessarily for jit calls r=mgaudet
Iain Ireland <iireland@mozilla.com> - Wed, 01 May 2019 19:50:41 +0000 - rev 531354
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1533890: Don't push callee unnecessarily for jit calls r=mgaudet When pushing arguments for a JIT call, we push the callee value onto the stack, and then immediately pop it off. This is a remnant of the old implementation. This patch removes that wart, with a small detour to rewrite/recomment alignJitStackBasedOnNArgs for clarity. Differential Revision: https://phabricator.services.mozilla.com/D29532
00441f7cdd1c724fab51360d0aa43023b47928dd: Bug 1548673 Part 4 - Fix the display macro usage in nsFileControlFrame::GetPrefISize(). r=jfkthame
Ting-Yu Lin <tlin@mozilla.com> - Fri, 03 May 2019 17:35:00 +0000 - rev 531353
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1548673 Part 4 - Fix the display macro usage in nsFileControlFrame::GetPrefISize(). r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D29749
5ad9fb7a2713a3c63e3375773ef3a26e093d69c1: Bug 1548673 Part 3 - Rename nsBlockFrame's mPrefWidth to mCachedPrefISize. r=jfkthame
Ting-Yu Lin <tlin@mozilla.com> - Fri, 03 May 2019 17:34:55 +0000 - rev 531352
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1548673 Part 3 - Rename nsBlockFrame's mPrefWidth to mCachedPrefISize. r=jfkthame Like Part 2, I choose mCachedPrefISize because grid and flex container are using it. Differential Revision: https://phabricator.services.mozilla.com/D29748
2a7dcc0cc43d85811a6a06904094143dc499dc8d: Bug 1548673 Part 2 - Rename nsBlockFrame's mMinWidth to mCachedMinISize. r=jfkthame
Ting-Yu Lin <tlin@mozilla.com> - Fri, 03 May 2019 17:34:46 +0000 - rev 531351
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1548673 Part 2 - Rename nsBlockFrame's mMinWidth to mCachedMinISize. r=jfkthame Instead of renaming it to mMinISize, I choose mCachedMinISize because both grid and flex container frames use mCachedMinISize for similar purpose. Differential Revision: https://phabricator.services.mozilla.com/D29747
a3ddb4c1ce28569b398d3b0789aef50a11d412e5: Bug 1548673 Part 1 - Rename NS_INTRINSIC_WIDTH_UNKNOWN to NS_INTRINSIC_ISIZE_UNKNOWN. r=jfkthame
Ting-Yu Lin <tlin@mozilla.com> - Fri, 03 May 2019 17:34:36 +0000 - rev 531350
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1548673 Part 1 - Rename NS_INTRINSIC_WIDTH_UNKNOWN to NS_INTRINSIC_ISIZE_UNKNOWN. r=jfkthame This patch is generated by running the following script under layout/, and then manually delete the FIXME comment in LayoutConstants.h #!/bin/bash function rename() { find .\ -type f\ ! -path "./obj*"\ ! -path "./.git"\ ! -path "./.hg"\ \( -name "*.cpp" -or\ -name "*.h" \)\ -exec sed -i -e "s/$1/$2/g" "{}" \; } rename NS_INTRINSIC_WIDTH_UNKNOWN NS_INTRINSIC_ISIZE_UNKNOWN Differential Revision: https://phabricator.services.mozilla.com/D29746
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 tip