70738ac7ba9b76a586cedc22ca11e02ebf659f16: Bug 1595482: change "responsiveness" field to "eventDelay" in profiler r=canaltinova
Randell Jesup <rjesup@wgate.com> - Wed, 13 Nov 2019 14:21:52 +0000 - rev 563592
Push 12351 by ffxbld-merge at Mon, 02 Dec 2019 11:32:26 +0000
Bug 1595482: change "responsiveness" field to "eventDelay" in profiler r=canaltinova We want the profiler UI to be able to know if the data can be used for reconstructing the event delays, since it measures something different from the old 16ms event injection. Differential Revision: https://phabricator.services.mozilla.com/D52534
be6ff7053ebe1e620a8a57af13bb6b6c11aab4a0: Bug 1593820 - [try] Create a ./mach try --pernosco flag to opt-in to the Pernosco debugging service, r=jmaher
Andrew Halberstadt <ahalberstadt@mozilla.com> - Wed, 13 Nov 2019 14:23:55 +0000 - rev 563591
Push 12351 by ffxbld-merge at Mon, 02 Dec 2019 11:32:26 +0000
Bug 1593820 - [try] Create a ./mach try --pernosco flag to opt-in to the Pernosco debugging service, r=jmaher This gives developers the ability to request analysis from the Pernosco service. When this flag is set, Pernosco will examine the push for relevant failures, analyze them and then send a link to the generated report. Previously developers needed to request access to a whitelist whereupon all their try pushes were analyzed. Developers currently on this whitelist who would like to opt-out can run |mach try --no-persnosco| to do so. Differential Revision: https://phabricator.services.mozilla.com/D52419
e333a13aa5f6f658c334e4553664b8df4adb5b7a: Bug 1577505 - Don't assume media element's canplay task runs immediately. r=jib
Andreas Pehrson <apehrson@mozilla.com> - Wed, 13 Nov 2019 14:02:58 +0000 - rev 563590
Push 12351 by ffxbld-merge at Mon, 02 Dec 2019 11:32:26 +0000
Bug 1577505 - Don't assume media element's canplay task runs immediately. r=jib Differential Revision: https://phabricator.services.mozilla.com/D52808
7db3af2ab4045e73695595aafb07857ed05b26fc: Bug 1543156 - Wait for the addon manager to start in DevTools addons xpcshell tests r=ochameau
Julian Descottes <jdescottes@mozilla.com> - Wed, 13 Nov 2019 12:29:08 +0000 - rev 563589
Push 12351 by ffxbld-merge at Mon, 02 Dec 2019 11:32:26 +0000
Bug 1543156 - Wait for the addon manager to start in DevTools addons xpcshell tests r=ochameau Differential Revision: https://phabricator.services.mozilla.com/D52535
f11a1221a1adf18caae99adcfc4bd24a0fb44c72: Bug 1595819 - Limit the audio output channel count maximum reported value if RFP is enabled. r=tjr
Paul Adenot <paul@paul.cx> - Wed, 13 Nov 2019 12:24:11 +0000 - rev 563588
Push 12351 by ffxbld-merge at Mon, 02 Dec 2019 11:32:26 +0000
Bug 1595819 - Limit the audio output channel count maximum reported value if RFP is enabled. r=tjr Stereo output is what the immense majority of mobile and desktop users have. Differential Revision: https://phabricator.services.mozilla.com/D52693
b8a3793ecceb864e30b0c7d060dc9397770b1d9e: Bug 1593944 - Test to ensure inactive CSS state does not linger when dependencies change. r=miker,pbro
Razvan Caliman <rcaliman@mozilla.com> - Wed, 13 Nov 2019 13:56:50 +0000 - rev 563587
Push 12351 by ffxbld-merge at Mon, 02 Dec 2019 11:32:26 +0000
Bug 1593944 - Test to ensure inactive CSS state does not linger when dependencies change. r=miker,pbro Depends on D52560 - Adds a test to check that the steps for [Bug 1593944](https://bugzilla.mozilla.org/show_bug.cgi?id=1593944) no longer cause an issue. - Introduces a new `updateDeclaration()` helper in `devtools/client/inspector/rules/test/shared.js` to simplify updating property names and values in one step. - Updates `toggleDeclaration()` to remove unused `inspector` parameter; updates existing tests. Differential Revision: https://phabricator.services.mozilla.com/D52561
47a58584b81390485c7530b1eef7d59b2d6c32b2: Bug 1593944 - Emit event with StyleRuleActor as argument when its underlying CSS rule is updated. r=pbro
Razvan Caliman <rcaliman@mozilla.com> - Wed, 13 Nov 2019 14:04:37 +0000 - rev 563586
Push 12351 by ffxbld-merge at Mon, 02 Dec 2019 11:32:26 +0000
Bug 1593944 - Emit event with StyleRuleActor as argument when its underlying CSS rule is updated. r=pbro The fix for [Bug 1557689](https://bugzilla.mozilla.org/show_bug.cgi?id=1557689) created a situation in the [`Rule.onDeclarationsChanged()`](https://searchfox.org/mozilla-central/rev/6566d92dd46417a2f57e75c515135ebe84c9cef5/devtools/client/inspector/rules/models/rule.js#869-887) whereby the `isUsed` state of client-side declarations was made to point to a fixed `isUsed` state received from the server, thus losing sync with the latest state of the `StyleRuleActor`. Until another "declarations-update" event was fired from the `StyleRuleActor`, the rule's declarations' `isUsed` flag would point to the state with which they were overwritten on the last event handler call. As a reminder, the root cause of [Bug 1557689](https://bugzilla.mozilla.org/show_bug.cgi?id=1557689) was the inability force a "refresh" of the `StyleRuleFront` so it picked-up the latest `isUsed` state for its declarations when they depend on other declarations from other rules (ex: `justify-content: center` depends on `display:flex`). Therefore, the "declarations-updated" event was introduced with a payload of changed declarations to overwrite the client-side ones. It was convoluted, but it worked. However, while investigating the cause of this newer bug [Bug 1593944](https://bugzilla.mozilla.org/show_bug.cgi?id=1593944), I discovered an unusual but perhaps expected side-effect: when dispatching an event over the protocol with a payload of the `StyleRuleActor`, its corresponding `StyleRuleFront` on the client would "refresh" automatically (meaning that, looking up state on the previous front reference would point to the latest state from the actor) . The client doesn't even need to use this payload to replace its previous front reference. Surprisingly, the client doesn't even need to explicitly listen to the event which carries the `StyleRuleActor`/`StyleRuleFront` reference. So long as a previous reference of the front exists on the client, it will point to the updated state of the actor. I haven't been able to identify whether this is a known and expected behavior, so I'm pinging @jdescottes and @ochameau to weigh in on the validity of these findings. Relying on this behavior, the fix for both [Bug 1557689](https://bugzilla.mozilla.org/show_bug.cgi?id=1557689) and [Bug 1557689](https://bugzilla.mozilla.org/show_bug.cgi?id=1557689) involves simply emitting an event, "rule-updated", with the `StyleRuleActor` instance as payload whenever its internal state changes meaningfully so the corresponding front updates. The client will pick-up the latest `isUsed` state of declarations from its reference to the `StyleRuleFront`. --- Another way to check this behavior and hypothesis is to do the following: - In [`StyleRuleActor.setRuleText()`](https://searchfox.org/mozilla-central/rev/6566d92dd46417a2f57e75c515135ebe84c9cef5/devtools/server/actors/styles.js#1704) replace `return this` with `return null`; (this will no longer return the `StyleRuleActor` over the protocol; it's not explicitly used on the client anyway). - In the spec, replace the [`setRuleText()`](https://searchfox.org/mozilla-central/rev/6566d92dd46417a2f57e75c515135ebe84c9cef5/devtools/shared/specs/styles.js#222) return value with `RetVal("nullable:domstylerule")` so the protocol doesn't throw an error when getting the `null` from the actor. - Make a build. - Then, open the Inspector -> Rules View and change the value of a valid declaration, say: `display: block`, to something invalid, like `display: booo`. Notice that the declaration is no longer marked invalid with a warning sign. That's because the declaration's [`isValid`](https://searchfox.org/mozilla-central/rev/6566d92dd46417a2f57e75c515135ebe84c9cef5/devtools/server/actors/styles.js#1447) flag is set on the actor but it no longer syncs with the client which uses the corresponding front to render the declaration after the change. Not returning the `StyleRuleActor` over the protocol breaks this sync actor-front sync. Differential Revision: https://phabricator.services.mozilla.com/D52560
4d16c3d62cfc0503075206bccfbd3b32ad396e64: Bug 1575008 - WebGPU implementation basis r=baku,bzbarsky
Dzmitry Malyshau <dmalyshau@mozilla.com> - Wed, 13 Nov 2019 12:48:33 +0000 - rev 563585
Push 12351 by ffxbld-merge at Mon, 02 Dec 2019 11:32:26 +0000
Bug 1575008 - WebGPU implementation basis r=baku,bzbarsky This change vendors `wgpu` library in-tree and hooks up the initialization bits. It implements adapter and device initialization and adds a simple test. Complementary ecosystem tracker - https://github.com/gfx-rs/wgpu/issues/374 Current status: - [x] Architecture - [x] figure out the IPC story - [ ] move wgpu crates into a dedicated folder (postponed as https://bugzilla.mozilla.org/show_bug.cgi?id=1594182) - [x] Linux - [x] avoid depending on spirv_cross - [x] macOS - [x] due to cross-compiling shaders - [x] need the dependency update - [x] stop using gcc - [x] unexpected SSL header collision - https://phabricator.services.mozilla.com/D51148 - [x] undefined Metal symbols - [x] missing webrtc headers for IPDL magic - https://phabricator.services.mozilla.com/D51558 - [x] spirv-cross linking failure in ASAN - https://phabricator.services.mozilla.com/D52688 - [x] Windows - [x] due to "ipc-channel" not supporting Windows yet - [x] due to some exceptional stuff - [x] undefined symbol: `D3D12CreateDevice` - [x] d3d12.dll is not found, dxgi1_4 doesn't present - [x] d3d11.dll and dxgi.dll need to be explicitly loaded on win32 mingw - [x] libbacktrace fails to link on win32 mingw - [x] cc mislinking C++ standard library - [x] Android - [x] spirv-cross fails to build due to exceptions Update-1: We decided to go with IPDL mechanism instead of Rust based ipc-channel (or any alternatives), which unblocks Windows build. Update-2: It appears that WebGPUThreading isn't needed any more as the child thread (and its event loop) is now managed by IPDL infrastructure. This PR removes it 🎉 . Update-3: InstanceProvider is also removed. Update-4: All set, the try is green, waiting for dependent changes to go in. Differential Revision: https://phabricator.services.mozilla.com/D49458
09a0252278f8bcd493345f2e05179f78f16e5a10: Bug 1594004 - Enable CacheSplit on nightly r=ckerschb,annevk
Sebastian Streich <sstreich@mozilla.com> - Wed, 13 Nov 2019 12:11:30 +0000 - rev 563584
Push 12351 by ffxbld-merge at Mon, 02 Dec 2019 11:32:26 +0000
Bug 1594004 - Enable CacheSplit on nightly r=ckerschb,annevk Differential Revision: https://phabricator.services.mozilla.com/D51815
35436d4e7917bf9d9b96a6173201ca001a8ff7bc: Bug 1591932 - Enable Sniffing on No Mime+ XCTO nosniff r=ckerschb
Sebastian Streich <sstreich@mozilla.com> - Wed, 13 Nov 2019 12:12:34 +0000 - rev 563583
Push 12351 by ffxbld-merge at Mon, 02 Dec 2019 11:32:26 +0000
Bug 1591932 - Enable Sniffing on No Mime+ XCTO nosniff r=ckerschb Differential Revision: https://phabricator.services.mozilla.com/D50816
7a55cb6e7aecdd0d3fb786fefe8cc165558b78e0: Bug 1594136 - Check for ended track in MediaStreamTrackAudioSourceNode. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Wed, 13 Nov 2019 13:13:48 +0000 - rev 563582
Push 12351 by ffxbld-merge at Mon, 02 Dec 2019 11:32:26 +0000
Bug 1594136 - Check for ended track in MediaStreamTrackAudioSourceNode. r=padenot Depends on D52521 Differential Revision: https://phabricator.services.mozilla.com/D52522
9473f8de212155dedc4eb74165211636324262bc: Bug 1594136 - Add crashtest. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Wed, 13 Nov 2019 13:13:55 +0000 - rev 563581
Push 12351 by ffxbld-merge at Mon, 02 Dec 2019 11:32:26 +0000
Bug 1594136 - Add crashtest. r=padenot Differential Revision: https://phabricator.services.mozilla.com/D52521
710f988369e5588af9b35bf07ac6051083a3407a: Bug 1595831 - use StaticPrefs for dom.ipc prefs for ContentParent and the hang monitor code, r=kmag
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Tue, 12 Nov 2019 21:30:11 +0000 - rev 563580
Push 12351 by ffxbld-merge at Mon, 02 Dec 2019 11:32:26 +0000
Bug 1595831 - use StaticPrefs for dom.ipc prefs for ContentParent and the hang monitor code, r=kmag This additionally turns on dom.ipc.processHangMonitor on non-m-c consumers of gecko, as well as turning off dom.ipc.reportProcessHangs on debug geckoview. Differential Revision: https://phabricator.services.mozilla.com/D52699
0a3045be7a72a15be26196a4401d0b695931387c: Backed out changeset 4d4982e04e4d (bug 1543156) for xpcshell failures on test_extension_storage_actor.js. CLOSED TREE
Narcis Beleuzu <nbeleuzu@mozilla.com> - Wed, 13 Nov 2019 13:36:30 +0200 - rev 563579
Push 12351 by ffxbld-merge at Mon, 02 Dec 2019 11:32:26 +0000
Backed out changeset 4d4982e04e4d (bug 1543156) for xpcshell failures on test_extension_storage_actor.js. CLOSED TREE
a46ef03516e66a6bd02531c651578dff1ae781fc: Bug 1586105 - Request longer timeout for page info tests r=canaltinova
Julien Wajsberg <felash@gmail.com> - Wed, 13 Nov 2019 01:08:32 +0000 - rev 563578
Push 12351 by ffxbld-merge at Mon, 02 Dec 2019 11:32:26 +0000
Bug 1586105 - Request longer timeout for page info tests r=canaltinova Differential Revision: https://phabricator.services.mozilla.com/D52696
360c8b9f1566c66e8890f8bda2891a508ad36cc9: Bug 1596045 - Modernize test_esni_dns_fetch.js and make sure we're not clearing the cache when setting the URI pref r=dragana
Valentin Gosu <valentin.gosu@gmail.com> - Wed, 13 Nov 2019 10:55:09 +0000 - rev 563577
Push 12351 by ffxbld-merge at Mon, 02 Dec 2019 11:32:26 +0000
Bug 1596045 - Modernize test_esni_dns_fetch.js and make sure we're not clearing the cache when setting the URI pref r=dragana When using add_task to schedule the tests, testEsniPushPart2 would always fail. That's because Bug 1587875 now clears the DNS cache when the network.trr.uri pref is changed. This is likely intermittent because of task scheduling. This patch modernizes the test to use add_task and promises, and sets the network.trr.clear-cache-on-pref-change;true pref so the test performs its checks properly. Differential Revision: https://phabricator.services.mozilla.com/D52825
ddc6fa7e24f2eb5e96e0e0215a943b06d4607b95: Bug 1566141 - implement nullish coalescence in ion monkey r=jandem
yulia <ystartsev@mozilla.com> - Tue, 12 Nov 2019 16:57:39 +0000 - rev 563576
Push 12351 by ffxbld-merge at Mon, 02 Dec 2019 11:32:26 +0000
Bug 1566141 - implement nullish coalescence in ion monkey r=jandem Differential Revision: https://phabricator.services.mozilla.com/D51640
2a8c35575189a16dcdf6af014a12b046817b28b2: Bug 1566141 - make baseline work with JSOP code for coalesce r=jorendorff,jandem
yulia <ystartsev@mozilla.com> - Tue, 12 Nov 2019 16:57:21 +0000 - rev 563575
Push 12351 by ffxbld-merge at Mon, 02 Dec 2019 11:32:26 +0000
Bug 1566141 - make baseline work with JSOP code for coalesce r=jorendorff,jandem Differential Revision: https://phabricator.services.mozilla.com/D51639
9b150dd56999e1c2b7aa47cf9c0e8d96c6c8eff3: Bug 1566141 - make interpreter work with JSOP code for coalesce r=jorendorff,jandem
yulia <ystartsev@mozilla.com> - Tue, 12 Nov 2019 17:33:55 +0000 - rev 563574
Push 12351 by ffxbld-merge at Mon, 02 Dec 2019 11:32:26 +0000
Bug 1566141 - make interpreter work with JSOP code for coalesce r=jorendorff,jandem Differential Revision: https://phabricator.services.mozilla.com/D51638
eec2b47cdc07333154fc07c0576d200076d4f3de: Bug 1576115 - Expose processes from xpcshell test DebuggerServer. r=jdescottes
Alexandre Poirot <poirot.alex@gmail.com> - Wed, 13 Nov 2019 09:51:01 +0000 - rev 563573
Push 12351 by ffxbld-merge at Mon, 02 Dec 2019 11:32:26 +0000
Bug 1576115 - Expose processes from xpcshell test DebuggerServer. r=jdescottes With Fission, we expect RootActor.listProcesses to return a list of all process actors. Differential Revision: https://phabricator.services.mozilla.com/D52646
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip