65aee3ceefec4af57f77b88c1352780fb9de49df: Bug 1344748 - Rename and register Marionette prefs; r=maja_zf
Andreas Tolfsen <ato@mozilla.com> - Thu, 09 Mar 2017 11:12:53 +0000 - rev 397848
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1344748 - Rename and register Marionette prefs; r=maja_zf This change renames the following Marionette preferences: marionette.defaultPrefs.enabled marionette.enabled marionette.defaultPrefs.port marionette.port marionette.force-local marionette.forcelocal marionette.logging marionette.log.level The old preference names are still usable, but are henceforth considered deprecated. They will be removed when Firefox 55 ships. It also registers these preferences in Firefox so that they are discoverable through about:config. This patch also refactors testing/marionette/components/marionette.js. MozReview-Commit-ID: 1dAMQS2e0og
75ed5a3cff70134bcebba474485957e01eeeff3e: Bug 1344748 - Merge dispatcher into server.js; r=maja_zf
Andreas Tolfsen <ato@mozilla.com> - Mon, 06 Mar 2017 17:39:42 +0000 - rev 397847
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1344748 - Merge dispatcher into server.js; r=maja_zf Merges testing/marionette/dispatcher.js into testing/marionette/server.js and renames it server.TCPConnection. The rationale behind this change is that the current dispatcher is not a single entity to which incoming requests are dispatched. The old organisation might make sense if this was an HTTP server where all connections are transitive and it didn't hold any connection details, however the dispatcher is in effect a representation of a client socket connection. Since the module is not used elsewhere, it makes sense to pair it with the existing server.TCPListener class. MozReview-Commit-ID: 2HF35OiP6AY
5e4ffba9bd16f105a2d7005cbed66abde8d37e55: Bug 1344748 - Make testing/marionette/server.js a class; r=maja_zf,whimboo
Andreas Tolfsen <ato@mozilla.com> - Mon, 06 Mar 2017 17:09:07 +0000 - rev 397846
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1344748 - Make testing/marionette/server.js a class; r=maja_zf,whimboo No functional changes apart from class'ifying the file and harmonising the export symbol with the rest of the Marionette code base by renaming the MarionetteServer class to server.TCPListener. MozReview-Commit-ID: 8WJKoprGGvr
d425dc57b170e9c7ce875be4b00832f796c4142b: Bug 1344748 - Set recommended prefs when Marionette starts; r=automatedtester,maja_zf,whimboo
Andreas Tolfsen <ato@mozilla.com> - Mon, 06 Mar 2017 16:47:38 +0000 - rev 397845
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1344748 - Set recommended prefs when Marionette starts; r=automatedtester,maja_zf,whimboo This makes the Marionette server itself set a long list of recommended automation preferences when it starts up, and reset those it changed when stopping. Preferences used in automation are currently written to the Firefox profile before Firefox starts, but after a closer examination of the preferences, it is thought that many of them can be set at runtime. There is a subset of preferences that are checked on startup and which must be set in the profile. These are clearly called out in the comments. We still set them at runtime, since we foresee a future where it will be possible to attach an existing Firefox session to geckodriver, and many of the prefs can also be checked at runtime during the course of that automation session. For example, if we would not set the "app.update.auto" preference in such a runtime, opening the About dialogue would cause a forced update of Firefox. This is not desirable when the browser is under Marionette control. When the Marionette server is stopped, the altered preferences are reset and the browser session's state is returned to its pre-existing condition. This change does not mean it is dangerous or wrong for consumers to write their own preferences to the profile. Any preferences written to the profile will take precedence over this set of recommended preferences. If the recommended Marionette preference has a user-defined value (i.e. it is written to the profile before starting up or has manually changed), that user-set value is preferred. The list of preferences in this file is the authorative reference of recommended preferences for using Marionette in automation. They have been gathered from geckoinstance.py and geckodriver. MozReview-Commit-ID: INHSQRg2XjF
6f7441656f46dbe815881ad273518d4259398cbe: Bug 1344748 - Remove B2G offline management from Marionette; r=maja_zf
Andreas Tolfsen <ato@mozilla.com> - Mon, 06 Mar 2017 16:45:35 +0000 - rev 397844
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1344748 - Remove B2G offline management from Marionette; r=maja_zf MozReview-Commit-ID: 68iUhwT7xdv
ee52b3615da626b5968ff3df558ff0cc029f17c5: Bug 1341102 - Update mochitest expectation.
Xidorn Quan <me@upsuper.org> - Mon, 27 Mar 2017 14:58:30 +1100 - rev 397843
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1341102 - Update mochitest expectation.
81099dbf284b1af027b99a942c2d3d0043e9b208: Bug 1194751 - Part 8. Implement ScreenHelperCocoa and delete old nsScreenManagerCocoa/nsScreenCocoa. r=mstange
Kan-Ru Chen <kanru@kanru.info> - Thu, 09 Mar 2017 19:34:49 +0800 - rev 397842
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1194751 - Part 8. Implement ScreenHelperCocoa and delete old nsScreenManagerCocoa/nsScreenCocoa. r=mstange ScreenHelperCocoa is the platform dependent part of the original nsScreenManagerCocoa and nsScreenCocoa. It registers NSApplicationDidChangeScreenParametersNotification and pushes updates to ScreenManager. See patch part 4. for how ScreenManager works. MozReview-Commit-ID: 1A5ha4Ys2dL
f4fa50b511ae0cc8d5940e47cf39cc317ade66be: Bug 1194751 - Part 7. Implement ScreenHelperWin and delete old nsScreenManagerWin/nsScreenWin. r=jimm
Kan-Ru Chen <kanru@kanru.info> - Thu, 09 Mar 2017 19:32:31 +0800 - rev 397841
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1194751 - Part 7. Implement ScreenHelperWin and delete old nsScreenManagerWin/nsScreenWin. r=jimm ScreenHelperWin is the platform dependent part of the original nsScreenManagerWin and nsScreenWin. It listens the WM_DISPLAYCHANGE message and pushes updates to ScreenManager. See patch part 4. for how ScreenManager works. MozReview-Commit-ID: 20A3ZQKmH9a
ad1425bed4ea19d0e098f7051e93f191d21e195c: Bug 1194751 - Part 6.1 change nsScreenManagerAndroid::ScreenForId to a concrete method. r=snorp
Kan-Ru Chen <kanru@kanru.info> - Thu, 09 Mar 2017 19:30:53 +0800 - rev 397840
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1194751 - Part 6.1 change nsScreenManagerAndroid::ScreenForId to a concrete method. r=snorp nsIScreen::GetId and nsIScreenManager::ScreenForId is removed in patch part 6. These methods are still used by Fennec on Android to implement Presentation API support so I changed them to concrete methods in nsScreenAndroid and nsScreenManagerAndroid. nsScreenAndroid and nsScreenManagerAndroid does not use the generic Screen and ScreenManager class because its implementation is quite different. MozReview-Commit-ID: 4rxxIgvNxMb
5a58b77947bf1146bd7080fc2e64e8b04c585861: Bug 1194751 - Part 6. Use mozilla::widget::ScreenManager in content process. r=mconley
Kan-Ru Chen <kanru@kanru.info> - Thu, 09 Mar 2017 19:30:26 +0800 - rev 397839
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1194751 - Part 6. Use mozilla::widget::ScreenManager in content process. r=mconley This is the most important part of the patch series. It removes the PScreenManager protocol and use ScreenManager directly in the content processes. Initial and subsequent updates are sent via PContent::RefreshScreens. struct ScreenDetails are kept to serialize Screen over IPC. nsIScreenManager::ScreenForNativeWidget is removed because nsIWidget::GetWidgetScreen can replace it. nsIScreen::GetId is removed because it's not useful for the more general Screen class. MozReview-Commit-ID: 5dJO3isgBuQ
4be4367d022d7b97eb90b503d6eef186cdb0309f: Bug 1194751 - Part 5. Implement ScreenHelperGTK and delete old nsScreenManagerGtk/nsScreenGtk. r=karlt
Kan-Ru Chen <kanru@kanru.info> - Thu, 09 Mar 2017 19:29:44 +0800 - rev 397838
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1194751 - Part 5. Implement ScreenHelperGTK and delete old nsScreenManagerGtk/nsScreenGtk. r=karlt ScreenHelperGTK is the platform dependent part of the original nsScreenManagerGtk and nsScreenGtk. It registers monitors-changed event listener from gtk and pushes updates to ScreenManager. See patch part 4. for how ScreenManager works. MozReview-Commit-ID: KBo7ZLFTjM3
b18a43068dc6d63c4f5d10d288614a4282215acc: Bug 1194751 - Part 4. Add ScreenManager and Screen classes. r=jimm,karlt,mconley
Kan-Ru Chen <kanru@kanru.info> - Tue, 14 Mar 2017 18:44:54 +0800 - rev 397837
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1194751 - Part 4. Add ScreenManager and Screen classes. r=jimm,karlt,mconley ScreenManager takes the common parts of ScreenManagerWin, ScreenManagerGtk and ScreenManagerCocoa. It caches all screen information in the new Screen class. The cache are updated when the OS notifies there is a monitor config change; all changes will be pushed to content processes via PContent (patch part 6.) Screen is a pure data object. All platform dependent logic will be in widget specific helper classes. Each process will have a singleton ScreenManager object. Widget specific helper object is held alive by the ScreenManager when necessary, for example to receive updates from the OS. The change to to VsyncDispatcher.cpp is due to unified-build bustage. ScreenManager::ScreenForNativeWidget is not implemented because it will be removed in patch part 6. MozReview-Commit-ID: 5ezytAXSqHp *** fixup MozReview-Commit-ID: DQtq3UVZytA
ace97d197b699443091db818a2e18222a7065bb0: Bug 1194751 - Part 3. Remove unused nsIScreen::rotation attribute. r=jimm
Kan-Ru Chen <kanru@kanru.info> - Thu, 09 Mar 2017 19:16:33 +0800 - rev 397836
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1194751 - Part 3. Remove unused nsIScreen::rotation attribute. r=jimm It's only used by gonk. Remove it will make removing PScreenManager easier. MozReview-Commit-ID: GCHonrz30xK
5df5fa8ee892ff9f893bf8ae15a66a89a1a72325: Bug 1194751 - Part 2. Remove unused nsIScreen::LockMinimumBrightness and related methods. r=snorp
Kan-Ru Chen <kanru@kanru.info> - Thu, 09 Mar 2017 19:16:29 +0800 - rev 397835
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1194751 - Part 2. Remove unused nsIScreen::LockMinimumBrightness and related methods. r=snorp It's not used anywhere in gecko or addons. Remove it will make removing PScreenManager easier. MozReview-Commit-ID: K3BHnktO7wU
57f989c1010f40a2b99ee89d61bd1621c633ab4a: Bug 1194751 - Part 1. Remove nsIScreenManager::GetNumberOfScreens. r=jimm
Kan-Ru Chen <kanru@kanru.info> - Thu, 09 Mar 2017 19:16:24 +0800 - rev 397834
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1194751 - Part 1. Remove nsIScreenManager::GetNumberOfScreens. r=jimm It's not used anywhere. Remove it will make removing PScreenManager easier. MozReview-Commit-ID: 5dn8kDhTZVl
e8a7790bd2685ca77713d2bf8b165e7e162a443d: Bug 1347648 - part4 : notify audible change after finishing set suspend and pause state. r=jwwang
Alastor Wu <alwu@mozilla.com> - Mon, 27 Mar 2017 10:59:44 +0800 - rev 397833
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1347648 - part4 : notify audible change after finishing set suspend and pause state. r=jwwang Since the audible state would depend on pause and suspend state, we should do the check after finishing play() or pause(). MozReview-Commit-ID: 1yhxuQDw067
ff66592a8baf37f8c8d27381c02800ce75962828: Bug 1347648 - part3 : only request audio focus from gecko. r=sebastian
Alastor Wu <alwu@mozilla.com> - Mon, 27 Mar 2017 10:59:10 +0800 - rev 397832
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1347648 - part3 : only request audio focus from gecko. r=sebastian Media control would also be displayed for non-audible media, we shouldn't arbitrary request audio focus . Only request audio focus from gecko which know whether the media is audible. MozReview-Commit-ID: Ke9DCYd0Qh2
dbcbc70b0bc7c1957f03ed1341a9698240fad677: Bug 1347648 - part2 : paused media element is non-audible. r=jwwang
Alastor Wu <alwu@mozilla.com> - Mon, 27 Mar 2017 10:59:07 +0800 - rev 397831
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1347648 - part2 : paused media element is non-audible. r=jwwang If the media element is paused, it should be non-audible. MozReview-Commit-ID: 2HjV9gNNcnV
29ad09fc4655c95004c6fc1bdaf06283f9986ae1: Bug 1347648 - part1 : only request Android audio focus for audible media. r=snorp
Alastor Wu <alwu@mozilla.com> - Mon, 27 Mar 2017 10:59:04 +0800 - rev 397830
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1347648 - part1 : only request Android audio focus for audible media. r=snorp For non-audible media, we shouldn't request audio focus because it might interrupt other app who is playing music or podcast. MozReview-Commit-ID: 25iWJktgKUw
88dd8824245d1fcfcb05762bc3b2423e3f212bca: Bug 1342867 - Label the runnable of ScrollOnFocusEvent. r=bevistseng,dholbert
KuoE0 <kuoe0.tw@gmail.com> - Wed, 08 Mar 2017 15:51:40 +0800 - rev 397829
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1342867 - Label the runnable of ScrollOnFocusEvent. r=bevistseng,dholbert MozReview-Commit-ID: Dwk7F0gQBiz
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip