62b191e02145b1220a39dd2034a3f4d7057e133f: Bug 1417387 - Don't mix unicode and bytes in clobber code; r=nalexander
Gregory Szorc <gps@mozilla.com> - Wed, 15 Nov 2017 10:17:26 -0800 - rev 443697
Push 8527 by Callek@gmail.com at Thu, 11 Jan 2018 21:05:50 +0000
Bug 1417387 - Don't mix unicode and bytes in clobber code; r=nalexander b6adf66f34c6 (bug 1416052) changed the value for "fh" when this code is called. It can now be an io.BytesIO. This type enforces that arguments are bytes and doesn't perform automatic type coercion like most other parts of Python 2. self.topobjdir is a unicode. And unicode_literals isn't in effect in this file. So convert self.topobjdir to bytes to make BytesIO happy. MozReview-Commit-ID: LrWTKFp3ZKT
6b9dc67f97beede1f64f535979fda82aa35d2593: Bug 1415556 - P11. Remove unecessary locking. r=padenot
Jean-Yves Avenard <jyavenard@mozilla.com> - Sat, 11 Nov 2017 10:20:59 +0100 - rev 443696
Push 8527 by Callek@gmail.com at Thu, 11 Jan 2018 21:05:50 +0000
Bug 1415556 - P11. Remove unecessary locking. r=padenot The method doesn't use any MSG member, only dispatching a task. MozReview-Commit-ID: 7uZbTvq9OQt
9738a5e24b1550482746878cd20fb74a9b6a985a: Bug 1415556 - P10. Make functions const where needed. r=padenot
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 10 Nov 2017 20:01:27 +0100 - rev 443695
Push 8527 by Callek@gmail.com at Thu, 11 Jan 2018 21:05:50 +0000
Bug 1415556 - P10. Make functions const where needed. r=padenot MozReview-Commit-ID: EBEgDVCTewa
99281de6fbc75ab7d4bcca6b332dcf05fa3fc339: Bug 1415556 - P9. Remove unused member. r=padenot
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 10 Nov 2017 19:00:12 +0100 - rev 443694
Push 8527 by Callek@gmail.com at Thu, 11 Jan 2018 21:05:50 +0000
Bug 1415556 - P9. Remove unused member. r=padenot MozReview-Commit-ID: 2LbqhBkmDBF
14eb28ed51c35be89249bd15537274ce30469787: Bug 1415556 - P8. Assert on proper access of mStreams member. r=padenot.
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 10 Nov 2017 18:56:29 +0100 - rev 443693
Push 8527 by Callek@gmail.com at Thu, 11 Jan 2018 21:05:50 +0000
Bug 1415556 - P8. Assert on proper access of mStreams member. r=padenot. mStreams should only ever be accessed on the MSG thread. However, under some shutdown circumstances, it can be accessed on the main thread while the MSG thread is still alive. This will be corrected in bug 1408276. MozReview-Commit-ID: 6xWzxxV1Dv3
329102ab6f3cce1ac6cd1dbfc16a740460a728e9: Bug 1415556 - P7. Remove unecessary locking. r=padenot.
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 10 Nov 2017 18:53:23 +0100 - rev 443692
Push 8527 by Callek@gmail.com at Thu, 11 Jan 2018 21:05:50 +0000
Bug 1415556 - P7. Remove unecessary locking. r=padenot. mForceShutdownTicket and mShutdownTimer are only ever accessed on the main thread. We don't need the use of the monitor to reset them. MozReview-Commit-ID: 1DL8bLmzEH5
67a7bd7c1ecfe1a8114871c62cc1f623132bd678: Bug 1415556 - P6. Ensure mLifecycleState member is always accessed safely. r=padenot
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 10 Nov 2017 18:38:02 +0100 - rev 443691
Push 8527 by Callek@gmail.com at Thu, 11 Jan 2018 21:05:50 +0000
Bug 1415556 - P6. Ensure mLifecycleState member is always accessed safely. r=padenot We only access mLifecycleState via a helper which strongly enforced how the member can be accessed. Two non-safe accesses are corrected. MozReview-Commit-ID: 6LYk7t4rSyB
da737c91bb30cd06141ba61bfe153f97eb92d0e2: Bug 1415556 - P5. Use helper to set mDriver. r=padenot
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 10 Nov 2017 18:28:42 +0100 - rev 443690
Push 8527 by Callek@gmail.com at Thu, 11 Jan 2018 21:05:50 +0000
Bug 1415556 - P5. Use helper to set mDriver. r=padenot MozReview-Commit-ID: Fres1YwcYYM
e5e283e7055ffebc9ec354ee94804c97c1078ff1: Bug 1415556 - P4. Make members atomics. r=padenot
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 10 Nov 2017 18:27:39 +0100 - rev 443689
Push 8527 by Callek@gmail.com at Thu, 11 Jan 2018 21:05:50 +0000
Bug 1415556 - P4. Make members atomics. r=padenot They are accessed across multiple threads without the use of monitors. While it could be argued that some use of the monitor in functions accessing those members would set in place memory barriers, making them atomics remove all doubts as to the thread safetyness of their use. MozReview-Commit-ID: tyTqeGgDNM
cfc4191ade585351c1a3f5759f34f3e67b86b92f: Bug 1415556 - P3. clearly mark functions' thread use. r=padenot
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 10 Nov 2017 18:24:20 +0100 - rev 443688
Push 8527 by Callek@gmail.com at Thu, 11 Jan 2018 21:05:50 +0000
Bug 1415556 - P3. clearly mark functions' thread use. r=padenot MozReview-Commit-ID: BXmdk4zBo28
44b20d160436d290d7f5b22f4644af980888b5ff: Bug 1415556 - P2. Make member const. r=padenot
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 10 Nov 2017 17:30:19 +0100 - rev 443687
Push 8527 by Callek@gmail.com at Thu, 11 Jan 2018 21:05:50 +0000
Bug 1415556 - P2. Make member const. r=padenot MozReview-Commit-ID: JPDW5cX8RvH
dbe88ff91a34c28eec2c9ec6473351b94755759c: Bug 1415556 - P1. Add precision on thread access with some members. r=padenot
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 10 Nov 2017 17:28:59 +0100 - rev 443686
Push 8527 by Callek@gmail.com at Thu, 11 Jan 2018 21:05:50 +0000
Bug 1415556 - P1. Add precision on thread access with some members. r=padenot Describe which members are accessed on the main threads. Other members are only accessed on MSG thread. MozReview-Commit-ID: CFU4ipRHB1P
87eba7dbe8434f7f55b2967d83295aacd6edab41: servo: Merge #19227 - Work around "this expression will panic at run-time" warnings (from servo:array-warn); r=emilio
Simon Sapin <simon.sapin@exyr.org> - Wed, 15 Nov 2017 11:00:29 -0600 - rev 443685
Push 8527 by Callek@gmail.com at Thu, 11 Jan 2018 21:05:50 +0000
servo: Merge #19227 - Work around "this expression will panic at run-time" warnings (from servo:array-warn); r=emilio CC https://github.com/rust-lang/rust/issues/45850 Source-Repo: https://github.com/servo/servo Source-Revision: 9863d514512aabbcfaeabba7e530b87f61a8d489
5ccd0ffe9bc773edd8745a2aefb7ca85c93e0c74: Bug 1403787 - Change try/catch to catch the correct exception r=eoger,nalexander
Grigory Kruglov <gkruglov@mozilla.com> - Mon, 30 Oct 2017 03:17:48 -0700 - rev 443684
Push 8527 by Callek@gmail.com at Thu, 11 Jan 2018 21:05:50 +0000
Bug 1403787 - Change try/catch to catch the correct exception r=eoger,nalexander We're aiming to catch FileNotFound exceptions here, but underneath they're re-thrown as IllegalStateException. MozReview-Commit-ID: HaCpbqq93q0
419c69148ec9f2285af274c352af0315ab235af3: Bug 1415872 - Implement colors.tab_text and colors.background_tab_text. r=jaws
Tim Nguyen <ntim.bugs@gmail.com> - Wed, 15 Nov 2017 17:34:12 +0000 - rev 443683
Push 8527 by Callek@gmail.com at Thu, 11 Jan 2018 21:05:50 +0000
Bug 1415872 - Implement colors.tab_text and colors.background_tab_text. r=jaws MozReview-Commit-ID: Gp5CHqmOi6A
ac4c3c628abfabf00d6f839877eab8c2843051ca: Bug 1404671 check the error string r=mixedpuppy
Shane Caraveo <scaraveo@mozilla.com> - Tue, 14 Nov 2017 17:09:23 -0800 - rev 443682
Push 8527 by Callek@gmail.com at Thu, 11 Jan 2018 21:05:50 +0000
Bug 1404671 check the error string r=mixedpuppy MozReview-Commit-ID: GEiFEb7JMdh
e7295a89f3270eb55fa54afefd28891a4dc174b5: Bug 1416261 - Use android:theme, as app:theme has been deprecated. r=jwu
Jan Henning <jh+bugzilla@buttercookie.de> - Fri, 10 Nov 2017 17:35:31 +0100 - rev 443681
Push 8527 by Callek@gmail.com at Thu, 11 Jan 2018 21:05:50 +0000
Bug 1416261 - Use android:theme, as app:theme has been deprecated. r=jwu MozReview-Commit-ID: Iuf4NfCWnyc
ecf4310e41f61c970433d442cee6179a5641b76e: Bug 1415858 - Adding logs for Talos cloning step r=jmaher
Tarek Ziadé <tarek@mozilla.com> - Wed, 15 Nov 2017 10:37:39 +0100 - rev 443680
Push 8527 by Callek@gmail.com at Thu, 11 Jan 2018 21:05:50 +0000
Bug 1415858 - Adding logs for Talos cloning step r=jmaher MozReview-Commit-ID: GVXcCty2nNi
4d02718fccf05f6c8fbc76eb7cc6cf5eaffa59bb: Bug 1414892 - Optimize moz_places_afterinsert_trigger r=mak
Doug Thayer <dothayer@mozilla.com> - Tue, 07 Nov 2017 12:01:53 -0800 - rev 443679
Push 8527 by Callek@gmail.com at Thu, 11 Jan 2018 21:05:50 +0000
Bug 1414892 - Optimize moz_places_afterinsert_trigger r=mak This uses a similar strategy as that employed by moz_places_afterdelete_trigger, creating a temp table which we write host inserts into, and then deleting all the rows from it when we're done inserting, effectively resulting in a per- statement trigger to only do the significant work per host. MozReview-Commit-ID: 5TUueknq3ng
cd4e8b6932498eb87729bf7dffa2c754e1129dd1: Bug 1350780 Part 2: Add a test of getComputedStyle with pseudo element styling on an unflowed display:grid element. r=mats
Brad Werth <bwerth@mozilla.com> - Mon, 13 Nov 2017 17:45:29 -0800 - rev 443678
Push 8527 by Callek@gmail.com at Thu, 11 Jan 2018 21:05:50 +0000
Bug 1350780 Part 2: Add a test of getComputedStyle with pseudo element styling on an unflowed display:grid element. r=mats MozReview-Commit-ID: KEk4cz5bEb0
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip