5c5a16ba81b7a2599d2764164d959a549a131d0a: Bug 1432793 - Force screensharing simulcast to one layer and stop generating layers once an odd width and height are found; r=bwc
Dan Minor <dminor@mozilla.com> - Wed, 28 Mar 2018 11:07:54 -0400 - rev 465558
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1432793 - Force screensharing simulcast to one layer and stop generating layers once an odd width and height are found; r=bwc This limits screensharing simulcast to a single layer. When window sharing, our source video can have arbitrary dimensions. If one of those dimensions ends up being odd, the aspect ratio of the smaller layer will not match the aspect ratio of the odd sized layer, causing a runtime assertion failure and crash. It is not sufficient to prevent the creation of odd sized layers in CreateEncoderStreams because the user can resize the window while it is being shared, which will cause a fatal assertion prior to the streams being recreated. When switching back from window sharing to camera, a call to CreateEncoderStreams will occur with resolutions matching the dimensions of the window that was just shared. To prevent a crash, this also adds a check which prevents the creation of layers with odd resolutions. Looking at cricket::GetSimulcastConfig for the version of webrtc.org in tree, the number of simulcast layers is limited to one, or two if a field experiment is enabled. That code also limits resolutions at which screensharing is allowed as well as the number of layers that can be created for each resolution, and ensures that each layer is exactly half the size of the layer above. Adding these new constraints to CreateEncoderStreams makes us more consistent with what the webrtc.org code would do when creating streams, which should help to avoid more assertion failures in the future. Long term, I believe we should just switch to using cricket::GetSimulcastConfig. MozReview-Commit-ID: 8gjdY5GPPjl
f0d3566d062e77c73c25da206f30e767fa4913ba: Backed out changeset 0222a82d1e90 (bug 1360198) for Talos exceptions on windows machines. CLOSED TREE
Dorel Luca <dluca@mozilla.com> - Thu, 05 Apr 2018 21:10:34 +0300 - rev 465557
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Backed out changeset 0222a82d1e90 (bug 1360198) for Talos exceptions on windows machines. CLOSED TREE
c93645d0a1c44baa0c7bfb7cbee406462ae6a8b0: Backed out changeset 186241aaea35 (bug 1360198) for Talos exceptions on windows machines. CLOSED TREE
Dorel Luca <dluca@mozilla.com> - Thu, 05 Apr 2018 21:10:24 +0300 - rev 465556
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Backed out changeset 186241aaea35 (bug 1360198) for Talos exceptions on windows machines. CLOSED TREE
ebeb68db4cb54ca9efd755f9472184e143c11d25: Bug 1451296 - Make enabling of font-variation-settings and font-optical-sizing properties dependent on adequate platform support at runtime. r=lsalzman
Jonathan Kew <jkew@mozilla.com> - Thu, 05 Apr 2018 18:53:56 +0100 - rev 465555
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1451296 - Make enabling of font-variation-settings and font-optical-sizing properties dependent on adequate platform support at runtime. r=lsalzman
c880e315c1b39277ce526108e988fc975839518a: Bug 1449976 - Add regression test for fast-shadow clipping. r=jrmuizel
Alexis Beingessner <a.beingessner@gmail.com> - Tue, 03 Apr 2018 13:01:00 -0400 - rev 465554
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1449976 - Add regression test for fast-shadow clipping. r=jrmuizel
d32c2aed28868ecd1d7aa1db701df5f07a256e07: Bug 1449631 part 13. Remove now-unnecessary forwarding macros. r=smaug
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 05 Apr 2018 13:42:42 -0400 - rev 465553
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1449631 part 13. Remove now-unnecessary forwarding macros. r=smaug MozReview-Commit-ID: 6teO2KoGqUo
27805d201b9009bf17a508dff2c840a2e919907f: Bug 1449631 part 12. Remove the Nullable smuggling from nsIDOMEventTarget. r=smaug
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 05 Apr 2018 13:42:42 -0400 - rev 465552
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1449631 part 12. Remove the Nullable smuggling from nsIDOMEventTarget. r=smaug MozReview-Commit-ID: 73qhRSCpr3S
6cf7b2b773dbefb08a1ca8f0a63ad5d8194b2f94: Bug 1449631 part 11. Remove nsIDOMEventTarget::AddSystemEventListener. r=smaug
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 05 Apr 2018 13:42:42 -0400 - rev 465551
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1449631 part 11. Remove nsIDOMEventTarget::AddSystemEventListener. r=smaug The security checks outer window did here don't seem right, because the whole point is that this method is only called by C++ code for its own purposes. We're not adding random untrusted listeners via addSystemEventListener! MozReview-Commit-ID: JdS5gTESclu
a73566a5d08ec5568f1f65cdf322d0fe93f99e81: Bug 1449631 part 10. Devirtualize AddEventListener. r=smaug
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 05 Apr 2018 13:42:42 -0400 - rev 465550
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1449631 part 10. Devirtualize AddEventListener. r=smaug The CanCallerAccess check in the "webidl" version of nsGlobalWindowOuter::AddEventListener was pointless, because bindings never call things on outer windows. MozReview-Commit-ID: 1CGMJ277bPu
51fd57c6877773116ab44264dcb34938f1bdd6ab: Bug 1449631 part 9. Remove nsIDOMEventTarget::AddEventListener. r=smaug
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 05 Apr 2018 13:42:42 -0400 - rev 465549
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1449631 part 9. Remove nsIDOMEventTarget::AddEventListener. r=smaug Also switch the XPCOM-y version of EventTarget::AddEventListner to a Nullable<bool> for aWantsUntrusted. The three-arg overload of AddEventListener in ContentFrameMessageManager was never called, so all the AddEventListener overloads there are not needed. MozReview-Commit-ID: 4IhqHmPVWzE
15546aaa4d0999765a7f278058614d08082a4558: Bug 1449631 part 8. Remove nsIDOMEventTarget::GetEventTargetParent. r=smaug
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 05 Apr 2018 13:42:41 -0400 - rev 465548
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1449631 part 8. Remove nsIDOMEventTarget::GetEventTargetParent. r=smaug MozReview-Commit-ID: 5wQ2LYrjUxf
433dba4e710415a040ca047a5f0cbcb94eeaf2d0: Bug 1449631 part 7. Remove nsIDOMEventTarget::GetTargetFor* methods. r=smaug
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 05 Apr 2018 13:42:41 -0400 - rev 465547
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1449631 part 7. Remove nsIDOMEventTarget::GetTargetFor* methods. r=smaug MozReview-Commit-ID: AIzDo67mTDf
caa5bef6848122d106ad47fc7b2bf104d2d8ce3d: Bug 1449631 part 6. Remove nsIDOMEventTarget::DispatchEvent. r=smaug
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 05 Apr 2018 13:42:41 -0400 - rev 465546
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1449631 part 6. Remove nsIDOMEventTarget::DispatchEvent. r=smaug MozReview-Commit-ID: 8YMgmMwZkAL
d05e92371389bf5992a4c96a243b4e3d26fe7e1f: Bug 1449631 part 5. Move Will/Pre/PostHandleEvent out of nsIDOMEventTarget. r=smaug
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 05 Apr 2018 13:42:41 -0400 - rev 465545
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1449631 part 5. Move Will/Pre/PostHandleEvent out of nsIDOMEventTarget. r=smaug MozReview-Commit-ID: K2nOZNPy0XE
1f824c936c25ac047e2a79aecb737f7095026d73: Bug 1449631 part 4. Remove nsIDOMEventTarget::GetContextForEventHandlers. r=smaug
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 05 Apr 2018 13:42:40 -0400 - rev 465544
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1449631 part 4. Remove nsIDOMEventTarget::GetContextForEventHandlers. r=smaug MozReview-Commit-ID: ID0FDvp28HY
059872bf21beb529dc3552b3953474d007e76423: Bug 1449631 part 3. Remove nsIDOMEventTarget::RemoveSystemEventListener. r=smaug
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 05 Apr 2018 13:42:40 -0400 - rev 465543
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1449631 part 3. Remove nsIDOMEventTarget::RemoveSystemEventListener. r=smaug MozReview-Commit-ID: F67Od8surQ8
34f06ffa0c0e0fe214d8cc9531c8a17654138fbc: Bug 1449631 part 2. Remove nsIDOMEventTarget::RemoveEventListener. r=smaug
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 05 Apr 2018 13:42:40 -0400 - rev 465542
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1449631 part 2. Remove nsIDOMEventTarget::RemoveEventListener. r=smaug We can't have a null content in ScrollbarActivity::StopListeningForScrollAreaEvents, because only viewport frames have a null GetContent(). MozReview-Commit-ID: 9iAg0ivVqqG
0e9e38b63ba46d90e0cc5410b99f085269a0f6d3: Bug 1449631 part 1. Remove JS uses of nsIDOMEventTarget. r=smaug
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 05 Apr 2018 13:42:40 -0400 - rev 465541
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1449631 part 1. Remove JS uses of nsIDOMEventTarget. r=smaug MozReview-Commit-ID: CCHCZjMgInu
186241aaea35cddcb969747e42d0fdc95a35d95c: Bug 1360198 - improve code comments per review feedback,r=dustin
Peter Moore <pmoore@mozilla.com> - Thu, 05 Apr 2018 19:04:39 +0200 - rev 465540
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1360198 - improve code comments per review feedback,r=dustin
0222a82d1e906a6ad3f3135cc54d60649778cc5f: Bug 1360198 - don't set expiry for generic-worker task artifacts,r=dustin
Peter Moore <pmoore@mozilla.com> - Thu, 05 Apr 2018 18:56:08 +0200 - rev 465539
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1360198 - don't set expiry for generic-worker task artifacts,r=dustin
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip