58062477493969eaafe39c01e34fc763ebe0a7f8: Bug 1623971 - P14: Replace `\` by `/` in `#include` r=alwu
Chun-Min Chang <chun.m.chang@gmail.com> - Fri, 19 Jun 2020 00:21:02 +0000 - rev 600513
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1623971 - P14: Replace `\` by `/` in `#include` r=alwu `\` is a window style in file path but Mozilla uses `/` instead. Differential Revision: https://phabricator.services.mozilla.com/D77890
bf18c71cc244df2e705ea65c4198961b26dc1ab6: Bug 1623971 - P13: Apply the same format for comments r=alwu
Chun-Min Chang <chun.m.chang@gmail.com> - Fri, 19 Jun 2020 00:21:00 +0000 - rev 600512
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1623971 - P13: Apply the same format for comments r=alwu Differential Revision: https://phabricator.services.mozilla.com/D77889
bba6f9948eaf5cc834f5154479f4cbc6986999ec: Bug 1623971 - P12: Reorganize member functions r=alwu
Chun-Min Chang <chun.m.chang@gmail.com> - Fri, 19 Jun 2020 00:20:52 +0000 - rev 600511
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1623971 - P12: Reorganize member functions r=alwu - Group related functions together - Sync the function order in .cpp and .h (except destructor) - Rename `Update` to `RefreshDisplay` Differential Revision: https://phabricator.services.mozilla.com/D77888
ac69b774f094fc4fa92fa8fa187d6f111c7ce039: Bug 1623971 - P11: Make methods used privately private r=alwu
Chun-Min Chang <chun.m.chang@gmail.com> - Fri, 19 Jun 2020 00:20:42 +0000 - rev 600510
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1623971 - P11: Make methods used privately private r=alwu Some functions are listed as public methods but they are only used privately. It's better to make them private. Differential Revision: https://phabricator.services.mozilla.com/D77887
a52ca855c703ac8e2554c594feff61849ac8b2b2: Bug 1623971 - P10: Assert mDisplay instead of mInitialized r=alwu
Chun-Min Chang <chun.m.chang@gmail.com> - Fri, 19 Jun 2020 00:20:40 +0000 - rev 600509
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1623971 - P10: Assert mDisplay instead of mInitialized r=alwu Differential Revision: https://phabricator.services.mozilla.com/D77886
3c572c4178238e119c5551cb7c43d0b440cab1b5: Bug 1623971 - P9: Assert mControls instead of mInitialized r=alwu
Chun-Min Chang <chun.m.chang@gmail.com> - Fri, 19 Jun 2020 00:20:33 +0000 - rev 600508
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1623971 - P9: Assert mControls instead of mInitialized r=alwu By assert mConrols instread of mInitialized in SetControlAttributes, we no longer need to call SetControlAttributes after setting mInitialized to true. Also, this patch change the timing to set mInitialized to true so we can call SetControlAttributes before RegisterEvent. By doing so, we no longer need to call UnregisterEvents when SetControlAttributes fails. Differential Revision: https://phabricator.services.mozilla.com/D77885
2d27658464882b8d506a86c4d620d9c26102adf6: Bug 1623971 - P8: Rework SMTP opening r=alwu
Chun-Min Chang <chun.m.chang@gmail.com> - Fri, 19 Jun 2020 00:20:30 +0000 - rev 600507
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1623971 - P8: Rework SMTP opening r=alwu - Add error messages so it's easier to debug when the error occurs - It's better to unregister the event listener if failed to open SMTP. (In release, the key-event listener may be alive when the SMTP isn't initialized successfully) Differential Revision: https://phabricator.services.mozilla.com/D77884
603f37b78016425c9533bf62d94cd2f0d638df38: Bug 1623971 - P7: Rename `IMSTCDisplayUpdater` to `ISMTCDisplayUpdater` r=alwu
Chun-Min Chang <chun.m.chang@gmail.com> - Fri, 19 Jun 2020 00:20:23 +0000 - rev 600506
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1623971 - P7: Rename `IMSTCDisplayUpdater` to `ISMTCDisplayUpdater` r=alwu Fix typo: `MSTC` should be `SMTC`. Differential Revision: https://phabricator.services.mozilla.com/D77883
03b978f0a35bec55e6a0ea105edf0e13791a55fc: Bug 1623971 - P6: No need to update metadata upon opening SMTC r=alwu
Chun-Min Chang <chun.m.chang@gmail.com> - Fri, 19 Jun 2020 00:20:15 +0000 - rev 600505
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1623971 - P6: No need to update metadata upon opening SMTC r=alwu Differential Revision: https://phabricator.services.mozilla.com/D77882
caca22b9204895dc08f174b5d1a41987a8caedcb: Bug 1623971 - P5: The arguments to `SetMusicMetadata` must be non-null r=alwu
Chun-Min Chang <chun.m.chang@gmail.com> - Fri, 19 Jun 2020 00:20:13 +0000 - rev 600504
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1623971 - P5: The arguments to `SetMusicMetadata` must be non-null r=alwu `HStringRefernece` must be constructed with a non-null `wchar_t*`. The raw pointer returned from `nsString::get()` is a non-null address so it's ok to add an assertion in `SetMusicMetadata`. Differential Revision: https://phabricator.services.mozilla.com/D77881
8e4699e0342564b3df0f44447afb415e006ea12a: Bug 1623971 - P4: No need to set default metadata when initializing r=alwu
Chun-Min Chang <chun.m.chang@gmail.com> - Fri, 19 Jun 2020 00:20:05 +0000 - rev 600503
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1623971 - P4: No need to set default metadata when initializing r=alwu Metadata would be reset every time when `SetMetadata` is called. Differential Revision: https://phabricator.services.mozilla.com/D77880
6a1f5c9153152d98fc0d273f9139486842380b7c: Bug 1623971 - P3: Return false when `SetMusicMetadata` fails r=alwu
Chun-Min Chang <chun.m.chang@gmail.com> - Fri, 19 Jun 2020 00:20:03 +0000 - rev 600502
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1623971 - P3: Return false when `SetMusicMetadata` fails r=alwu Differential Revision: https://phabricator.services.mozilla.com/D77879
bb32e9a08fbcc7ef8afe83ec5e44d96d99696dec: Bug 1623971 - P2: Delete comments r=alwu
Chun-Min Chang <chun.m.chang@gmail.com> - Fri, 19 Jun 2020 00:19:55 +0000 - rev 600501
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1623971 - P2: Delete comments r=alwu Differential Revision: https://phabricator.services.mozilla.com/D77878
8f34dd451242d8d6dec17a9221a9195fabbafba7: Bug 1623971 - P1: Replace `Maybe<const wchar_t*>` by `const wchar_t*` r=alwu
Chun-Min Chang <chun.m.chang@gmail.com> - Fri, 19 Jun 2020 00:19:48 +0000 - rev 600500
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1623971 - P1: Replace `Maybe<const wchar_t*>` by `const wchar_t*` r=alwu - The maybe value could be `nullptr` even it's `Some` - `Nothing` can be replaced by `nullptr`. Differential Revision: https://phabricator.services.mozilla.com/D77877
bbbb545514b135facbeed04b7ffd49d0679afd09: Bug 1632574 - Turn Pocket stories on by default in GB r=gvn
Scott <scott.downe@gmail.com> - Wed, 10 Jun 2020 18:04:12 +0000 - rev 600499
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1632574 - Turn Pocket stories on by default in GB r=gvn Differential Revision: https://phabricator.services.mozilla.com/D78722
c8be39c5c14dd1db8d4faa6f04bc673fbd32f976: Bug 1308251 relax builtincert requirement if we require signed extensions r=mossop,dveditz
Shane Caraveo <scaraveo@mozilla.com> - Fri, 19 Jun 2020 00:10:58 +0000 - rev 600498
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1308251 relax builtincert requirement if we require signed extensions r=mossop,dveditz This changes the default for requiring builtin certs for extension install and update if we also require signed extensions. For builds that allow unsigned extensions, the default still requires builtin certs. Differential Revision: https://phabricator.services.mozilla.com/D80301
3671a57712e43382e6b70f875dfdf821c5d455d7: Bug 1646780 - use a template to wrap the identity popup while it's not needed, r=johannh
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Fri, 19 Jun 2020 00:02:11 +0000 - rev 600497
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1646780 - use a template to wrap the identity popup while it's not needed, r=johannh Differential Revision: https://phabricator.services.mozilla.com/D78894
1d58c168c2cc57cab49c1ad84f702f5865381c04: Bug 1646838: Rename this variable. r=mjf
Byron Campen [:bwc] <docfaraday@gmail.com> - Thu, 18 Jun 2020 23:44:37 +0000 - rev 600496
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1646838: Rename this variable. r=mjf Depends on D80277 Differential Revision: https://phabricator.services.mozilla.com/D80278
fab65df8e9c81e829a317dda92e40a79c676df04: Bug 1646838: Rewrite this to use c++ structured bindings, and pick better names. r=mjf
Byron Campen [:bwc] <docfaraday@gmail.com> - Thu, 18 Jun 2020 23:46:13 +0000 - rev 600495
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1646838: Rewrite this to use c++ structured bindings, and pick better names. r=mjf Depends on D80275 Differential Revision: https://phabricator.services.mozilla.com/D80277
44ab1e4eae15d988aa94b30130def46d16ff3697: Bug 1646838: Replace this function with a better named one. r=mjf
Byron Campen [:bwc] <docfaraday@gmail.com> - Thu, 18 Jun 2020 23:47:47 +0000 - rev 600494
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1646838: Replace this function with a better named one. r=mjf Depends on D80272 Differential Revision: https://phabricator.services.mozilla.com/D80275
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip