55935c0cdcb403767b529b865be953b7bc529157: Backed out changeset b12dda048dd5 (bug 1535666) patch does not work on beta DONTBUILD
Andreea Pavel <apavel@mozilla.com> - Sat, 16 Mar 2019 18:51:42 +0200 - rev 522382
Push 10871 by cbrindusan@mozilla.com at Mon, 18 Mar 2019 15:49:32 +0000
Backed out changeset b12dda048dd5 (bug 1535666) patch does not work on beta DONTBUILD
786be6f1f8e0ede952a00e55132648950a30b44b: Bug 1535790 - Initialize members in nsLookAndFeel, and bail out when there's no screen settings. r=stransky
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 16 Mar 2019 15:17:49 +0000 - rev 522381
Push 10871 by cbrindusan@mozilla.com at Mon, 18 Mar 2019 15:49:32 +0000
Bug 1535790 - Initialize members in nsLookAndFeel, and bail out when there's no screen settings. r=stransky A patch of mine starts calling nsLookAndFeel from xpcshell tests, which makes gtk crash eventually. Differential Revision: https://phabricator.services.mozilla.com/D23759
b12dda048dd5b1d0bed3d3e0cb7387c4cb6b66cf: Bug 1535666 - Explicitly turn on new cert error pages in browser_aboutCertError_noSubjectAltName.js to let it pass on beta r=Gijs
Sebastian Hengst <archaeopteryx@coole-files.de> - Fri, 15 Mar 2019 22:45:46 +0000 - rev 522380
Push 10871 by cbrindusan@mozilla.com at Mon, 18 Mar 2019 15:49:32 +0000
Bug 1535666 - Explicitly turn on new cert error pages in browser_aboutCertError_noSubjectAltName.js to let it pass on beta r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D23728
1b9bfa6dab28e2824ea695dedc76f64e0636d0f3: Merge mozilla-central to autoland. CLOSED TREE
Csoregi Natalia <ncsoregi@mozilla.com> - Sat, 16 Mar 2019 12:25:06 +0200 - rev 522379
Push 10871 by cbrindusan@mozilla.com at Mon, 18 Mar 2019 15:49:32 +0000
Merge mozilla-central to autoland. CLOSED TREE
124ee436c4214fbb5c770c87054a7484c31772f5: Bug 1534878 - xpcom: Rename NS_InitXPCOM2() to NS_InitXPCOM(). r=froydnj
Chris Peterson <cpeterson@mozilla.com> - Thu, 14 Mar 2019 23:38:09 -0700 - rev 522378
Push 10871 by cbrindusan@mozilla.com at Mon, 18 Mar 2019 15:49:32 +0000
Bug 1534878 - xpcom: Rename NS_InitXPCOM2() to NS_InitXPCOM(). r=froydnj
ecf117f6a9b78d9c0f918107b0ea9dc9d9d3dd1e: Bug 1534878 - xpcom: Remove unused function NS_InitXPCOM(). r=froydnj
Chris Peterson <cpeterson@mozilla.com> - Sun, 24 Feb 2019 16:48:33 -0800 - rev 522377
Push 10871 by cbrindusan@mozilla.com at Mon, 18 Mar 2019 15:49:32 +0000
Bug 1534878 - xpcom: Remove unused function NS_InitXPCOM(). r=froydnj NS_InitXPCOM() is currently not called in Gecko. It has been a one-line wrapper around NS_InitXPCOM2() since the year 2000 (bug 46320), presumably to maintain ABI compatibility for third-party users of XPCOM. We no longer need to worry about XPCOM ABI compatibility. https://searchfox.org/mozilla-central/commit/cddb62593d786e0ff12b25037c74b01cb1a802e5 clang's -Wmissing-prototypes option identifies global functions that can be made static (because they're only called from one compilation unit) or removed (if they're never called). xpcom/build/XPCOMInit.cpp:187:1 [-Wmissing-prototypes] no previous prototype for function 'NS_InitXPCOM' Differential Revision: https://phabricator.services.mozilla.com/D23266
710481a0ddfa6826b5d06e93d683547f4da97402: Bug 1534878 - xpcom: Re-enable NonASCII16 UTF-16 string tests. r=hsivonen
Chris Peterson <cpeterson@mozilla.com> - Sun, 24 Feb 2019 21:45:15 -0800 - rev 522376
Push 10871 by cbrindusan@mozilla.com at Mon, 18 Mar 2019 15:49:32 +0000
Bug 1534878 - xpcom: Re-enable NonASCII16 UTF-16 string tests. r=hsivonen The NonASCII16 test function was removed in bug 1402247 but the NonASCII16_helper() function was not: https://hg.mozilla.org/mozilla-central/rev/4ef0f163fdeb xpcom/tests/gtest/TestUTF.cpp:119:6 [-Wmissing-prototypes] no previous prototype for function 'NonASCII16_helper' Differential Revision: https://phabricator.services.mozilla.com/D23267
25fbad7b3214444a3b07a52880faa61e399309a9: Bug 1534878 - xpcom: #include headers for global functions' declarations. r=erahm
Chris Peterson <cpeterson@mozilla.com> - Thu, 07 Mar 2019 23:32:54 -0800 - rev 522375
Push 10871 by cbrindusan@mozilla.com at Mon, 18 Mar 2019 15:49:32 +0000
Bug 1534878 - xpcom: #include headers for global functions' declarations. r=erahm clang's -Wmissing-prototypes option identifies global functions that can be made static (because they're only called from one compilation unit) or removed (if they're never called). The .cpp files defining these functions did not include the headers with the corresponding function prototypes used by other compilation units. Including a header file in its corresponding .cpp file can help catch mismatched declarations and definitions. xpcom/components/nsCategoryManager.cpp:637:6 [-Wmissing-prototypes] no previous prototype for function 'NS_CreateServicesFromCategory' xpcom/io/nsPipe3.cpp:1824:10 [-Wmissing-prototypes] no previous prototype for function 'nsPipeConstructor' xpcom/io/nsStringStream.cpp:475:10 [-Wmissing-prototypes] no previous prototype for function 'nsStringInputStreamConstructor' xpcom/threads/ThreadDelay.cpp:18:6 [-Wmissing-prototypes] no previous prototype for function 'DelayForChaosMode' Differential Revision: https://phabricator.services.mozilla.com/D23265
5ff84e853d700af894616574f581551a88a93dc7: Bug 1534878 - xpcom: Make some global functions static. r=erahm
Chris Peterson <cpeterson@mozilla.com> - Sun, 24 Feb 2019 17:35:59 -0800 - rev 522374
Push 10871 by cbrindusan@mozilla.com at Mon, 18 Mar 2019 15:49:32 +0000
Bug 1534878 - xpcom: Make some global functions static. r=erahm clang's -Wmissing-prototypes option identifies global functions that can be made static (because they're only called from one compilation unit) or removed (if they're never called). xpcom/base/Logging.cpp:85:13 [-Wmissing-prototypes] no previous prototype for function 'ToLogStr' xpcom/base/Logging.cpp:132:13 [-Wmissing-prototypes] no previous prototype for function 'ExpandPIDMarker' xpcom/base/LogModulePrefWatcher.cpp:37:6 [-Wmissing-prototypes] no previous prototype for function 'ResetExistingPrefs' xpcom/base/LogModulePrefWatcher.cpp:109:6 [-Wmissing-prototypes] no previous prototype for function 'LoadExistingPrefs' xpcom/base/nsCycleCollector.cpp:212:6 [-Wmissing-prototypes] no previous prototype for function 'SuspectUsingNurseryPurpleBuffer' xpcom/components/nsComponentManager.cpp:421:31 [-Wmissing-prototypes] no previous prototype for function 'begin' xpcom/components/nsComponentManager.cpp:427:31 [-Wmissing-prototypes] no previous prototype for function 'end' xpcom/ds/Dafsa.cpp:23:6 [-Wmissing-prototypes] no previous prototype for function 'GetNextOffset' xpcom/ds/Dafsa.cpp:55:6 [-Wmissing-prototypes] no previous prototype for function 'IsEOL' xpcom/ds/Dafsa.cpp:62:6 [-Wmissing-prototypes] no previous prototype for function 'IsMatch' xpcom/ds/Dafsa.cpp:70:6 [-Wmissing-prototypes] no previous prototype for function 'IsEndCharMatch' xpcom/ds/Dafsa.cpp:78:6 [-Wmissing-prototypes] no previous prototype for function 'GetReturnValue' xpcom/ds/Dafsa.cpp:91:5 [-Wmissing-prototypes] no previous prototype for function 'LookupString' xpcom/io/CocoaFileUtils.mm:195:13 [-Wmissing-prototypes] no previous prototype for function 'GetQuarantinePropKey' xpcom/io/CocoaFileUtils.mm:203:24 [-Wmissing-prototypes] no previous prototype for function 'CreateQuarantineDictionary' xpcom/rust/gtest/bench-collections/Bench.cpp:65:11 [-Wmissing-prototypes] no previous prototype for function 'MyRand' xpcom/rust/gtest/bench-collections/Bench.cpp:85:6 [-Wmissing-prototypes] no previous prototype for function 'Bench_Cpp_unordered_set' xpcom/rust/gtest/bench-collections/Bench.cpp:125:6 [-Wmissing-prototypes] no previous prototype for function 'Bench_Cpp_PLDHashTable' xpcom/rust/gtest/bench-collections/Bench.cpp:166:6 [-Wmissing-prototypes] no previous prototype for function 'Bench_Cpp_MozHashSet' xpcom/tests/gtest/TestAtoms.cpp:114:6 [-Wmissing-prototypes] no previous prototype for function 'isStaticAtom' xpcom/tests/gtest/TestCallTemplates.cpp:72:6 [-Wmissing-prototypes] no previous prototype for function 'JustTestingCompilation' xpcom/tests/gtest/TestCOMPtr.cpp:87:10 [-Wmissing-prototypes] no previous prototype for function 'CreateIFoo' xpcom/tests/gtest/TestCOMPtr.cpp:98:6 [-Wmissing-prototypes] no previous prototype for function 'set_a_IFoo' xpcom/tests/gtest/TestCOMPtr.cpp:105:16 [-Wmissing-prototypes] no previous prototype for function 'return_a_IFoo' xpcom/tests/gtest/TestCOMPtr.cpp:164:10 [-Wmissing-prototypes] no previous prototype for function 'CreateIBar' xpcom/tests/gtest/TestCOMPtr.cpp:175:6 [-Wmissing-prototypes] no previous prototype for function 'AnIFooPtrPtrContext' xpcom/tests/gtest/TestCOMPtr.cpp:177:6 [-Wmissing-prototypes] no previous prototype for function 'AVoidPtrPtrContext' xpcom/tests/gtest/TestCOMPtr.cpp:179:6 [-Wmissing-prototypes] no previous prototype for function 'AnISupportsPtrPtrContext' xpcom/tests/gtest/TestCOMPtr.cpp:263:6 [-Wmissing-prototypes] no previous prototype for function 'Comparison' xpcom/tests/gtest/TestCOMPtr.cpp:298:6 [-Wmissing-prototypes] no previous prototype for function 'DontAddRef' xpcom/tests/gtest/TestCRT.cpp:17:5 [-Wmissing-prototypes] no previous prototype for function 'sign' xpcom/tests/gtest/TestDeadlockDetector.cpp:62:6 [-Wmissing-prototypes] no previous prototype for function 'DisableCrashReporter' xpcom/tests/gtest/TestDeadlockDetector.cpp:74:5 [-Wmissing-prototypes] no previous prototype for function 'Sanity_Child' xpcom/tests/gtest/TestDeadlockDetector.cpp:95:5 [-Wmissing-prototypes] no previous prototype for function 'Sanity2_Child' xpcom/tests/gtest/TestDeadlockDetector.cpp:159:5 [-Wmissing-prototypes] no previous prototype for function 'Sanity4_Child' xpcom/tests/gtest/TestDeadlockDetector.cpp:182:5 [-Wmissing-prototypes] no previous prototype for function 'Sanity5_Child' xpcom/tests/gtest/TestDeadlockDetector.cpp:303:5 [-Wmissing-prototypes] no previous prototype for function 'ContentionNoDeadlock_Child' xpcom/tests/gtest/TestHashtables.cpp:88:6 [-Wmissing-prototypes] no previous prototype for function 'testTHashtable' xpcom/tests/gtest/TestHashtables.cpp:205:10 [-Wmissing-prototypes] no previous prototype for function 'CreateIFoo' xpcom/tests/gtest/TestMoveString.cpp:25:6 [-Wmissing-prototypes] no previous prototype for function 'SetAsOwned' xpcom/tests/gtest/TestMoveString.cpp:34:6 [-Wmissing-prototypes] no previous prototype for function 'ExpectTruncated' xpcom/tests/gtest/TestMoveString.cpp:40:6 [-Wmissing-prototypes] no previous prototype for function 'ExpectNew' xpcom/tests/gtest/TestMruCache.cpp:52:11 [-Wmissing-prototypes] no previous prototype for function 'MakeStringKey' xpcom/tests/gtest/TestMultiplexInputStream.cpp:106:34 [-Wmissing-prototypes] no previous prototype for function 'CreateStreamHelper' xpcom/tests/gtest/TestNonBlockingAsyncInputStream.cpp:62:10 [-Wmissing-prototypes] no previous prototype for function 'ReadSegmentsFunction' xpcom/tests/gtest/TestNsDeque.cpp:240:6 [-Wmissing-prototypes] no previous prototype for function 'CheckIfQueueEmpty' xpcom/tests/gtest/TestNsRefPtr.cpp:105:10 [-Wmissing-prototypes] no previous prototype for function 'CreateFoo' xpcom/tests/gtest/TestNsRefPtr.cpp:116:6 [-Wmissing-prototypes] no previous prototype for function 'set_a_Foo' xpcom/tests/gtest/TestNsRefPtr.cpp:123:13 [-Wmissing-prototypes] no previous prototype for function 'return_a_Foo' xpcom/tests/gtest/TestNsRefPtr.cpp:391:6 [-Wmissing-prototypes] no previous prototype for function 'AnFooPtrPtrContext' xpcom/tests/gtest/TestNsRefPtr.cpp:392:6 [-Wmissing-prototypes] no previous prototype for function 'AVoidPtrPtrContext' xpcom/tests/gtest/TestPLDHash.cpp:33:6 [-Wmissing-prototypes] no previous prototype for function 'TestCrashyOperation' xpcom/tests/gtest/TestPipes.cpp:98:10 [-Wmissing-prototypes] no previous prototype for function 'TestPipe' xpcom/tests/gtest/TestPipes.cpp:212:10 [-Wmissing-prototypes] no previous prototype for function 'TestShortWrites' xpcom/tests/gtest/TestPipes.cpp:354:6 [-Wmissing-prototypes] no previous prototype for function 'RunTests' xpcom/tests/gtest/TestPLDHash.cpp:90:6 [-Wmissing-prototypes] no previous prototype for function 'InitCapacityOk_InitialLengthTooBig' xpcom/tests/gtest/TestPLDHash.cpp:95:6 [-Wmissing-prototypes] no previous prototype for function 'InitCapacityOk_InitialEntryStoreTooBig' xpcom/tests/gtest/TestPLDHash.cpp:102:6 [-Wmissing-prototypes] no previous prototype for function 'InitCapacityOk_EntrySizeTooBig' xpcom/tests/gtest/TestSlicedInputStream.cpp:111:20 [-Wmissing-prototypes] no previous prototype for function 'CreateSeekableStreams' xpcom/tests/gtest/TestSlicedInputStream.cpp:125:20 [-Wmissing-prototypes] no previous prototype for function 'CreateNonSeekableStreams' xpcom/tests/gtest/TestStrings.cpp:471:6 [-Wmissing-prototypes] no previous prototype for function 'test_assign_helper' xpcom/tests/gtest/TestTArray.cpp:60:22 [-Wmissing-prototypes] no previous prototype for function 'DummyArray' xpcom/tests/gtest/TestTArray.cpp:72:22 [-Wmissing-prototypes] no previous prototype for function 'FakeHugeArray' xpcom/tests/gtest/TestThrottledEventQueue.cpp:96:6 [-Wmissing-prototypes] no previous prototype for function 'Enqueue' xpcom/threads/BlockingResourceBase.cpp:86:6 [-Wmissing-prototypes] no previous prototype for function 'PrintCycle' xpcom/threads/CPUUsageWatcher.cpp:41:10 [-Wmissing-prototypes] no previous prototype for function 'GetMicroseconds' xpcom/threads/CPUUsageWatcher.cpp:46:10 [-Wmissing-prototypes] no previous prototype for function 'GetMicroseconds' xpcom/threads/CPUUsageWatcher.cpp:51:40 [-Wmissing-prototypes] no previous prototype for function 'GetProcessCPUStats' xpcom/threads/CPUUsageWatcher.cpp:80:40 [-Wmissing-prototypes] no previous prototype for function 'GetGlobalCPUStats' xpcom/threads/nsTimerImpl.cpp:196:21 [-Wmissing-prototypes] no previous prototype for function 'GetTimerFiringsLog' Differential Revision: https://phabricator.services.mozilla.com/D23264
8f2a6dbf221ca51fcb80f1a94eea41d377a0c91c: Backed out 3 changesets (bug 1512838) for memory leaks. CLOSED TREE
Csoregi Natalia <ncsoregi@mozilla.com> - Sat, 16 Mar 2019 12:20:45 +0200 - rev 522373
Push 10871 by cbrindusan@mozilla.com at Mon, 18 Mar 2019 15:49:32 +0000
Backed out 3 changesets (bug 1512838) for memory leaks. CLOSED TREE Backed out changeset 589f41b2e253 (bug 1512838) Backed out changeset 6bd80d61cee8 (bug 1512838) Backed out changeset 754f833aaa41 (bug 1512838)
38849d9496e669b52277a069804786effb44fb2c: Bug 1535708 - Separate out browser and plain mochitests into separate directories to aid ESLint. r=baku
Mark Banner <standard8@mozilla.com> - Sat, 16 Mar 2019 02:40:40 +0000 - rev 522372
Push 10871 by cbrindusan@mozilla.com at Mon, 18 Mar 2019 15:49:32 +0000
Bug 1535708 - Separate out browser and plain mochitests into separate directories to aid ESLint. r=baku Differential Revision: https://phabricator.services.mozilla.com/D23717
e19d324e5970979c11c697c600d60fc366314ed8: Bug 1493317 Part 2 - Enable AccessibleCaret in unit tests. r=jchen
Ting-Yu Lin <tlin@mozilla.com> - Sat, 16 Mar 2019 07:38:34 +0000 - rev 522371
Push 10871 by cbrindusan@mozilla.com at Mon, 18 Mar 2019 15:49:32 +0000
Bug 1493317 Part 2 - Enable AccessibleCaret in unit tests. r=jchen And use correct AccessibleCaret preference to disable it individually in tests. Differential Revision: https://phabricator.services.mozilla.com/D10299
afb8dc106fc6a8e534946eddf2246fbae45394d9: Bug 1493317 Part 1 - Fix pending popup group assertion after enabling AccessibleCaret in unittest. r=mats
Ting-Yu Lin <tlin@mozilla.com> - Sat, 16 Mar 2019 07:29:11 +0000 - rev 522370
Push 10871 by cbrindusan@mozilla.com at Mon, 18 Mar 2019 15:49:32 +0000
Bug 1493317 Part 1 - Fix pending popup group assertion after enabling AccessibleCaret in unittest. r=mats The assertion can be reproduced locally by running "./mach test dom/canvas/test/chrome/test_drawWindow_widget_layers.html" with layout.accessiblecaret.enabled=true. When AccessibleCaret is enabled, caret elements will be inserted into nsCanvasFrame::mCustomContentContainer, thus it recursively invokes ConstructFramesFromItemList() to construct frames for carets before it had a chance to construct popup group. I feel it's too strict to assume that ConstructFramesFromItemList() cannot be invoke recursively whenever there's a popup group item. I move the assertion to the end of ConstructDocElementFrame() to ensure the popup group is processed by then. Differential Revision: https://phabricator.services.mozilla.com/D10298
7bd5d216421291c6d53f5577357e78dc0da4392b: Backed out changeset 6e1f82657583 for debugger failures on Breakpoints.css . CLOSED TREE
Narcis Beleuzu <nbeleuzu@mozilla.com> - Sat, 16 Mar 2019 06:11:21 +0200 - rev 522369
Push 10871 by cbrindusan@mozilla.com at Mon, 18 Mar 2019 15:49:32 +0000
Backed out changeset 6e1f82657583 for debugger failures on Breakpoints.css . CLOSED TREE
6e1f82657583fef11cca382054af09c37ebda020: No bug - Update debugger's column breakpoint colors
David Walsh <dwalsh@mozilla.com> - Sat, 16 Mar 2019 03:37:46 +0000 - rev 522368
Push 10871 by cbrindusan@mozilla.com at Mon, 18 Mar 2019 15:49:32 +0000
No bug - Update debugger's column breakpoint colors This replaces https://phabricator.services.mozilla.com/D23701, which couldn't be autoland-ed due to merge conflict, but my local gecko-dev wouldn't work properly, so I needed to start from scratch. This has been submitted via mercurial. Differential Revision: https://phabricator.services.mozilla.com/D23767
2717903072b67945042d543901238c491e5d20ca: Bug 1072758 - ScheduleReflowSVGNonDisplayText when changing style to display none r=emilio
violet <violet.bugreport@gmail.com> - Sat, 16 Mar 2019 02:36:09 +0000 - rev 522367
Push 10871 by cbrindusan@mozilla.com at Mon, 18 Mar 2019 15:49:32 +0000
Bug 1072758 - ScheduleReflowSVGNonDisplayText when changing style to display none r=emilio DidSetComputedStyle won't be called if the style changes to "display:none". To ensure the reflow is properly scheduled, we need to also hook DestroyFrom. Differential Revision: https://phabricator.services.mozilla.com/D23353
3c2169f7665e64eb2de2a86543afe2a41bdd1c25: Bug 1535337 - Part 3: Don't set prefs inside browser_blockingServiceWorkers.js from the content process and just pass them through extraPrefs; r=baku
Ehsan Akhgari <ehsan@mozilla.com> - Sat, 16 Mar 2019 02:42:42 +0000 - rev 522366
Push 10871 by cbrindusan@mozilla.com at Mon, 18 Mar 2019 15:49:32 +0000
Bug 1535337 - Part 3: Don't set prefs inside browser_blockingServiceWorkers.js from the content process and just pass them through extraPrefs; r=baku Depends on D23509 Differential Revision: https://phabricator.services.mozilla.com/D23510
81d4d461ab15c506dcc9baef1341024d6410b7b8: Bug 1535337 - Part 2: Don't clobber the extraPrefs argument when calling AntiTracking._createTask(); r=baku
Ehsan Akhgari <ehsan@mozilla.com> - Sat, 16 Mar 2019 02:42:25 +0000 - rev 522365
Push 10871 by cbrindusan@mozilla.com at Mon, 18 Mar 2019 15:49:32 +0000
Bug 1535337 - Part 2: Don't clobber the extraPrefs argument when calling AntiTracking._createTask(); r=baku Depends on D23508 Differential Revision: https://phabricator.services.mozilla.com/D23509
7eed7ef4c16e6bd19879bd441f76ef96476869b4: Bug 1535337 - Part 1: Don't pass an extra argument to AntiTracking._setupTest(); r=baku
Ehsan Akhgari <ehsan@mozilla.com> - Sat, 16 Mar 2019 02:42:23 +0000 - rev 522364
Push 10871 by cbrindusan@mozilla.com at Mon, 18 Mar 2019 15:49:32 +0000
Bug 1535337 - Part 1: Don't pass an extra argument to AntiTracking._setupTest(); r=baku Differential Revision: https://phabricator.services.mozilla.com/D23508
4f3f5decaa5fc85883a86dc508655dc17e8610ec: Bug 1535776 - Add verify CFR tests, dev dependencies and hero card style fixes to Activity Stream r=k88hudson
Punam Dahiya <punamdahiya@yahoo.com> - Sat, 16 Mar 2019 02:36:57 +0000 - rev 522363
Push 10871 by cbrindusan@mozilla.com at Mon, 18 Mar 2019 15:49:32 +0000
Bug 1535776 - Add verify CFR tests, dev dependencies and hero card style fixes to Activity Stream r=k88hudson Differential Revision: https://phabricator.services.mozilla.com/D23754
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 tip